Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45196 )
Change subject: mb/google/dedede: Enable SaGv support
......................................................................
Patch Set 4: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/45196/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45196/4//COMMIT_MSG@7
PS4, Line 7: SaGv support
Does SaGv support depend on mainboard components (e.g. VR), or …
[View More]can it be enabled on any mainboard?
I've been thinking about moving the SaGv settings to Kconfig, so that one can easily choose which mode to use without having to edit the devicetree.
https://review.coreboot.org/c/coreboot/+/45196/4//COMMIT_MSG@9
PS4, Line 9:
nit: no space before the comma
https://review.coreboot.org/c/coreboot/+/45196/4//COMMIT_MSG@11
PS4, Line 11:
same here
--
To view, visit https://review.coreboot.org/c/coreboot/+/45196
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f60aad031ce9dfe23e54426753311c35db46c05
Gerrit-Change-Number: 45196
Gerrit-PatchSet: 4
Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sat, 10 Oct 2020 21:31:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
[View Less]
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45959 )
Change subject: mb/clevo/l140cu: set PS/2 timeout for SeaBIOS
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45959/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45959/1//COMMIT_MSG@12
PS1, Line 12: successfully
Please elaborate. Was something not working before? …
[View More]Is it working now?
--
To view, visit https://review.coreboot.org/c/coreboot/+/45959
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2be75961035f04a7ffa6f7e1dbaabb1243b857f9
Gerrit-Change-Number: 45959
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sat, 10 Oct 2020 21:22:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
[View Less]
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46249 )
Change subject: mb/clevo/l140cu: Correct FSP-M UPDs
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46249/1/src/mainboard/clevo/cml-u/…
File src/mainboard/clevo/cml-u/variants/l140cu/romstage.c:
https://review.coreboot.org/c/coreboot/+/46249/1/src/mainboard/clevo/cml-u/…
PS1, Line 10: .spd_spec = …
[View More]{.spd_index = 0},
> nit: this is redundant, as the non-initialized struct members default to zero
already done in CB:46248 ;)
--
To view, visit https://review.coreboot.org/c/coreboot/+/46249
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32f1b7bb46eaaf0f0ecad1df310f5de988f64c85
Gerrit-Change-Number: 46249
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sat, 10 Oct 2020 20:09:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
[View Less]