coreboot-gerrit October 2020

coreboot-gerrit@coreboot.org

1 participants
3474 discussions

Change in coreboot[master]: device: Rework bus master option
by Felix Singer (Code Review) 13 Oct '20

13 Oct '20

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45149 ) Change subject: device: Rework bus master option ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/45149 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I33b37a79022007a16e97350db61575b63fa8256b Gerrit-Change-Number: 45149 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 13 Oct 2020 14:19:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device: Rephrase bus master Kconfig option
by Felix Singer (Code Review) 13 Oct '20

13 Oct '20

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46341 ) Change subject: device: Rephrase bus master Kconfig option ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/46341 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I902915133035fb2adff7edd9c931d4b1d3e7dc40 Gerrit-Change-Number: 46341 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Tue, 13 Oct 2020 14:19:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/boldar: Set devicetree configuration
by Aamir Bohra (Code Review) 13 Oct '20

13 Oct '20

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46245 ) Change subject: mb/google/boldar: Set devicetree configuration ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/46245 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4fdf9410a5f06aac02240cd4e1f15e085b4d3b0c Gerrit-Change-Number: 46245 Gerrit-PatchSet: 4 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Comment-Date: Tue, 13 Oct 2020 13:42:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Alexander Couzens (Code Review) 13 Oct '20

13 Oct '20

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 12: > Patch Set 12: > > > Patch Set 12: > > > > > Patch Set 12: > > > > > > > Patch Set 12: > > > > > > > > > Patch Set 12: > > > > > > > > > > Hi, > > > > > I was able to build with this patch (using nb51 mod, not Nitrocaster), and it generally works, with following caveats: > > > > > - can't start Windows with libgfxinit - it loads, but as soon as Intel GPU driver is installed the screen goes dark, there's also no output on other connectors > > > > > - display brightness doesn't work out-of-the-box, however there's a utility that takes care of that, so no biggie > > > > > > > > > > I can start Windows if I compile with VGA option ROM, VESA framebuffer - which I can set to 1280x1024 (8:8:8) tops, this looks kinda ugly :( Windows will start booting with this resolution, and then switch to FullHD on login screen. > > > > > > > > > > I've seen other people have compiled Coreboot with libgfxinit and can start Windows just fine, but all the reports I found were from plain X230, not X330. As far as I understand, libgfxinit uses only data.vbt to initialize GPU. On the other hand, (I might be wrong but) I believe data.vbt is where magic happens to disable LVDS? Or can I use "stock" data.vbt? This is where I'm starting to be lost. > > > > > > > > > > Are you able to figure out how to have Windows and FullHD on boot (possibly with libgfxinit)? > > > > > > > > libgfxinit does not use data.vbt at all. However, Windows does. Linux can boot without data.vbt as well. > > > > > > That's good to know - so essentially the data.vbt here was modify for Windows to use, but Windows doesn't really boot up with provided data.vbt, so I can replace with stock one and not risk being unable to boot into Linux? > > > > nb51 mod is different! The brightness of the nb51 is controlled via usb and not via the brightness on board as the nitrocaster does. Can you test if windows boots with the OEM vbt? It would really surprise me, but I don't know the windows IGD driver. > > To be frank, I'm not concerned about brightness control at all :-) > > I just flashed coreboot with OEM vbt, and surprise! Windows booted, but was thinking it has 2 screens; Linux (Ubuntu 20.04, fully updated) booted, but no output until I started with video=LVDS-0:d video=DP-2:e. Seems that all the secret sauce is indeed in data.vbt provided in this patch, but while Linux is cool with it, Windows isn't. > How to modify data.vbt? I might do some experiments with it. I've created https://code.fe80.eu/lynxis/vbtparse to modify the vbt. -- To view, visit https://review.coreboot.org/c/coreboot/+/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 12 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kilian Neuner <cb(a)9-r.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Richard Slindee Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Aleksei Kharlamov <derlafff(a)ya.ru> Gerrit-CC: Christian Herzog Gerrit-CC: Holger Levsen <holger(a)layer-acht.org> Gerrit-CC: Matthias Wiedhalm Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me> Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com> Gerrit-CC: Stanislaw Kaminski <stanislaw.kaminski(a)gmail.com> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-CC: Tomasz Jan Góralczyk Gerrit-CC: clayton craft Gerrit-CC: slact Gerrit-Comment-Date: Tue, 13 Oct 2020 12:20:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Stanislaw Kaminski (Code Review) 13 Oct '20

13 Oct '20

Stanislaw Kaminski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 12: > Patch Set 12: > > > Patch Set 12: > > > > > Patch Set 12: > > > > > > > Patch Set 12: > > > > > > > > Hi, > > > > I was able to build with this patch (using nb51 mod, not Nitrocaster), and it generally works, with following caveats: > > > > - can't start Windows with libgfxinit - it loads, but as soon as Intel GPU driver is installed the screen goes dark, there's also no output on other connectors > > > > - display brightness doesn't work out-of-the-box, however there's a utility that takes care of that, so no biggie > > > > > > > > I can start Windows if I compile with VGA option ROM, VESA framebuffer - which I can set to 1280x1024 (8:8:8) tops, this looks kinda ugly :( Windows will start booting with this resolution, and then switch to FullHD on login screen. > > > > > > > > I've seen other people have compiled Coreboot with libgfxinit and can start Windows just fine, but all the reports I found were from plain X230, not X330. As far as I understand, libgfxinit uses only data.vbt to initialize GPU. On the other hand, (I might be wrong but) I believe data.vbt is where magic happens to disable LVDS? Or can I use "stock" data.vbt? This is where I'm starting to be lost. > > > > > > > > Are you able to figure out how to have Windows and FullHD on boot (possibly with libgfxinit)? > > > > > > libgfxinit does not use data.vbt at all. However, Windows does. Linux can boot without data.vbt as well. > > > > That's good to know - so essentially the data.vbt here was modify for Windows to use, but Windows doesn't really boot up with provided data.vbt, so I can replace with stock one and not risk being unable to boot into Linux? > > nb51 mod is different! The brightness of the nb51 is controlled via usb and not via the brightness on board as the nitrocaster does. Can you test if windows boots with the OEM vbt? It would really surprise me, but I don't know the windows IGD driver. To be frank, I'm not concerned about brightness control at all :-) I just flashed coreboot with OEM vbt, and surprise! Windows booted, but was thinking it has 2 screens; Linux (Ubuntu 20.04, fully updated) booted, but no output until I started with video=LVDS-0:d video=DP-2:e. Seems that all the secret sauce is indeed in data.vbt provided in this patch, but while Linux is cool with it, Windows isn't. How to modify data.vbt? I might do some experiments with it. -- To view, visit https://review.coreboot.org/c/coreboot/+/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 12 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kilian Neuner <cb(a)9-r.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Richard Slindee Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Aleksei Kharlamov <derlafff(a)ya.ru> Gerrit-CC: Christian Herzog Gerrit-CC: Holger Levsen <holger(a)layer-acht.org> Gerrit-CC: Matthias Wiedhalm Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me> Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com> Gerrit-CC: Stanislaw Kaminski <stanislaw.kaminski(a)gmail.com> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-CC: Tomasz Jan Góralczyk Gerrit-CC: clayton craft Gerrit-CC: slact Gerrit-Comment-Date: Tue, 13 Oct 2020 12:17:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Alexander Couzens (Code Review) 13 Oct '20

13 Oct '20

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 12: > Patch Set 12: > > > Patch Set 12: > > > > > Patch Set 12: > > > > > > Hi, > > > I was able to build with this patch (using nb51 mod, not Nitrocaster), and it generally works, with following caveats: > > > - can't start Windows with libgfxinit - it loads, but as soon as Intel GPU driver is installed the screen goes dark, there's also no output on other connectors > > > - display brightness doesn't work out-of-the-box, however there's a utility that takes care of that, so no biggie > > > > > > I can start Windows if I compile with VGA option ROM, VESA framebuffer - which I can set to 1280x1024 (8:8:8) tops, this looks kinda ugly :( Windows will start booting with this resolution, and then switch to FullHD on login screen. > > > > > > I've seen other people have compiled Coreboot with libgfxinit and can start Windows just fine, but all the reports I found were from plain X230, not X330. As far as I understand, libgfxinit uses only data.vbt to initialize GPU. On the other hand, (I might be wrong but) I believe data.vbt is where magic happens to disable LVDS? Or can I use "stock" data.vbt? This is where I'm starting to be lost. > > > > > > Are you able to figure out how to have Windows and FullHD on boot (possibly with libgfxinit)? > > > > libgfxinit does not use data.vbt at all. However, Windows does. Linux can boot without data.vbt as well. > > That's good to know - so essentially the data.vbt here was modify for Windows to use, but Windows doesn't really boot up with provided data.vbt, so I can replace with stock one and not risk being unable to boot into Linux? nb51 mod is different! The brightness of the nb51 is controlled via usb and not via the brightness on board as the nitrocaster does. Can you test if windows boots with the OEM vbt? It would really surprise me, but I don't know the windows IGD driver. -- To view, visit https://review.coreboot.org/c/coreboot/+/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 12 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kilian Neuner <cb(a)9-r.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Richard Slindee Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Aleksei Kharlamov <derlafff(a)ya.ru> Gerrit-CC: Christian Herzog Gerrit-CC: Holger Levsen <holger(a)layer-acht.org> Gerrit-CC: Matthias Wiedhalm Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me> Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com> Gerrit-CC: Stanislaw Kaminski <stanislaw.kaminski(a)gmail.com> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-CC: Tomasz Jan Góralczyk Gerrit-CC: clayton craft Gerrit-CC: slact Gerrit-Comment-Date: Tue, 13 Oct 2020 11:42:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Stanislaw Kaminski (Code Review) 13 Oct '20

13 Oct '20

Stanislaw Kaminski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 12: > Patch Set 12: > > > Patch Set 12: > > > > Hi, > > I was able to build with this patch (using nb51 mod, not Nitrocaster), and it generally works, with following caveats: > > - can't start Windows with libgfxinit - it loads, but as soon as Intel GPU driver is installed the screen goes dark, there's also no output on other connectors > > - display brightness doesn't work out-of-the-box, however there's a utility that takes care of that, so no biggie > > > > I can start Windows if I compile with VGA option ROM, VESA framebuffer - which I can set to 1280x1024 (8:8:8) tops, this looks kinda ugly :( Windows will start booting with this resolution, and then switch to FullHD on login screen. > > > > I've seen other people have compiled Coreboot with libgfxinit and can start Windows just fine, but all the reports I found were from plain X230, not X330. As far as I understand, libgfxinit uses only data.vbt to initialize GPU. On the other hand, (I might be wrong but) I believe data.vbt is where magic happens to disable LVDS? Or can I use "stock" data.vbt? This is where I'm starting to be lost. > > > > Are you able to figure out how to have Windows and FullHD on boot (possibly with libgfxinit)? > > libgfxinit does not use data.vbt at all. However, Windows does. Linux can boot without data.vbt as well. That's good to know - so essentially the data.vbt here was modify for Windows to use, but Windows doesn't really boot up with provided data.vbt, so I can replace with stock one and not risk being unable to boot into Linux? -- To view, visit https://review.coreboot.org/c/coreboot/+/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 12 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kilian Neuner <cb(a)9-r.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Richard Slindee Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Aleksei Kharlamov <derlafff(a)ya.ru> Gerrit-CC: Christian Herzog Gerrit-CC: Holger Levsen <holger(a)layer-acht.org> Gerrit-CC: Matthias Wiedhalm Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me> Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com> Gerrit-CC: Stanislaw Kaminski <stanislaw.kaminski(a)gmail.com> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-CC: Tomasz Jan Góralczyk Gerrit-CC: clayton craft Gerrit-CC: slact Gerrit-Comment-Date: Tue, 13 Oct 2020 11:32:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Angel Pons (Code Review) 13 Oct '20

13 Oct '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 12: > Patch Set 12: > > Hi, > I was able to build with this patch (using nb51 mod, not Nitrocaster), and it generally works, with following caveats: > - can't start Windows with libgfxinit - it loads, but as soon as Intel GPU driver is installed the screen goes dark, there's also no output on other connectors > - display brightness doesn't work out-of-the-box, however there's a utility that takes care of that, so no biggie > > I can start Windows if I compile with VGA option ROM, VESA framebuffer - which I can set to 1280x1024 (8:8:8) tops, this looks kinda ugly :( Windows will start booting with this resolution, and then switch to FullHD on login screen. > > I've seen other people have compiled Coreboot with libgfxinit and can start Windows just fine, but all the reports I found were from plain X230, not X330. As far as I understand, libgfxinit uses only data.vbt to initialize GPU. On the other hand, (I might be wrong but) I believe data.vbt is where magic happens to disable LVDS? Or can I use "stock" data.vbt? This is where I'm starting to be lost. > > Are you able to figure out how to have Windows and FullHD on boot (possibly with libgfxinit)? libgfxinit does not use data.vbt at all. However, Windows does. Linux can boot without data.vbt as well. -- To view, visit https://review.coreboot.org/c/coreboot/+/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 12 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kilian Neuner <cb(a)9-r.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Richard Slindee Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Aleksei Kharlamov <derlafff(a)ya.ru> Gerrit-CC: Christian Herzog Gerrit-CC: Holger Levsen <holger(a)layer-acht.org> Gerrit-CC: Matthias Wiedhalm Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me> Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com> Gerrit-CC: Stanislaw Kaminski <stanislaw.kaminski(a)gmail.com> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-CC: Tomasz Jan Góralczyk Gerrit-CC: clayton craft Gerrit-CC: slact Gerrit-Comment-Date: Tue, 13 Oct 2020 11:23:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Stanislaw Kaminski (Code Review) 13 Oct '20

13 Oct '20

Stanislaw Kaminski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 12: Hi, I was able to build with this patch (using nb51 mod, not Nitrocaster), and it generally works, with following caveats: - can't start Windows with libgfxinit - it loads, but as soon as Intel GPU driver is installed the screen goes dark, there's also no output on other connectors - display brightness doesn't work out-of-the-box, however there's a utility that takes care of that, so no biggie I can start Windows if I compile with VGA option ROM, VESA framebuffer - which I can set to 1280x1024 (8:8:8) tops, this looks kinda ugly :( Windows will start booting with this resolution, and then switch to FullHD on login screen. I've seen other people have compiled Coreboot with libgfxinit and can start Windows just fine, but all the reports I found were from plain X230, not X330. As far as I understand, libgfxinit uses only data.vbt to initialize GPU. On the other hand, (I might be wrong but) I believe data.vbt is where magic happens to disable LVDS? Or can I use "stock" data.vbt? This is where I'm starting to be lost. Are you able to figure out how to have Windows and FullHD on boot (possibly with libgfxinit)? -- To view, visit https://review.coreboot.org/c/coreboot/+/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 12 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kilian Neuner <cb(a)9-r.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Richard Slindee Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Aleksei Kharlamov <derlafff(a)ya.ru> Gerrit-CC: Christian Herzog Gerrit-CC: Holger Levsen <holger(a)layer-acht.org> Gerrit-CC: Matthias Wiedhalm Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me> Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com> Gerrit-CC: Stanislaw Kaminski <stanislaw.kaminski(a)gmail.com> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-CC: Tomasz Jan Góralczyk Gerrit-CC: clayton craft Gerrit-CC: slact Gerrit-Comment-Date: Tue, 13 Oct 2020 11:16:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vendorcode/intel/fsp: Add Jasper Lake FSP headers for FSP v2376
by Angel Pons (Code Review) 13 Oct '20

13 Oct '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45899 ) Change subject: vendorcode/intel/fsp: Add Jasper Lake FSP headers for FSP v2376 ...................................................................... Patch Set 6: Code-Review+2 (1 comment) https://review.coreboot.org/c/coreboot/+/45899/5/src/vendorcode/intel/fsp/f… File src/vendorcode/intel/fsp/fsp2_0/jasperlake/FspmUpd.h: https://review.coreboot.org/c/coreboot/+/45899/5/src/vendorcode/intel/fsp/f… PS5, Line 2715: Level 1 > check this in TGL there is 2 level. Right now in JSL there is only one level. […] I see, perfect. Thank you! -- To view, visit https://review.coreboot.org/c/coreboot/+/45899 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65c03d8eda11664541479983c7be11854410e1c6 Gerrit-Change-Number: 45899 Gerrit-PatchSet: 6 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Oct 2020 10:49:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2020