coreboot-gerrit October 2020

coreboot-gerrit@coreboot.org

1 participants
3474 discussions

Change in coreboot[master]: drivers/intel/wifi: Change to PCI driver only
by Furquan Shaikh (Code Review) 13 Oct '20

13 Oct '20

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46036 ) Change subject: drivers/intel/wifi: Change to PCI driver only ...................................................................... drivers/intel/wifi: Change to PCI driver only Currently, drivers/intel/wifi is a PCI driver (provides `struct pci_driver`) as well as a chip driver (provids `struct chip_operations`). However, there is no need for a separate chip driver for the WiFi device since drivers/wifi/generic already provides one. Having two separate chip drivers makes it difficult to multi-source WiFi devices and share the same firmware target without having to add a probe property for each of these devices. This is unnecessary since the WiFi driver in coreboot is primarily responsible for: 1. PCI resource allocation 2. ACPI SSDT node generation to expose wake property and SAR tables 3. SMBIOS table generation For the most part, coreboot can perform the above operations without really caring about the specifics of which WiFi device is being used by the mainboard. Thus, this change drops the chip driver from drivers/intel/wifi and retains only the PCI driver. The PCI driver is retained for backward compatibility with boards that never utilized the chip driver to support Intel WiFi device. For these devices, the PCI driver helps perform the same operations as above (except exposing the wake property) by utilizing the same `wifi_generic_ops` exposed by drivers/wifi/generic. BUG=b:169802515 BRANCH=zork Change-Id: I780a7d1a87f387d5e01e6b35aac7cca31a2033ac Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/drivers/intel/wifi/Kconfig D src/drivers/intel/wifi/chip.h M src/drivers/intel/wifi/wifi.c M src/drivers/wifi/generic/generic.c 4 files changed, 5 insertions(+), 95 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/46036/1 diff --git a/src/drivers/intel/wifi/Kconfig b/src/drivers/intel/wifi/Kconfig index 83df822..5454e97 100644 --- a/src/drivers/intel/wifi/Kconfig +++ b/src/drivers/intel/wifi/Kconfig @@ -2,7 +2,7 @@ bool "Support Intel PCI-e WiFi adapters" depends on PCI default y if PCIEXP_PLUGIN_SUPPORT - select DRIVERS_WIFI_GENERIC if HAVE_ACPI_TABLES + select DRIVERS_WIFI_GENERIC help When enabled, add identifiers in ACPI and SMBIOS tables to make OS drivers work with certain Intel PCI-e WiFi chipsets. diff --git a/src/drivers/intel/wifi/chip.h b/src/drivers/intel/wifi/chip.h deleted file mode 100644 index 966573f..0000000 --- a/src/drivers/intel/wifi/chip.h +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#ifndef _INTEL_WIFI_CHIP_H_ -#define _INTEL_WIFI_CHIP_H_ - -struct drivers_intel_wifi_config { - unsigned int wake; /* Wake pin for ACPI _PRW */ -}; - -#endif /* _INTEL_WIFI_CHIP_H_ */ diff --git a/src/drivers/intel/wifi/wifi.c b/src/drivers/intel/wifi/wifi.c index 6010673..9674130 100644 --- a/src/drivers/intel/wifi/wifi.c +++ b/src/drivers/intel/wifi/wifi.c @@ -1,80 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <device/device.h> #include <device/pci.h> -#include <device/pci_ops.h> #include <device/pci_ids.h> -#include <elog.h> -#include <smbios.h> -#include <string.h> -#include "chip.h" -#include "drivers/wifi/generic/chip.h" - -#if CONFIG(GENERATE_SMBIOS_TABLES) -static int smbios_write_wifi(struct device *dev, int *handle, - unsigned long *current) -{ - struct smbios_type_intel_wifi { - u8 type; - u8 length; - u16 handle; - u8 str; - u8 eos[2]; - } __packed; - - struct smbios_type_intel_wifi *t = - (struct smbios_type_intel_wifi *)*current; - int len = sizeof(struct smbios_type_intel_wifi); - - memset(t, 0, sizeof(struct smbios_type_intel_wifi)); - t->type = 0x85; - t->length = len - 2; - t->handle = *handle; - /* - * Intel wifi driver expects this string to be in the table 0x85 - * with PCI IDs enumerated below. - */ - t->str = smbios_add_string(t->eos, "KHOIHGIUCCHHII"); - - len = t->length + smbios_string_table_len(t->eos); - *current += len; - *handle += 1; - return len; -} -#endif - -#if CONFIG(HAVE_ACPI_TABLES) -static void intel_wifi_fill_ssdt(const struct device *dev) -{ - struct drivers_intel_wifi_config *config = dev->chip_info; - struct drivers_wifi_generic_config generic_config; - - if (config) - generic_config.wake = config->wake; - - wifi_generic_fill_ssdt(dev, config ? &generic_config : NULL); -} -#endif - -static void wifi_pci_dev_init(struct device *dev) -{ - pci_dev_log_wake(dev, ELOG_WAKE_SOURCE_PME_WIFI, 0); -} - -struct device_operations device_ops = { - .read_resources = pci_dev_read_resources, - .set_resources = pci_dev_set_resources, - .enable_resources = pci_dev_enable_resources, - .init = wifi_pci_dev_init, -#if CONFIG(GENERATE_SMBIOS_TABLES) - .get_smbios_data = smbios_write_wifi, -#endif - .ops_pci = &pci_dev_ops_pci, -#if CONFIG(HAVE_ACPI_TABLES) - .acpi_name = wifi_generic_acpi_name, - .acpi_fill_ssdt = intel_wifi_fill_ssdt, -#endif -}; static const unsigned short pci_device_ids[] = { PCI_DEVICE_ID_1000_SERIES_WIFI, @@ -128,18 +55,10 @@ 0 }; +extern struct device_operations wifi_generic_ops; + static const struct pci_driver pch_intel_wifi __pci_driver = { - .ops = &device_ops, + .ops = &wifi_generic_ops, .vendor = PCI_VENDOR_ID_INTEL, .devices = pci_device_ids, }; - -static void intel_wifi_enable(struct device *dev) -{ - dev->ops = &device_ops; -} - -struct chip_operations drivers_intel_wifi_ops = { - CHIP_NAME("Intel WiFi") - .enable_dev = intel_wifi_enable -}; diff --git a/src/drivers/wifi/generic/generic.c b/src/drivers/wifi/generic/generic.c index 0fb4dc5..b515f3c 100644 --- a/src/drivers/wifi/generic/generic.c +++ b/src/drivers/wifi/generic/generic.c @@ -6,6 +6,7 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_def.h> +#include <device/pci_ids.h> #include <elog.h> #include <sar.h> #include <smbios.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/46036 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I780a7d1a87f387d5e01e6b35aac7cca31a2033ac Gerrit-Change-Number: 46036 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

5 19

Change in coreboot[master]: mb/*/*/dsdt.asl: Drop comment on DefinitionBlock's TableSignature
by HAOUAS Elyes (Code Review) 13 Oct '20

13 Oct '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45801 ) Change subject: mb/*/*/dsdt.asl: Drop comment on DefinitionBlock's TableSignature ...................................................................... mb/*/*/dsdt.asl: Drop comment on DefinitionBlock's TableSignature Change-Id: I1e0489ec6730760f74102cdd00e4aaa66975d69a Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/amd/gardenia/dsdt.asl M src/mainboard/amd/inagua/dsdt.asl M src/mainboard/amd/mandolin/dsdt.asl M src/mainboard/amd/olivehill/dsdt.asl M src/mainboard/amd/padmelon/dsdt.asl M src/mainboard/amd/parmer/dsdt.asl M src/mainboard/amd/persimmon/dsdt.asl M src/mainboard/amd/south_station/dsdt.asl M src/mainboard/amd/thatcher/dsdt.asl M src/mainboard/amd/union_station/dsdt.asl M src/mainboard/asrock/e350m1/dsdt.asl M src/mainboard/asrock/imb-a180/dsdt.asl M src/mainboard/asus/a88xm-e/dsdt.asl M src/mainboard/asus/am1i-a/dsdt.asl M src/mainboard/asus/f2a85-m/dsdt.asl M src/mainboard/bap/ode_e20XX/dsdt.asl M src/mainboard/biostar/a68n_5200/dsdt.asl M src/mainboard/biostar/am1ml/dsdt.asl M src/mainboard/elmex/pcm205400/dsdt.asl M src/mainboard/gizmosphere/gizmo/dsdt.asl M src/mainboard/gizmosphere/gizmo2/dsdt.asl M src/mainboard/google/kahlee/dsdt.asl M src/mainboard/google/zork/dsdt.asl M src/mainboard/hp/abm/dsdt.asl M src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl M src/mainboard/jetway/nf81-t56n-lf/dsdt.asl M src/mainboard/lenovo/g505s/dsdt.asl M src/mainboard/lippert/frontrunner-af/dsdt.asl M src/mainboard/msi/ms7721/dsdt.asl M src/mainboard/pcengines/apu1/dsdt.asl M src/mainboard/pcengines/apu2/dsdt.asl 31 files changed, 31 insertions(+), 31 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/45801/1 diff --git a/src/mainboard/amd/gardenia/dsdt.asl b/src/mainboard/amd/gardenia/dsdt.asl index 8ed47a7..f6c5f64 100644 --- a/src/mainboard/amd/gardenia/dsdt.asl +++ b/src/mainboard/amd/gardenia/dsdt.asl @@ -6,7 +6,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/amd/inagua/dsdt.asl b/src/mainboard/amd/inagua/dsdt.asl index 866adc8..41e55f6 100644 --- a/src/mainboard/amd/inagua/dsdt.asl +++ b/src/mainboard/amd/inagua/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/amd/mandolin/dsdt.asl b/src/mainboard/amd/mandolin/dsdt.asl index efc3686..ca17492 100644 --- a/src/mainboard/amd/mandolin/dsdt.asl +++ b/src/mainboard/amd/mandolin/dsdt.asl @@ -6,7 +6,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/amd/olivehill/dsdt.asl b/src/mainboard/amd/olivehill/dsdt.asl index 555073e..06597dc 100644 --- a/src/mainboard/amd/olivehill/dsdt.asl +++ b/src/mainboard/amd/olivehill/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/amd/padmelon/dsdt.asl b/src/mainboard/amd/padmelon/dsdt.asl index 4e34caa..2bc8721 100644 --- a/src/mainboard/amd/padmelon/dsdt.asl +++ b/src/mainboard/amd/padmelon/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/amd/parmer/dsdt.asl b/src/mainboard/amd/parmer/dsdt.asl index 7aa048a..063951b 100644 --- a/src/mainboard/amd/parmer/dsdt.asl +++ b/src/mainboard/amd/parmer/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/amd/persimmon/dsdt.asl b/src/mainboard/amd/persimmon/dsdt.asl index 866adc8..41e55f6 100644 --- a/src/mainboard/amd/persimmon/dsdt.asl +++ b/src/mainboard/amd/persimmon/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/amd/south_station/dsdt.asl b/src/mainboard/amd/south_station/dsdt.asl index 866adc8..41e55f6 100644 --- a/src/mainboard/amd/south_station/dsdt.asl +++ b/src/mainboard/amd/south_station/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/amd/thatcher/dsdt.asl b/src/mainboard/amd/thatcher/dsdt.asl index 7aa048a..063951b 100644 --- a/src/mainboard/amd/thatcher/dsdt.asl +++ b/src/mainboard/amd/thatcher/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/amd/union_station/dsdt.asl b/src/mainboard/amd/union_station/dsdt.asl index 866adc8..41e55f6 100644 --- a/src/mainboard/amd/union_station/dsdt.asl +++ b/src/mainboard/amd/union_station/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/asrock/e350m1/dsdt.asl b/src/mainboard/asrock/e350m1/dsdt.asl index 7689575..c241e43 100644 --- a/src/mainboard/asrock/e350m1/dsdt.asl +++ b/src/mainboard/asrock/e350m1/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/asrock/imb-a180/dsdt.asl b/src/mainboard/asrock/imb-a180/dsdt.asl index 555073e..06597dc 100644 --- a/src/mainboard/asrock/imb-a180/dsdt.asl +++ b/src/mainboard/asrock/imb-a180/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/asus/a88xm-e/dsdt.asl b/src/mainboard/asus/a88xm-e/dsdt.asl index cef1798..9a33f17 100644 --- a/src/mainboard/asus/a88xm-e/dsdt.asl +++ b/src/mainboard/asus/a88xm-e/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/asus/am1i-a/dsdt.asl b/src/mainboard/asus/am1i-a/dsdt.asl index af2980b..4e7c340 100644 --- a/src/mainboard/asus/am1i-a/dsdt.asl +++ b/src/mainboard/asus/am1i-a/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/asus/f2a85-m/dsdt.asl b/src/mainboard/asus/f2a85-m/dsdt.asl index b47b392..483ba09 100644 --- a/src/mainboard/asus/f2a85-m/dsdt.asl +++ b/src/mainboard/asus/f2a85-m/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/bap/ode_e20XX/dsdt.asl b/src/mainboard/bap/ode_e20XX/dsdt.asl index 555073e..06597dc 100644 --- a/src/mainboard/bap/ode_e20XX/dsdt.asl +++ b/src/mainboard/bap/ode_e20XX/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/biostar/a68n_5200/dsdt.asl b/src/mainboard/biostar/a68n_5200/dsdt.asl index 555073e..06597dc 100644 --- a/src/mainboard/biostar/a68n_5200/dsdt.asl +++ b/src/mainboard/biostar/a68n_5200/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/biostar/am1ml/dsdt.asl b/src/mainboard/biostar/am1ml/dsdt.asl index 5edffa0..ee899ef 100644 --- a/src/mainboard/biostar/am1ml/dsdt.asl +++ b/src/mainboard/biostar/am1ml/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/elmex/pcm205400/dsdt.asl b/src/mainboard/elmex/pcm205400/dsdt.asl index 866adc8..41e55f6 100644 --- a/src/mainboard/elmex/pcm205400/dsdt.asl +++ b/src/mainboard/elmex/pcm205400/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/gizmosphere/gizmo/dsdt.asl b/src/mainboard/gizmosphere/gizmo/dsdt.asl index 6d63ab8..99d34e0 100644 --- a/src/mainboard/gizmosphere/gizmo/dsdt.asl +++ b/src/mainboard/gizmosphere/gizmo/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/gizmosphere/gizmo2/dsdt.asl b/src/mainboard/gizmosphere/gizmo2/dsdt.asl index 555073e..06597dc 100644 --- a/src/mainboard/gizmosphere/gizmo2/dsdt.asl +++ b/src/mainboard/gizmosphere/gizmo2/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/google/kahlee/dsdt.asl b/src/mainboard/google/kahlee/dsdt.asl index 79baa2d..b0142d0 100644 --- a/src/mainboard/google/kahlee/dsdt.asl +++ b/src/mainboard/google/kahlee/dsdt.asl @@ -6,7 +6,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/google/zork/dsdt.asl b/src/mainboard/google/zork/dsdt.asl index 1ed66ba..0b95860 100644 --- a/src/mainboard/google/zork/dsdt.asl +++ b/src/mainboard/google/zork/dsdt.asl @@ -7,7 +7,7 @@ DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/hp/abm/dsdt.asl b/src/mainboard/hp/abm/dsdt.asl index 555073e..06597dc 100644 --- a/src/mainboard/hp/abm/dsdt.asl +++ b/src/mainboard/hp/abm/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl b/src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl index e1b224f..a82e9fc 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl +++ b/src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl @@ -6,7 +6,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/jetway/nf81-t56n-lf/dsdt.asl b/src/mainboard/jetway/nf81-t56n-lf/dsdt.asl index 0a4bce7..1e76a38 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/dsdt.asl +++ b/src/mainboard/jetway/nf81-t56n-lf/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/lenovo/g505s/dsdt.asl b/src/mainboard/lenovo/g505s/dsdt.asl index 0d99721..79f8bc7 100644 --- a/src/mainboard/lenovo/g505s/dsdt.asl +++ b/src/mainboard/lenovo/g505s/dsdt.asl @@ -6,7 +6,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/lippert/frontrunner-af/dsdt.asl b/src/mainboard/lippert/frontrunner-af/dsdt.asl index 1b93108..05f4c49 100644 --- a/src/mainboard/lippert/frontrunner-af/dsdt.asl +++ b/src/mainboard/lippert/frontrunner-af/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/msi/ms7721/dsdt.asl b/src/mainboard/msi/ms7721/dsdt.asl index fa582eb..791ddbe 100644 --- a/src/mainboard/msi/ms7721/dsdt.asl +++ b/src/mainboard/msi/ms7721/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/pcengines/apu1/dsdt.asl b/src/mainboard/pcengines/apu1/dsdt.asl index 5b8ebfd..a59805f 100644 --- a/src/mainboard/pcengines/apu1/dsdt.asl +++ b/src/mainboard/pcengines/apu1/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, diff --git a/src/mainboard/pcengines/apu2/dsdt.asl b/src/mainboard/pcengines/apu2/dsdt.asl index 56e4402..695bd3e 100644 --- a/src/mainboard/pcengines/apu2/dsdt.asl +++ b/src/mainboard/pcengines/apu2/dsdt.asl @@ -4,7 +4,7 @@ #include <acpi/acpi.h> DefinitionBlock ( "dsdt.aml", - "DSDT", /* Signature */ + "DSDT", CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, -- To view, visit https://review.coreboot.org/c/coreboot/+/45801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e0489ec6730760f74102cdd00e4aaa66975d69a Gerrit-Change-Number: 45801 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

3 3

Change in coreboot[master]: mainboard/*/*/dsdt.asl: Make DefinitionBlock's AMLFileName uniform
by HAOUAS Elyes (Code Review) 13 Oct '20

13 Oct '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45792 ) Change subject: mainboard/*/*/dsdt.asl: Make DefinitionBlock's AMLFileName uniform ...................................................................... mainboard/*/*/dsdt.asl: Make DefinitionBlock's AMLFileName uniform Make output AML file name uniform. Change-Id: Ic6cac4748a6159c695888b2737ada677d91f4262 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/amd/gardenia/dsdt.asl M src/mainboard/amd/inagua/dsdt.asl M src/mainboard/amd/mandolin/dsdt.asl M src/mainboard/amd/olivehill/dsdt.asl M src/mainboard/amd/padmelon/dsdt.asl M src/mainboard/amd/parmer/dsdt.asl M src/mainboard/amd/persimmon/dsdt.asl M src/mainboard/amd/south_station/dsdt.asl M src/mainboard/amd/thatcher/dsdt.asl M src/mainboard/amd/union_station/dsdt.asl M src/mainboard/asrock/e350m1/dsdt.asl M src/mainboard/asrock/imb-a180/dsdt.asl M src/mainboard/asus/a88xm-e/dsdt.asl M src/mainboard/asus/am1i-a/dsdt.asl M src/mainboard/asus/f2a85-m/dsdt.asl M src/mainboard/asus/p2b/dsdt.asl M src/mainboard/bap/ode_e20XX/dsdt.asl M src/mainboard/biostar/a68n_5200/dsdt.asl M src/mainboard/biostar/am1ml/dsdt.asl M src/mainboard/elmex/pcm205400/dsdt.asl M src/mainboard/gizmosphere/gizmo/dsdt.asl M src/mainboard/gizmosphere/gizmo2/dsdt.asl M src/mainboard/google/kahlee/dsdt.asl M src/mainboard/google/zork/dsdt.asl M src/mainboard/hp/abm/dsdt.asl M src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl M src/mainboard/jetway/nf81-t56n-lf/dsdt.asl M src/mainboard/lenovo/g505s/dsdt.asl M src/mainboard/lippert/frontrunner-af/dsdt.asl M src/mainboard/msi/ms7721/dsdt.asl M src/mainboard/pcengines/apu1/dsdt.asl M src/mainboard/pcengines/apu2/dsdt.asl 32 files changed, 32 insertions(+), 32 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/45792/1 diff --git a/src/mainboard/amd/gardenia/dsdt.asl b/src/mainboard/amd/gardenia/dsdt.asl index d704581..8ed47a7 100644 --- a/src/mainboard/amd/gardenia/dsdt.asl +++ b/src/mainboard/amd/gardenia/dsdt.asl @@ -5,7 +5,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/amd/inagua/dsdt.asl b/src/mainboard/amd/inagua/dsdt.asl index 7407a8d..866adc8 100644 --- a/src/mainboard/amd/inagua/dsdt.asl +++ b/src/mainboard/amd/inagua/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/amd/mandolin/dsdt.asl b/src/mainboard/amd/mandolin/dsdt.asl index 612fa32..efc3686 100644 --- a/src/mainboard/amd/mandolin/dsdt.asl +++ b/src/mainboard/amd/mandolin/dsdt.asl @@ -5,7 +5,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/amd/olivehill/dsdt.asl b/src/mainboard/amd/olivehill/dsdt.asl index b6760ff..555073e 100644 --- a/src/mainboard/amd/olivehill/dsdt.asl +++ b/src/mainboard/amd/olivehill/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/amd/padmelon/dsdt.asl b/src/mainboard/amd/padmelon/dsdt.asl index 2e78381..4e34caa 100644 --- a/src/mainboard/amd/padmelon/dsdt.asl +++ b/src/mainboard/amd/padmelon/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/amd/parmer/dsdt.asl b/src/mainboard/amd/parmer/dsdt.asl index 4834366..7aa048a 100644 --- a/src/mainboard/amd/parmer/dsdt.asl +++ b/src/mainboard/amd/parmer/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/amd/persimmon/dsdt.asl b/src/mainboard/amd/persimmon/dsdt.asl index 7407a8d..866adc8 100644 --- a/src/mainboard/amd/persimmon/dsdt.asl +++ b/src/mainboard/amd/persimmon/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/amd/south_station/dsdt.asl b/src/mainboard/amd/south_station/dsdt.asl index 7407a8d..866adc8 100644 --- a/src/mainboard/amd/south_station/dsdt.asl +++ b/src/mainboard/amd/south_station/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/amd/thatcher/dsdt.asl b/src/mainboard/amd/thatcher/dsdt.asl index 4834366..7aa048a 100644 --- a/src/mainboard/amd/thatcher/dsdt.asl +++ b/src/mainboard/amd/thatcher/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/amd/union_station/dsdt.asl b/src/mainboard/amd/union_station/dsdt.asl index 7407a8d..866adc8 100644 --- a/src/mainboard/amd/union_station/dsdt.asl +++ b/src/mainboard/amd/union_station/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/asrock/e350m1/dsdt.asl b/src/mainboard/asrock/e350m1/dsdt.asl index b97bd80..7689575 100644 --- a/src/mainboard/asrock/e350m1/dsdt.asl +++ b/src/mainboard/asrock/e350m1/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/asrock/imb-a180/dsdt.asl b/src/mainboard/asrock/imb-a180/dsdt.asl index b6760ff..555073e 100644 --- a/src/mainboard/asrock/imb-a180/dsdt.asl +++ b/src/mainboard/asrock/imb-a180/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/asus/a88xm-e/dsdt.asl b/src/mainboard/asus/a88xm-e/dsdt.asl index d143cde..cef1798 100644 --- a/src/mainboard/asus/a88xm-e/dsdt.asl +++ b/src/mainboard/asus/a88xm-e/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/asus/am1i-a/dsdt.asl b/src/mainboard/asus/am1i-a/dsdt.asl index e916041..af2980b 100644 --- a/src/mainboard/asus/am1i-a/dsdt.asl +++ b/src/mainboard/asus/am1i-a/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/asus/f2a85-m/dsdt.asl b/src/mainboard/asus/f2a85-m/dsdt.asl index d442a86..b47b392 100644 --- a/src/mainboard/asus/f2a85-m/dsdt.asl +++ b/src/mainboard/asus/f2a85-m/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/asus/p2b/dsdt.asl b/src/mainboard/asus/p2b/dsdt.asl index 19bdb61..66d54dc 100644 --- a/src/mainboard/asus/p2b/dsdt.asl +++ b/src/mainboard/asus/p2b/dsdt.asl @@ -10,7 +10,7 @@ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.aml", + "dsdt.aml", "DSDT", CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/bap/ode_e20XX/dsdt.asl b/src/mainboard/bap/ode_e20XX/dsdt.asl index b6760ff..555073e 100644 --- a/src/mainboard/bap/ode_e20XX/dsdt.asl +++ b/src/mainboard/bap/ode_e20XX/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/biostar/a68n_5200/dsdt.asl b/src/mainboard/biostar/a68n_5200/dsdt.asl index b6760ff..555073e 100644 --- a/src/mainboard/biostar/a68n_5200/dsdt.asl +++ b/src/mainboard/biostar/a68n_5200/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/biostar/am1ml/dsdt.asl b/src/mainboard/biostar/am1ml/dsdt.asl index 813ed2e..5edffa0 100644 --- a/src/mainboard/biostar/am1ml/dsdt.asl +++ b/src/mainboard/biostar/am1ml/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/elmex/pcm205400/dsdt.asl b/src/mainboard/elmex/pcm205400/dsdt.asl index 7407a8d..866adc8 100644 --- a/src/mainboard/elmex/pcm205400/dsdt.asl +++ b/src/mainboard/elmex/pcm205400/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/gizmosphere/gizmo/dsdt.asl b/src/mainboard/gizmosphere/gizmo/dsdt.asl index 9f8a574..6d63ab8 100644 --- a/src/mainboard/gizmosphere/gizmo/dsdt.asl +++ b/src/mainboard/gizmosphere/gizmo/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/gizmosphere/gizmo2/dsdt.asl b/src/mainboard/gizmosphere/gizmo2/dsdt.asl index b6760ff..555073e 100644 --- a/src/mainboard/gizmosphere/gizmo2/dsdt.asl +++ b/src/mainboard/gizmosphere/gizmo2/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/google/kahlee/dsdt.asl b/src/mainboard/google/kahlee/dsdt.asl index e2ddee9..79baa2d 100644 --- a/src/mainboard/google/kahlee/dsdt.asl +++ b/src/mainboard/google/kahlee/dsdt.asl @@ -5,7 +5,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/google/zork/dsdt.asl b/src/mainboard/google/zork/dsdt.asl index 595aa1b..1ed66ba 100644 --- a/src/mainboard/google/zork/dsdt.asl +++ b/src/mainboard/google/zork/dsdt.asl @@ -6,7 +6,7 @@ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/hp/abm/dsdt.asl b/src/mainboard/hp/abm/dsdt.asl index b6760ff..555073e 100644 --- a/src/mainboard/hp/abm/dsdt.asl +++ b/src/mainboard/hp/abm/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl b/src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl index 55ba0ea..e1b224f 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl +++ b/src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl @@ -5,7 +5,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/jetway/nf81-t56n-lf/dsdt.asl b/src/mainboard/jetway/nf81-t56n-lf/dsdt.asl index 956a7c8..0a4bce7 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/dsdt.asl +++ b/src/mainboard/jetway/nf81-t56n-lf/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/lenovo/g505s/dsdt.asl b/src/mainboard/lenovo/g505s/dsdt.asl index a72d87c..0d99721 100644 --- a/src/mainboard/lenovo/g505s/dsdt.asl +++ b/src/mainboard/lenovo/g505s/dsdt.asl @@ -5,7 +5,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/lippert/frontrunner-af/dsdt.asl b/src/mainboard/lippert/frontrunner-af/dsdt.asl index a9fd9af..1b93108 100644 --- a/src/mainboard/lippert/frontrunner-af/dsdt.asl +++ b/src/mainboard/lippert/frontrunner-af/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/msi/ms7721/dsdt.asl b/src/mainboard/msi/ms7721/dsdt.asl index d5cc2ed..fa582eb 100644 --- a/src/mainboard/msi/ms7721/dsdt.asl +++ b/src/mainboard/msi/ms7721/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/pcengines/apu1/dsdt.asl b/src/mainboard/pcengines/apu1/dsdt.asl index b42d43e..5b8ebfd 100644 --- a/src/mainboard/pcengines/apu1/dsdt.asl +++ b/src/mainboard/pcengines/apu1/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, diff --git a/src/mainboard/pcengines/apu2/dsdt.asl b/src/mainboard/pcengines/apu2/dsdt.asl index e93f860..56e4402 100644 --- a/src/mainboard/pcengines/apu2/dsdt.asl +++ b/src/mainboard/pcengines/apu2/dsdt.asl @@ -3,7 +3,7 @@ /* DefinitionBlock Statement */ #include <acpi/acpi.h> DefinitionBlock ( - "DSDT.AML", /* Output filename */ + "dsdt.aml", "DSDT", /* Signature */ CURRENT_DSDT_REV, OEM_ID, -- To view, visit https://review.coreboot.org/c/coreboot/+/45792 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6cac4748a6159c695888b2737ada677d91f4262 Gerrit-Change-Number: 45792 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

3 2

Change in coreboot[master]: mb/emulation/qemu-{i440fx,q35}/dsdt.asl: Use ACPI_DSDT_REV_1 macro
by HAOUAS Elyes (Code Review) 13 Oct '20

13 Oct '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45904 ) Change subject: mb/emulation/qemu-{i440fx,q35}/dsdt.asl: Use ACPI_DSDT_REV_1 macro ...................................................................... mb/emulation/qemu-{i440fx,q35}/dsdt.asl: Use ACPI_DSDT_REV_1 macro Change-Id: I5a5f4e7067948c5cc7a715a08f7a5a3e9b391191 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/emulation/qemu-i440fx/dsdt.asl M src/mainboard/emulation/qemu-q35/dsdt.asl 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/45904/1 diff --git a/src/mainboard/emulation/qemu-i440fx/dsdt.asl b/src/mainboard/emulation/qemu-i440fx/dsdt.asl index 5a341b4..6b3061b 100644 --- a/src/mainboard/emulation/qemu-i440fx/dsdt.asl +++ b/src/mainboard/emulation/qemu-i440fx/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "dsdt.aml", // Output Filename "DSDT", // Signature - 0x01, // DSDT Compliance Revision + ACPI_DSDT_REV_1, OEM_ID, ACPI_TABLE_CREATOR, 0x1 // OEM Revision diff --git a/src/mainboard/emulation/qemu-q35/dsdt.asl b/src/mainboard/emulation/qemu-q35/dsdt.asl index a9c96be..41065df 100644 --- a/src/mainboard/emulation/qemu-q35/dsdt.asl +++ b/src/mainboard/emulation/qemu-q35/dsdt.asl @@ -9,7 +9,7 @@ DefinitionBlock ( "dsdt.aml", // Output Filename "DSDT", // Signature - 0x01, // DSDT Compliance Revision + ACPI_DSDT_REV_1, OEM_ID, ACPI_TABLE_CREATOR, 0x2 // OEM Revision -- To view, visit https://review.coreboot.org/c/coreboot/+/45904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a5f4e7067948c5cc7a715a08f7a5a3e9b391191 Gerrit-Change-Number: 45904 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

4 6

Change in coreboot[master]: vendorcode/google/dram_part_num: Fix the severity of debug statement
by Karthik Ramasubramanian (Code Review) 13 Oct '20

13 Oct '20

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46299 ) Change subject: vendorcode/google/dram_part_num: Fix the severity of debug statement ...................................................................... vendorcode/google/dram_part_num: Fix the severity of debug statement DRAM part number may not be provisioned in CBI during early stages of development. Logging the debug statement with error severity interferes with some of the test tools. Update the severity of the debug statement to just DEBUG severity BUG=b:170529094 TEST=Build and boot to ChromeOS in Drawlat. Change-Id: Ib0c707ec6478060d6e18ea01cc467dfda00a6d42 Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> --- M src/vendorcode/google/chromeos/dram_part_num_override.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/46299/1 diff --git a/src/vendorcode/google/chromeos/dram_part_num_override.c b/src/vendorcode/google/chromeos/dram_part_num_override.c index d624e13..4b934fe 100644 --- a/src/vendorcode/google/chromeos/dram_part_num_override.c +++ b/src/vendorcode/google/chromeos/dram_part_num_override.c @@ -16,8 +16,8 @@ if (part_num_state == PART_NUM_NOT_READ) { if (google_chromeec_cbi_get_dram_part_num(part_num_store, sizeof(part_num_store)) < 0) { - printk(BIOS_ERR, - "ERROR: Couldn't obtain DRAM part number from CBI\n"); + printk(BIOS_DEBUG, + "Couldn't obtain DRAM part number from CBI\n"); part_num_state = PART_NUM_NOT_IN_CBI; } else { part_num_state = PART_NUM_AVAILABLE; -- To view, visit https://review.coreboot.org/c/coreboot/+/46299 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0c707ec6478060d6e18ea01cc467dfda00a6d42 Gerrit-Change-Number: 46299 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newchange

4 6

Change in coreboot[master]: volteer: Create elemi variant
by Chen Wisley (Code Review) 13 Oct '20

13 Oct '20

Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46294 ) Change subject: volteer: Create elemi variant ...................................................................... volteer: Create elemi variant Create the elemi variant of the volteer reference board by copying the template files to a new directory named for the variant. (Auto-Generated by create_coreboot_variant.sh version 4.2.0). BUG=b:170604353 BRANCH=None TEST=util/abuild/abuild -p none -t google/volteer -x -a make sure the build includes GOOGLE_ELEMI Change-Id: I6013b6d8b28610a79f5ec49d373b2897799bffef Signed-off-by: Wisley Chen <wisley.chen(a)quantatw.com> --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/Kconfig.name A src/mainboard/google/volteer/variants/elemi/include/variant/ec.h A src/mainboard/google/volteer/variants/elemi/include/variant/gpio.h A src/mainboard/google/volteer/variants/elemi/overridetree.cb 5 files changed, 35 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/46294/1 diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index 58ff4eb..edc9c91 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -92,6 +92,7 @@ default "Volteer2" if BOARD_GOOGLE_VOLTEER2 default "Voxel" if BOARD_GOOGLE_VOXEL default "Boldar" if BOARD_GOOGLE_BOLDAR + default "Elemi" if BOARD_GOOGLE_ELEMI config MAX_CPUS int @@ -129,6 +130,7 @@ default "volteer2" if BOARD_GOOGLE_VOLTEER2 default "voxel" if BOARD_GOOGLE_VOXEL default "boldar" if BOARD_GOOGLE_BOLDAR + default "elemi" if BOARD_GOOGLE_ELEMI config VARIANT_HAS_MIPI_CAMERA bool diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index 2817448..f59d82b 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -67,3 +67,7 @@ config BOARD_GOOGLE_BOLDAR bool "-> Boldar" select BOARD_GOOGLE_BASEBOARD_VOLTEER + +config BOARD_GOOGLE_ELEMI + bool "-> Elemi" + select BOARD_GOOGLE_BASEBOARD_VOLTEER diff --git a/src/mainboard/google/volteer/variants/elemi/include/variant/ec.h b/src/mainboard/google/volteer/variants/elemi/include/variant/ec.h new file mode 100644 index 0000000..7a2a6ff --- /dev/null +++ b/src/mainboard/google/volteer/variants/elemi/include/variant/ec.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef __VARIANT_EC_H__ +#define __VARIANT_EC_H__ + +#include <baseboard/ec.h> + +#endif diff --git a/src/mainboard/google/volteer/variants/elemi/include/variant/gpio.h b/src/mainboard/google/volteer/variants/elemi/include/variant/gpio.h new file mode 100644 index 0000000..b5fa8c5 --- /dev/null +++ b/src/mainboard/google/volteer/variants/elemi/include/variant/gpio.h @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef VARIANT_GPIO_H +#define VARIANT_GPIO_H + +#include <baseboard/gpio.h> + +/* Memory configuration board straps */ +/* Copied from baseboard and may need to change for the new variant. */ +#define GPIO_MEM_CONFIG_0 GPP_C12 +#define GPIO_MEM_CONFIG_1 GPP_C15 +#define GPIO_MEM_CONFIG_2 GPP_C14 +#define GPIO_MEM_CONFIG_3 GPP_D15 + +#endif diff --git a/src/mainboard/google/volteer/variants/elemi/overridetree.cb b/src/mainboard/google/volteer/variants/elemi/overridetree.cb new file mode 100644 index 0000000..32204c5 --- /dev/null +++ b/src/mainboard/google/volteer/variants/elemi/overridetree.cb @@ -0,0 +1,6 @@ +chip soc/intel/tigerlake + + device domain 0 on + end + +end -- To view, visit https://review.coreboot.org/c/coreboot/+/46294 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6013b6d8b28610a79f5ec49d373b2897799bffef Gerrit-Change-Number: 46294 Gerrit-PatchSet: 1 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-MessageType: newchange

3 2

Change in coreboot[master]: mb/google/zork: Convert to ASL 2.0 syntax
by HAOUAS Elyes (Code Review) 13 Oct '20

13 Oct '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46181 ) Change subject: mb/google/zork: Convert to ASL 2.0 syntax ...................................................................... mb/google/zork: Convert to ASL 2.0 syntax Change-Id: I71ee54116ade4d6826dffc31ee879a70d3fc967f Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl 1 file changed, 10 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/46181/1 diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl index 8f5aa6a..8576d12 100644 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl +++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl @@ -21,10 +21,10 @@ /* Convert from Degrees C to 1/10 Kelvin for ACPI */ Method (CTOK, 1) { /* 10th of Degrees C */ - Multiply (Arg0, 10, Local0) + Local0 = Arg0 * 10 /* Convert to Kelvin */ - Add (Local0, 2732, Local0) + Local0 += 2732 Return (Local0) } @@ -50,23 +50,23 @@ Method (_TMP, 0, Serialized) { /* Get temperature from EC in deci-kelvin */ - Store (\_SB.PCI0.LPCB.EC0.TSRD (TMPS), Local0) + Local0 =\_SB.PCI0.LPCB.EC0.TSRD (TMPS) /* Critical temperature in deci-kelvin */ - Store (CTOK (\TCRT), Local1) + Local1 = CTOK (\TCRT) - If (LGreaterEqual (Local0, Local1)) { - Store ("CRITICAL TEMPERATURE", Debug) - Store (Local0, Debug) + If (Local0 >= Local1) { + Debug = "CRITICAL TEMPERATURE" + Debug = Local0 /* Wait 1 second for EC to re-poll */ Sleep (1000) /* Re-read temperature from EC */ - Store (\_SB.PCI0.LPCB.EC0.TSRD (TMPS), Local0) + Local0 =\_SB.PCI0.LPCB.EC0.TSRD (TMPS) - Store ("RE-READ TEMPERATURE", Debug) - Store (Local0, Debug) + Debug = "RE-READ TEMPERATURE" + Debug = Local0 } Return (Local0) -- To view, visit https://review.coreboot.org/c/coreboot/+/46181 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I71ee54116ade4d6826dffc31ee879a70d3fc967f Gerrit-Change-Number: 46181 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

3 5

Change in coreboot[master]: soc/intel/skl + cpu/intel/common: move AES-NI locking to common cpu code
by Nico Huber (Code Review) 13 Oct '20

13 Oct '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46272 ) Change subject: soc/intel/skl + cpu/intel/common: move AES-NI locking to common cpu code ...................................................................... Patch Set 4: (2 comments) https://review.coreboot.org/c/coreboot/+/46272/4/src/include/cpu/intel/msr.h File src/include/cpu/intel/msr.h: https://review.coreboot.org/c/coreboot/+/46272/4/src/include/cpu/intel/msr.… PS4, Line 8: #define MSR_FEATURE_CONFIG 0x13c > did you mean "the other header[s]"? […] I meant the one that is close to this change and was used in the moved code `src/soc/intel/common/block/include/intelblocks/msr.h`. Not a requirement, though. https://review.coreboot.org/c/coreboot/+/46272/4/src/include/cpu/intel/msr.… PS4, Line 9: #define AESNI_LOCK_BIT 0 > Hmm, indeed it's only used a few times in cpu/intel and once in soc/intel. […] I would replace msr_set_bit() with _unset and _set versions like we have them for other registers like CB:42134. -- To view, visit https://review.coreboot.org/c/coreboot/+/46272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I81ad5c0d4797b139435c57d3af0a95db94a5c15e Gerrit-Change-Number: 46272 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Oct 2020 17:42:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: wifi: Move addition of CBFS SAR file to wifi/generic/Makefile.inc
by Furquan Shaikh (Code Review) 13 Oct '20

13 Oct '20

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46039 ) Change subject: wifi: Move addition of CBFS SAR file to wifi/generic/Makefile.inc ...................................................................... wifi: Move addition of CBFS SAR file to wifi/generic/Makefile.inc This change moves the addition of CBFS SAR file from intel/wifi/Makefile.inc to wifi/generic/Makefile.inc to keep it in the same sub-directory as the Kconfig definition. BUG=b:169802515 BRANCH=zork Change-Id: I7ee33232b6a07bbf929f3a79fabe89130fb6fa6f Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/drivers/intel/wifi/Makefile.inc M src/drivers/wifi/generic/Makefile.inc 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/46039/1 diff --git a/src/drivers/intel/wifi/Makefile.inc b/src/drivers/intel/wifi/Makefile.inc index 57f60af..9bfdd79 100644 --- a/src/drivers/intel/wifi/Makefile.inc +++ b/src/drivers/intel/wifi/Makefile.inc @@ -1,7 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-only ramstage-$(CONFIG_DRIVERS_INTEL_WIFI) += wifi.c - -cbfs-files-$(CONFIG_WIFI_SAR_CBFS) += wifi_sar_defaults.hex -wifi_sar_defaults.hex-file := $(call strip_quotes,$(CONFIG_WIFI_SAR_CBFS_FILEPATH)) -wifi_sar_defaults.hex-type := raw diff --git a/src/drivers/wifi/generic/Makefile.inc b/src/drivers/wifi/generic/Makefile.inc index 6240c71..407041a 100644 --- a/src/drivers/wifi/generic/Makefile.inc +++ b/src/drivers/wifi/generic/Makefile.inc @@ -1 +1,5 @@ ramstage-$(CONFIG_DRIVERS_WIFI_GENERIC) += generic.c + +cbfs-files-$(CONFIG_WIFI_SAR_CBFS) += wifi_sar_defaults.hex +wifi_sar_defaults.hex-file := $(call strip_quotes,$(CONFIG_WIFI_SAR_CBFS_FILEPATH)) +wifi_sar_defaults.hex-type := raw -- To view, visit https://review.coreboot.org/c/coreboot/+/46039 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ee33232b6a07bbf929f3a79fabe89130fb6fa6f Gerrit-Change-Number: 46039 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

5 6

Change in coreboot[master]: superio/nuvoton/nct6791d: Add symbol to select COM port
by Angel Pons (Code Review) 13 Oct '20

13 Oct '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33640 ) Change subject: superio/nuvoton/nct6791d: Add symbol to select COM port ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/33640/1/src/superio/nuvoton/common… File src/superio/nuvoton/common/early_serial.c: https://review.coreboot.org/c/coreboot/+/33640/1/src/superio/nuvoton/common… PS1, Line 74: pnp_write_config(dev, 0x2a, 0x00); > yeah, it probably shouldn't matter too much here. […] Oh, past me, how mistaken you were... -- To view, visit https://review.coreboot.org/c/coreboot/+/33640 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62dc18810026f9b1550da19950f66af605600ec8 Gerrit-Change-Number: 33640 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Maxim Polyakov <m.poliakov(a)yahoo.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Oct 2020 17:39:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2020