Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38318 )
Change subject: soc/intel/skylake: Call mainboard ACPI sleep methods
......................................................................
Patch Set 6: Code-Review+1
I'm not averse to using the common code, but this is even more minimal of a change and it seemed safer to start with
--
To view, visit https://review.coreboot.org/c/coreboot/+/38318
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I969d92c7445b01964d92d28b21f6667614ea82e7
Gerrit-Change-Number: 38318
Gerrit-PatchSet: 6
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 10 Jan 2020 00:59:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Gaggery Tsai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36622 )
Change subject: drivers/fsp2_0: drop support for FSP-T
......................................................................
Patch Set 5: Code-Review-1
I still need it for BtG
--
To view, visit https://review.coreboot.org/c/coreboot/+/36622
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib791b30b621730f4b7c0a5f668a3b6559245daf5
Gerrit-Change-Number: 36622
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <lean.sheng.tan(a)intel.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: Vincent Zimmer <vincent.zimmer(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 10 Jan 2020 00:05:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37427 )
Change subject: soc/intel/tigerlake: Update GPIO config
......................................................................
Patch Set 16:
(2 comments)
> Patch Set 16:
>
> This CL should really be split into 4 changes:
>
> a) Changes for GPP_* and PMC_GPP_* that are done in gpio.c(soc_pmc_gpio_routes), gpio_soc_defs.h(GPP_* definitions) and pmc.h -- This is really fixing the GPIO group mapping to GPE.
> b) Changes for matching GPIO community/group mapping in coreboot with that of the latest kernel driver -- This should include changes in gpio.asl to add GCM0, GCM1, GCM4, GCM5 and the changes in GADD. Changes in gpio.c. Changes in gpio.h. Changes in gpio_defs.h. Changes in gpio_soc_defs.h except the pinmux macros.
> c) Changes for adding ASL routines for GPIO(GTXS, STXS, CTXS) and updating GRXS.
> d) Changes for pinmux -- Ideally I don't think this is required. But, if we do, then this should be a separate change.
Got it. Will split into 4 patches.
https://review.coreboot.org/c/coreboot/+/37427/16/src/soc/intel/tigerlake/a…
File src/soc/intel/tigerlake/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/37427/16/src/soc/intel/tigerlake/a…
PS16, Line 20: Device (GPIO)
> So, I was looking at the latest version of pinctrl-tigerlake. […]
Got it. So with this it should be pins for every community listed as INT34C5:0<0-5>
https://review.coreboot.org/c/coreboot/+/37427/16/src/soc/intel/tigerlake/i…
File src/soc/intel/tigerlake/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/37427/16/src/soc/intel/tigerlake/i…
PS16, Line 22: CROS_GPIO_DEVICE_NAME
> This will have to be provided for each community device as per the comment on gpio.asl file.
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/37427
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I585100375feee39b5a9105bdf6d9f5ca3a5bb2fa
Gerrit-Change-Number: 37427
Gerrit-PatchSet: 16
Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 09 Jan 2020 23:43:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment