coreboot-gerrit August 2019

coreboot-gerrit@coreboot.org

1 participants
1942 discussions

Change in coreboot[master]: 3rdparty/ffs: add open-power ffs utils
by Marty E. Plummer (Code Review) 25 Aug '19

25 Aug '19

Marty E. Plummer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35007 ) Change subject: 3rdparty/ffs: add open-power ffs utils ...................................................................... 3rdparty/ffs: add open-power ffs utils These tools are used to manipulate open-power specific partitioning and ecc algorithms. Change-Id: I0657f76aab75190244d0e81c2b1a525e50af484d Signed-off-by: Marty E. Plummer <hanetzer(a)startmail.com> --- M .gitmodules A 3rdparty/ffs 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/35007/1 diff --git a/.gitmodules b/.gitmodules index e18f0dc..ef323e9 100644 --- a/.gitmodules +++ b/.gitmodules @@ -34,3 +34,6 @@ url = ../intel-microcode.git update = none ignore = dirty +[submodule "3rdparty/ffs"] + path = 3rdparty/ffs + url = https://github.com/open-power/ffs diff --git a/3rdparty/ffs b/3rdparty/ffs new file mode 160000 index 0000000..3ec70fb --- /dev/null +++ b/3rdparty/ffs @@ -0,0 +1 @@ +Subproject commit 3ec70fbc458e32eef0d0b1de79688b4dc48cbd57 -- To view, visit https://review.coreboot.org/c/coreboot/+/35007 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0657f76aab75190244d0e81c2b1a525e50af484d Gerrit-Change-Number: 35007 Gerrit-PatchSet: 1 Gerrit-Owner: Marty E. Plummer <hanetzer(a)startmail.com> Gerrit-MessageType: newchange

4 8

Change in ...coreboot[master]: mb/samsung/lumpy: Fix MRC raminit
by Patrick Rudolph (Code Review) 25 Aug '19

25 Aug '19

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32682 Change subject: mb/samsung/lumpy: Fix MRC raminit ...................................................................... mb/samsung/lumpy: Fix MRC raminit Fix onboard SPD config placement for mrc.bin and remove outdated comment. ChangeId dedcc78ff44f4eb7c227ade84ee35e007f183a89 removed support for 0xf0 SPD address, but the spd_data index wasn't adjusted. ChangeId If1b94e050d7e8d0dbd349c0415a182730aa5fa90 missed that too while fixing the channel order for native raminit. Change-Id: If1910e82a4bd178c2a6c2991c91e09782122888e Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/mainboard/samsung/lumpy/romstage.c 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/32682/1 diff --git a/src/mainboard/samsung/lumpy/romstage.c b/src/mainboard/samsung/lumpy/romstage.c index 1080689..a77149d 100644 --- a/src/mainboard/samsung/lumpy/romstage.c +++ b/src/mainboard/samsung/lumpy/romstage.c @@ -148,7 +148,6 @@ die("SPD data not found."); if (spd_file_len < (spd_index + 1) * 256) die("Missing SPD data."); - // leave onboard dimm address at f0, and copy spd data there. return spd_data[spd_index]; } @@ -198,8 +197,7 @@ }, }; *pei_data = pei_data_template; - // leave onboard dimm address at f0, and copy spd data there. - memcpy(pei_data->spd_data[0], locate_spd(), 256); + memcpy(pei_data->spd_data[2], locate_spd(), 256); } const struct southbridge_usb_port mainboard_usb_ports[] = { -- To view, visit https://review.coreboot.org/c/coreboot/+/32682 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1910e82a4bd178c2a6c2991c91e09782122888e Gerrit-Change-Number: 32682 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

5 9

Change in coreboot[master]: nb/intel/x4x/raminit: Move dummy reads after JEDEC init
by Angel Pons (Code Review) 25 Aug '19

25 Aug '19

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/20979 ) Change subject: nb/intel/x4x/raminit: Move dummy reads after JEDEC init ...................................................................... Patch Set 8: Code-Review+1 (3 comments) https://review.coreboot.org/c/coreboot/+/20979/8//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/20979/8//COMMIT_MSG@14 PS8, Line 14: ready. > Why can’t we remove the dummy reads? <rant> First things first, there's cases in which registers are read right after writing to them, but the read value is never used. This is because the act of reading a value can have intended and desired side-effects. Cursed sand is cursed! About JEDEC dummy reads: Intel Memory Reference Code (the thing used in vendor firmwares) for Eaglelake (known here as x4x) does this, as well as any other Intel raminit I've looked at. Feel free to check the JEDEC DDR2 and DDR3 specs and ponder whether these are needed or not. And then you'd have to go bug Intel about it so that they validate raminit with the proposed change... Ehhh... I have better things to do, so I'd stick to what's known to work. </rant> TL;DR: A rant about hardware being sorely undocumented, the main reason to stick with the dummy reads: these are known to work, so removing them could cause things to not work later. If it's working, don't break it :) PS: Please do not take this rant as a personal attack. It's late and I needed to rant about something. https://review.coreboot.org/c/coreboot/+/20979/8/src/northbridge/intel/x4x/… File src/northbridge/intel/x4x/raminit_ddr23.c: https://review.coreboot.org/c/coreboot/+/20979/8/src/northbridge/intel/x4x/… PS8, Line 2163: (ch << 29) | (r * 0x08000000) > reimplementation of test_address(ch, r). […] I wonder why this was lost when moving the code. Also, printk()'s were also lost https://review.coreboot.org/c/coreboot/+/20979/8/src/northbridge/intel/x4x/… PS8, Line 2164: 0x800000 > I wonder where this offset is for me too -- To view, visit https://review.coreboot.org/c/coreboot/+/20979 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8069f9c08ad5e5268ddbe3711d58bc42522f938c Gerrit-Change-Number: 20979 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 25 Aug 2019 02:39:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/ocp/monolake: Add ACPI HPET table
by Andrey Petrov (Code Review) 24 Aug '19

24 Aug '19

Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35027 ) Change subject: mb/ocp/monolake: Add ACPI HPET table ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/c/coreboot/+/35027/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/35027/1//COMMIT_MSG@10 PS1, Line 10: please add this was tested, i.e TEST=note kernel log clocksource switch to hpet https://review.coreboot.org/c/coreboot/+/35027/1/src/mainboard/ocp/monolake… File src/mainboard/ocp/monolake/mainboard.c: https://review.coreboot.org/c/coreboot/+/35027/1/src/mainboard/ocp/monolake… PS1, Line 85: /* Enable access to the BMC IPMI via KCS */ this code is not mainboard-specific and should go to SoC. Could you please move this code to soc/intel/fsp_broadwell_de/southcluster.c ? Just add write_acpi_tables ops. -- To view, visit https://review.coreboot.org/c/coreboot/+/35027 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idae9a7d3d4233037214d6203996bf44fe5f3a845 Gerrit-Change-Number: 35027 Gerrit-PatchSet: 1 Gerrit-Owner: Johnny Lin Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: David Hendricks <dhendrix.sync(a)gmail.com> Gerrit-Reviewer: Johnny Lin Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Name of user not set #1002539 Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Łukasz Siudut Gerrit-CC: Andrey Petrov <anpetrov(a)fb.com> Gerrit-Comment-Date: Sat, 24 Aug 2019 00:05:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/ocp/monolake: Add ACPI HPET table
by Johnny Lin (Code Review) 24 Aug '19

24 Aug '19

Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35027 ) Change subject: mb/ocp/monolake: Add ACPI HPET table ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/35027 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idae9a7d3d4233037214d6203996bf44fe5f3a845 Gerrit-Change-Number: 35027 Gerrit-PatchSet: 1 Gerrit-Owner: Johnny Lin Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: David Hendricks <dhendrix.sync(a)gmail.com> Gerrit-Reviewer: Johnny Lin Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Name of user not set #1002539 Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Łukasz Siudut Gerrit-Comment-Date: Fri, 23 Aug 2019 23:35:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF
by Keno Fischer (Code Review) 24 Aug '19

24 Aug '19

Keno Fischer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 ) Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF ...................................................................... Patch Set 74: (1 comment) https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/… File src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb: https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/… PS74, Line 263: device pnp 2e.b on # SUART3 > ouch, forget about it... […] A bit of a nit, but in reality all the UARTS are virtual and what physical wires they end up depends on how the BMC firmware configures it (though the startup configuration does indeed put SUART1 to COM1, SUART2 to COM2). -- To view, visit https://review.coreboot.org/c/coreboot/+/32734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2edaa4a928de3a065e517c0f20e3302b4b702323 Gerrit-Change-Number: 32734 Gerrit-PatchSet: 74 Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Keno Fischer <keno(a)alumni.harvard.edu> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: T. Hudson <trammell.hudson(a)gmail.com> Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Christoph Pomaska <github(a)aufmachen.jetzt> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Fri, 23 Aug 2019 22:36:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF
by Michael Niewöhner (Code Review) 24 Aug '19

24 Aug '19

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 ) Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF ...................................................................... Patch Set 74: (2 comments) https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/… File src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb: https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/… PS74, Line 263: device pnp 2e.b on # SUART3 > Yes, to COM1 (external) ouch, forget about it... SUART1 ist COM1 https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/… PS74, Line 267: device pnp 2e.c on # SUART4 > Yes, to COM2 (internal) ... same as above -- To view, visit https://review.coreboot.org/c/coreboot/+/32734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2edaa4a928de3a065e517c0f20e3302b4b702323 Gerrit-Change-Number: 32734 Gerrit-PatchSet: 74 Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Keno Fischer <keno(a)alumni.harvard.edu> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: T. Hudson <trammell.hudson(a)gmail.com> Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Christoph Pomaska <github(a)aufmachen.jetzt> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Fri, 23 Aug 2019 22:29:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF
by Michael Niewöhner (Code Review) 24 Aug '19

24 Aug '19

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 ) Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF ...................................................................... Patch Set 74: (2 comments) https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/… File src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb: https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/… PS74, Line 263: device pnp 2e.b on # SUART3 > Is this UART connected anywhere? Yes, to COM1 (external) https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/… PS74, Line 267: device pnp 2e.c on # SUART4 > Is this UART connected anywhere? Yes, to COM2 (internal) -- To view, visit https://review.coreboot.org/c/coreboot/+/32734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2edaa4a928de3a065e517c0f20e3302b4b702323 Gerrit-Change-Number: 32734 Gerrit-PatchSet: 74 Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Keno Fischer <keno(a)alumni.harvard.edu> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: T. Hudson <trammell.hudson(a)gmail.com> Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Christoph Pomaska <github(a)aufmachen.jetzt> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Fri, 23 Aug 2019 22:26:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Add Razer Blade Stealth (2016) H2U
by Mimoja (Code Review) 24 Aug '19

24 Aug '19

Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34475 ) Change subject: Add Razer Blade Stealth (2016) H2U ...................................................................... Patch Set 26: (7 comments) https://review.coreboot.org/c/coreboot/+/34475/6//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/34475/6//COMMIT_MSG@10 PS6, Line 10: - A way to determin equipped ram (help appreciated) > Only have this one board and don't have the schematics Done https://review.coreboot.org/c/coreboot/+/34475/6//COMMIT_MSG@13 PS6, Line 13: - HDA double-checking (just copied from kblrvp) > Not sure, but is it possible to read this out of the registers with oem firmware? Done https://review.coreboot.org/c/coreboot/+/34475/6//COMMIT_MSG@41 PS6, Line 41: - Headphones > most likely because of incorrect HDA configuration Done https://review.coreboot.org/c/coreboot/+/34475/7//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/34475/7//COMMIT_MSG@10 PS7, Line 10: - A way to determin equipped ram (help appreciated) > Usually some platform ID GPIOs are used. […] Done https://review.coreboot.org/c/coreboot/+/34475/7//COMMIT_MSG@42 PS7, Line 42: - Onboard Keyboard in SeaBIOS > I used the vendor ACPI table and the expected results to RE some RAM values. […] Done https://review.coreboot.org/c/coreboot/+/34475/7/src/mainboard/razer/blade_… File src/mainboard/razer/blade_stealth_kbl/Kconfig: https://review.coreboot.org/c/coreboot/+/34475/7/src/mainboard/razer/blade_… PS7, Line 24: INTEL_GMA_ADD_VBT > It does not seem to get added. […] Done https://review.coreboot.org/c/coreboot/+/34475/9/src/mainboard/razer/blade_… File src/mainboard/razer/blade_stealth_kbl/spd/spd_util.c: https://review.coreboot.org/c/coreboot/+/34475/9/src/mainboard/razer/blade_… PS9, Line 53: : : : : : : > Do these need to be specified? weird... Done -- To view, visit https://review.coreboot.org/c/coreboot/+/34475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ede881d631e1863f07f5130f84bc3b8ca61a350 Gerrit-Change-Number: 34475 Gerrit-PatchSet: 26 Gerrit-Owner: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christoph Pomaska <github(a)aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Fri, 23 Aug 2019 22:06:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Alexander Couzens <lynxis(a)fe80.eu> Comment-In-Reply-To: Mimoja <coreboot(a)mimoja.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF
by Michael Niewöhner (Code Review) 23 Aug '19

23 Aug '19

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 ) Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF ...................................................................... Patch Set 74: (1 comment) https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/… File src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb: https://review.coreboot.org/c/coreboot/+/32734/74/src/mainboard/supermicro/… PS74, Line 73: register "SsicPortEnable" = "0" doesn't this effectively disable usb3.0? ssic is default-on on my x11ssm-f -- To view, visit https://review.coreboot.org/c/coreboot/+/32734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2edaa4a928de3a065e517c0f20e3302b4b702323 Gerrit-Change-Number: 32734 Gerrit-PatchSet: 74 Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Keno Fischer <keno(a)alumni.harvard.edu> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: T. Hudson <trammell.hudson(a)gmail.com> Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Christoph Pomaska <github(a)aufmachen.jetzt> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Fri, 23 Aug 2019 21:41:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2019