coreboot-gerrit August 2019

coreboot-gerrit@coreboot.org

1 participants
1942 discussions

Change in coreboot[master]: Fix VBOOT
by Christian Walter (Code Review) 01 Aug '19

01 Aug '19

Christian Walter has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34654 ) Change subject: Fix VBOOT ...................................................................... Fix VBOOT Change-Id: Ie1341ac40086f1ed878f7c86a8963f913adf6bcd Signed-off-by: Christian Walter <christian.walter(a)9elements.com> --- M src/security/vboot/Makefile.inc M src/security/vboot/tpm_common.c 2 files changed, 2 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/34654/1 diff --git a/src/security/vboot/Makefile.inc b/src/security/vboot/Makefile.inc index 33a9a5e..d554f10 100644 --- a/src/security/vboot/Makefile.inc +++ b/src/security/vboot/Makefile.inc @@ -89,8 +89,8 @@ romstage-$(CONFIG_VBOOT_SEPARATE_VERSTAGE) += secdata_tpm.c endif -ifneq ($(filter y,$(CONFIG_TPM1) $(CONFIG_TPM2)),) -verstage-y+= tpm_common.c +ifneq ($(CONFIG_TPM1)$(CONFIG_TPM2),) +verstage-y += tpm_common.c endif romstage-y += vboot_logic.c diff --git a/src/security/vboot/tpm_common.c b/src/security/vboot/tpm_common.c index 02fb810..9d4d8f2 100644 --- a/src/security/vboot/tpm_common.c +++ b/src/security/vboot/tpm_common.c @@ -14,7 +14,6 @@ #include <security/tpm/tspi.h> #include <vb2_api.h> -#include <security/vboot/antirollback.h> #include <security/vboot/tpm_common.h> #define TPM_PCR_GBB_FLAGS_NAME "GBB flags" -- To view, visit https://review.coreboot.org/c/coreboot/+/34654 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1341ac40086f1ed878f7c86a8963f913adf6bcd Gerrit-Change-Number: 34654 Gerrit-PatchSet: 1 Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

1 4

Change in coreboot[master]: mb/google/hatch/variants/helios: Adjust all I2C CLK and I2C0 SDA hold...
by Frank Chu (Code Review) 01 Aug '19

01 Aug '19

Hello Philip Chen, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34647 to look at the new patch set (#2). Change subject: mb/google/hatch/variants/helios: Adjust all I2C CLK and I2C0 SDA hold time ...................................................................... mb/google/hatch/variants/helios: Adjust all I2C CLK and I2C0 SDA hold time After adjustment Touch Pad CLK: 383.4 KHz Touch Screen CLK: 381.6 KHz Audio codec CLK: 386.0 KHz TouchPad SDA hold time: 0.325ns BUG=b:137722634 BRANCH=none TEST=emerge-hatch coreboot chromeos-bootimage Signed-off-by: Frank_Chu <frank_chu(a)pegatron.corp-partner.google.com> Change-Id: I27dec2f3e00eb6618cc429aff3dae7a5d937d638 --- M src/mainboard/google/hatch/variants/helios/overridetree.cb 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/34647/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/34647 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27dec2f3e00eb6618cc429aff3dae7a5d937d638 Gerrit-Change-Number: 34647 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Philip Chen <philipchen(a)google.com> Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2019