Patrick Rudolph has uploaded a new patch set (#21) to the change originally created by Philipp Deppenwiese. ( https://review.coreboot.org/c/coreboot/+/29744 )
Change subject: util/cbfstool: Add optional argument ibb
......................................................................
util/cbfstool: Add optional argument ibb
* Mark files in CBFS as IBB (Initial BootBlock)
* Will be used to identify the IBB by any TEE
Change-Id: Idb4857c894b9ee1edc464c0a1216cdda29937bbd
Signed-off-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
---
M util/cbfstool/cbfs.h
M util/cbfstool/cbfs_image.c
M util/cbfstool/cbfs_image.h
M util/cbfstool/cbfstool.c
4 files changed, 46 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/29744/21
--
To view, visit https://review.coreboot.org/c/coreboot/+/29744
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb4857c894b9ee1edc464c0a1216cdda29937bbd
Gerrit-Change-Number: 29744
Gerrit-PatchSet: 21
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Amol N Sukerkar <amol.n.sukerkar(a)intel.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Jens Drenhaus <jens.drenhaus(a)9elements.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Kai Michaelis <kai.michaelis(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Roy Wen <rgzwen(a)arista.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )
Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF
......................................................................
Patch Set 74:
> Patch Set 74:
>
> I had a look on Supermicro's products list, especially on the X11 series, when I bought my X11SSM-F some days ago (I am currently working on porting coreboot to that board, too). I just realized that X11SSM-F and X11SSH-TF are basically the same board with just some minor differences (SSH has an m.2 slot and 10GBase-T).
>
> I am wondering if it may be sensible to group those boards in a different scheme than suggested here (mainboards/x11ssh/tf), because we can support more boards this way more simple.
>
> Many X11SS* boards share the same chipset and are more or less the same boards but have only minimal differences in internal/external interfaces.
>
> My suggestion would be to group all these mainboards by chipset and make the rest configurable by selecting the specific board in Kconfig.
>
> This could result in the following tree:
>
> src/mainboard/supermicro/
> src/mainboard/supermicro/c236/variants/x11ssh-f/
> src/mainboard/supermicro/c236/variants/x11ssh-tf/
> src/mainboard/supermicro/c236/variants/x11ssm-f/
> src/mainboard/supermicro/c232/variants/...
> ...
>
> As one chipset does only appear in one series but a series has multiple chipsets, this could also look like this one:
>
> src/mainboard/supermicro/
> src/mainboard/supermicro/x10/c222/variants/...
> src/mainboard/supermicro/x10/c224/variants/...
> src/mainboard/supermicro/x11/c236/variants/ssh-f/
> src/mainboard/supermicro/x11/c236/variants/ssh-tf/
> src/mainboard/supermicro/x11/c236/variants/ssm-f/
> src/mainboard/supermicro/x11/c232/variants/...
> ...
>
> These boards have C236 and I would not be surprised if those boards work with mostly identical coreboot code/config:
> X11SSH
> X11SSH-F
> X11SSH-TF
> X11SSH-CTF
> X11SSi-LN4F
> X11SSM
> X11SSM-F
> X11SSM-TF
> X11SSM-CTF
> X11SSZ-F
> X11SSZ-TLN4F
> X11SSW-F
> X11SSW-TF
> X11SSW-4TF
> X11SSH-GTF-1585L (soldered CPU, but no SoC)
> X11SSH-GTF-1585 (soldered CPU, but no SoC)
> X11SSH-GF-1585L (soldered CPU, but no SoC)
> X11SSH-GF-1585 (soldered CPU, but no SoC)
> X11SSA-F
> X11SSD-F
> X11SSE-F
Is this structure used somewhere else as well in the coreboot tree? I dont think we should reinvent something new and mix up chipsets with vendors and board variants.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32734
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2edaa4a928de3a065e517c0f20e3302b4b702323
Gerrit-Change-Number: 32734
Gerrit-PatchSet: 74
Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Keno Fischer <keno(a)alumni.harvard.edu>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Name of user not set #1002358
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: T. Hudson <trammell.hudson(a)gmail.com>
Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Christoph Pomaska <github(a)aufmachen.jetzt>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Fri, 23 Aug 2019 12:35:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )
Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF
......................................................................
Patch Set 74:
I had a look on Supermicro's products list, especially on the X11 series, when I bought my X11SSM-F some days ago (I am currently working on porting coreboot to that board, too). I just realized that X11SSM-F and X11SSH-TF are basically the same board with just some minor differences (SSH has an m.2 slot and 10GBase-T).
I am wondering if it may be sensible to group those boards in a different scheme than suggested here (mainboards/x11ssh/tf), because we can support more boards this way more simple.
Many X11SS* boards share the same chipset and are more or less the same boards but have only minimal differences in internal/external interfaces.
My suggestion would be to group all these mainboards by chipset and make the rest configurable by selecting the specific board in Kconfig.
This could result in the following tree:
src/mainboard/supermicro/
src/mainboard/supermicro/c236/variants/x11ssh-f/
src/mainboard/supermicro/c236/variants/x11ssh-tf/
src/mainboard/supermicro/c236/variants/x11ssm-f/
src/mainboard/supermicro/c232/variants/...
...
As one chipset does only appear in one series but a series has multiple chipsets, this could also look like this one:
src/mainboard/supermicro/
src/mainboard/supermicro/x10/c222/variants/...
src/mainboard/supermicro/x10/c224/variants/...
src/mainboard/supermicro/x11/c236/variants/ssh-f/
src/mainboard/supermicro/x11/c236/variants/ssh-tf/
src/mainboard/supermicro/x11/c236/variants/ssm-f/
src/mainboard/supermicro/x11/c232/variants/...
...
These boards have C236 and I would not be surprised if those boards work with mostly identical coreboot code/config:
X11SSH
X11SSH-F
X11SSH-TF
X11SSH-CTF
X11SSi-LN4F
X11SSM
X11SSM-F
X11SSM-TF
X11SSM-CTF
X11SSZ-F
X11SSZ-TLN4F
X11SSW-F
X11SSW-TF
X11SSW-4TF
X11SSH-GTF-1585L (soldered CPU, but no SoC)
X11SSH-GTF-1585 (soldered CPU, but no SoC)
X11SSH-GF-1585L (soldered CPU, but no SoC)
X11SSH-GF-1585 (soldered CPU, but no SoC)
X11SSA-F
X11SSD-F
X11SSE-F
--
To view, visit https://review.coreboot.org/c/coreboot/+/32734
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2edaa4a928de3a065e517c0f20e3302b4b702323
Gerrit-Change-Number: 32734
Gerrit-PatchSet: 74
Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Keno Fischer <keno(a)alumni.harvard.edu>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Name of user not set #1002358
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: T. Hudson <trammell.hudson(a)gmail.com>
Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Christoph Pomaska <github(a)aufmachen.jetzt>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Fri, 23 Aug 2019 11:10:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )
Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF
......................................................................
Patch Set 74:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/…
File src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/…
PS68, Line 210: device pci 01.1 on
> According to MNL-1783, the PEG x16 port is split in two, one half is routed to SLOT6 (PCIe x8 slot), […]
@Angel Pons, thank you for the clarification. My comment about the LinkWidth limitation applies only to the case when x4 is used
--
To view, visit https://review.coreboot.org/c/coreboot/+/32734
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2edaa4a928de3a065e517c0f20e3302b4b702323
Gerrit-Change-Number: 32734
Gerrit-PatchSet: 74
Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Keno Fischer <keno(a)alumni.harvard.edu>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Name of user not set #1002358
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: T. Hudson <trammell.hudson(a)gmail.com>
Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Christoph Pomaska <github(a)aufmachen.jetzt>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Fri, 23 Aug 2019 09:06:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Comment-In-Reply-To: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-MessageType: comment
Asami Doi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35022 )
Change subject: lib: hardwaremain: Call exception_init() as soon as possible
......................................................................
lib: hardwaremain: Call exception_init() as soon as possible
Call exception_init() before calling cbmem_initialize() because
ARMv8 on QEMU uses an exception handler to detect a ram size.
Change-Id: If010234a6576414e7e174c075b599a4aa4c19eab
---
M src/lib/hardwaremain.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/35022/1
diff --git a/src/lib/hardwaremain.c b/src/lib/hardwaremain.c
index 2881162..d46cdc0 100644
--- a/src/lib/hardwaremain.c
+++ b/src/lib/hardwaremain.c
@@ -454,6 +454,8 @@
* it is the very first thing done in ramstage.*/
console_init();
+ exception_init();
+
post_code(POST_CONSOLE_READY);
/*
@@ -472,8 +474,6 @@
#if CONFIG(HAVE_ACPI_RESUME)
acpi_is_wakeup();
#endif
-
- exception_init();
threads_initialize();
/* Schedule the static boot state entries. */
--
To view, visit https://review.coreboot.org/c/coreboot/+/35022
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If010234a6576414e7e174c075b599a4aa4c19eab
Gerrit-Change-Number: 35022
Gerrit-PatchSet: 1
Gerrit-Owner: Asami Doi <d0iasm.pub(a)gmail.com>
Gerrit-MessageType: newchange