coreboot-gerrit August 2019

coreboot-gerrit@coreboot.org

1 participants
1942 discussions

Change in coreboot[master]: soc/intel/common: Implement power-failure-state handling
by build bot (Jenkins) (Code Review) 06 Aug '19

06 Aug '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34724 ) Change subject: soc/intel/common: Implement power-failure-state handling ...................................................................... Patch Set 4: (2 comments) https://review.coreboot.org/c/coreboot/+/34724/4/src/soc/intel/common/block… File src/soc/intel/common/block/include/intelblocks/pmclib.h: https://review.coreboot.org/c/coreboot/+/34724/4/src/soc/intel/common/block… PS4, Line 222: void pmc_soc_set_afterg3_en(pci_devfn_t, bool on); function definition argument 'pci_devfn_t' should also have an identifier name https://review.coreboot.org/c/coreboot/+/34724/4/src/soc/intel/common/block… PS4, Line 223: void pmc_set_power_failure_state(pci_devfn_t); function definition argument 'pci_devfn_t' should also have an identifier name -- To view, visit https://review.coreboot.org/c/coreboot/+/34724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6970a79d9b95373c2855f4c92232d2aa05963bb Gerrit-Change-Number: 34724 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Aug 2019 12:02:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common: Implement MAINBOARD_POWER_STATE_PREVIOUS
by Nico Huber (Code Review) 06 Aug '19

06 Aug '19

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34728 to look at the new patch set (#3). Change subject: soc/intel/common: Implement MAINBOARD_POWER_STATE_PREVIOUS ...................................................................... soc/intel/common: Implement MAINBOARD_POWER_STATE_PREVIOUS Firmware has to keep track of the `previous` state. It was advertised in Kconfig long ago, but not implemented. Change-Id: I22bd71e4f3b67309c1aa0cb6faeb5959521bf656 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/soc/intel/apollolake/pmc.c M src/soc/intel/cannonlake/pmc.c M src/soc/intel/common/block/include/intelblocks/pmclib.h M src/soc/intel/common/block/pmc/pmclib.c M src/soc/intel/common/block/smm/smihandler.c M src/soc/intel/icelake/pmc.c M src/soc/intel/skylake/pmc.c 7 files changed, 23 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/34728/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/34728 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22bd71e4f3b67309c1aa0cb6faeb5959521bf656 Gerrit-Change-Number: 34728 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common: Implement power-failure-state handling
by Nico Huber (Code Review) 06 Aug '19

06 Aug '19

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34724 to look at the new patch set (#4). Change subject: soc/intel/common: Implement power-failure-state handling ...................................................................... soc/intel/common: Implement power-failure-state handling Mimics current implementations in `soc/intel/*` to hopefully ease review. Full functionality will be added in later patches. Change-Id: Ic6970a79d9b95373c2855f4c92232d2aa05963bb Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/soc/intel/common/block/include/intelblocks/pmclib.h M src/soc/intel/common/block/pmc/pmclib.c 2 files changed, 30 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/34724/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/34724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6970a79d9b95373c2855f4c92232d2aa05963bb Gerrit-Change-Number: 34724 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common: Implement power-failure-state handling
by build bot (Jenkins) (Code Review) 06 Aug '19

06 Aug '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34724 ) Change subject: soc/intel/common: Implement power-failure-state handling ...................................................................... Patch Set 3: (3 comments) https://review.coreboot.org/c/coreboot/+/34724/3/src/soc/intel/common/block… File src/soc/intel/common/block/include/intelblocks/pmclib.h: https://review.coreboot.org/c/coreboot/+/34724/3/src/soc/intel/common/block… PS3, Line 222: void pmc_soc_set_afterg3_en(pci_devfn_t, bool on); function definition argument 'pci_devfn_t' should also have an identifier name https://review.coreboot.org/c/coreboot/+/34724/3/src/soc/intel/common/block… PS3, Line 223: void pmc_set_power_failure_state(pci_devfn_t); function definition argument 'pci_devfn_t' should also have an identifier name https://review.coreboot.org/c/coreboot/+/34724/3/src/soc/intel/common/block… File src/soc/intel/common/block/pmc/pmclib.c: https://review.coreboot.org/c/coreboot/+/34724/3/src/soc/intel/common/block… PS3, Line 598: printk(BIOS_WARNING, "WARNING: Unknow power-failure state: %d\n", state); 'Unknow' may be misspelled - perhaps 'Unknown'? -- To view, visit https://review.coreboot.org/c/coreboot/+/34724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6970a79d9b95373c2855f4c92232d2aa05963bb Gerrit-Change-Number: 34724 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Aug 2019 12:01:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common: Set power-failure-state via option table
by Nico Huber (Code Review) 06 Aug '19

06 Aug '19

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34729 to look at the new patch set (#2). Change subject: soc/intel/common: Set power-failure-state via option table ...................................................................... soc/intel/common: Set power-failure-state via option table Allow get_option() to override the Kconfig choice. Change-Id: Ie91b502a38d1a40a3dea3711b017b7a5b7edd2db Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/soc/intel/common/block/pmc/pmclib.c 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/34729/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/34729 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie91b502a38d1a40a3dea3711b017b7a5b7edd2db Gerrit-Change-Number: 34729 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/apl: Implement power-failure-state API
by Nico Huber (Code Review) 06 Aug '19

06 Aug '19

Nico Huber has uploaded a new patch set (#7) to the change originally created by Thomas Heijligen. ( https://review.coreboot.org/c/coreboot/+/31352 ) Change subject: soc/intel/apl: Implement power-failure-state API ...................................................................... soc/intel/apl: Implement power-failure-state API The PMC is not represented as a PCI device on this platform, so we pass PCI_DEV_INVALID, and ignore the device argument to pmc_soc_set_afterg3_en(). Needed some Makefile changes to be able to compile in SMM. TEST=Manually tested all four cases with Kontron/mAL10, at the end of this patch series. Change-Id: Ibf218b90088a45349c54f4b881e895bb852e88bb Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M src/soc/intel/apollolake/Makefile.inc M src/soc/intel/apollolake/pmc.c M src/soc/intel/common/block/fast_spi/Makefile.inc 3 files changed, 22 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/31352/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/31352 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf218b90088a45349c54f4b881e895bb852e88bb Gerrit-Change-Number: 31352 Gerrit-PatchSet: 7 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/{cnl,icl}: Use new power-failure-state API
by Nico Huber (Code Review) 06 Aug '19

06 Aug '19

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34726 to look at the new patch set (#2). Change subject: soc/intel/{cnl,icl}: Use new power-failure-state API ...................................................................... soc/intel/{cnl,icl}: Use new power-failure-state API The PMC is not represented as a PCI device on these platforms, so we pass PCI_DEV_INVALID, and ignore the device argument to pmc_soc_set_afterg3_en(). pmc_soc_restore_power_failure() is only called from SMM, so add `pmc.c` to the `smm` class. Once all platforms moved to the new API, it can be implemented in a central place, avoiding the weak- function trap. TEST=Confirmed register states for MAINBOARD_POWER_STATE_OFF and MAINBOARD_POWER_STATE_ON on Cannonlake PCH-H, at the end of this patch series. Change-Id: Ib13eac00002232d4377f683ad92b04a0907529f3 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/mainboard/google/sarien/chromeos.c M src/soc/intel/cannonlake/Makefile.inc M src/soc/intel/cannonlake/pmc.c M src/soc/intel/icelake/Makefile.inc M src/soc/intel/icelake/pmc.c 5 files changed, 21 insertions(+), 111 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/34726/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/34726 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib13eac00002232d4377f683ad92b04a0907529f3 Gerrit-Change-Number: 34726 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/skylake: Use new power-failure-state API
by Nico Huber (Code Review) 06 Aug '19

06 Aug '19

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34725 to look at the new patch set (#2). Change subject: soc/intel/skylake: Use new power-failure-state API ...................................................................... soc/intel/skylake: Use new power-failure-state API Also move pmc_soc_restore_power_failure() which was guarded twice to not be included in SMM, where the only call lives. Once all platforms moved to the new API, it can be implemented in a central place, avoi- ding the weak-function trap. TEST=Manually tested all four cases with Kontron/bSL6 at the end of this patch series. Change-Id: Ie72753764ecd876e6cb999fa0074d1114ae5efcf Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/soc/intel/skylake/Makefile.inc M src/soc/intel/skylake/pmc.c 2 files changed, 26 insertions(+), 68 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/34725/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/34725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie72753764ecd876e6cb999fa0074d1114ae5efcf Gerrit-Change-Number: 34725 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common: Implement power-failure-state handling
by Nico Huber (Code Review) 06 Aug '19

06 Aug '19

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34724 to look at the new patch set (#3). Change subject: soc/intel/common: Implement power-failure-state handling ...................................................................... soc/intel/common: Implement power-failure-state handling Mimics current implementations in `soc/intel/*` to hopefully ease review. Full functionality will be added in later patches. Change-Id: Ic6970a79d9b95373c2855f4c92232d2aa05963bb Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/soc/intel/common/block/include/intelblocks/pmclib.h M src/soc/intel/common/block/pmc/pmclib.c 2 files changed, 30 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/34724/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/34724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6970a79d9b95373c2855f4c92232d2aa05963bb Gerrit-Change-Number: 34724 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: TEST-ONLY: google/krane: fix krane panel get id error
by jitao shi (Code Review) 06 Aug '19

06 Aug '19

jitao shi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33955 Change subject: TEST-ONLY: google/krane: fix krane panel get id error ...................................................................... TEST-ONLY: google/krane: fix krane panel get id error BUG=b:129299873 BRANCH=none Change-Id: I27ff83ed1934c33fa40c225a8435a06ca526ec9a Signed-off-by: Jitao Shi <jitao.shi(a)mediatek.com> --- M src/mainboard/google/kukui/panel_krane.c 1 file changed, 9 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/33955/1 diff --git a/src/mainboard/google/kukui/panel_krane.c b/src/mainboard/google/kukui/panel_krane.c index 55c7ff5..91c2744 100644 --- a/src/mainboard/google/kukui/panel_krane.c +++ b/src/mainboard/google/kukui/panel_krane.c @@ -377,8 +377,15 @@ static union panel_id krane_get_panel_id(struct board_display_intf *intf) { - return (union panel_id) - ((sku_id() >> KRANE_PANEL_ID_BIT_POSITION) & 0xf); + switch (sku_id() >> KRANE_PANEL_ID_BIT_POSITION) { + case 0x0: + return (union panel_id)PANEL_KRANE_AUO_KD101N80_45NA; + case 0x1: /* Incorrect strapping for BOE on rev3 */ + case 0xb: + return (union panel_id)PANEL_KRANE_BOE_TV101WUM_NL6; + default: + return (union panel_id)PANEL_KRANE_UNKNOWN; + } }; static bool krane_is_panel_id_valid(union panel_id id) -- To view, visit https://review.coreboot.org/c/coreboot/+/33955 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27ff83ed1934c33fa40c225a8435a06ca526ec9a Gerrit-Change-Number: 33955 Gerrit-PatchSet: 1 Gerrit-Owner: jitao shi <jitao.shi(a)mediatek.com> Gerrit-MessageType: newchange

3 4

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2019