jitao shi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33955
Change subject: TEST-ONLY: google/krane: fix krane panel get id error ......................................................................
TEST-ONLY: google/krane: fix krane panel get id error
BUG=b:129299873 BRANCH=none
Change-Id: I27ff83ed1934c33fa40c225a8435a06ca526ec9a Signed-off-by: Jitao Shi jitao.shi@mediatek.com --- M src/mainboard/google/kukui/panel_krane.c 1 file changed, 9 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/33955/1
diff --git a/src/mainboard/google/kukui/panel_krane.c b/src/mainboard/google/kukui/panel_krane.c index 55c7ff5..91c2744 100644 --- a/src/mainboard/google/kukui/panel_krane.c +++ b/src/mainboard/google/kukui/panel_krane.c @@ -377,8 +377,15 @@
static union panel_id krane_get_panel_id(struct board_display_intf *intf) { - return (union panel_id) - ((sku_id() >> KRANE_PANEL_ID_BIT_POSITION) & 0xf); + switch (sku_id() >> KRANE_PANEL_ID_BIT_POSITION) { + case 0x0: + return (union panel_id)PANEL_KRANE_AUO_KD101N80_45NA; + case 0x1: /* Incorrect strapping for BOE on rev3 */ + case 0xb: + return (union panel_id)PANEL_KRANE_BOE_TV101WUM_NL6; + default: + return (union panel_id)PANEL_KRANE_UNKNOWN; + } };
static bool krane_is_panel_id_valid(union panel_id id)
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33955 )
Change subject: TEST-ONLY: google/krane: fix krane panel get id error ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/33955/1/src/mainboard/google/kukui/panel_kra... File src/mainboard/google/kukui/panel_krane.c:
https://review.coreboot.org/#/c/33955/1/src/mainboard/google/kukui/panel_kra... PS1, Line 382: return (union panel_id)PANEL_KRANE_AUO_KD101N80_45NA; Statements should start on a tabstop
https://review.coreboot.org/#/c/33955/1/src/mainboard/google/kukui/panel_kra... PS1, Line 385: return (union panel_id)PANEL_KRANE_BOE_TV101WUM_NL6; Statements should start on a tabstop
https://review.coreboot.org/#/c/33955/1/src/mainboard/google/kukui/panel_kra... PS1, Line 387: return (union panel_id)PANEL_KRANE_UNKNOWN; Statements should start on a tabstop
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33955
to look at the new patch set (#2).
Change subject: TEST-ONLY: google/krane: fix krane panel get id error ......................................................................
TEST-ONLY: google/krane: fix krane panel get id error
BUG=b:129299873 BRANCH=none
Change-Id: I27ff83ed1934c33fa40c225a8435a06ca526ec9a Signed-off-by: Jitao Shi jitao.shi@mediatek.com --- M src/mainboard/google/kukui/panel_krane.c 1 file changed, 9 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/33955/2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33955 )
Change subject: TEST-ONLY: google/krane: fix krane panel get id error ......................................................................
Patch Set 2:
please abandon this. it's already implemented in the new series.
jitao shi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33955 )
Change subject: TEST-ONLY: google/krane: fix krane panel get id error ......................................................................
Abandoned
-
build bot (Jenkins) (Code Review) -
Hung-Te Lin (Code Review)
-
jitao shi (Code Review)