coreboot-gerrit June 2019

coreboot-gerrit@coreboot.org

1 participants
1454 discussions

Change in ...coreboot[master]: ec/kontron/kempld/kempld_i2c.c: Remove unneeded 'else'
by HAOUAS Elyes (Code Review) 21 Jun '19

21 Jun '19

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33334 Change subject: ec/kontron/kempld/kempld_i2c.c: Remove unneeded 'else' ...................................................................... ec/kontron/kempld/kempld_i2c.c: Remove unneeded 'else' 'else' is not needed after a 'break' or 'return'. Change-Id: I0843bebe48e4b91fc76c440ae33bbca838621de9 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/ec/kontron/kempld/kempld_i2c.c 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/33334/1 diff --git a/src/ec/kontron/kempld/kempld_i2c.c b/src/ec/kontron/kempld/kempld_i2c.c index fdc0b50..ab41097 100644 --- a/src/ec/kontron/kempld/kempld_i2c.c +++ b/src/ec/kontron/kempld/kempld_i2c.c @@ -166,10 +166,9 @@ if (!(msg->flags & I2C_M_NOSTART)) { i2c->state = STATE_ADDR; return 0; - } else { - i2c->state = (msg->flags & I2C_M_RD) - ? STATE_READ : STATE_WRITE; } + i2c->state = (msg->flags & I2C_M_RD) + ? STATE_READ : STATE_WRITE; } else { i2c->state = STATE_DONE; kempld_write8(KEMPLD_I2C_CMD, I2C_CMD_STOP); -- To view, visit https://review.coreboot.org/c/coreboot/+/33334 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0843bebe48e4b91fc76c440ae33bbca838621de9 Gerrit-Change-Number: 33334 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

4 3

Change in ...coreboot[master]: ec/google/chromeec/ec_lpc: Remove unneeded 'else'
by HAOUAS Elyes (Code Review) 21 Jun '19

21 Jun '19

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33333 Change subject: ec/google/chromeec/ec_lpc: Remove unneeded 'else' ...................................................................... ec/google/chromeec/ec_lpc: Remove unneeded 'else' 'else' is not needed after a 'break' or 'return'. Change-Id: I98d0ab0d139186b312e8c1086c475ba6ef0b7d3b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/ec/google/chromeec/ec_lpc.c 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/33333/1 diff --git a/src/ec/google/chromeec/ec_lpc.c b/src/ec/google/chromeec/ec_lpc.c index 7293cff..f73bd1c 100644 --- a/src/ec/google/chromeec/ec_lpc.c +++ b/src/ec/google/chromeec/ec_lpc.c @@ -188,11 +188,10 @@ return EC_HOST_CMD_FLAG_VERSION_3; } else if (flags & EC_HOST_CMD_FLAG_LPC_ARGS_SUPPORTED) { return EC_HOST_CMD_FLAG_LPC_ARGS_SUPPORTED; - } else { - printk(BIOS_ERR, - "Chromium EC command version unsupported\n"); - return -1; } + printk(BIOS_ERR, + "Chromium EC command version unsupported\n"); + return -1; } static int google_chromeec_command_v3(struct chromeec_command *cec_command) -- To view, visit https://review.coreboot.org/c/coreboot/+/33333 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98d0ab0d139186b312e8c1086c475ba6ef0b7d3b Gerrit-Change-Number: 33333 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

4 7

Change in ...coreboot[master]: drivers/intel/fsp1_0/fastboot_cache: Remove unneeded 'else'
by HAOUAS Elyes (Code Review) 21 Jun '19

21 Jun '19

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33332 Change subject: drivers/intel/fsp1_0/fastboot_cache: Remove unneeded 'else' ...................................................................... drivers/intel/fsp1_0/fastboot_cache: Remove unneeded 'else' 'else' is not needed after a 'break' or 'return'. Change-Id: I109f5aaa87afde61a36fff884305b43c1de2c680 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/drivers/intel/fsp1_0/fastboot_cache.c 1 file changed, 5 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/33332/1 diff --git a/src/drivers/intel/fsp1_0/fastboot_cache.c b/src/drivers/intel/fsp1_0/fastboot_cache.c index 088c292..34761a0 100644 --- a/src/drivers/intel/fsp1_0/fastboot_cache.c +++ b/src/drivers/intel/fsp1_0/fastboot_cache.c @@ -65,13 +65,12 @@ } *mrc_region_ptr = NULL; return 0; - } else { - *mrc_region_ptr = cbfs_boot_map_with_leak("mrc.cache", - CBFS_TYPE_MRC_CACHE, - &region_size); - - return region_size; } + *mrc_region_ptr = cbfs_boot_map_with_leak("mrc.cache", + CBFS_TYPE_MRC_CACHE, + &region_size); + + return region_size; } /* -- To view, visit https://review.coreboot.org/c/coreboot/+/33332 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I109f5aaa87afde61a36fff884305b43c1de2c680 Gerrit-Change-Number: 33332 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

3 2

Change in ...coreboot[master]: arch/x86/rdrand.c: Remove unneeded 'else'
by HAOUAS Elyes (Code Review) 21 Jun '19

21 Jun '19

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33331 Change subject: arch/x86/rdrand.c: Remove unneeded 'else' ...................................................................... arch/x86/rdrand.c: Remove unneeded 'else' 'else' is not needed after a 'break' or 'return'. Change-Id: Ib7bdefb0027a35de42f6a665b98f9e5a2791061f Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/x86/rdrand.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/33331/1 diff --git a/src/arch/x86/rdrand.c b/src/arch/x86/rdrand.c index 35aac71..c9090df 100644 --- a/src/arch/x86/rdrand.c +++ b/src/arch/x86/rdrand.c @@ -75,7 +75,6 @@ #if ENV_X86_64 if (rdrand_64(rand)) return 0; - else #endif if (rdrand_32(&rand_high) && rdrand_32(&rand_low)) { *rand = ((uint64_t)rand_high << 32) | -- To view, visit https://review.coreboot.org/c/coreboot/+/33331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7bdefb0027a35de42f6a665b98f9e5a2791061f Gerrit-Change-Number: 33331 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

3 2

Change in ...coreboot[master]: lib: Prevent memory leak on error path
by Jacob Garber (Code Review) 21 Jun '19

21 Jun '19

Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33298 Change subject: lib: Prevent memory leak on error path ...................................................................... lib: Prevent memory leak on error path Free the tree before returning to prevent a leak. Change-Id: I1132c0e7404eec1af3adc19a83257f28563f8a58 Signed-off-by: Jacob Garber <jgarber1(a)ualberta.ca> Found-by: Coverity CID 1401799 --- M src/lib/device_tree.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/33298/1 diff --git a/src/lib/device_tree.c b/src/lib/device_tree.c index a5021ca..ed878a2 100644 --- a/src/lib/device_tree.c +++ b/src/lib/device_tree.c @@ -259,11 +259,13 @@ if (magic != FDT_HEADER_MAGIC) { printk(BIOS_DEBUG, "Invalid device tree magic %#.8x!\n", magic); + free(tree); return NULL; } if (last_comp_version > FDT_SUPPORTED_VERSION) { printk(BIOS_DEBUG, "Unsupported device tree version %u(>=%u)\n", version, last_comp_version); + free(tree); return NULL; } if (version > FDT_SUPPORTED_VERSION) -- To view, visit https://review.coreboot.org/c/coreboot/+/33298 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1132c0e7404eec1af3adc19a83257f28563f8a58 Gerrit-Change-Number: 33298 Gerrit-PatchSet: 1 Gerrit-Owner: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-MessageType: newchange

3 2

Change in ...coreboot[master]: drivers/amd/agesa: Assert that StdHeader is non-null
by Jacob Garber (Code Review) 21 Jun '19

21 Jun '19

Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33214 Change subject: drivers/amd/agesa: Assert that StdHeader is non-null ...................................................................... drivers/amd/agesa: Assert that StdHeader is non-null Coverity believes there is a path where StdHeader is possibly null. This *should* be incorrect, since the header is actually initialized through the module dispatch framework, though Coverity can't see it due to the extensive type-punning. However, the control flow is so dizzingly complicated that I'm not even completely sure, so adding an extra assert to be careful won't hurt anyway. Change-Id: If3d7c5d5c5bba846e7453b3dbc824e2208d749fb Signed-off-by: Jacob Garber <jgarber1(a)ualberta.ca> Found-by: Coverity CID 1379932 --- M src/drivers/amd/agesa/state_machine.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/33214/1 diff --git a/src/drivers/amd/agesa/state_machine.c b/src/drivers/amd/agesa/state_machine.c index c8529c5e..750d192 100644 --- a/src/drivers/amd/agesa/state_machine.c +++ b/src/drivers/amd/agesa/state_machine.c @@ -272,7 +272,7 @@ /* Must call the function buffer was allocated for.*/ AMD_CONFIG_PARAMS *StdHeader = aip.NewStructPtr; - ASSERT(StdHeader->Func == func); + ASSERT(StdHeader != NULL && StdHeader->Func == func); if (CONFIG(AGESA_EXTRA_TIMESTAMPS) && task.ts_entry_id) timestamp_add_now(task.ts_entry_id); -- To view, visit https://review.coreboot.org/c/coreboot/+/33214 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If3d7c5d5c5bba846e7453b3dbc824e2208d749fb Gerrit-Change-Number: 33214 Gerrit-PatchSet: 1 Gerrit-Owner: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-MessageType: newchange

4 3

Change in ...coreboot[master]: nb/amd/amdmct/mct: Remove duplicate if condition
by Jacob Garber (Code Review) 21 Jun '19

21 Jun '19

Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33213 Change subject: nb/amd/amdmct/mct: Remove duplicate if condition ...................................................................... nb/amd/amdmct/mct: Remove duplicate if condition The case when Speed == 5 is already dealt with on line 111. Change-Id: Icc41c00fb333a51001568f588c17f7b6c6a3a923 Signed-off-by: Jacob Garber <jgarber1(a)ualberta.ca> Found-by: Coverity CID 1229626 --- M src/northbridge/amd/amdmct/mct/mctardk4.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33213/1 diff --git a/src/northbridge/amd/amdmct/mct/mctardk4.c b/src/northbridge/amd/amdmct/mct/mctardk4.c index d112c46..2e16a80 100644 --- a/src/northbridge/amd/amdmct/mct/mctardk4.c +++ b/src/northbridge/amd/amdmct/mct/mctardk4.c @@ -128,8 +128,6 @@ *AddrTmgCTL = 0x002F2F00; } else if (Speed == 1) { *AddrTmgCTL = 0x002F2F00; - } else if (Speed == 5) { - *AddrTmgCTL = 0x002F2020; } else { *AddrTmgCTL = 0x002F2F2F; } -- To view, visit https://review.coreboot.org/c/coreboot/+/33213 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc41c00fb333a51001568f588c17f7b6c6a3a923 Gerrit-Change-Number: 33213 Gerrit-PatchSet: 1 Gerrit-Owner: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-MessageType: newchange

5 6

Change in ...coreboot[master]: nb/amd/amdmct/mct_ddr3: Remove duplicate conditional
by Jacob Garber (Code Review) 21 Jun '19

21 Jun '19

Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33264 Change subject: nb/amd/amdmct/mct_ddr3: Remove duplicate conditional ...................................................................... nb/amd/amdmct/mct_ddr3: Remove duplicate conditional This check is already performed at the beginning of dct_ddr_voltage_index(). Change-Id: Ia73025333c152f14249afb16d05f66791e69e7cb Signed-off-by: Jacob Garber <jgarber1(a)ualberta.ca> Found-by: Coverity CID 1347322, 1347323 --- M src/northbridge/amd/amdmct/mct_ddr3/mct_d.c 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/33264/1 diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c index 5be4566..b30a663 100644 --- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c +++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c @@ -3071,11 +3071,6 @@ */ uint8_t dimm_event_l_pin_support = 0; - if (pDCTstat->DIMMValidDCT[dct] == 0) - ddr_voltage_index = 1; - else - ddr_voltage_index = dct_ddr_voltage_index(pDCTstat, dct); - ddr_voltage_index = dct_ddr_voltage_index(pDCTstat, dct); max_dimms_installable = mctGet_NVbits(NV_MAX_DIMMS_PER_CH); -- To view, visit https://review.coreboot.org/c/coreboot/+/33264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia73025333c152f14249afb16d05f66791e69e7cb Gerrit-Change-Number: 33264 Gerrit-PatchSet: 1 Gerrit-Owner: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-MessageType: newchange

3 2

Change in ...coreboot[master]: nb/amd/amdmct/mct_ddr3: Remove duplicate code
by Jacob Garber (Code Review) 21 Jun '19

21 Jun '19

Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33267 Change subject: nb/amd/amdmct/mct_ddr3: Remove duplicate code ...................................................................... nb/amd/amdmct/mct_ddr3: Remove duplicate code This conditional is exactly the same as the one right below it, except the operations are reorganized slightly. Change-Id: I00c19a467d23a0736bc2a33b516f97080039e634 Signed-off-by: Jacob Garber <jgarber1(a)ualberta.ca> Found-by: Coverity CID 1347321 --- M src/northbridge/amd/amdmct/mct_ddr3/mct_d.c 1 file changed, 0 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/33267/1 diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c index 5be4566..945ae82 100644 --- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c +++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c @@ -3090,12 +3090,6 @@ if (pDCTstat->DIMMValidDCT[0] && pDCTstat->DIMMValidDCT[1] && mctGet_NVbits(NV_Unganged)) interleave_channels = 1; - dword = (Get_NB32_DCT(dev, dct, 0x240) >> 4) & 0xf; - if (dword > 6) - read_odt_delay = dword - 6; - else - read_odt_delay = 0; - dword = Get_NB32_DCT(dev, dct, 0x240); delay = (dword >> 4) & 0xf; if (delay > 6) -- To view, visit https://review.coreboot.org/c/coreboot/+/33267 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00c19a467d23a0736bc2a33b516f97080039e634 Gerrit-Change-Number: 33267 Gerrit-PatchSet: 1 Gerrit-Owner: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-MessageType: newchange

3 3

Change in ...coreboot[master]: cbfstool: Add ifittool
by Patrick Rudolph (Code Review) 21 Jun '19

21 Jun '19

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31493 ) Change subject: cbfstool: Add ifittool ...................................................................... Patch Set 13: (11 comments) https://review.coreboot.org/#/c/31493/12/util/cbfstool/fit.h File util/cbfstool/fit.h: https://review.coreboot.org/#/c/31493/12/util/cbfstool/fit.h@77 PS12, Line 77: const char *microcode_blob_name, unsigned int empty_entries, > line over 80 characters Done https://review.coreboot.org/#/c/31493/12/util/cbfstool/fit.c File util/cbfstool/fit.c: https://review.coreboot.org/#/c/31493/12/util/cbfstool/fit.c@205 PS12, Line 205: /* Check that the address field has the proper signature. */ > null pointer? Done https://review.coreboot.org/#/c/31493/12/util/cbfstool/fit.c@234 PS12, Line 234: fit->header.checksum = 0; > null pointer? Done https://review.coreboot.org/#/c/31493/12/util/cbfstool/fit.c@254 PS12, Line 254: bgets(buf, &file->magic, sizeof(file->magic)); > null pointer? Done https://review.coreboot.org/#/c/31493/12/util/cbfstool/fit.c@295 PS12, Line 295: mcus = malloc(sizeof(*mcus) * max_fit_entries); > I always think it's bad practice to malloc something within a function and free it somewhere else. […] Done https://review.coreboot.org/#/c/31493/12/util/cbfstool/fit.c@366 PS12, Line 366: entry->address = acm_addr; > null pointer? Done https://review.coreboot.org/#/c/31493/12/util/cbfstool/fit.c@388 PS12, Line 388: entry->address = sm_addr; > null pointer? Done https://review.coreboot.org/#/c/31493/12/util/cbfstool/fit.c@417 PS12, Line 417: { > null pointer? Done https://review.coreboot.org/#/c/31493/12/util/cbfstool/fit.c@431 PS12, Line 431: entry->address = txt_policy_addr; > null pointer? Done https://review.coreboot.org/#/c/31493/12/util/cbfstool/fit.c@650 PS12, Line 650: struct fit_entry *entry; > null pointer? Done https://review.coreboot.org/#/c/31493/12/util/cbfstool/fit.c@750 PS12, Line 750: const char *microcode_blob_name, unsigned int empty_entries, > line over 80 characters Done -- To view, visit https://review.coreboot.org/c/coreboot/+/31493 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0fe8cd70611d58823aca1147d5b830722ed72bd5 Gerrit-Change-Number: 31493 Gerrit-PatchSet: 13 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Amol N Sukerkar <amol.n.sukerkar(a)intel.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jens Drenhaus <jens.drenhaus(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kai Michaelis <kai.michaelis(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Roy Wen <rgzwen(a)arista.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Christian Walter <christian.walter(a)9elements.com> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Jun 2019 07:40:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Christian Walter <christian.walter(a)9elements.com> Comment-In-Reply-To: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2019