coreboot-gerrit June 2019

coreboot-gerrit@coreboot.org

1 participants
1454 discussions

Change in ...coreboot[master]: device/pci_rom: Fix on-board optionrom address
by Kyösti Mälkki (Code Review) 30 Jun '19

30 Jun '19

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33908 ) Change subject: device/pci_rom: Fix on-board optionrom address ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/33908 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14374954af09201494bf2f13e5a6e4dc640c05ee Gerrit-Change-Number: 33908 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 30 Jun 2019 04:06:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Documentation/releases: Fix typo in IASL version
by HAOUAS Elyes (Code Review) 29 Jun '19

29 Jun '19

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30349 ) Change subject: Documentation/releases: Fix typo in IASL version ...................................................................... Patch Set 1: to move to 'Abandoned' status? -- To view, visit https://review.coreboot.org/c/coreboot/+/30349 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e6584289b07d006c9edc1aa2a5147fa295ae93e Gerrit-Change-Number: 30349 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 29 Jun 2019 18:42:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/broadwell: transition away from device_t
by HAOUAS Elyes (Code Review) 29 Jun '19

29 Jun '19

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/17318 ) Change subject: soc/intel/broadwell: transition away from device_t ...................................................................... Patch Set 1: to move to 'Abandoned' status -- To view, visit https://review.coreboot.org/c/coreboot/+/17318 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibadf383f81e78e160749f1811b6224b417d2a1f9 Gerrit-Change-Number: 17318 Gerrit-PatchSet: 1 Gerrit-Owner: Antonello Dettori <dev(a)dettori.io> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 29 Jun 2019 18:33:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: tint: introduce the new tint build system with checksum verification
by Mike Banon (Code Review) 29 Jun '19

29 Jun '19

Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/23856 ) Change subject: tint: introduce the new tint build system with checksum verification ...................................................................... Abandoned Too many revisions, need a fresh start. -- To view, visit https://review.coreboot.org/c/coreboot/+/23856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1d24f222d1b92030b81bba3951e243a2a9f37290 Gerrit-Change-Number: 23856 Gerrit-PatchSet: 15 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: G505S AtomBIOS ROMs: known good binaries with a script to check their...
by mikeb mikeb (Code Review) 29 Jun '19

29 Jun '19

Hello Mike Banon, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/31944 to review the following change. Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ...................................................................... G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 This change is a mirror for the known good AMD Lenovo G505S AtomBIOS ROMs from this repository - https://github.com/g505s-opensource-researcher/g505s-atombios AtomBIOS ROMs are required to enable the integrated and discrete VGA adapters, however to add the discrete GPU support you will also need to apply these patches: https://review.coreboot.org/c/coreboot/+/31929 G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches Here are the SHA256 checksums for these AtomBIOS ROMs: 6104e6989ea3f494d7bfa30573bf38e830f1068bab9980caec5e890e0ccbfced ./pci1002,990b.rom - for integrated GPU (iGPU) HD-8650G 6052b5def3fda2a93f6c4d55ec91b819429e212e26cdb8e0fcca54599c9c92ed ./pci1002,6663.rom - for discrete GPU (dGPU) HD-8570M 15d74515332bc512de66e0dc910d8600aeb134bf715bbc34a4faac0257f4a0dc ./pci1002,6665.rom - for discrete GPU (dGPU) R5-M230 Save to ./coreboot/ then run ./extract_atombios_roms.sh and ./check... . Could analyze these ROMs with AtomDis - https://cgit.freedesktop.org/~mhopf/AtomDis/ pci1002,990b.rom (for iGPU HD-8650G) has been taken from G505S with R5-M230, and despite the tiny voltage difference - it's working great for all G505S versions. https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/ GZNWISLFHUTYN6C7RTWSQUMJIFOUHMED/ Signed-off-by: Mike Banon <mikebdp2(a)gmail.com> Change-Id: I0cb38927e3f5ae0f0850ca8bc79be791c51ae503 --- A check_atombios_roms.sh A extract_atombios_roms.sh A pci1002,6663.rom.txt A pci1002,6665.rom.txt A pci1002,990b.rom.txt A sha256sums_atombios_correct.txt 6 files changed, 8,082 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/31944/1 -- To view, visit https://review.coreboot.org/c/coreboot/+/31944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cb38927e3f5ae0f0850ca8bc79be791c51ae503 Gerrit-Change-Number: 31944 Gerrit-PatchSet: 1 Gerrit-Owner: mikeb mikeb <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-MessageType: newchange

4 13

Change in ...coreboot[master]: G505S dGPU support: scripts for applying the unofficial (not-merged-y...
by mikeb mikeb (Code Review) 29 Jun '19

29 Jun '19

Hello Mike Banon, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/31929 to review the following change. Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) updates ...................................................................... G505S dGPU support: scripts for applying the unofficial (not-merged-yet) updates These scripts will help you to securely and conveniently apply the three changes 31357, 31448, 31450 to add the discrete GPU support for AMD Lenovo G505S laptop. Save to ./coreboot/ then run ./get_dgpu_patches.sh , ./check... and ./apply... https://review.coreboot.org/c/coreboot/+/31357 src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware https://review.coreboot.org/c/coreboot/+/31448 src/device/pci: Add support for discrete VGA initialization and OpROM loading https://review.coreboot.org/c/coreboot/+/31450 lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop Signed-off-by: Mike Banon <mikebdp2(a)gmail.com> Change-Id: I956f360681762b4321ba5d967f8a27b4a0387a73 --- A apply_dgpu_patches.sh A check_dgpu_patches.sh A get_dgpu_patches.sh A sha256sums_dgpu_correct.txt 4 files changed, 50 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/31929/1 diff --git a/apply_dgpu_patches.sh b/apply_dgpu_patches.sh new file mode 100755 index 0000000..972800a --- /dev/null +++ b/apply_dgpu_patches.sh @@ -0,0 +1,16 @@ +#!/bin/sh +### +### https://review.coreboot.org/c/coreboot/+/31357 +### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware +### +patch -p1 < f5c1e4d.diff +### +### https://review.coreboot.org/c/coreboot/+/31448 +### src/device/pci: Add support for discrete VGA initialization and OpROM loading +### +patch -p1 < 828c74a.diff +### +### https://review.coreboot.org/c/coreboot/+/31450 +### lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop +### +patch -p1 < 54dd729.diff diff --git a/check_dgpu_patches.sh b/check_dgpu_patches.sh new file mode 100755 index 0000000..cae1e9f --- /dev/null +++ b/check_dgpu_patches.sh @@ -0,0 +1,11 @@ +#!/bin/sh +rm -f ./sha256sums_dgpu_my.txt +sha256sum ./f5c1e4d.diff > ./sha256sums_dgpu_my.txt +sha256sum ./828c74a.diff >> ./sha256sums_dgpu_my.txt +sha256sum ./54dd729.diff >> ./sha256sums_dgpu_my.txt +if cmp -s "./sha256sums_dgpu_my.txt" "./sha256sums_dgpu_correct.txt" +then + echo "SHA256 checksums are correct, please run ./apply_dgpu_patches.sh" +else + echo "! MISMATCH ! See ./sha256sums_dgpu_my.txt and ./sha256sums_dgpu_correct.txt" +fi diff --git a/get_dgpu_patches.sh b/get_dgpu_patches.sh new file mode 100755 index 0000000..c1703df --- /dev/null +++ b/get_dgpu_patches.sh @@ -0,0 +1,20 @@ +#!/bin/sh +rm -f ./*.diff && rm -f ./patch\?zip +### +### https://review.coreboot.org/c/coreboot/+/31357 +### src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware +### +wget https://review.coreboot.org/changes/31357/revisions/6/patch?zip +unzip ./patch\?zip && rm -f ./patch\?zip # && patch -p1 < f5c1e4d.diff +### +### https://review.coreboot.org/c/coreboot/+/31448 +### src/device/pci: Add support for discrete VGA initialization and OpROM loading +### +wget https://review.coreboot.org/changes/31448/revisions/8/patch?zip +unzip ./patch\?zip && rm -f ./patch\?zip # && patch -p1 < 828c74a.diff +### +### https://review.coreboot.org/c/coreboot/+/31450 +### lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop +### +wget https://review.coreboot.org/changes/31450/revisions/8/patch?zip +unzip ./patch\?zip && rm -f ./patch\?zip # && patch -p1 < 54dd729.diff diff --git a/sha256sums_dgpu_correct.txt b/sha256sums_dgpu_correct.txt new file mode 100644 index 0000000..b519a6a --- /dev/null +++ b/sha256sums_dgpu_correct.txt @@ -0,0 +1,3 @@ +1e6dff37ae1b8080c431f25b7a12c561bd949dfa68f6487a1bece39941f74195 ./f5c1e4d.diff +1879c633478c105eb9d66afa97fc59db0c850a813d4bcdb3693a6f52645092d8 ./828c74a.diff +a055e0d1fff668b95da68b7b6c7274d000bbf90572747b4f33de7f5f59a5bb44 ./54dd729.diff -- To view, visit https://review.coreboot.org/c/coreboot/+/31929 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I956f360681762b4321ba5d967f8a27b4a0387a73 Gerrit-Change-Number: 31929 Gerrit-PatchSet: 1 Gerrit-Owner: mikeb mikeb <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-MessageType: newchange

4 28

Change in ...coreboot[master]: MAINTAINERS: Add myself as a maintainer for Lenovo G505S and ASUS AM1I-A
by Mike Banon (Code Review) 29 Jun '19

29 Jun '19

Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33778 Change subject: MAINTAINERS: Add myself as a maintainer for Lenovo G505S and ASUS AM1I-A ...................................................................... MAINTAINERS: Add myself as a maintainer for Lenovo G505S and ASUS AM1I-A These are the boards I have and currently working on (also going to work on ASUS A88XM-E in the near future - there is a patch by Balázs Vinarz but not merged to coreboot yet, so too early to add any MAINTAINERS for it). Signed-off-by: Mike Banon <mikebdp2(a)gmail.com> Change-Id: I41550f6ce538ec6c48295f8aeaeabd916c28e385 --- M MAINTAINERS 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/33778/1 diff --git a/MAINTAINERS b/MAINTAINERS index e7780a8..0ccbbc2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -164,6 +164,11 @@ S: Maintained F: src/mainboard/lenovo/ +LENOVO G505S MAINBOARD +M: Mike Banon <mikebdp2(a)gmail.com> +S: Maintained +F: src/mainboard/lenovo/g505s + GETAC P470 MAINBOARD M: Patrick Georgi <patrick(a)georgi.software> S: Maintained @@ -328,6 +333,11 @@ S: Maintained F: src/mainboard/asrock/h81m-hds/ +ASUS AM1I-A MAINBOARD +M: Mike Banon <mikebdp2(a)gmail.com> +S: Maintained +F: src/mainboard/asus/am1i-a + ASUS KFSN4-DRE & KFSN4-DRE_K8 MAINBOARDS M: Timothy Pearson <tpearson(a)raptorengineeringinc.com> S: Supported -- To view, visit https://review.coreboot.org/c/coreboot/+/33778 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41550f6ce538ec6c48295f8aeaeabd916c28e385 Gerrit-Change-Number: 33778 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-MessageType: newchange

2 3

Change in ...coreboot[master]: src/mainboard/asus/am1i-a: Disable SeaBIOS options not supported by h...
by Mike Banon (Code Review) 29 Jun '19

29 Jun '19

Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33869 Change subject: src/mainboard/asus/am1i-a: Disable SeaBIOS options not supported by hardware ...................................................................... src/mainboard/asus/am1i-a: Disable SeaBIOS options not supported by hardware AM1I-A does not have any SAS or NVMe controllers, so it makes sense to disable the related SeaBIOS options for this motherboard. This reduces the size of compiled SeaBIOS by 129344-124096 = 5248 bytes. Signed-off-by: Mike Banon <mikebdp2(a)gmail.com> Change-Id: I3f161c4ade56670fb7195a2c3f1d32e3288fba00 --- A src/mainboard/asus/am1i-a/config_seabios 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/33869/1 diff --git a/src/mainboard/asus/am1i-a/config_seabios b/src/mainboard/asus/am1i-a/config_seabios new file mode 100644 index 0000000..95cddb5 --- /dev/null +++ b/src/mainboard/asus/am1i-a/config_seabios @@ -0,0 +1,5 @@ +### +### SeaBIOS custom configuration for ASUS AM1I-A +### +# CONFIG_MEGASAS is not set +# CONFIG_NVME is not set -- To view, visit https://review.coreboot.org/c/coreboot/+/33869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f161c4ade56670fb7195a2c3f1d32e3288fba00 Gerrit-Change-Number: 33869 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-MessageType: newchange

1 5

Change in ...coreboot[master]: src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by ...
by mikeb mikeb (Code Review) 29 Jun '19

29 Jun '19

Hello Mike Banon, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/31357 to review the following change. Change subject: src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware ...................................................................... src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware G505S does not have any SAS or NVMe controllers and could not have a TPM, so it makes sense to disable the related SeaBIOS options for this laptop. Signed-off-by: Mike Banon <mikebdp2(a)gmail.com> Change-Id: I5b2ee6403d7d2298725729d8d833e37627a4f202 --- M src/mainboard/lenovo/g505s/Kconfig A src/mainboard/lenovo/g505s/config_seabios 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/31357/1 diff --git a/src/mainboard/lenovo/g505s/Kconfig b/src/mainboard/lenovo/g505s/Kconfig index 883ef27..71ab909 100644 --- a/src/mainboard/lenovo/g505s/Kconfig +++ b/src/mainboard/lenovo/g505s/Kconfig @@ -55,4 +55,8 @@ string default "1002,990b" +config PAYLOAD_CONFIGFILE + string + default "$(top)/src/mainboard/$(MAINBOARDDIR)/config_seabios" if PAYLOAD_SEABIOS + endif # BOARD_LENOVO_G505S diff --git a/src/mainboard/lenovo/g505s/config_seabios b/src/mainboard/lenovo/g505s/config_seabios new file mode 100644 index 0000000..8d3957b --- /dev/null +++ b/src/mainboard/lenovo/g505s/config_seabios @@ -0,0 +1,6 @@ +# +# SeaBIOS custom configuration for Lenovo G505S +# +# CONFIG_MEGASAS is not set +# CONFIG_NVME is not set +# CONFIG_TCGBIOS is not set -- To view, visit https://review.coreboot.org/c/coreboot/+/31357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b2ee6403d7d2298725729d8d833e37627a4f202 Gerrit-Change-Number: 31357 Gerrit-PatchSet: 1 Gerrit-Owner: mikeb mikeb <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-MessageType: newchange

4 12

Change in ...coreboot[master]: pci_ids.h: Add AMD Picasso IDs
by Edward O'Callaghan (Code Review) 29 Jun '19

29 Jun '19

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33748 ) Change subject: pci_ids.h: Add AMD Picasso IDs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/33748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4ac67d1577229e63424dd7fd0ff84d1acfe826c3 Gerrit-Change-Number: 33748 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 29 Jun 2019 08:49:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2019