Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33326 )
Change subject: mb/google/hatch: Disable dynamic clock gating for cr50's GPIO
......................................................................
Patch Set 2:
> Patch Set 2:
>
> This works to observe even the skinniest cr50 irqs. Cool! I've updated it to only mess with COMM_4, since that's the one cr50 is on. Subrata, is it better to clobber all the flags that were in here, or is there a more minimal set of changes that can be made?
i think your patchset 2 makes more sense as it just disable all gpio pm dynamic clock gating option. can you please share your cbmem -t (with release cb build) after this modification
--
To view, visit https://review.coreboot.org/c/coreboot/+/33326
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34d14fb7cc97e33eecfda2c99cc53a541c87662d
Gerrit-Change-Number: 33326
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 11 Jun 2019 02:16:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33326 )
Change subject: mb/google/hatch: Disable dynamic clock gating for cr50's GPIO
......................................................................
Patch Set 2:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33326
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34d14fb7cc97e33eecfda2c99cc53a541c87662d
Gerrit-Change-Number: 33326
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 11 Jun 2019 02:13:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33377 )
Change subject: mb/google/octopus: Add API to disable USB devices from devicetree
......................................................................
Patch Set 1:
(1 comment)
This change is ready for review.
https://review.coreboot.org/#/c/33377/1/src/mainboard/google/octopus/mainbo…
File src/mainboard/google/octopus/mainboard.c:
https://review.coreboot.org/#/c/33377/1/src/mainboard/google/octopus/mainbo…
PS1, Line 191: usb_device_disable
Prefer two improvements:
1) move inside src/soc/intel/common/block/xhci.c
2) Check Current Connect Status(CCS) bit in the USB Port Status and Control register in the XHCI register block and then disable the unconnected devices. I believe it works for externally visible ports too.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33377
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied12faabee1b8c096f2b27de89ab42ee8be5d94d
Gerrit-Change-Number: 33377
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-Comment-Date: Mon, 10 Jun 2019 21:22:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33376 )
Change subject: device: Move pci_irq_info out of early devicetree
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33376
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icde376f9cf7431f09d7eb7e738b38e7dd97be8eb
Gerrit-Change-Number: 33376
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-Comment-Date: Mon, 10 Jun 2019 21:18:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment