Felix Singer has uploaded a new patch set (#18) to the change originally created by Frans Hendriks. ( https://review.coreboot.org/c/coreboot/+/23135 )
Change subject: superio: Add ASpeed AST2400
......................................................................
superio: Add ASpeed AST2400
Add support for ASpeed AST2400.
This device uses write twice 0xA5 to enter config mode.
BUG = N/A
TEST = ASRock D1521D4U
Change-Id: I58fce31f0a2483e61e9d31f38ab5a059b8cf4f83
Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com>
Signed-off-by: Felix Singer <migy(a)darmstadt.ccc.de>
---
M src/include/superio/conf_mode.h
M src/superio/Makefile.inc
A src/superio/aspeed/Makefile.inc
A src/superio/aspeed/ast2400/Kconfig
A src/superio/aspeed/ast2400/Makefile.inc
A src/superio/aspeed/ast2400/ast2400.h
A src/superio/aspeed/ast2400/superio.c
A src/superio/aspeed/common/Kconfig
A src/superio/aspeed/common/aspeed.h
A src/superio/aspeed/common/early_serial.c
M src/superio/common/conf_mode.c
11 files changed, 315 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/23135/18
--
To view, visit https://review.coreboot.org/c/coreboot/+/23135
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58fce31f0a2483e61e9d31f38ab5a059b8cf4f83
Gerrit-Change-Number: 23135
Gerrit-PatchSet: 18
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-MessageType: newpatchset
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29470 )
Change subject: src/mainboard/portwell/m107: Do initial mainboard commit
......................................................................
Patch Set 8:
> Patch Set 8:
>
> (23 comments)
Will implement the comment.
--
To view, visit https://review.coreboot.org/c/coreboot/+/29470
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d3173fdcf881f894a75cd9798ba173b425d4e62
Gerrit-Change-Number: 29470
Gerrit-PatchSet: 8
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Fri, 12 Apr 2019 12:56:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23135 )
Change subject: superio: Add ASpeed AST2400
......................................................................
Patch Set 17:
(1 comment)
https://review.coreboot.org/#/c/23135/17/src/superio/aspeed/ast2400/ast2400…
File src/superio/aspeed/ast2400/ast2400.h:
https://review.coreboot.org/#/c/23135/17/src/superio/aspeed/ast2400/ast2400…
PS17, Line 37: void aspeed2400_enable_serial(u16 port, u16 device, u16 iobase);
> seems to be unused
This function will be called 'external (e.g. mainboard)'to enable the serial port.
--
To view, visit https://review.coreboot.org/c/coreboot/+/23135
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58fce31f0a2483e61e9d31f38ab5a059b8cf4f83
Gerrit-Change-Number: 23135
Gerrit-PatchSet: 17
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Comment-Date: Fri, 12 Apr 2019 09:16:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-MessageType: comment
Felix Singer has uploaded a new patch set (#17) to the change originally created by Frans Hendriks. ( https://review.coreboot.org/c/coreboot/+/23135 )
Change subject: superio: Add ASpeed AST2400
......................................................................
superio: Add ASpeed AST2400
Add support for ASpeed AST2400.
This device uses write twice 0xA5 to enter config mode.
BUG = N/A
TEST = ASRock D1521D4U
Change-Id: I58fce31f0a2483e61e9d31f38ab5a059b8cf4f83
Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com>
Signed-off-by: Felix Singer <migy(a)darmstadt.ccc.de>
---
M src/include/superio/conf_mode.h
M src/superio/Makefile.inc
A src/superio/aspeed/Makefile.inc
A src/superio/aspeed/ast2400/Kconfig
A src/superio/aspeed/ast2400/Makefile.inc
A src/superio/aspeed/ast2400/ast2400.h
A src/superio/aspeed/ast2400/superio.c
A src/superio/aspeed/common/Kconfig
A src/superio/aspeed/common/aspeed.h
A src/superio/aspeed/common/early_serial.c
M src/superio/common/conf_mode.c
11 files changed, 312 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/23135/17
--
To view, visit https://review.coreboot.org/c/coreboot/+/23135
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58fce31f0a2483e61e9d31f38ab5a059b8cf4f83
Gerrit-Change-Number: 23135
Gerrit-PatchSet: 17
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset