coreboot-gerrit December 2019

coreboot-gerrit@coreboot.org

1 participants
1761 discussions

Change in coreboot[4.11_branch]: mb/ocp/monolake: Override SMBIOS data with IPMI read FRU data
by Johnny Lin (Code Review) 11 Dec '19

11 Dec '19

Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37445 ) Change subject: mb/ocp/monolake: Override SMBIOS data with IPMI read FRU data ...................................................................... Patch Set 11: (1 comment) https://review.coreboot.org/c/coreboot/+/37445/8/src/mainboard/ocp/monolake… File src/mainboard/ocp/monolake/mainboard.c: https://review.coreboot.org/c/coreboot/+/37445/8/src/mainboard/ocp/monolake… PS8, Line 133: } else > nit: use braces for the else clauses, since the if clauses are multiple lines […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/37445 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: 4.11_branch Gerrit-Change-Id: I58cbe95055dea053b115e99f354f40d5902c6a35 Gerrit-Change-Number: 37445 Gerrit-PatchSet: 11 Gerrit-Owner: Johnny Lin Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jingle Hsu Gerrit-Reviewer: Johnny Lin Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Morgan Jang Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Dec 2019 06:17:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[4.11_branch]: drivers/ipmi: Add IPMI Read FRU function
by Johnny Lin (Code Review) 11 Dec '19

11 Dec '19

Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37444 ) Change subject: drivers/ipmi: Add IPMI Read FRU function ...................................................................... Patch Set 8: (13 comments) https://review.coreboot.org/c/coreboot/+/37444/6/src/drivers/ipmi/ipmi_fru.c File src/drivers/ipmi/ipmi_fru.c: https://review.coreboot.org/c/coreboot/+/37444/6/src/drivers/ipmi/ipmi_fru.… PS6, Line 58: 30 > This looks arbitrary. To make the rationale for 30ms clear, how about making a #define such as: […] Done https://review.coreboot.org/c/coreboot/+/37444/6/src/drivers/ipmi/ipmi_fru.… PS6, Line 67: + > nit: space on each side of '+' operator Done https://review.coreboot.org/c/coreboot/+/37444/6/src/drivers/ipmi/ipmi_fru.… PS6, Line 98: + > nit: space around '+' operator Done https://review.coreboot.org/c/coreboot/+/37444/6/src/drivers/ipmi/ipmi_fru.… PS6, Line 103: void > Oh, I see now... […] Yes current design is the caller needs to check if the string is NULL to know if it's successfully read or not. If you think it's better to return a type please let me know. https://review.coreboot.org/c/coreboot/+/37444/6/src/drivers/ipmi/ipmi_fru.… PS6, Line 104: > nit: spacing (this looks like it became a tab?) Done https://review.coreboot.org/c/coreboot/+/37444/6/src/drivers/ipmi/ipmi_fru.… PS6, Line 110: offset = offset * 8; > I wonder if it's worth adding a comment about this... […] Done https://review.coreboot.org/c/coreboot/+/37444/6/src/drivers/ipmi/ipmi_fru.… PS6, Line 115: + > nit: spacing around '+' operator (there are a few occurrences in this functions) Done https://review.coreboot.org/c/coreboot/+/37444/6/src/drivers/ipmi/ipmi_fru.… PS6, Line 121: * 8 > same comment as above w.r.t. […] Done https://review.coreboot.org/c/coreboot/+/37444/6/src/drivers/ipmi/ipmi_fru.… PS6, Line 139: bit[5:0] is the string length. > Since this is used several times, maybe a macro will make it easier to follow: […] Done https://review.coreboot.org/c/coreboot/+/37444/6/src/drivers/ipmi/ipmi_fru.… PS6, Line 199: void > does it make sense to add a return type? Same as above. https://review.coreboot.org/c/coreboot/+/37444/6/src/drivers/ipmi/ipmi_fru.… PS6, Line 205: > Same comments apply to this function (spaces around '+' operator, suggested macros for 8x multiplier […] Done https://review.coreboot.org/c/coreboot/+/37444/6/src/drivers/ipmi/ipmi_fru.… PS6, Line 337: t*/ > missing space at the end of the comment Done https://review.coreboot.org/c/coreboot/+/37444/6/src/drivers/ipmi/ipmi_ops.h File src/drivers/ipmi/ipmi_ops.h: https://review.coreboot.org/c/coreboot/+/37444/6/src/drivers/ipmi/ipmi_ops.… PS6, Line 56: uint8_t count; /* count to read. */ > It might be useful to note in the comment that it's 1-based, i.e.: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/37444 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: 4.11_branch Gerrit-Change-Id: Id6353f5ce3f7ddd3bb161b91364b3cf276d020b8 Gerrit-Change-Number: 37444 Gerrit-PatchSet: 8 Gerrit-Owner: Johnny Lin Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jingle Hsu Gerrit-Reviewer: Johnny Lin Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Morgan Jang Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Dec 2019 06:16:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[4.11_branch]: drivers/ipmi: Add IPMI Read FRU function
by Johnny Lin (Code Review) 11 Dec '19

11 Dec '19

Hello Andrey Petrov, Jingle Hsu, Morgan Jang, Patrick Rudolph, Jonathan Zhang, David Hendricks, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/37444 to look at the new patch set (#8). Change subject: drivers/ipmi: Add IPMI Read FRU function ...................................................................... drivers/ipmi: Add IPMI Read FRU function Implemented according to IPMI "Platform Management FRU Information Storage Definition" specification v1.0 for reading FRU data Product Info Area and Board Info Area. SMBIOS data can be updated with the FRU data. Tested on OCP Mono Lake. Change-Id: Id6353f5ce3f7ddd3bb161b91364b3cf276d020b8 Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com> --- M src/drivers/ipmi/Kconfig M src/drivers/ipmi/Makefile.inc A src/drivers/ipmi/ipmi_fru.c M src/drivers/ipmi/ipmi_kcs.h M src/drivers/ipmi/ipmi_ops.h 5 files changed, 494 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/37444/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/37444 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: 4.11_branch Gerrit-Change-Id: Id6353f5ce3f7ddd3bb161b91364b3cf276d020b8 Gerrit-Change-Number: 37444 Gerrit-PatchSet: 8 Gerrit-Owner: Johnny Lin Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jingle Hsu Gerrit-Reviewer: Johnny Lin Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Morgan Jang Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[4.11_branch]: mb/ocp/monolake: Override SMBIOS data with IPMI read FRU data
by Johnny Lin (Code Review) 11 Dec '19

11 Dec '19

Hello Andrey Petrov, Jingle Hsu, Morgan Jang, Patrick Rudolph, Jonathan Zhang, David Hendricks, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/37445 to look at the new patch set (#10). Change subject: mb/ocp/monolake: Override SMBIOS data with IPMI read FRU data ...................................................................... mb/ocp/monolake: Override SMBIOS data with IPMI read FRU data SMBIOS type 1 data fields are overwritten by FRU product info area data, SMBIOS type 2 fields are overwritten by FRU board info area data. Tested on OCP Mono Lake. Change-Id: I58cbe95055dea053b115e99f354f40d5902c6a35 Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com> --- M src/mainboard/ocp/monolake/Kconfig M src/mainboard/ocp/monolake/mainboard.c 2 files changed, 89 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/37445/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/37445 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: 4.11_branch Gerrit-Change-Id: I58cbe95055dea053b115e99f354f40d5902c6a35 Gerrit-Change-Number: 37445 Gerrit-PatchSet: 10 Gerrit-Owner: Johnny Lin Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jingle Hsu Gerrit-Reviewer: Johnny Lin Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Morgan Jang Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[4.11_branch]: drivers/ipmi: Add IPMI Read FRU function
by Johnny Lin (Code Review) 11 Dec '19

11 Dec '19

Hello Andrey Petrov, Jingle Hsu, Morgan Jang, Patrick Rudolph, Jonathan Zhang, David Hendricks, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/37444 to look at the new patch set (#7). Change subject: drivers/ipmi: Add IPMI Read FRU function ...................................................................... drivers/ipmi: Add IPMI Read FRU function Implemented according to IPMI "Platform Management FRU Information Storage Definition" specification v1.0 for reading FRU data Product Info Area and Board Info Area. SMBIOS data can be updated with the FRU data. Tested on OCP Mono Lake. Change-Id: Id6353f5ce3f7ddd3bb161b91364b3cf276d020b8 Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com> --- M src/drivers/ipmi/Kconfig M src/drivers/ipmi/Makefile.inc A src/drivers/ipmi/ipmi_fru.c M src/drivers/ipmi/ipmi_kcs.h M src/drivers/ipmi/ipmi_ops.h 5 files changed, 494 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/37444/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/37444 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: 4.11_branch Gerrit-Change-Id: Id6353f5ce3f7ddd3bb161b91364b3cf276d020b8 Gerrit-Change-Number: 37444 Gerrit-PatchSet: 7 Gerrit-Owner: Johnny Lin Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jingle Hsu Gerrit-Reviewer: Johnny Lin Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Morgan Jang Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/tigerlake: Fix build issues
by build bot (Jenkins) (Code Review) 11 Dec '19

11 Dec '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37426 ) Change subject: soc/intel/tigerlake: Fix build issues ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/c/coreboot/+/37426/5/src/soc/intel/tigerlake/in… File src/soc/intel/tigerlake/include/soc/romstage.h: https://review.coreboot.org/c/coreboot/+/37426/5/src/soc/intel/tigerlake/in… PS5, Line 21: void mainboard_fspm_params(FSPM_UPD *mupd); need consistent spacing around '*' (ctx:WxV) -- To view, visit https://review.coreboot.org/c/coreboot/+/37426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I04020d55f1063d521b15f8d0dabbd6f1dabf577c Gerrit-Change-Number: 37426 Gerrit-PatchSet: 5 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Venkata Krishna Nimmagadda Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Wed, 11 Dec 2019 03:20:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/tigerlake: Update GPIO configuration
by Wonkyu Kim (Code Review) 11 Dec '19

11 Dec '19

Wonkyu Kim has uploaded a new patch set (#6) to the change originally created by Ravishankar Sarawadi. ( https://review.coreboot.org/c/coreboot/+/37427 ) Change subject: soc/intel/tigerlake: Update GPIO configuration ...................................................................... soc/intel/tigerlake: Update GPIO configuration Add tigerlake SOC specific GPIO definitions and ASL setting. Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi(a)intel.com> Change-Id: I585100375feee39b5a9105bdf6d9f5ca3a5bb2fa --- M src/soc/intel/tigerlake/acpi/gpio.asl M src/soc/intel/tigerlake/gpio.c M src/soc/intel/tigerlake/include/soc/gpio.h M src/soc/intel/tigerlake/include/soc/gpio_defs.h M src/soc/intel/tigerlake/include/soc/gpio_soc_defs.h 5 files changed, 775 insertions(+), 573 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/37427/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/37427 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I585100375feee39b5a9105bdf6d9f5ca3a5bb2fa Gerrit-Change-Number: 37427 Gerrit-PatchSet: 6 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Venkata Krishna Nimmagadda Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/tigerlake: Fix build issues
by Wonkyu Kim (Code Review) 11 Dec '19

11 Dec '19

Wonkyu Kim has uploaded a new patch set (#5) to the change originally created by Ravishankar Sarawadi. ( https://review.coreboot.org/c/coreboot/+/37426 ) Change subject: soc/intel/tigerlake: Fix build issues ...................................................................... soc/intel/tigerlake: Fix build issues Add following to fix build issues: 1. Update ASL files: a. Add new PMC, SMBUS files b. Remove unused files c. Update tigerlake specific changes on top of icelake 2. Update tigerlake PMC_REG_BASE 3. Update SOC header files to include tigerlake specific 4. Update chip files to include tigerlake PCH DEVFNs Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi(a)intel.com> Change-Id: I04020d55f1063d521b15f8d0dabbd6f1dabf577c --- M src/soc/intel/Kconfig M src/soc/intel/tigerlake/Kconfig M src/soc/intel/tigerlake/acpi/northbridge.asl A src/soc/intel/tigerlake/acpi/pch_clock_ctl.asl M src/soc/intel/tigerlake/acpi/pci_irqs.asl M src/soc/intel/tigerlake/acpi/pcie.asl M src/soc/intel/tigerlake/acpi/platform.asl A src/soc/intel/tigerlake/acpi/pmc.asl D src/soc/intel/tigerlake/acpi/scs.asl M src/soc/intel/tigerlake/acpi/serialio.asl A src/soc/intel/tigerlake/acpi/sleepstates.asl R src/soc/intel/tigerlake/acpi/smbus.asl M src/soc/intel/tigerlake/acpi/southbridge.asl M src/soc/intel/tigerlake/bootblock/pch.c M src/soc/intel/tigerlake/chip.c M src/soc/intel/tigerlake/chip.h M src/soc/intel/tigerlake/fsp_params.c M src/soc/intel/tigerlake/include/soc/iomap.h M src/soc/intel/tigerlake/include/soc/irq.h M src/soc/intel/tigerlake/include/soc/pci_devs.h M src/soc/intel/tigerlake/include/soc/pmc.h M src/soc/intel/tigerlake/include/soc/ramstage.h M src/soc/intel/tigerlake/include/soc/romstage.h M src/soc/intel/tigerlake/include/soc/serialio.h M src/soc/intel/tigerlake/pmutil.c M src/soc/intel/tigerlake/romstage/fsp_params.c 26 files changed, 867 insertions(+), 457 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/37426/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/37426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I04020d55f1063d521b15f8d0dabbd6f1dabf577c Gerrit-Change-Number: 37426 Gerrit-PatchSet: 5 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Venkata Krishna Nimmagadda Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/tigerlake: Update GPIO configuration
by build bot (Jenkins) (Code Review) 11 Dec '19

11 Dec '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37427 ) Change subject: soc/intel/tigerlake: Update GPIO configuration ...................................................................... Patch Set 5: (30 comments) https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… File src/soc/intel/tigerlake/gpio.c: https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 61: INTEL_GPP_BASE(GPP_S0, GPP_S0, GPP_S7, 67), /* GPP_S */ code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 61: INTEL_GPP_BASE(GPP_S0, GPP_S0, GPP_S7, 67), /* GPP_S */ please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 62: INTEL_GPP_BASE(GPP_S0, GPP_H0, GPP_H23, 75), /* GPP_H */ code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 62: INTEL_GPP_BASE(GPP_S0, GPP_H0, GPP_H23, 75), /* GPP_H */ please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 63: INTEL_GPP_BASE(GPP_S0, GPP_D0, GPP_GSPI2_CLK_LOOPBK, 99), /* GPP_D */ code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 63: INTEL_GPP_BASE(GPP_S0, GPP_D0, GPP_GSPI2_CLK_LOOPBK, 99), /* GPP_D */ please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 64: INTEL_GPP_BASE(GPP_S0, GPP_U0, GPP_GSPI6_CLK_LOOPBK, 120), /* GPP_U */ code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 64: INTEL_GPP_BASE(GPP_S0, GPP_U0, GPP_GSPI6_CLK_LOOPBK, 120), /* GPP_U */ please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 65: INTEL_GPP_BASE(GPP_S0, GPP_VGPIO0, GPP_VGPIO37, 144), /* GPP_VGPIO */ code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 65: INTEL_GPP_BASE(GPP_S0, GPP_VGPIO0, GPP_VGPIO37, 144), /* GPP_VGPIO */ please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 70: INTEL_GPP_BASE(GPD0, GPD0, GPD_DRAM_RESETB, 171), /* GPD */ code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 70: INTEL_GPP_BASE(GPD0, GPD0, GPD_DRAM_RESETB, 171), /* GPD */ please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 75: INTEL_GPP_BASE(GPP_C0, GPP_C0, GPP_C23, 188), /* GPP_F */ code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 75: INTEL_GPP_BASE(GPP_C0, GPP_C0, GPP_C23, 188), /* GPP_F */ please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 76: INTEL_GPP_BASE(GPP_C0, GPP_F0, GPP_F_CLK_LOOPBK, 212), /* GPP_C */ code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 76: INTEL_GPP_BASE(GPP_C0, GPP_F0, GPP_F_CLK_LOOPBK, 212), /* GPP_C */ please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 77: INTEL_GPP_BASE(GPP_C0, GPP_L_BKLTEN, GPP_MLK_RSTB, 237), /* GPP_HVCMOS */ code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 77: INTEL_GPP_BASE(GPP_C0, GPP_L_BKLTEN, GPP_MLK_RSTB, 237), /* GPP_HVCMOS */ please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 78: INTEL_GPP_BASE(GPP_C0, GPP_E0, GPP_E_CLK_LOOPBK, 243), /* GPP_E */ code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 78: INTEL_GPP_BASE(GPP_C0, GPP_E0, GPP_E_CLK_LOOPBK, 243), /* GPP_E */ please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 79: INTEL_GPP_BASE(GPP_C0, GPP_JTAG_TDO, GPP_MLK, 268), /* GPP_JTAG */ code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 79: INTEL_GPP_BASE(GPP_C0, GPP_JTAG_TDO, GPP_MLK, 268), /* GPP_JTAG */ please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 182: { PMC_GPP_A, GPP_A }, code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 182: { PMC_GPP_A, GPP_A }, please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 189: { PMC_GPP_C, GPP_C }, code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 189: { PMC_GPP_C, GPP_C }, please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 191: { PMC_GPP_HVCMOS, GPP_HVCMOS }, code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 191: { PMC_GPP_HVCMOS, GPP_HVCMOS }, please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 195: { PMC_GPP_SPI, GPP_SPI } code indent should use tabs where possible https://review.coreboot.org/c/coreboot/+/37427/5/src/soc/intel/tigerlake/gp… PS5, Line 195: { PMC_GPP_SPI, GPP_SPI } please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/37427 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I585100375feee39b5a9105bdf6d9f5ca3a5bb2fa Gerrit-Change-Number: 37427 Gerrit-PatchSet: 5 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Venkata Krishna Nimmagadda Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Wed, 11 Dec 2019 02:57:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/tigerlake: Update GPIO configuration
by Wonkyu Kim (Code Review) 11 Dec '19

11 Dec '19

Wonkyu Kim has uploaded a new patch set (#5) to the change originally created by Ravishankar Sarawadi. ( https://review.coreboot.org/c/coreboot/+/37427 ) Change subject: soc/intel/tigerlake: Update GPIO configuration ...................................................................... soc/intel/tigerlake: Update GPIO configuration Add tigerlake SOC specific GPIO definitions and ASL setting. Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi(a)intel.com> Change-Id: I585100375feee39b5a9105bdf6d9f5ca3a5bb2fa --- M src/soc/intel/tigerlake/acpi/gpio.asl M src/soc/intel/tigerlake/gpio.c M src/soc/intel/tigerlake/include/soc/gpio.h M src/soc/intel/tigerlake/include/soc/gpio_defs.h M src/soc/intel/tigerlake/include/soc/gpio_soc_defs.h 5 files changed, 777 insertions(+), 575 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/37427/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/37427 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I585100375feee39b5a9105bdf6d9f5ca3a5bb2fa Gerrit-Change-Number: 37427 Gerrit-PatchSet: 5 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Venkata Krishna Nimmagadda Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2019