coreboot-gerrit November 2019

coreboot-gerrit@coreboot.org

1 participants
2418 discussions

Change in coreboot[master]: binaryPI: Drop CAR teardown without POSTCAR_STAGE
by Arthur Heymans (Code Review) 24 Nov '19

24 Nov '19

1 0

Change in coreboot[master]: binaryPI: Drop CAR teardown without POSTCAR_STAGE
by Kyösti Mälkki (Code Review) 24 Nov '19

24 Nov '19

1 0

Change in coreboot[master]: binaryPI: Drop CAR teardown without POSTCAR_STAGE
by Arthur Heymans (Code Review) 24 Nov '19

24 Nov '19

1 0

Change in coreboot[master]: binaryPI: Drop CAR teardown without POSTCAR_STAGE
by Kyösti Mälkki (Code Review) 24 Nov '19

24 Nov '19

1 0

Change in coreboot[master]: binaryPI: Drop CAR teardown without POSTCAR_STAGE
by Arthur Heymans (Code Review) 24 Nov '19

24 Nov '19

1 0

Change in coreboot[master]: binaryPI: Drop CAR teardown without POSTCAR_STAGE
by Kyösti Mälkki (Code Review) 24 Nov '19

24 Nov '19

1 0

Change in coreboot[master]: binaryPI: Drop CAR teardown without POSTCAR_STAGE
by Kyösti Mälkki (Code Review) 24 Nov '19

24 Nov '19

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18526 ) Change subject: binaryPI: Drop CAR teardown without POSTCAR_STAGE ...................................................................... Patch Set 8: (3 comments) https://review.coreboot.org/c/coreboot/+/18526/8//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/18526/8//COMMIT_MSG@11 PS8, Line 11: POSTCAR_STAGE now. I need to add references to changes and discussions. … [View More]This is really a revert for the gcccar.inc parts, to put it back into the state AMD originally shipped it. https://review.coreboot.org/c/coreboot/+/18526/8/src/vendorcode/amd/pi/0063… File src/vendorcode/amd/pi/00630F01/binaryPI/gcccar.inc: https://review.coreboot.org/c/coreboot/+/18526/8/src/vendorcode/amd/pi/0063… PS8, Line 1550: * AMD_DISABLE_STACK: Destroy the stack inside the cache. This routine : * should only be executed on the BSP > Is there some documentation of what is run on AP's by AGESA and in what state those are? The code be […] The source. https://review.coreboot.org/c/coreboot/+/18526/8/src/vendorcode/amd/pi/0063… PS8, Line 1574: : # Set lower 640K MTRRs for Write-Back memory caching : mov $AMD_MTRR_FIX64k_00000, %ecx : mov $0x1E1E1E1E, %eax : mov %eax, %edx : _WRMSR # 0 - 512K = WB Mem : mov $AMD_MTRR_FIX16k_80000, %ecx : _WRMSR > Is this still needed with relocatable ramstage? Perhaps not. I am not going to open up the MTRR mess here. This commit is really a revert of changes that happened at SAGE for coreboot deployment. CAR teardown used to happen with a non-empty C stack so invd did not work. -- To view, visit https://review.coreboot.org/c/coreboot/+/18526 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I693c104c3aab3be537c00695cbd764a48bd603b0 Gerrit-Change-Number: 18526 Gerrit-PatchSet: 8 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 24 Nov 2019 16:51:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment [View Less]

1 0

Change in coreboot[master]: binaryPI: Drop CAR teardown without POSTCAR_STAGE
by Arthur Heymans (Code Review) 24 Nov '19

24 Nov '19

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18526 ) Change subject: binaryPI: Drop CAR teardown without POSTCAR_STAGE ...................................................................... Patch Set 8: (3 comments) https://review.coreboot.org/c/coreboot/+/18526/8/src/drivers/amd/agesa/exit… File src/drivers/amd/agesa/exit_car.S: https://review.coreboot.org/c/coreboot/+/18526/8/src/drivers/amd/agesa/exit… PS8, Line 32: /* enable cache */ … [View More] : movl %cr0, %eax : andl $(~(CR0_CD | CR0_NW)), %eax : movl %eax, %cr0 Done in exit_car.S https://review.coreboot.org/c/coreboot/+/18526/8/src/vendorcode/amd/pi/0063… File src/vendorcode/amd/pi/00630F01/binaryPI/gcccar.inc: https://review.coreboot.org/c/coreboot/+/18526/8/src/vendorcode/amd/pi/0063… PS8, Line 1550: * AMD_DISABLE_STACK: Destroy the stack inside the cache. This routine : * should only be executed on the BSP Is there some documentation of what is run on AP's by AGESA and in what state those are? The code below seems to be explicitly written to also run AP's? https://review.coreboot.org/c/coreboot/+/18526/8/src/vendorcode/amd/pi/0063… PS8, Line 1574: : # Set lower 640K MTRRs for Write-Back memory caching : mov $AMD_MTRR_FIX64k_00000, %ecx : mov $0x1E1E1E1E, %eax : mov %eax, %edx : _WRMSR # 0 - 512K = WB Mem : mov $AMD_MTRR_FIX16k_80000, %ecx : _WRMSR Is this still needed with relocatable ramstage? -- To view, visit https://review.coreboot.org/c/coreboot/+/18526 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I693c104c3aab3be537c00695cbd764a48bd603b0 Gerrit-Change-Number: 18526 Gerrit-PatchSet: 8 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 24 Nov 2019 16:38:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment [View Less]

1 0

Change in coreboot[master]: binaryPI: Drop CAR teardown without POSTCAR_STAGE
by Kyösti Mälkki (Code Review) 24 Nov '19

24 Nov '19

1 0

Change in coreboot[master]: binaryPI: Drop BINARYPI_LEGACY_WRAPPER support
by Michał Żygowski (Code Review) 24 Nov '19

24 Nov '19

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/19275 ) Change subject: binaryPI: Drop BINARYPI_LEGACY_WRAPPER support ...................................................................... Patch Set 8: src/northbridge/amd/pi/agesawrapper_call.h left I think? -- To view, visit https://review.coreboot.org/c/coreboot/+/19275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot … [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2019