coreboot-gerrit November 2019

coreboot-gerrit@coreboot.org

1 participants
2418 discussions

Change in coreboot[master]: drives/amd/agesa: remove legacy wrapper and separate CAR teardown
by Michał Żygowski (Code Review) 24 Nov '19

24 Nov '19

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37171 ) Change subject: drives/amd/agesa: remove legacy wrapper and separate CAR teardown ...................................................................... drives/amd/agesa: remove legacy wrapper and separate CAR teardown TEST=boot PC Engines apu1 Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I2ef73a2afa8dbb6ae676ee9fdc6beeecde57d6a5 --- M src/drivers/amd/agesa/Makefile.inc M src/drivers/amd/agesa/cache_as_ram.S A src/drivers/amd/agesa/exit_car.S 3 files changed, 47 insertions(+), 67 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/37171/1 diff --git a/src/drivers/amd/agesa/Makefile.inc b/src/drivers/amd/agesa/Makefile.inc index 4d5bd3e..1b0dd3e 100644 --- a/src/drivers/amd/agesa/Makefile.inc +++ b/src/drivers/amd/agesa/Makefile.inc @@ -13,32 +13,22 @@ ifeq ($(CONFIG_DRIVERS_AMD_PI),y) -ifneq ($(CONFIG_BINARYPI_LEGACY_WRAPPER),y) - -romstage-y += romstage.c -romstage-y += mtrr_fixme.c -romstage-y += state_machine.c - -ramstage-y += state_machine.c - cpu_incs-y += $(src)/drivers/amd/agesa/cache_as_ram.S -postcar-y += cache_as_ram.S - -else - -romstage-y += heapmanager.c - -endif romstage-y += def_callouts.c romstage-y += eventlog.c +romstage-y += mtrr_fixme.c +romstage-$(CONFIG_CPU_AMD_AGESA) += oem_s3.c +romstage-y += romstage.c +romstage-y += state_machine.c +postcar-y += exit_car.S + +ramstage-y += acpi_tables.c ramstage-y += def_callouts.c ramstage-y += eventlog.c ramstage-y += heapmanager.c -ramstage-y += acpi_tables.c - -romstage-$(CONFIG_CPU_AMD_AGESA) += oem_s3.c ramstage-$(CONFIG_CPU_AMD_AGESA) += oem_s3.c s3_mtrr.c +ramstage-y += state_machine.c endif diff --git a/src/drivers/amd/agesa/cache_as_ram.S b/src/drivers/amd/agesa/cache_as_ram.S index dcb0c43..1c53275 100644 --- a/src/drivers/amd/agesa/cache_as_ram.S +++ b/src/drivers/amd/agesa/cache_as_ram.S @@ -27,7 +27,6 @@ .code32 .globl _cache_as_ram_setup, _cache_as_ram_setup_end -.globl chipset_teardown_car _cache_as_ram_setup: @@ -105,59 +104,11 @@ pushl %eax call romstage_main -#if CONFIG(POSTCAR_STAGE) - /* We do not return. Execution continues with run_postcar_phase() * calling to chipset_teardown_car below. */ jmp postcar_entry_failure -chipset_teardown_car: - -/* - * Retrieve return address from stack as it will get trashed below if - * execution is utilizing the cache-as-ram stack. - */ - pop %esp - -#else - - movl %eax, %esp - -/* Register %esp is new stacktop for remaining of romstage. */ - -#endif - - /* Disable cache */ - movl %cr0, %eax - orl $CR0_CacheDisable, %eax - movl %eax, %cr0 - -/* Register %esp is preserved in AMD_DISABLE_STACK. */ - AMD_DISABLE_STACK - -#if CONFIG(POSTCAR_STAGE) - - jmp *%esp - -#else - - /* enable cache */ - movl %cr0, %eax - andl $0x9fffffff, %eax - movl %eax, %cr0 - - call romstage_after_car - -#endif - - /* Should never see this postcode */ - post_code(0xaf) - -stop: - hlt - jmp stop - /* These are here for linking purposes. */ .weak early_all_cores, romstage_main early_all_cores: @@ -165,6 +116,8 @@ postcar_entry_failure: /* Should never see this postcode */ post_code(0xae) +stop: + hlt jmp stop _cache_as_ram_setup_end: diff --git a/src/drivers/amd/agesa/exit_car.S b/src/drivers/amd/agesa/exit_car.S new file mode 100644 index 0000000..f9d056e --- /dev/null +++ b/src/drivers/amd/agesa/exit_car.S @@ -0,0 +1,37 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2011 Advanced Micro Devices, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <gcccar.inc> +#include <cpu/x86/cache.h> + +.code32 +.globl chipset_teardown_car + +chipset_teardown_car: + pop %esp + + /* Disable cache */ + movl %cr0, %eax + orl $CR0_CacheDisable, %eax + movl %eax, %cr0 + + AMD_DISABLE_STACK + + /* enable cache */ + movl %cr0, %eax + andl $(~(CR0_CD | CR0_NW)), %eax + movl %eax, %cr0 + + jmp *%esp -- To view, visit https://review.coreboot.org/c/coreboot/+/37171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ef73a2afa8dbb6ae676ee9fdc6beeecde57d6a5 Gerrit-Change-Number: 37171 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newchange

2 8

Change in coreboot[master]: binaryPI: Drop CAR teardown without POSTCAR_STAGE
by Michał Żygowski (Code Review) 24 Nov '19

24 Nov '19

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18526 ) Change subject: binaryPI: Drop CAR teardown without POSTCAR_STAGE ...................................................................... Patch Set 8: > Patch Set 8: > > Michal, doing C_ENV_BOOTBLOCK on top of this one would allow to concentrate on APU2 as other binaryPI boards are disabled from build. Understood. Will try to reuse as much as possible from stoneyridge. -- To view, visit https://review.coreboot.org/c/coreboot/+/18526 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I693c104c3aab3be537c00695cbd764a48bd603b0 Gerrit-Change-Number: 18526 Gerrit-PatchSet: 8 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Nov 2019 10:35:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: binaryPI: Drop CAR teardown without POSTCAR_STAGE
by Kyösti Mälkki (Code Review) 24 Nov '19

24 Nov '19

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18526 ) Change subject: binaryPI: Drop CAR teardown without POSTCAR_STAGE ...................................................................... Patch Set 8: Michal, doing C_ENV_BOOTBLOCK on top of this one would allow to concentrate on APU2 as other binaryPI boards are disabled from build. -- To view, visit https://review.coreboot.org/c/coreboot/+/18526 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I693c104c3aab3be537c00695cbd764a48bd603b0 Gerrit-Change-Number: 18526 Gerrit-PatchSet: 8 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Nov 2019 10:32:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: binaryPI: Drop CAR teardown without POSTCAR_STAGE
by Kyösti Mälkki (Code Review) 24 Nov '19

24 Nov '19

Hello Marshall Dawson, Paul Menzel, Marc Jones, build bot (Jenkins), Michał Żygowski, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/18526 to look at the new patch set (#8). Change subject: binaryPI: Drop CAR teardown without POSTCAR_STAGE ...................................................................... binaryPI: Drop CAR teardown without POSTCAR_STAGE All binaryPI boards have moved away from BINARYPI_LEGACY_WRAPPER, thus they all have POSTCAR_STAGE now. Change-Id: I693c104c3aab3be537c00695cbd764a48bd603b0 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> --- M src/drivers/amd/agesa/Makefile.inc M src/drivers/amd/agesa/cache_as_ram.S A src/drivers/amd/agesa/exit_car.S M src/vendorcode/amd/pi/00630F01/binaryPI/gcccar.inc M src/vendorcode/amd/pi/00660F01/binaryPI/gcccar.inc M src/vendorcode/amd/pi/00730F01/binaryPI/gcccar.inc 6 files changed, 46 insertions(+), 131 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/18526/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/18526 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I693c104c3aab3be537c00695cbd764a48bd603b0 Gerrit-Change-Number: 18526 Gerrit-PatchSet: 8 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: binaryPI: Drop BINARYPI_LEGACY_WRAPPER support
by Kyösti Mälkki (Code Review) 24 Nov '19

24 Nov '19

Hello Marshall Dawson, Paul Menzel, build bot (Jenkins), Marc Jones, Michał Żygowski, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/19275 to look at the new patch set (#8). Change subject: binaryPI: Drop BINARYPI_LEGACY_WRAPPER support ...................................................................... binaryPI: Drop BINARYPI_LEGACY_WRAPPER support Drop all the sources that were guarded with this. Change-Id: I6c6fd19875cb57f0caf42a1a94f59efed83bfe0d Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/cpu/amd/pi/Kconfig M src/cpu/amd/pi/Makefile.inc D src/cpu/amd/pi/amd_late_init.c D src/cpu/amd/pi/romstage.c M src/drivers/amd/agesa/Makefile.inc M src/drivers/amd/agesa/def_callouts.c M src/drivers/amd/agesa/eventlog.c M src/drivers/amd/agesa/romstage.c M src/mainboard/amd/bettong/Kconfig M src/mainboard/amd/db-ft3b-lc/Kconfig M src/mainboard/amd/lamar/Kconfig M src/mainboard/amd/olivehillplus/Kconfig M src/mainboard/bap/ode_e21XX/Kconfig M src/northbridge/amd/agesa/state_machine.h M src/northbridge/amd/pi/00630F01/northbridge.c M src/northbridge/amd/pi/00660F01/northbridge.c M src/northbridge/amd/pi/00730F01/Makefile.inc M src/northbridge/amd/pi/00730F01/northbridge.c M src/northbridge/amd/pi/Makefile.inc D src/northbridge/amd/pi/agesawrapper.c D src/northbridge/amd/pi/agesawrapper.h M src/vendorcode/amd/Kconfig D src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c D src/vendorcode/amd/pi/00660F01/binaryPI/AGESA.c D src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c M src/vendorcode/amd/pi/Makefile.inc 26 files changed, 9 insertions(+), 1,999 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/19275/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/19275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6c6fd19875cb57f0caf42a1a94f59efed83bfe0d Gerrit-Change-Number: 19275 Gerrit-PatchSet: 8 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Kconfig: comply to Linux 5.3's Kconfig language rules
by Patrick Georgi (Code Review) 23 Nov '19

23 Nov '19

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37156 ) Change subject: Kconfig: comply to Linux 5.3's Kconfig language rules ...................................................................... Kconfig: comply to Linux 5.3's Kconfig language rules Kconfig became stricter on what it accepts, so accomodate before updating to a new release. Change-Id: I92a9e9bf0d557a7532ba533cd7776c48f2488f91 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M payloads/external/LinuxBoot/Kconfig M src/arch/arm/Kconfig M src/arch/arm64/Kconfig M src/console/Kconfig M src/cpu/amd/Kconfig M src/cpu/amd/agesa/Kconfig M src/cpu/amd/pi/Kconfig M src/cpu/armltd/Kconfig M src/cpu/intel/Kconfig M src/cpu/ti/Kconfig M src/drivers/uart/Kconfig M src/mainboard/amd/bettong/Kconfig M src/mainboard/amd/db-ft3b-lc/Kconfig M src/mainboard/amd/gardenia/Kconfig M src/mainboard/amd/inagua/Kconfig M src/mainboard/amd/lamar/Kconfig M src/mainboard/amd/olivehill/Kconfig M src/mainboard/amd/olivehillplus/Kconfig M src/mainboard/amd/padmelon/Kconfig M src/mainboard/amd/parmer/Kconfig M src/mainboard/amd/persimmon/Kconfig M src/mainboard/amd/south_station/Kconfig M src/mainboard/amd/thatcher/Kconfig M src/mainboard/amd/union_station/Kconfig M src/mainboard/aopen/dxplplusu/Kconfig M src/mainboard/apple/macbook21/Kconfig M src/mainboard/apple/macbookair4_2/Kconfig M src/mainboard/asrock/b75pro3-m/Kconfig M src/mainboard/asrock/e350m1/Kconfig M src/mainboard/asrock/h81m-hds/Kconfig M src/mainboard/asrock/imb-a180/Kconfig M src/mainboard/asus/am1i-a/Kconfig M src/mainboard/asus/f2a85-m/Kconfig M src/mainboard/asus/h61m-cs/Kconfig M src/mainboard/asus/maximus_iv_gene-z/Kconfig M src/mainboard/asus/p2b-d/Kconfig M src/mainboard/asus/p2b-ds/Kconfig M src/mainboard/asus/p2b-f/Kconfig M src/mainboard/asus/p2b-ls/Kconfig M src/mainboard/asus/p2b/Kconfig M src/mainboard/asus/p3b-f/Kconfig M src/mainboard/asus/p5gc-mx/Kconfig M src/mainboard/asus/p8h61-m_lx/Kconfig M src/mainboard/asus/p8h61-m_pro/Kconfig M src/mainboard/bap/ode_e20XX/Kconfig M src/mainboard/bap/ode_e21XX/Kconfig M src/mainboard/biostar/a68n_5200/Kconfig M src/mainboard/biostar/am1ml/Kconfig M src/mainboard/compulab/intense_pc/Kconfig M src/mainboard/elmex/pcm205400/Kconfig M src/mainboard/emulation/qemu-aarch64/Kconfig M src/mainboard/emulation/qemu-armv7/Kconfig M src/mainboard/emulation/qemu-i440fx/Kconfig M src/mainboard/emulation/qemu-q35/Kconfig M src/mainboard/emulation/qemu-riscv/Kconfig M src/mainboard/emulation/spike-riscv/Kconfig M src/mainboard/emulation/spike-riscv/Kconfig.name M src/mainboard/facebook/fbg1701/Kconfig M src/mainboard/foxconn/d41s/Kconfig M src/mainboard/getac/p470/Kconfig M src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig M src/mainboard/gigabyte/ga-b75m-d3h/Kconfig M src/mainboard/gizmosphere/gizmo/Kconfig M src/mainboard/gizmosphere/gizmo2/Kconfig M src/mainboard/google/auron/Kconfig M src/mainboard/google/beltino/Kconfig M src/mainboard/google/butterfly/Kconfig M src/mainboard/google/cheza/Kconfig M src/mainboard/google/cyan/Kconfig M src/mainboard/google/daisy/Kconfig M src/mainboard/google/foster/Kconfig M src/mainboard/google/gale/Kconfig M src/mainboard/google/gru/Kconfig M src/mainboard/google/jecht/Kconfig M src/mainboard/google/kahlee/Kconfig M src/mainboard/google/kukui/Kconfig M src/mainboard/google/link/Kconfig M src/mainboard/google/mistral/Kconfig M src/mainboard/google/nyan/Kconfig M src/mainboard/google/nyan_big/Kconfig M src/mainboard/google/nyan_blaze/Kconfig M src/mainboard/google/oak/Kconfig M src/mainboard/google/octopus/Kconfig M src/mainboard/google/parrot/Kconfig M src/mainboard/google/peach_pit/Kconfig M src/mainboard/google/rambi/Kconfig M src/mainboard/google/reef/Kconfig M src/mainboard/google/slippy/Kconfig M src/mainboard/google/smaug/Kconfig M src/mainboard/google/storm/Kconfig M src/mainboard/google/stout/Kconfig M src/mainboard/google/trogdor/Kconfig M src/mainboard/google/veyron/Kconfig M src/mainboard/google/veyron_mickey/Kconfig M src/mainboard/google/veyron_rialto/Kconfig M src/mainboard/hp/2570p/Kconfig M src/mainboard/hp/2760p/Kconfig M src/mainboard/hp/8460p/Kconfig M src/mainboard/hp/8470p/Kconfig M src/mainboard/hp/8770w/Kconfig M src/mainboard/hp/abm/Kconfig M src/mainboard/hp/compaq_8200_elite_sff/Kconfig M src/mainboard/hp/folio_9470m/Kconfig M src/mainboard/hp/pavilion_m6_1035dx/Kconfig M src/mainboard/hp/revolve_810_g1/Kconfig M src/mainboard/hp/z220_sff_workstation/Kconfig M src/mainboard/ibase/mb899/Kconfig M src/mainboard/intel/apollolake_rvp/Kconfig M src/mainboard/intel/baskingridge/Kconfig M src/mainboard/intel/d510mo/Kconfig M src/mainboard/intel/d945gclf/Kconfig M src/mainboard/intel/dcp847ske/Kconfig M src/mainboard/intel/emeraldlake2/Kconfig M src/mainboard/intel/galileo/Kconfig M src/mainboard/intel/glkrvp/Kconfig M src/mainboard/intel/harcuvar/Kconfig M src/mainboard/intel/leafhill/Kconfig M src/mainboard/intel/minnow3/Kconfig M src/mainboard/intel/strago/Kconfig M src/mainboard/intel/wtm2/Kconfig M src/mainboard/jetway/nf81-t56n-lf/Kconfig M src/mainboard/kontron/986lcd-m/Kconfig M src/mainboard/kontron/ktqm77/Kconfig M src/mainboard/lenovo/g505s/Kconfig M src/mainboard/lenovo/l520/Kconfig M src/mainboard/lenovo/s230u/Kconfig M src/mainboard/lenovo/t400/Kconfig M src/mainboard/lenovo/t410/Kconfig M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t420s/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/t440p/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/t60/Kconfig M src/mainboard/lenovo/x131e/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/Kconfig M src/mainboard/lenovo/x200/Kconfig M src/mainboard/lenovo/x201/Kconfig M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x60/Kconfig M src/mainboard/lippert/frontrunner-af/Kconfig M src/mainboard/lippert/toucan-af/Kconfig M src/mainboard/msi/ms7707/Kconfig M src/mainboard/msi/ms7721/Kconfig M src/mainboard/packardbell/ms2290/Kconfig M src/mainboard/pcengines/apu1/Kconfig M src/mainboard/pcengines/apu2/Kconfig M src/mainboard/portwell/m107/Kconfig M src/mainboard/purism/librem_bdw/Kconfig M src/mainboard/roda/rk886ex/Kconfig M src/mainboard/roda/rk9/Kconfig M src/mainboard/samsung/lumpy/Kconfig M src/mainboard/samsung/stumpy/Kconfig M src/mainboard/sapphire/pureplatinumh61/Kconfig M src/mainboard/scaleway/tagada/Kconfig M src/mainboard/siemens/mc_apl1/Kconfig M src/mainboard/sifive/hifive-unleashed/Kconfig M src/mainboard/ti/beaglebone/Kconfig M src/northbridge/amd/pi/Kconfig M src/southbridge/amd/agesa/Kconfig M src/southbridge/amd/cimx/Kconfig M src/southbridge/amd/pi/Kconfig M src/vendorcode/amd/Kconfig M src/vendorcode/eltan/security/Kconfig M src/vendorcode/google/Kconfig 168 files changed, 204 insertions(+), 206 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/37156/1 diff --git a/payloads/external/LinuxBoot/Kconfig b/payloads/external/LinuxBoot/Kconfig index a91288b..d132c7e 100644 --- a/payloads/external/LinuxBoot/Kconfig +++ b/payloads/external/LinuxBoot/Kconfig @@ -117,7 +117,6 @@ config LINUXBOOT_KERNEL_CUSTOM_CONFIG bool "Custom (def)config file" - help endchoice diff --git a/src/arch/arm/Kconfig b/src/arch/arm/Kconfig index 47c333b..1eed2de 100644 --- a/src/arch/arm/Kconfig +++ b/src/arch/arm/Kconfig @@ -18,8 +18,8 @@ bool select ARCH_ARM -source src/arch/arm/armv4/Kconfig -source src/arch/arm/armv7/Kconfig +source "src/arch/arm/armv4/Kconfig" +source "src/arch/arm/armv7/Kconfig" config ARM_LPAE bool diff --git a/src/arch/arm64/Kconfig b/src/arch/arm64/Kconfig index 3d1d184..96a23dc 100644 --- a/src/arch/arm64/Kconfig +++ b/src/arch/arm64/Kconfig @@ -18,7 +18,7 @@ bool select ARCH_ARM64 -source src/arch/arm64/armv8/Kconfig +source "src/arch/arm64/armv8/Kconfig" if ARCH_ARM64 diff --git a/src/console/Kconfig b/src/console/Kconfig index e767edd..b90823e 100644 --- a/src/console/Kconfig +++ b/src/console/Kconfig @@ -88,7 +88,7 @@ depends on DRIVERS_UART_8250IO && UART_FOR_CONSOLE = 3 config UART_OVERRIDE_BAUDRATE - boolean + bool help Set to "y" when the platform overrides the baudrate by providing a get_uart_baudrate routine. @@ -303,7 +303,7 @@ drivers are written. config CONSOLE_OVERRIDE_LOGLEVEL - boolean + bool help Set to "y" when the platform overrides the loglevel by providing a get_console_loglevel routine. diff --git a/src/cpu/amd/Kconfig b/src/cpu/amd/Kconfig index 4ade0f6..db8989d 100644 --- a/src/cpu/amd/Kconfig +++ b/src/cpu/amd/Kconfig @@ -1,2 +1,2 @@ -source src/cpu/amd/agesa/Kconfig -source src/cpu/amd/pi/Kconfig +source "src/cpu/amd/agesa/Kconfig" +source "src/cpu/amd/pi/Kconfig" diff --git a/src/cpu/amd/agesa/Kconfig b/src/cpu/amd/agesa/Kconfig index b6b757f..ddfe707 100644 --- a/src/cpu/amd/agesa/Kconfig +++ b/src/cpu/amd/agesa/Kconfig @@ -66,6 +66,6 @@ endif # CPU_AMD_AGESA -source src/cpu/amd/agesa/family14/Kconfig -source src/cpu/amd/agesa/family15tn/Kconfig -source src/cpu/amd/agesa/family16kb/Kconfig +source "src/cpu/amd/agesa/family14/Kconfig" +source "src/cpu/amd/agesa/family15tn/Kconfig" +source "src/cpu/amd/agesa/family16kb/Kconfig" diff --git a/src/cpu/amd/pi/Kconfig b/src/cpu/amd/pi/Kconfig index b33302e..ee6fa4b 100644 --- a/src/cpu/amd/pi/Kconfig +++ b/src/cpu/amd/pi/Kconfig @@ -61,6 +61,6 @@ endif # CPU_AMD_PI -source src/cpu/amd/pi/00630F01/Kconfig -source src/cpu/amd/pi/00730F01/Kconfig -source src/cpu/amd/pi/00660F01/Kconfig +source "src/cpu/amd/pi/00630F01/Kconfig" +source "src/cpu/amd/pi/00730F01/Kconfig" +source "src/cpu/amd/pi/00660F01/Kconfig" diff --git a/src/cpu/armltd/Kconfig b/src/cpu/armltd/Kconfig index af0c5c5..db1af75 100644 --- a/src/cpu/armltd/Kconfig +++ b/src/cpu/armltd/Kconfig @@ -1 +1 @@ -source src/cpu/armltd/cortex-a9/Kconfig +source "src/cpu/armltd/cortex-a9/Kconfig" diff --git a/src/cpu/intel/Kconfig b/src/cpu/intel/Kconfig index c21de59..43b360b 100644 --- a/src/cpu/intel/Kconfig +++ b/src/cpu/intel/Kconfig @@ -1,31 +1,31 @@ # CPU models -source src/cpu/intel/model_6xx/Kconfig -source src/cpu/intel/model_65x/Kconfig -source src/cpu/intel/model_67x/Kconfig -source src/cpu/intel/model_68x/Kconfig -source src/cpu/intel/model_6bx/Kconfig -source src/cpu/intel/model_6ex/Kconfig -source src/cpu/intel/model_6fx/Kconfig -source src/cpu/intel/model_1067x/Kconfig -source src/cpu/intel/model_106cx/Kconfig -source src/cpu/intel/model_206ax/Kconfig -source src/cpu/intel/model_2065x/Kconfig -source src/cpu/intel/model_f2x/Kconfig -source src/cpu/intel/model_f3x/Kconfig -source src/cpu/intel/model_f4x/Kconfig -source src/cpu/intel/haswell/Kconfig +source "src/cpu/intel/model_6xx/Kconfig" +source "src/cpu/intel/model_65x/Kconfig" +source "src/cpu/intel/model_67x/Kconfig" +source "src/cpu/intel/model_68x/Kconfig" +source "src/cpu/intel/model_6bx/Kconfig" +source "src/cpu/intel/model_6ex/Kconfig" +source "src/cpu/intel/model_6fx/Kconfig" +source "src/cpu/intel/model_1067x/Kconfig" +source "src/cpu/intel/model_106cx/Kconfig" +source "src/cpu/intel/model_206ax/Kconfig" +source "src/cpu/intel/model_2065x/Kconfig" +source "src/cpu/intel/model_f2x/Kconfig" +source "src/cpu/intel/model_f3x/Kconfig" +source "src/cpu/intel/model_f4x/Kconfig" +source "src/cpu/intel/haswell/Kconfig" # Sockets/Slots -source src/cpu/intel/slot_1/Kconfig -source src/cpu/intel/socket_BGA956/Kconfig -source src/cpu/intel/socket_FCBGA559/Kconfig -source src/cpu/intel/socket_m/Kconfig -source src/cpu/intel/socket_p/Kconfig -source src/cpu/intel/socket_mPGA604/Kconfig -source src/cpu/intel/socket_441/Kconfig -source src/cpu/intel/socket_LGA775/Kconfig +source "src/cpu/intel/slot_1/Kconfig" +source "src/cpu/intel/socket_BGA956/Kconfig" +source "src/cpu/intel/socket_FCBGA559/Kconfig" +source "src/cpu/intel/socket_m/Kconfig" +source "src/cpu/intel/socket_p/Kconfig" +source "src/cpu/intel/socket_mPGA604/Kconfig" +source "src/cpu/intel/socket_441/Kconfig" +source "src/cpu/intel/socket_LGA775/Kconfig" # Architecture specific features -source src/cpu/intel/fit/Kconfig -source src/cpu/intel/turbo/Kconfig -source src/cpu/intel/common/Kconfig -source src/cpu/intel/microcode/Kconfig -source src/cpu/intel/car/non-evict/Kconfig +source "src/cpu/intel/fit/Kconfig" +source "src/cpu/intel/turbo/Kconfig" +source "src/cpu/intel/common/Kconfig" +source "src/cpu/intel/microcode/Kconfig" +source "src/cpu/intel/car/non-evict/Kconfig" diff --git a/src/cpu/ti/Kconfig b/src/cpu/ti/Kconfig index 5a62219..119e84b 100644 --- a/src/cpu/ti/Kconfig +++ b/src/cpu/ti/Kconfig @@ -1 +1 @@ -source src/cpu/ti/am335x/Kconfig +source "src/cpu/ti/am335x/Kconfig" diff --git a/src/drivers/uart/Kconfig b/src/drivers/uart/Kconfig index 1f23a19..41b870f 100644 --- a/src/drivers/uart/Kconfig +++ b/src/drivers/uart/Kconfig @@ -20,14 +20,14 @@ def_bool n config UART_OVERRIDE_INPUT_CLOCK_DIVIDER - boolean + bool default n help Set to "y" when the platform overrides the uart_input_clock_divider routine. config UART_OVERRIDE_REFCLK - boolean + bool default n help Set to "y" when the platform overrides the uart_platform_refclk diff --git a/src/mainboard/amd/bettong/Kconfig b/src/mainboard/amd/bettong/Kconfig index eaebfb5..5f26e87 100644 --- a/src/mainboard/amd/bettong/Kconfig +++ b/src/mainboard/amd/bettong/Kconfig @@ -30,7 +30,7 @@ config MAINBOARD_DIR string - default amd/bettong + default "amd/bettong" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/amd/db-ft3b-lc/Kconfig b/src/mainboard/amd/db-ft3b-lc/Kconfig index ffb3f10..256b555 100644 --- a/src/mainboard/amd/db-ft3b-lc/Kconfig +++ b/src/mainboard/amd/db-ft3b-lc/Kconfig @@ -31,7 +31,7 @@ config MAINBOARD_DIR string - default amd/db-ft3b-lc + default "amd/db-ft3b-lc" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/amd/gardenia/Kconfig b/src/mainboard/amd/gardenia/Kconfig index 7adc678..02e3e95 100644 --- a/src/mainboard/amd/gardenia/Kconfig +++ b/src/mainboard/amd/gardenia/Kconfig @@ -26,7 +26,7 @@ config MAINBOARD_DIR string - default amd/gardenia + default "amd/gardenia" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/amd/inagua/Kconfig b/src/mainboard/amd/inagua/Kconfig index 6d6ec4f..e24af40 100644 --- a/src/mainboard/amd/inagua/Kconfig +++ b/src/mainboard/amd/inagua/Kconfig @@ -30,7 +30,7 @@ config MAINBOARD_DIR string - default amd/inagua + default "amd/inagua" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/amd/lamar/Kconfig b/src/mainboard/amd/lamar/Kconfig index 210b3c2..025e5ff 100644 --- a/src/mainboard/amd/lamar/Kconfig +++ b/src/mainboard/amd/lamar/Kconfig @@ -31,7 +31,7 @@ config MAINBOARD_DIR string - default amd/lamar + default "amd/lamar" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/amd/olivehill/Kconfig b/src/mainboard/amd/olivehill/Kconfig index 066d967..bd9a2fe 100644 --- a/src/mainboard/amd/olivehill/Kconfig +++ b/src/mainboard/amd/olivehill/Kconfig @@ -30,7 +30,7 @@ config MAINBOARD_DIR string - default amd/olivehill + default "amd/olivehill" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/amd/olivehillplus/Kconfig b/src/mainboard/amd/olivehillplus/Kconfig index 5779aaf..96d9347 100644 --- a/src/mainboard/amd/olivehillplus/Kconfig +++ b/src/mainboard/amd/olivehillplus/Kconfig @@ -30,7 +30,7 @@ config MAINBOARD_DIR string - default amd/olivehillplus + default "amd/olivehillplus" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/amd/padmelon/Kconfig b/src/mainboard/amd/padmelon/Kconfig index 3d8efb1..e4dd90c 100644 --- a/src/mainboard/amd/padmelon/Kconfig +++ b/src/mainboard/amd/padmelon/Kconfig @@ -35,7 +35,7 @@ config MAINBOARD_DIR string - default amd/padmelon + default "amd/padmelon" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/amd/parmer/Kconfig b/src/mainboard/amd/parmer/Kconfig index 506f9ac..6d989b6 100644 --- a/src/mainboard/amd/parmer/Kconfig +++ b/src/mainboard/amd/parmer/Kconfig @@ -30,7 +30,7 @@ config MAINBOARD_DIR string - default amd/parmer + default "amd/parmer" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/amd/persimmon/Kconfig b/src/mainboard/amd/persimmon/Kconfig index 4a4d274..41bf3c9 100644 --- a/src/mainboard/amd/persimmon/Kconfig +++ b/src/mainboard/amd/persimmon/Kconfig @@ -31,7 +31,7 @@ config MAINBOARD_DIR string - default amd/persimmon + default "amd/persimmon" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/amd/south_station/Kconfig b/src/mainboard/amd/south_station/Kconfig index 6f1d1b4..a059403 100644 --- a/src/mainboard/amd/south_station/Kconfig +++ b/src/mainboard/amd/south_station/Kconfig @@ -30,7 +30,7 @@ config MAINBOARD_DIR string - default amd/south_station + default "amd/south_station" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/amd/thatcher/Kconfig b/src/mainboard/amd/thatcher/Kconfig index 7791a1d..a957d4c 100644 --- a/src/mainboard/amd/thatcher/Kconfig +++ b/src/mainboard/amd/thatcher/Kconfig @@ -31,7 +31,7 @@ config MAINBOARD_DIR string - default amd/thatcher + default "amd/thatcher" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/amd/union_station/Kconfig b/src/mainboard/amd/union_station/Kconfig index 4f2cddd..72881b8 100644 --- a/src/mainboard/amd/union_station/Kconfig +++ b/src/mainboard/amd/union_station/Kconfig @@ -29,7 +29,7 @@ config MAINBOARD_DIR string - default amd/union_station + default "amd/union_station" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/aopen/dxplplusu/Kconfig b/src/mainboard/aopen/dxplplusu/Kconfig index 738a2ea..0036915 100644 --- a/src/mainboard/aopen/dxplplusu/Kconfig +++ b/src/mainboard/aopen/dxplplusu/Kconfig @@ -12,7 +12,7 @@ config MAINBOARD_DIR string - default aopen/dxplplusu + default "aopen/dxplplusu" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/apple/macbook21/Kconfig b/src/mainboard/apple/macbook21/Kconfig index 84c00cf..93e2d8d 100644 --- a/src/mainboard/apple/macbook21/Kconfig +++ b/src/mainboard/apple/macbook21/Kconfig @@ -21,7 +21,7 @@ config MAINBOARD_DIR string - default apple/macbook21 + default "apple/macbook21" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/apple/macbookair4_2/Kconfig b/src/mainboard/apple/macbookair4_2/Kconfig index df8ecfd..771f327 100644 --- a/src/mainboard/apple/macbookair4_2/Kconfig +++ b/src/mainboard/apple/macbookair4_2/Kconfig @@ -17,7 +17,7 @@ config MAINBOARD_DIR string - default apple/macbookair4_2 + default "apple/macbookair4_2" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/asrock/b75pro3-m/Kconfig b/src/mainboard/asrock/b75pro3-m/Kconfig index 878eaad..561bea5 100644 --- a/src/mainboard/asrock/b75pro3-m/Kconfig +++ b/src/mainboard/asrock/b75pro3-m/Kconfig @@ -31,7 +31,7 @@ config MAINBOARD_DIR string - default asrock/b75pro3-m + default "asrock/b75pro3-m" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/asrock/e350m1/Kconfig b/src/mainboard/asrock/e350m1/Kconfig index cc380e5..3bbc2a5 100644 --- a/src/mainboard/asrock/e350m1/Kconfig +++ b/src/mainboard/asrock/e350m1/Kconfig @@ -32,7 +32,7 @@ config MAINBOARD_DIR string - default asrock/e350m1 + default "asrock/e350m1" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/asrock/h81m-hds/Kconfig b/src/mainboard/asrock/h81m-hds/Kconfig index 6974cda..7088cbb 100644 --- a/src/mainboard/asrock/h81m-hds/Kconfig +++ b/src/mainboard/asrock/h81m-hds/Kconfig @@ -41,7 +41,7 @@ config MAINBOARD_DIR string - default asrock/h81m-hds + default "asrock/h81m-hds" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/asrock/imb-a180/Kconfig b/src/mainboard/asrock/imb-a180/Kconfig index 3dae526..2391202 100644 --- a/src/mainboard/asrock/imb-a180/Kconfig +++ b/src/mainboard/asrock/imb-a180/Kconfig @@ -31,7 +31,7 @@ config MAINBOARD_DIR string - default asrock/imb-a180 + default "asrock/imb-a180" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/asus/am1i-a/Kconfig b/src/mainboard/asus/am1i-a/Kconfig index d50edbe..0aafd8b 100644 --- a/src/mainboard/asus/am1i-a/Kconfig +++ b/src/mainboard/asus/am1i-a/Kconfig @@ -20,7 +20,7 @@ config MAINBOARD_DIR string - default asus/am1i-a + default "asus/am1i-a" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/asus/f2a85-m/Kconfig b/src/mainboard/asus/f2a85-m/Kconfig index 100b33c..c1dd063 100644 --- a/src/mainboard/asus/f2a85-m/Kconfig +++ b/src/mainboard/asus/f2a85-m/Kconfig @@ -57,7 +57,7 @@ config MAINBOARD_DIR string - default asus/f2a85-m + default "asus/f2a85-m" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/asus/h61m-cs/Kconfig b/src/mainboard/asus/h61m-cs/Kconfig index 69efa9d..6040208 100644 --- a/src/mainboard/asus/h61m-cs/Kconfig +++ b/src/mainboard/asus/h61m-cs/Kconfig @@ -19,7 +19,7 @@ config MAINBOARD_DIR string - default asus/h61m-cs + default "asus/h61m-cs" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/asus/maximus_iv_gene-z/Kconfig b/src/mainboard/asus/maximus_iv_gene-z/Kconfig index a0bc318..be832ce 100644 --- a/src/mainboard/asus/maximus_iv_gene-z/Kconfig +++ b/src/mainboard/asus/maximus_iv_gene-z/Kconfig @@ -36,7 +36,7 @@ config MAINBOARD_DIR string - default asus/maximus_iv_gene-z + default "asus/maximus_iv_gene-z" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/asus/p2b-d/Kconfig b/src/mainboard/asus/p2b-d/Kconfig index e1fc221..8db9b7a 100644 --- a/src/mainboard/asus/p2b-d/Kconfig +++ b/src/mainboard/asus/p2b-d/Kconfig @@ -29,7 +29,7 @@ config MAINBOARD_DIR string - default asus/p2b-d + default "asus/p2b-d" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/asus/p2b-ds/Kconfig b/src/mainboard/asus/p2b-ds/Kconfig index b3c4b2d..8b55174 100644 --- a/src/mainboard/asus/p2b-ds/Kconfig +++ b/src/mainboard/asus/p2b-ds/Kconfig @@ -29,7 +29,7 @@ config MAINBOARD_DIR string - default asus/p2b-ds + default "asus/p2b-ds" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/asus/p2b-f/Kconfig b/src/mainboard/asus/p2b-f/Kconfig index f0ab38d..efe625c 100644 --- a/src/mainboard/asus/p2b-f/Kconfig +++ b/src/mainboard/asus/p2b-f/Kconfig @@ -25,7 +25,7 @@ config MAINBOARD_DIR string - default asus/p2b-f + default "asus/p2b-f" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/asus/p2b-ls/Kconfig b/src/mainboard/asus/p2b-ls/Kconfig index c39dc79..60124fe 100644 --- a/src/mainboard/asus/p2b-ls/Kconfig +++ b/src/mainboard/asus/p2b-ls/Kconfig @@ -27,7 +27,7 @@ config MAINBOARD_DIR string - default asus/p2b-ls + default "asus/p2b-ls" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/asus/p2b/Kconfig b/src/mainboard/asus/p2b/Kconfig index f34b4dd..65e7681 100644 --- a/src/mainboard/asus/p2b/Kconfig +++ b/src/mainboard/asus/p2b/Kconfig @@ -26,7 +26,7 @@ config MAINBOARD_DIR string - default asus/p2b + default "asus/p2b" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/asus/p3b-f/Kconfig b/src/mainboard/asus/p3b-f/Kconfig index e09adf1..179fed2 100644 --- a/src/mainboard/asus/p3b-f/Kconfig +++ b/src/mainboard/asus/p3b-f/Kconfig @@ -26,7 +26,7 @@ config MAINBOARD_DIR string - default asus/p3b-f + default "asus/p3b-f" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/asus/p5gc-mx/Kconfig b/src/mainboard/asus/p5gc-mx/Kconfig index 193364a..a0e6014 100644 --- a/src/mainboard/asus/p5gc-mx/Kconfig +++ b/src/mainboard/asus/p5gc-mx/Kconfig @@ -34,7 +34,7 @@ config MAINBOARD_DIR string - default asus/p5gc-mx + default "asus/p5gc-mx" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/asus/p8h61-m_lx/Kconfig b/src/mainboard/asus/p8h61-m_lx/Kconfig index 010641a..2210b1a 100644 --- a/src/mainboard/asus/p8h61-m_lx/Kconfig +++ b/src/mainboard/asus/p8h61-m_lx/Kconfig @@ -37,7 +37,7 @@ config MAINBOARD_DIR string - default asus/p8h61-m_lx + default "asus/p8h61-m_lx" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/asus/p8h61-m_pro/Kconfig b/src/mainboard/asus/p8h61-m_pro/Kconfig index e8a6f64..0c8988e 100644 --- a/src/mainboard/asus/p8h61-m_pro/Kconfig +++ b/src/mainboard/asus/p8h61-m_pro/Kconfig @@ -37,7 +37,7 @@ config MAINBOARD_DIR string - default asus/p8h61-m_pro + default "asus/p8h61-m_pro" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/bap/ode_e20XX/Kconfig b/src/mainboard/bap/ode_e20XX/Kconfig index 0c37d5f..1d52639 100644 --- a/src/mainboard/bap/ode_e20XX/Kconfig +++ b/src/mainboard/bap/ode_e20XX/Kconfig @@ -31,7 +31,7 @@ config MAINBOARD_DIR string - default bap/ode_e20XX + default "bap/ode_e20XX" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/bap/ode_e21XX/Kconfig b/src/mainboard/bap/ode_e21XX/Kconfig index 3bdb573..bf812f2 100644 --- a/src/mainboard/bap/ode_e21XX/Kconfig +++ b/src/mainboard/bap/ode_e21XX/Kconfig @@ -31,7 +31,7 @@ config MAINBOARD_DIR string - default bap/ode_e21XX + default "bap/ode_e21XX" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/biostar/a68n_5200/Kconfig b/src/mainboard/biostar/a68n_5200/Kconfig index f5f2338..e4271d3 100644 --- a/src/mainboard/biostar/a68n_5200/Kconfig +++ b/src/mainboard/biostar/a68n_5200/Kconfig @@ -32,7 +32,7 @@ config MAINBOARD_DIR string - default biostar/a68n_5200 + default "biostar/a68n_5200" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/biostar/am1ml/Kconfig b/src/mainboard/biostar/am1ml/Kconfig index a981787..31aa5f0 100644 --- a/src/mainboard/biostar/am1ml/Kconfig +++ b/src/mainboard/biostar/am1ml/Kconfig @@ -33,7 +33,7 @@ config MAINBOARD_DIR string - default biostar/am1ml + default "biostar/am1ml" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/compulab/intense_pc/Kconfig b/src/mainboard/compulab/intense_pc/Kconfig index 3326b74..68a01f1 100644 --- a/src/mainboard/compulab/intense_pc/Kconfig +++ b/src/mainboard/compulab/intense_pc/Kconfig @@ -18,7 +18,7 @@ config MAINBOARD_DIR string - default compulab/intense_pc + default "compulab/intense_pc" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/elmex/pcm205400/Kconfig b/src/mainboard/elmex/pcm205400/Kconfig index 850361a..7dc67d1 100644 --- a/src/mainboard/elmex/pcm205400/Kconfig +++ b/src/mainboard/elmex/pcm205400/Kconfig @@ -43,7 +43,7 @@ config MAINBOARD_DIR string - default elmex/pcm205400 + default "elmex/pcm205400" config HW_MEM_HOLE_SIZEK hex diff --git a/src/mainboard/emulation/qemu-aarch64/Kconfig b/src/mainboard/emulation/qemu-aarch64/Kconfig index ebdbf16..895446d 100644 --- a/src/mainboard/emulation/qemu-aarch64/Kconfig +++ b/src/mainboard/emulation/qemu-aarch64/Kconfig @@ -30,7 +30,7 @@ config MAINBOARD_DIR string - default emulation/qemu-aarch64 + default "emulation/qemu-aarch64" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/emulation/qemu-armv7/Kconfig b/src/mainboard/emulation/qemu-armv7/Kconfig index 73b2d5d..181f9a4 100644 --- a/src/mainboard/emulation/qemu-armv7/Kconfig +++ b/src/mainboard/emulation/qemu-armv7/Kconfig @@ -39,7 +39,7 @@ config MAINBOARD_DIR string - default emulation/qemu-armv7 + default "emulation/qemu-armv7" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/emulation/qemu-i440fx/Kconfig b/src/mainboard/emulation/qemu-i440fx/Kconfig index 8632ef6..3c27b1e 100644 --- a/src/mainboard/emulation/qemu-i440fx/Kconfig +++ b/src/mainboard/emulation/qemu-i440fx/Kconfig @@ -42,7 +42,7 @@ config MAINBOARD_DIR string - default emulation/qemu-i440fx + default "emulation/qemu-i440fx" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/emulation/qemu-q35/Kconfig b/src/mainboard/emulation/qemu-q35/Kconfig index 8b97495..3a9bb6f 100644 --- a/src/mainboard/emulation/qemu-q35/Kconfig +++ b/src/mainboard/emulation/qemu-q35/Kconfig @@ -41,7 +41,7 @@ config MAINBOARD_DIR string - default emulation/qemu-q35 + default "emulation/qemu-q35" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/emulation/qemu-riscv/Kconfig b/src/mainboard/emulation/qemu-riscv/Kconfig index fa6dccc..4d4c900 100644 --- a/src/mainboard/emulation/qemu-riscv/Kconfig +++ b/src/mainboard/emulation/qemu-riscv/Kconfig @@ -44,7 +44,7 @@ config MAINBOARD_DIR string - default emulation/qemu-riscv + default "emulation/qemu-riscv" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/emulation/spike-riscv/Kconfig b/src/mainboard/emulation/spike-riscv/Kconfig index 03046f72..2fe0e17 100644 --- a/src/mainboard/emulation/spike-riscv/Kconfig +++ b/src/mainboard/emulation/spike-riscv/Kconfig @@ -25,7 +25,7 @@ config MAINBOARD_DIR string - default emulation/spike-riscv + default "emulation/spike-riscv" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/emulation/spike-riscv/Kconfig.name b/src/mainboard/emulation/spike-riscv/Kconfig.name index 17549c6..0c0205d 100644 --- a/src/mainboard/emulation/spike-riscv/Kconfig.name +++ b/src/mainboard/emulation/spike-riscv/Kconfig.name @@ -1,3 +1,2 @@ config BOARD_EMULATION_SPIKE_RISCV bool "SPIKE riscv" - help diff --git a/src/mainboard/facebook/fbg1701/Kconfig b/src/mainboard/facebook/fbg1701/Kconfig index c92626b..dc8dc26 100644 --- a/src/mainboard/facebook/fbg1701/Kconfig +++ b/src/mainboard/facebook/fbg1701/Kconfig @@ -42,7 +42,7 @@ config MAINBOARD_DIR string - default facebook/fbg1701 + default "facebook/fbg1701" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/foxconn/d41s/Kconfig b/src/mainboard/foxconn/d41s/Kconfig index 56ab34f..4805fe0 100644 --- a/src/mainboard/foxconn/d41s/Kconfig +++ b/src/mainboard/foxconn/d41s/Kconfig @@ -37,7 +37,7 @@ config MAINBOARD_DIR string - default foxconn/d41s + default "foxconn/d41s" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/getac/p470/Kconfig b/src/mainboard/getac/p470/Kconfig index f1c7d45..7394ea4 100644 --- a/src/mainboard/getac/p470/Kconfig +++ b/src/mainboard/getac/p470/Kconfig @@ -36,7 +36,7 @@ config MAINBOARD_DIR string - default getac/p470 + default "getac/p470" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig b/src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig index e9ed54d..3c373a7 100644 --- a/src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig +++ b/src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig @@ -35,7 +35,7 @@ config MAINBOARD_DIR string - default gigabyte/ga-945gcm-s2l + default "gigabyte/ga-945gcm-s2l" config VARIANT_DIR string diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig b/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig index ceb2dbc..64d9cc5 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig +++ b/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig @@ -28,7 +28,7 @@ config MAINBOARD_DIR string - default gigabyte/ga-b75m-d3h + default "gigabyte/ga-b75m-d3h" config VARIANT_DIR string diff --git a/src/mainboard/gizmosphere/gizmo/Kconfig b/src/mainboard/gizmosphere/gizmo/Kconfig index 51f7fa0..e195e8f 100644 --- a/src/mainboard/gizmosphere/gizmo/Kconfig +++ b/src/mainboard/gizmosphere/gizmo/Kconfig @@ -31,7 +31,7 @@ config MAINBOARD_DIR string - default gizmosphere/gizmo + default "gizmosphere/gizmo" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/gizmosphere/gizmo2/Kconfig b/src/mainboard/gizmosphere/gizmo2/Kconfig index 94158ba..034b6ee 100644 --- a/src/mainboard/gizmosphere/gizmo2/Kconfig +++ b/src/mainboard/gizmosphere/gizmo2/Kconfig @@ -32,7 +32,7 @@ config MAINBOARD_DIR string - default gizmosphere/gizmo2 + default "gizmosphere/gizmo2" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig index b4ef3a8..b64b47e 100644 --- a/src/mainboard/google/auron/Kconfig +++ b/src/mainboard/google/auron/Kconfig @@ -27,7 +27,7 @@ config MAINBOARD_DIR string - default google/auron + default "google/auron" config VARIANT_DIR string diff --git a/src/mainboard/google/beltino/Kconfig b/src/mainboard/google/beltino/Kconfig index 9de141f..4b18c8c 100644 --- a/src/mainboard/google/beltino/Kconfig +++ b/src/mainboard/google/beltino/Kconfig @@ -20,7 +20,7 @@ config MAINBOARD_DIR string - default google/beltino + default "google/beltino" config VARIANT_DIR string diff --git a/src/mainboard/google/butterfly/Kconfig b/src/mainboard/google/butterfly/Kconfig index 76bcc3d..92fc236 100644 --- a/src/mainboard/google/butterfly/Kconfig +++ b/src/mainboard/google/butterfly/Kconfig @@ -26,7 +26,7 @@ config MAINBOARD_DIR string - default google/butterfly + default "google/butterfly" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/google/cheza/Kconfig b/src/mainboard/google/cheza/Kconfig index ce69fe0..30218cc 100644 --- a/src/mainboard/google/cheza/Kconfig +++ b/src/mainboard/google/cheza/Kconfig @@ -25,7 +25,7 @@ config MAINBOARD_DIR string - default google/cheza + default "google/cheza" config MAINBOARD_VENDOR string diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig index 647d4e9..bb5ffb6 100644 --- a/src/mainboard/google/cyan/Kconfig +++ b/src/mainboard/google/cyan/Kconfig @@ -34,7 +34,7 @@ config MAINBOARD_DIR string - default google/cyan + default "google/cyan" config MAINBOARD_FAMILY string diff --git a/src/mainboard/google/daisy/Kconfig b/src/mainboard/google/daisy/Kconfig index ec09d5e..f15bd9b 100644 --- a/src/mainboard/google/daisy/Kconfig +++ b/src/mainboard/google/daisy/Kconfig @@ -36,7 +36,7 @@ config MAINBOARD_DIR string - default google/daisy + default "google/daisy" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/google/foster/Kconfig b/src/mainboard/google/foster/Kconfig index 6157519..eefc2c0 100644 --- a/src/mainboard/google/foster/Kconfig +++ b/src/mainboard/google/foster/Kconfig @@ -32,7 +32,7 @@ config MAINBOARD_DIR string - default google/foster + default "google/foster" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/google/gale/Kconfig b/src/mainboard/google/gale/Kconfig index 5e00be0..81aaabf 100644 --- a/src/mainboard/google/gale/Kconfig +++ b/src/mainboard/google/gale/Kconfig @@ -41,7 +41,7 @@ config MAINBOARD_DIR string - default google/gale + default "google/gale" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/google/gru/Kconfig b/src/mainboard/google/gru/Kconfig index e7db185..72003e0 100644 --- a/src/mainboard/google/gru/Kconfig +++ b/src/mainboard/google/gru/Kconfig @@ -67,7 +67,7 @@ config MAINBOARD_DIR string - default google/gru + default "google/gru" config MAINBOARD_VENDOR string diff --git a/src/mainboard/google/jecht/Kconfig b/src/mainboard/google/jecht/Kconfig index 041ffce..41727c5 100644 --- a/src/mainboard/google/jecht/Kconfig +++ b/src/mainboard/google/jecht/Kconfig @@ -20,7 +20,7 @@ config MAINBOARD_DIR string - default google/jecht + default "google/jecht" config VARIANT_DIR diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig index a83b07a..86325532 100644 --- a/src/mainboard/google/kahlee/Kconfig +++ b/src/mainboard/google/kahlee/Kconfig @@ -50,7 +50,7 @@ config MAINBOARD_DIR string - default google/kahlee + default "google/kahlee" config VGA_BIOS_FILE string diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index c5c7a86..098ce49 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -46,7 +46,7 @@ config MAINBOARD_DIR string - default google/kukui + default "google/kukui" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/google/link/Kconfig b/src/mainboard/google/link/Kconfig index 12c5ffe..4a32ac2 100644 --- a/src/mainboard/google/link/Kconfig +++ b/src/mainboard/google/link/Kconfig @@ -26,7 +26,7 @@ config MAINBOARD_DIR string - default google/link + default "google/link" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/google/mistral/Kconfig b/src/mainboard/google/mistral/Kconfig index d6f9b16..88e6709 100644 --- a/src/mainboard/google/mistral/Kconfig +++ b/src/mainboard/google/mistral/Kconfig @@ -22,7 +22,7 @@ config MAINBOARD_DIR string - default google/mistral + default "google/mistral" config MAINBOARD_VENDOR string diff --git a/src/mainboard/google/nyan/Kconfig b/src/mainboard/google/nyan/Kconfig index 5ad945e..c617545 100644 --- a/src/mainboard/google/nyan/Kconfig +++ b/src/mainboard/google/nyan/Kconfig @@ -35,7 +35,7 @@ config MAINBOARD_DIR string - default google/nyan + default "google/nyan" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/google/nyan_big/Kconfig b/src/mainboard/google/nyan_big/Kconfig index bef2557..f02f694 100644 --- a/src/mainboard/google/nyan_big/Kconfig +++ b/src/mainboard/google/nyan_big/Kconfig @@ -37,7 +37,7 @@ config MAINBOARD_DIR string - default google/nyan_big + default "google/nyan_big" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/google/nyan_blaze/Kconfig b/src/mainboard/google/nyan_blaze/Kconfig index cb00153..8de957d 100644 --- a/src/mainboard/google/nyan_blaze/Kconfig +++ b/src/mainboard/google/nyan_blaze/Kconfig @@ -37,7 +37,7 @@ config MAINBOARD_DIR string - default google/nyan_blaze + default "google/nyan_blaze" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/google/oak/Kconfig b/src/mainboard/google/oak/Kconfig index f943a4f..264f371 100644 --- a/src/mainboard/google/oak/Kconfig +++ b/src/mainboard/google/oak/Kconfig @@ -50,7 +50,7 @@ config MAINBOARD_DIR string - default google/oak + default "google/oak" config MAINBOARD_VENDOR string diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig index d712600..1177cd5 100644 --- a/src/mainboard/google/octopus/Kconfig +++ b/src/mainboard/google/octopus/Kconfig @@ -48,7 +48,7 @@ config MAINBOARD_DIR string - default google/octopus + default "google/octopus" config VARIANT_DIR string diff --git a/src/mainboard/google/parrot/Kconfig b/src/mainboard/google/parrot/Kconfig index daf605d..0169bea 100644 --- a/src/mainboard/google/parrot/Kconfig +++ b/src/mainboard/google/parrot/Kconfig @@ -27,7 +27,7 @@ config MAINBOARD_DIR string - default google/parrot + default "google/parrot" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/google/peach_pit/Kconfig b/src/mainboard/google/peach_pit/Kconfig index fc2ceb8..b0b4d23 100644 --- a/src/mainboard/google/peach_pit/Kconfig +++ b/src/mainboard/google/peach_pit/Kconfig @@ -34,7 +34,7 @@ config MAINBOARD_DIR string - default google/peach_pit + default "google/peach_pit" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig index 83bcc1a..fc6e28e 100644 --- a/src/mainboard/google/rambi/Kconfig +++ b/src/mainboard/google/rambi/Kconfig @@ -23,7 +23,7 @@ config MAINBOARD_DIR string - default google/rambi + default "google/rambi" config VARIANT_DIR string diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig index 520b788..5d782b1 100644 --- a/src/mainboard/google/reef/Kconfig +++ b/src/mainboard/google/reef/Kconfig @@ -48,7 +48,7 @@ config MAINBOARD_DIR string - default google/reef + default "google/reef" config VARIANT_DIR string diff --git a/src/mainboard/google/slippy/Kconfig b/src/mainboard/google/slippy/Kconfig index 13dbe19..94ade7a 100644 --- a/src/mainboard/google/slippy/Kconfig +++ b/src/mainboard/google/slippy/Kconfig @@ -28,7 +28,7 @@ config MAINBOARD_DIR string - default google/slippy + default "google/slippy" config VARIANT_DIR string diff --git a/src/mainboard/google/smaug/Kconfig b/src/mainboard/google/smaug/Kconfig index 2b9be02..fa08251 100644 --- a/src/mainboard/google/smaug/Kconfig +++ b/src/mainboard/google/smaug/Kconfig @@ -38,7 +38,7 @@ config MAINBOARD_DIR string - default google/smaug + default "google/smaug" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/google/storm/Kconfig b/src/mainboard/google/storm/Kconfig index 3abea56..0bd8f5a 100644 --- a/src/mainboard/google/storm/Kconfig +++ b/src/mainboard/google/storm/Kconfig @@ -39,7 +39,7 @@ config MAINBOARD_DIR string - default google/storm + default "google/storm" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/google/stout/Kconfig b/src/mainboard/google/stout/Kconfig index dfe687b..a77964b 100644 --- a/src/mainboard/google/stout/Kconfig +++ b/src/mainboard/google/stout/Kconfig @@ -25,7 +25,7 @@ config MAINBOARD_DIR string - default google/stout + default "google/stout" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/google/trogdor/Kconfig b/src/mainboard/google/trogdor/Kconfig index 56b3a72..fba6b17 100644 --- a/src/mainboard/google/trogdor/Kconfig +++ b/src/mainboard/google/trogdor/Kconfig @@ -25,7 +25,7 @@ config MAINBOARD_DIR string - default google/trogdor + default "google/trogdor" config MAINBOARD_VENDOR string diff --git a/src/mainboard/google/veyron/Kconfig b/src/mainboard/google/veyron/Kconfig index 8e29661..5d1e616 100644 --- a/src/mainboard/google/veyron/Kconfig +++ b/src/mainboard/google/veyron/Kconfig @@ -47,7 +47,7 @@ config MAINBOARD_DIR string - default google/veyron + default "google/veyron" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/google/veyron_mickey/Kconfig b/src/mainboard/google/veyron_mickey/Kconfig index 876d70e..5d15f0e 100644 --- a/src/mainboard/google/veyron_mickey/Kconfig +++ b/src/mainboard/google/veyron_mickey/Kconfig @@ -32,7 +32,7 @@ config MAINBOARD_DIR string - default google/veyron_mickey + default "google/veyron_mickey" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/google/veyron_rialto/Kconfig b/src/mainboard/google/veyron_rialto/Kconfig index 4550c5b..ac6f382 100644 --- a/src/mainboard/google/veyron_rialto/Kconfig +++ b/src/mainboard/google/veyron_rialto/Kconfig @@ -32,7 +32,7 @@ config MAINBOARD_DIR string - default google/veyron_rialto + default "google/veyron_rialto" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/hp/2570p/Kconfig b/src/mainboard/hp/2570p/Kconfig index 5e33aac..a014b0c 100644 --- a/src/mainboard/hp/2570p/Kconfig +++ b/src/mainboard/hp/2570p/Kconfig @@ -35,7 +35,7 @@ config MAINBOARD_DIR string - default hp/2570p + default "hp/2570p" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/hp/2760p/Kconfig b/src/mainboard/hp/2760p/Kconfig index ab29836..935064c 100644 --- a/src/mainboard/hp/2760p/Kconfig +++ b/src/mainboard/hp/2760p/Kconfig @@ -35,7 +35,7 @@ config MAINBOARD_DIR string - default hp/2760p + default "hp/2760p" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/hp/8460p/Kconfig b/src/mainboard/hp/8460p/Kconfig index ca97cd6..08e21fd 100644 --- a/src/mainboard/hp/8460p/Kconfig +++ b/src/mainboard/hp/8460p/Kconfig @@ -38,7 +38,7 @@ config MAINBOARD_DIR string - default hp/8460p + default "hp/8460p" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/hp/8470p/Kconfig b/src/mainboard/hp/8470p/Kconfig index 5b30208..e084d00 100644 --- a/src/mainboard/hp/8470p/Kconfig +++ b/src/mainboard/hp/8470p/Kconfig @@ -36,7 +36,7 @@ config MAINBOARD_DIR string - default hp/8470p + default "hp/8470p" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/hp/8770w/Kconfig b/src/mainboard/hp/8770w/Kconfig index 41e2ed3..80f9199 100644 --- a/src/mainboard/hp/8770w/Kconfig +++ b/src/mainboard/hp/8770w/Kconfig @@ -35,7 +35,7 @@ config MAINBOARD_DIR string - default hp/8770w + default "hp/8770w" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/hp/abm/Kconfig b/src/mainboard/hp/abm/Kconfig index 43cf67f..5ba1b5b 100644 --- a/src/mainboard/hp/abm/Kconfig +++ b/src/mainboard/hp/abm/Kconfig @@ -30,7 +30,7 @@ config MAINBOARD_DIR string - default hp/abm + default "hp/abm" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig index cbfb0ed..42efd4a 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig +++ b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig @@ -21,7 +21,7 @@ config MAINBOARD_DIR string - default hp/compaq_8200_elite_sff + default "hp/compaq_8200_elite_sff" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/hp/folio_9470m/Kconfig b/src/mainboard/hp/folio_9470m/Kconfig index d9bb68e..8759192 100644 --- a/src/mainboard/hp/folio_9470m/Kconfig +++ b/src/mainboard/hp/folio_9470m/Kconfig @@ -21,7 +21,7 @@ config MAINBOARD_DIR string - default hp/folio_9470m + default "hp/folio_9470m" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/hp/pavilion_m6_1035dx/Kconfig b/src/mainboard/hp/pavilion_m6_1035dx/Kconfig index 7fa04ee..3c67e2a 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/Kconfig +++ b/src/mainboard/hp/pavilion_m6_1035dx/Kconfig @@ -35,7 +35,7 @@ config MAINBOARD_DIR string - default hp/pavilion_m6_1035dx + default "hp/pavilion_m6_1035dx" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/hp/revolve_810_g1/Kconfig b/src/mainboard/hp/revolve_810_g1/Kconfig index ce7364c..26e645f 100644 --- a/src/mainboard/hp/revolve_810_g1/Kconfig +++ b/src/mainboard/hp/revolve_810_g1/Kconfig @@ -23,7 +23,7 @@ config MAINBOARD_DIR string - default hp/revolve_810_g1 + default "hp/revolve_810_g1" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/hp/z220_sff_workstation/Kconfig b/src/mainboard/hp/z220_sff_workstation/Kconfig index 4598de2..649cbb1 100644 --- a/src/mainboard/hp/z220_sff_workstation/Kconfig +++ b/src/mainboard/hp/z220_sff_workstation/Kconfig @@ -32,7 +32,7 @@ config MAINBOARD_DIR string - default hp/z220_sff_workstation + default "hp/z220_sff_workstation" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/ibase/mb899/Kconfig b/src/mainboard/ibase/mb899/Kconfig index fcc2e38..d93121d 100644 --- a/src/mainboard/ibase/mb899/Kconfig +++ b/src/mainboard/ibase/mb899/Kconfig @@ -18,7 +18,7 @@ config MAINBOARD_DIR string - default ibase/mb899 + default "ibase/mb899" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/intel/apollolake_rvp/Kconfig b/src/mainboard/intel/apollolake_rvp/Kconfig index ed7d77f..391ce1f 100644 --- a/src/mainboard/intel/apollolake_rvp/Kconfig +++ b/src/mainboard/intel/apollolake_rvp/Kconfig @@ -9,7 +9,7 @@ config MAINBOARD_DIR string - default intel/apollolake_rvp + default "intel/apollolake_rvp" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/intel/baskingridge/Kconfig b/src/mainboard/intel/baskingridge/Kconfig index d5dafa0..8268891 100644 --- a/src/mainboard/intel/baskingridge/Kconfig +++ b/src/mainboard/intel/baskingridge/Kconfig @@ -18,7 +18,7 @@ config MAINBOARD_DIR string - default intel/baskingridge + default "intel/baskingridge" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/intel/d510mo/Kconfig b/src/mainboard/intel/d510mo/Kconfig index 153c113..003e009 100644 --- a/src/mainboard/intel/d510mo/Kconfig +++ b/src/mainboard/intel/d510mo/Kconfig @@ -36,7 +36,7 @@ config MAINBOARD_DIR string - default intel/d510mo + default "intel/d510mo" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/intel/d945gclf/Kconfig b/src/mainboard/intel/d945gclf/Kconfig index 46d82ec..683ea2d 100644 --- a/src/mainboard/intel/d945gclf/Kconfig +++ b/src/mainboard/intel/d945gclf/Kconfig @@ -33,7 +33,7 @@ config MAINBOARD_DIR string - default intel/d945gclf + default "intel/d945gclf" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/intel/dcp847ske/Kconfig b/src/mainboard/intel/dcp847ske/Kconfig index b1c7bab..9bf9e52 100644 --- a/src/mainboard/intel/dcp847ske/Kconfig +++ b/src/mainboard/intel/dcp847ske/Kconfig @@ -27,7 +27,7 @@ config MAINBOARD_DIR string - default intel/dcp847ske + default "intel/dcp847ske" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/intel/emeraldlake2/Kconfig b/src/mainboard/intel/emeraldlake2/Kconfig index 61dd1b0..c37da03 100644 --- a/src/mainboard/intel/emeraldlake2/Kconfig +++ b/src/mainboard/intel/emeraldlake2/Kconfig @@ -19,7 +19,7 @@ config MAINBOARD_DIR string - default intel/emeraldlake2 + default "intel/emeraldlake2" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/intel/galileo/Kconfig b/src/mainboard/intel/galileo/Kconfig index 84f09c4..2e855da 100644 --- a/src/mainboard/intel/galileo/Kconfig +++ b/src/mainboard/intel/galileo/Kconfig @@ -28,7 +28,7 @@ config MAINBOARD_DIR string - default intel/galileo + default "intel/galileo" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/intel/glkrvp/Kconfig b/src/mainboard/intel/glkrvp/Kconfig index ebb5a3a..8ed2aff 100644 --- a/src/mainboard/intel/glkrvp/Kconfig +++ b/src/mainboard/intel/glkrvp/Kconfig @@ -50,7 +50,7 @@ config MAINBOARD_DIR string - default intel/glkrvp + default "intel/glkrvp" config VARIANT_DIR string diff --git a/src/mainboard/intel/harcuvar/Kconfig b/src/mainboard/intel/harcuvar/Kconfig index 9d43b11..e3cd86e8 100644 --- a/src/mainboard/intel/harcuvar/Kconfig +++ b/src/mainboard/intel/harcuvar/Kconfig @@ -23,7 +23,7 @@ config MAINBOARD_DIR string - default intel/harcuvar + default "intel/harcuvar" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/intel/leafhill/Kconfig b/src/mainboard/intel/leafhill/Kconfig index e89d892..5832570 100644 --- a/src/mainboard/intel/leafhill/Kconfig +++ b/src/mainboard/intel/leafhill/Kconfig @@ -9,7 +9,7 @@ config MAINBOARD_DIR string - default intel/leafhill + default "intel/leafhill" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/intel/minnow3/Kconfig b/src/mainboard/intel/minnow3/Kconfig index 2dea6b4..8d95a35 100644 --- a/src/mainboard/intel/minnow3/Kconfig +++ b/src/mainboard/intel/minnow3/Kconfig @@ -9,7 +9,7 @@ config MAINBOARD_DIR string - default intel/minnow3 + default "intel/minnow3" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/intel/strago/Kconfig b/src/mainboard/intel/strago/Kconfig index 5a49e8c..246add1 100644 --- a/src/mainboard/intel/strago/Kconfig +++ b/src/mainboard/intel/strago/Kconfig @@ -24,7 +24,7 @@ config MAINBOARD_DIR string - default intel/strago + default "intel/strago" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/intel/wtm2/Kconfig b/src/mainboard/intel/wtm2/Kconfig index 27545fe..2f6b21e 100644 --- a/src/mainboard/intel/wtm2/Kconfig +++ b/src/mainboard/intel/wtm2/Kconfig @@ -19,7 +19,7 @@ config MAINBOARD_DIR string - default intel/wtm2 + default "intel/wtm2" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/jetway/nf81-t56n-lf/Kconfig b/src/mainboard/jetway/nf81-t56n-lf/Kconfig index 6cc06c2..d2dda67 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/Kconfig +++ b/src/mainboard/jetway/nf81-t56n-lf/Kconfig @@ -32,7 +32,7 @@ config MAINBOARD_DIR string - default jetway/nf81-t56n-lf + default "jetway/nf81-t56n-lf" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/kontron/986lcd-m/Kconfig b/src/mainboard/kontron/986lcd-m/Kconfig index 5584eb3..1ccdf1a 100644 --- a/src/mainboard/kontron/986lcd-m/Kconfig +++ b/src/mainboard/kontron/986lcd-m/Kconfig @@ -20,7 +20,7 @@ config MAINBOARD_DIR string - default kontron/986lcd-m + default "kontron/986lcd-m" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/kontron/ktqm77/Kconfig b/src/mainboard/kontron/ktqm77/Kconfig index c215bdf..1cefa59 100644 --- a/src/mainboard/kontron/ktqm77/Kconfig +++ b/src/mainboard/kontron/ktqm77/Kconfig @@ -17,7 +17,7 @@ config MAINBOARD_DIR string - default kontron/ktqm77 + default "kontron/ktqm77" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/lenovo/g505s/Kconfig b/src/mainboard/lenovo/g505s/Kconfig index b80019e..a277145 100644 --- a/src/mainboard/lenovo/g505s/Kconfig +++ b/src/mainboard/lenovo/g505s/Kconfig @@ -33,7 +33,7 @@ config MAINBOARD_DIR string - default lenovo/g505s + default "lenovo/g505s" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/lenovo/l520/Kconfig b/src/mainboard/lenovo/l520/Kconfig index 4495d79..a300d16 100644 --- a/src/mainboard/lenovo/l520/Kconfig +++ b/src/mainboard/lenovo/l520/Kconfig @@ -20,7 +20,7 @@ config MAINBOARD_DIR string - default lenovo/l520 + default "lenovo/l520" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/lenovo/s230u/Kconfig b/src/mainboard/lenovo/s230u/Kconfig index c7faebb..662c9a5 100644 --- a/src/mainboard/lenovo/s230u/Kconfig +++ b/src/mainboard/lenovo/s230u/Kconfig @@ -22,7 +22,7 @@ config MAINBOARD_DIR string - default lenovo/s230u + default "lenovo/s230u" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/lenovo/t400/Kconfig b/src/mainboard/lenovo/t400/Kconfig index a68d1fa..9355540 100644 --- a/src/mainboard/lenovo/t400/Kconfig +++ b/src/mainboard/lenovo/t400/Kconfig @@ -47,7 +47,7 @@ config MAINBOARD_DIR string - default lenovo/t400 + default "lenovo/t400" config VARIANT_DIR string diff --git a/src/mainboard/lenovo/t410/Kconfig b/src/mainboard/lenovo/t410/Kconfig index 329d08d..943bf43 100644 --- a/src/mainboard/lenovo/t410/Kconfig +++ b/src/mainboard/lenovo/t410/Kconfig @@ -44,7 +44,7 @@ config MAINBOARD_DIR string - default lenovo/t410 + default "lenovo/t410" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/lenovo/t420/Kconfig b/src/mainboard/lenovo/t420/Kconfig index 5148604..d26ad17 100644 --- a/src/mainboard/lenovo/t420/Kconfig +++ b/src/mainboard/lenovo/t420/Kconfig @@ -49,7 +49,7 @@ config MAINBOARD_DIR string - default lenovo/t420 + default "lenovo/t420" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/lenovo/t420s/Kconfig b/src/mainboard/lenovo/t420s/Kconfig index 190f35e..89f84fc 100644 --- a/src/mainboard/lenovo/t420s/Kconfig +++ b/src/mainboard/lenovo/t420s/Kconfig @@ -48,7 +48,7 @@ config MAINBOARD_DIR string - default lenovo/t420s + default "lenovo/t420s" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/lenovo/t430/Kconfig b/src/mainboard/lenovo/t430/Kconfig index 7137b5e..78da385 100644 --- a/src/mainboard/lenovo/t430/Kconfig +++ b/src/mainboard/lenovo/t430/Kconfig @@ -28,7 +28,7 @@ config MAINBOARD_DIR string - default lenovo/t430 + default "lenovo/t430" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/lenovo/t430s/Kconfig b/src/mainboard/lenovo/t430s/Kconfig index 0c7d075..36f03ae 100644 --- a/src/mainboard/lenovo/t430s/Kconfig +++ b/src/mainboard/lenovo/t430s/Kconfig @@ -29,7 +29,7 @@ config MAINBOARD_DIR string - default lenovo/t430s + default "lenovo/t430s" config VARIANT_DIR string diff --git a/src/mainboard/lenovo/t440p/Kconfig b/src/mainboard/lenovo/t440p/Kconfig index bf821f3..faaa73a 100644 --- a/src/mainboard/lenovo/t440p/Kconfig +++ b/src/mainboard/lenovo/t440p/Kconfig @@ -25,7 +25,7 @@ config MAINBOARD_DIR string - default lenovo/t440p + default "lenovo/t440p" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/lenovo/t520/Kconfig b/src/mainboard/lenovo/t520/Kconfig index d4934d6..a6183d9 100644 --- a/src/mainboard/lenovo/t520/Kconfig +++ b/src/mainboard/lenovo/t520/Kconfig @@ -49,7 +49,7 @@ config MAINBOARD_DIR string - default lenovo/t520 + default "lenovo/t520" config DEVICETREE string diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig index f63a120..d1ba6a8 100644 --- a/src/mainboard/lenovo/t530/Kconfig +++ b/src/mainboard/lenovo/t530/Kconfig @@ -35,7 +35,7 @@ config MAINBOARD_DIR string - default lenovo/t530 + default "lenovo/t530" config DEVICETREE string diff --git a/src/mainboard/lenovo/t60/Kconfig b/src/mainboard/lenovo/t60/Kconfig index 436b035..58d41a6 100644 --- a/src/mainboard/lenovo/t60/Kconfig +++ b/src/mainboard/lenovo/t60/Kconfig @@ -25,7 +25,7 @@ config MAINBOARD_DIR string - default lenovo/t60 + default "lenovo/t60" config VARIANT_DIR string diff --git a/src/mainboard/lenovo/x131e/Kconfig b/src/mainboard/lenovo/x131e/Kconfig index e7da8d0..2cf3a8f 100644 --- a/src/mainboard/lenovo/x131e/Kconfig +++ b/src/mainboard/lenovo/x131e/Kconfig @@ -23,7 +23,7 @@ config MAINBOARD_DIR string - default lenovo/x131e + default "lenovo/x131e" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig index a15cadf..91ba208 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig +++ b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig @@ -28,7 +28,7 @@ config MAINBOARD_DIR string - default lenovo/x1_carbon_gen1 + default "lenovo/x1_carbon_gen1" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/lenovo/x200/Kconfig b/src/mainboard/lenovo/x200/Kconfig index 5e88c21..432c805 100644 --- a/src/mainboard/lenovo/x200/Kconfig +++ b/src/mainboard/lenovo/x200/Kconfig @@ -44,7 +44,7 @@ config MAINBOARD_DIR string - default lenovo/x200 + default "lenovo/x200" config VARIANT_DIR string diff --git a/src/mainboard/lenovo/x201/Kconfig b/src/mainboard/lenovo/x201/Kconfig index e40c0d3..a94d24e 100644 --- a/src/mainboard/lenovo/x201/Kconfig +++ b/src/mainboard/lenovo/x201/Kconfig @@ -44,7 +44,7 @@ config MAINBOARD_DIR string - default lenovo/x201 + default "lenovo/x201" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/lenovo/x220/Kconfig b/src/mainboard/lenovo/x220/Kconfig index c80c2520..b20255e 100644 --- a/src/mainboard/lenovo/x220/Kconfig +++ b/src/mainboard/lenovo/x220/Kconfig @@ -43,7 +43,7 @@ config MAINBOARD_DIR string - default lenovo/x220 + default "lenovo/x220" config VARIANT_DIR string diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig index a043efc..e7edf6b 100644 --- a/src/mainboard/lenovo/x230/Kconfig +++ b/src/mainboard/lenovo/x230/Kconfig @@ -29,7 +29,7 @@ config MAINBOARD_DIR string - default lenovo/x230 + default "lenovo/x230" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/lenovo/x60/Kconfig b/src/mainboard/lenovo/x60/Kconfig index a1a5fec..1815892 100644 --- a/src/mainboard/lenovo/x60/Kconfig +++ b/src/mainboard/lenovo/x60/Kconfig @@ -28,7 +28,7 @@ config MAINBOARD_DIR string - default lenovo/x60 + default "lenovo/x60" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/lippert/frontrunner-af/Kconfig b/src/mainboard/lippert/frontrunner-af/Kconfig index f8a3f3a..92d7743 100644 --- a/src/mainboard/lippert/frontrunner-af/Kconfig +++ b/src/mainboard/lippert/frontrunner-af/Kconfig @@ -33,7 +33,7 @@ config MAINBOARD_DIR string - default lippert/frontrunner-af + default "lippert/frontrunner-af" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/lippert/toucan-af/Kconfig b/src/mainboard/lippert/toucan-af/Kconfig index 67efdfe..74b335a 100644 --- a/src/mainboard/lippert/toucan-af/Kconfig +++ b/src/mainboard/lippert/toucan-af/Kconfig @@ -35,7 +35,7 @@ config MAINBOARD_DIR string - default lippert/toucan-af + default "lippert/toucan-af" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/msi/ms7707/Kconfig b/src/mainboard/msi/ms7707/Kconfig index 4923bbf..c1a1b4c 100644 --- a/src/mainboard/msi/ms7707/Kconfig +++ b/src/mainboard/msi/ms7707/Kconfig @@ -16,7 +16,7 @@ config MAINBOARD_DIR string - default msi/ms7707 + default "msi/ms7707" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/msi/ms7721/Kconfig b/src/mainboard/msi/ms7721/Kconfig index 5fa4768..1fee747 100644 --- a/src/mainboard/msi/ms7721/Kconfig +++ b/src/mainboard/msi/ms7721/Kconfig @@ -33,7 +33,7 @@ config MAINBOARD_DIR string - default msi/ms7721 + default "msi/ms7721" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/packardbell/ms2290/Kconfig b/src/mainboard/packardbell/ms2290/Kconfig index a104fec..6a61384 100644 --- a/src/mainboard/packardbell/ms2290/Kconfig +++ b/src/mainboard/packardbell/ms2290/Kconfig @@ -16,7 +16,7 @@ config MAINBOARD_DIR string - default packardbell/ms2290 + default "packardbell/ms2290" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/pcengines/apu1/Kconfig b/src/mainboard/pcengines/apu1/Kconfig index 07aaa8c..3396845 100644 --- a/src/mainboard/pcengines/apu1/Kconfig +++ b/src/mainboard/pcengines/apu1/Kconfig @@ -35,7 +35,7 @@ config MAINBOARD_DIR string - default pcengines/apu1 + default "pcengines/apu1" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/pcengines/apu2/Kconfig b/src/mainboard/pcengines/apu2/Kconfig index 6c3958b..0437c84 100644 --- a/src/mainboard/pcengines/apu2/Kconfig +++ b/src/mainboard/pcengines/apu2/Kconfig @@ -36,7 +36,7 @@ config MAINBOARD_DIR string - default pcengines/apu2 + default "pcengines/apu2" config VARIANT_DIR string diff --git a/src/mainboard/portwell/m107/Kconfig b/src/mainboard/portwell/m107/Kconfig index e5e3ff5..a89daa1 100644 --- a/src/mainboard/portwell/m107/Kconfig +++ b/src/mainboard/portwell/m107/Kconfig @@ -51,7 +51,7 @@ config MAINBOARD_DIR string - default portwell/m107 + default "portwell/m107" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/purism/librem_bdw/Kconfig b/src/mainboard/purism/librem_bdw/Kconfig index 224bde0..466e03e 100644 --- a/src/mainboard/purism/librem_bdw/Kconfig +++ b/src/mainboard/purism/librem_bdw/Kconfig @@ -40,7 +40,7 @@ config MAINBOARD_DIR string - default purism/librem_bdw + default "purism/librem_bdw" config MAINBOARD_VENDOR string diff --git a/src/mainboard/roda/rk886ex/Kconfig b/src/mainboard/roda/rk886ex/Kconfig index 563b7739..9d08c96 100644 --- a/src/mainboard/roda/rk886ex/Kconfig +++ b/src/mainboard/roda/rk886ex/Kconfig @@ -22,7 +22,7 @@ config MAINBOARD_DIR string - default roda/rk886ex + default "roda/rk886ex" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/roda/rk9/Kconfig b/src/mainboard/roda/rk9/Kconfig index fd29739..7516255 100644 --- a/src/mainboard/roda/rk9/Kconfig +++ b/src/mainboard/roda/rk9/Kconfig @@ -19,7 +19,7 @@ config MAINBOARD_DIR string - default roda/rk9 + default "roda/rk9" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/samsung/lumpy/Kconfig b/src/mainboard/samsung/lumpy/Kconfig index 2d1544b..f87ba8f 100644 --- a/src/mainboard/samsung/lumpy/Kconfig +++ b/src/mainboard/samsung/lumpy/Kconfig @@ -29,7 +29,7 @@ config MAINBOARD_DIR string - default samsung/lumpy + default "samsung/lumpy" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/samsung/stumpy/Kconfig b/src/mainboard/samsung/stumpy/Kconfig index a2919f9..5deb0f0 100644 --- a/src/mainboard/samsung/stumpy/Kconfig +++ b/src/mainboard/samsung/stumpy/Kconfig @@ -25,7 +25,7 @@ config MAINBOARD_DIR string - default samsung/stumpy + default "samsung/stumpy" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/sapphire/pureplatinumh61/Kconfig b/src/mainboard/sapphire/pureplatinumh61/Kconfig index 6d27b3f..0e289c1 100644 --- a/src/mainboard/sapphire/pureplatinumh61/Kconfig +++ b/src/mainboard/sapphire/pureplatinumh61/Kconfig @@ -18,7 +18,7 @@ config MAINBOARD_DIR string - default sapphire/pureplatinumh61 + default "sapphire/pureplatinumh61" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/scaleway/tagada/Kconfig b/src/mainboard/scaleway/tagada/Kconfig index 9530505..25cb7e1 100644 --- a/src/mainboard/scaleway/tagada/Kconfig +++ b/src/mainboard/scaleway/tagada/Kconfig @@ -26,7 +26,7 @@ config MAINBOARD_DIR string - default scaleway/tagada + default "scaleway/tagada" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/siemens/mc_apl1/Kconfig b/src/mainboard/siemens/mc_apl1/Kconfig index 0b8cff3..52883b8 100644 --- a/src/mainboard/siemens/mc_apl1/Kconfig +++ b/src/mainboard/siemens/mc_apl1/Kconfig @@ -13,7 +13,7 @@ config MAINBOARD_DIR string - default siemens/mc_apl1 + default "siemens/mc_apl1" config VARIANT_DIR string diff --git a/src/mainboard/sifive/hifive-unleashed/Kconfig b/src/mainboard/sifive/hifive-unleashed/Kconfig index fc9bc1e..460fdfb 100644 --- a/src/mainboard/sifive/hifive-unleashed/Kconfig +++ b/src/mainboard/sifive/hifive-unleashed/Kconfig @@ -26,7 +26,7 @@ config MAINBOARD_DIR string - default sifive/hifive-unleashed + default "sifive/hifive-unleashed" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/ti/beaglebone/Kconfig b/src/mainboard/ti/beaglebone/Kconfig index 322ac0c..7009622 100644 --- a/src/mainboard/ti/beaglebone/Kconfig +++ b/src/mainboard/ti/beaglebone/Kconfig @@ -23,7 +23,7 @@ config MAINBOARD_DIR string - default ti/beaglebone + default "ti/beaglebone" config MAINBOARD_PART_NUMBER string diff --git a/src/northbridge/amd/pi/Kconfig b/src/northbridge/amd/pi/Kconfig index 65c6556..c0df2a1 100644 --- a/src/northbridge/amd/pi/Kconfig +++ b/src/northbridge/amd/pi/Kconfig @@ -41,9 +41,9 @@ bool default n -source src/northbridge/amd/pi/00630F01/Kconfig -source src/northbridge/amd/pi/00730F01/Kconfig -source src/northbridge/amd/pi/00660F01/Kconfig +source "src/northbridge/amd/pi/00630F01/Kconfig" +source "src/northbridge/amd/pi/00730F01/Kconfig" +source "src/northbridge/amd/pi/00660F01/Kconfig" config HW_MEM_HOLE_SIZEK hex diff --git a/src/southbridge/amd/agesa/Kconfig b/src/southbridge/amd/agesa/Kconfig index e5bc990..7162c27 100644 --- a/src/southbridge/amd/agesa/Kconfig +++ b/src/southbridge/amd/agesa/Kconfig @@ -13,4 +13,4 @@ # GNU General Public License for more details. # -source src/southbridge/amd/agesa/hudson/Kconfig +source "src/southbridge/amd/agesa/hudson/Kconfig" diff --git a/src/southbridge/amd/cimx/Kconfig b/src/southbridge/amd/cimx/Kconfig index 62a717b..3e12327 100644 --- a/src/southbridge/amd/cimx/Kconfig +++ b/src/southbridge/amd/cimx/Kconfig @@ -17,4 +17,4 @@ bool default n -source src/southbridge/amd/cimx/sb800/Kconfig +source "src/southbridge/amd/cimx/sb800/Kconfig" diff --git a/src/southbridge/amd/pi/Kconfig b/src/southbridge/amd/pi/Kconfig index 2fb509c..531b460 100644 --- a/src/southbridge/amd/pi/Kconfig +++ b/src/southbridge/amd/pi/Kconfig @@ -13,4 +13,4 @@ # GNU General Public License for more details. # -source src/southbridge/amd/pi/hudson/Kconfig +source "src/southbridge/amd/pi/hudson/Kconfig" diff --git a/src/vendorcode/amd/Kconfig b/src/vendorcode/amd/Kconfig index 44b3940..10a4947 100644 --- a/src/vendorcode/amd/Kconfig +++ b/src/vendorcode/amd/Kconfig @@ -44,7 +44,7 @@ endchoice if CPU_AMD_AGESA_BINARY_PI -source src/vendorcode/amd/pi/Kconfig +source "src/vendorcode/amd/pi/Kconfig" endif config AGESA_EXTRA_TIMESTAMPS diff --git a/src/vendorcode/eltan/security/Kconfig b/src/vendorcode/eltan/security/Kconfig index 1cc0365..9a89381 100644 --- a/src/vendorcode/eltan/security/Kconfig +++ b/src/vendorcode/eltan/security/Kconfig @@ -19,8 +19,8 @@ menu "Eltan Security Settings" -source src/vendorcode/eltan/security/mboot/Kconfig -source src/vendorcode/eltan/security/verified_boot/Kconfig +source "src/vendorcode/eltan/security/mboot/Kconfig" +source "src/vendorcode/eltan/security/verified_boot/Kconfig" endmenu diff --git a/src/vendorcode/google/Kconfig b/src/vendorcode/google/Kconfig index fcb28df..498d0ed 100644 --- a/src/vendorcode/google/Kconfig +++ b/src/vendorcode/google/Kconfig @@ -12,7 +12,7 @@ ## GNU General Public License for more details. ## -source src/vendorcode/google/chromeos/Kconfig +source "src/vendorcode/google/chromeos/Kconfig" config GOOGLE_SMBIOS_MAINBOARD_VERSION bool -- To view, visit https://review.coreboot.org/c/coreboot/+/37156 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I92a9e9bf0d557a7532ba533cd7776c48f2488f91 Gerrit-Change-Number: 37156 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

2 2

Change in coreboot[master]: northbridge/amd/pi: drop BINARYPI_LEGACY_WRAPPER
by Michał Żygowski (Code Review) 23 Nov '19

23 Nov '19

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37172 ) Change subject: northbridge/amd/pi: drop BINARYPI_LEGACY_WRAPPER ...................................................................... northbridge/amd/pi: drop BINARYPI_LEGACY_WRAPPER Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I91bf6216e147b376849966aed775dc8b10cd33c4 --- M src/northbridge/amd/pi/00630F01/northbridge.c M src/northbridge/amd/pi/00660F01/northbridge.c M src/northbridge/amd/pi/00730F01/northbridge.c M src/northbridge/amd/pi/Makefile.inc D src/northbridge/amd/pi/agesawrapper.c D src/northbridge/amd/pi/agesawrapper.h D src/northbridge/amd/pi/agesawrapper_call.h 7 files changed, 1 insertion(+), 480 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/37172/1 diff --git a/src/northbridge/amd/pi/00630F01/northbridge.c b/src/northbridge/amd/pi/00630F01/northbridge.c index 000ccd9..6f44d60 100644 --- a/src/northbridge/amd/pi/00630F01/northbridge.c +++ b/src/northbridge/amd/pi/00630F01/northbridge.c @@ -36,12 +36,8 @@ #include <arch/acpigen.h> #include <northbridge/amd/pi/nb_common.h> #include <northbridge/amd/agesa/agesa_helper.h> -#if CONFIG(BINARYPI_LEGACY_WRAPPER) -#include <northbridge/amd/pi/agesawrapper.h> -#include <northbridge/amd/pi/agesawrapper_call.h> -#else #include <northbridge/amd/agesa/state_machine.h> -#endif + #define MAX_NODE_NUMS MAX_NODES @@ -612,16 +608,6 @@ static void domain_enable_resources(struct device *dev) { -#if CONFIG(BINARYPI_LEGACY_WRAPPER) - /* Must be called after PCI enumeration and resource allocation */ - if (!acpi_is_wakeup_s3()) { - /* Enable MMIO on AMD CPU Address Map Controller */ - amd_initcpuio(); - - agesawrapper_amdinitmid(); - } - printk(BIOS_DEBUG, " ader - leaving %s.\n", __func__); -#endif } #if CONFIG_HW_MEM_HOLE_SIZEK != 0 diff --git a/src/northbridge/amd/pi/00660F01/northbridge.c b/src/northbridge/amd/pi/00660F01/northbridge.c index 2e15533..80112dd 100644 --- a/src/northbridge/amd/pi/00660F01/northbridge.c +++ b/src/northbridge/amd/pi/00660F01/northbridge.c @@ -36,12 +36,7 @@ #include <arch/acpigen.h> #include <northbridge/amd/pi/nb_common.h> #include <northbridge/amd/agesa/agesa_helper.h> -#if CONFIG(BINARYPI_LEGACY_WRAPPER) -#include <northbridge/amd/pi/agesawrapper.h> -#include <northbridge/amd/pi/agesawrapper_call.h> -#else #include <northbridge/amd/agesa/state_machine.h> -#endif #define MAX_NODE_NUMS MAX_NODES @@ -613,13 +608,6 @@ static void domain_enable_resources(struct device *dev) { -#if CONFIG(BINARYPI_LEGACY_WRAPPER) - /* Must be called after PCI enumeration and resource allocation */ - if (!acpi_is_wakeup_s3()) - AGESAWRAPPER(amdinitmid); - - printk(BIOS_DEBUG, " ader - leaving domain_enable_resources.\n"); -#endif } #if CONFIG_HW_MEM_HOLE_SIZEK != 0 diff --git a/src/northbridge/amd/pi/00730F01/northbridge.c b/src/northbridge/amd/pi/00730F01/northbridge.c index 83bcbea..8d8b025 100644 --- a/src/northbridge/amd/pi/00730F01/northbridge.c +++ b/src/northbridge/amd/pi/00730F01/northbridge.c @@ -37,12 +37,7 @@ #include <arch/acpigen.h> #include <northbridge/amd/pi/nb_common.h> #include <northbridge/amd/agesa/agesa_helper.h> -#if CONFIG(BINARYPI_LEGACY_WRAPPER) -#include <northbridge/amd/pi/agesawrapper.h> -#include <northbridge/amd/pi/agesawrapper_call.h> -#else #include <northbridge/amd/agesa/state_machine.h> -#endif #define MAX_NODE_NUMS MAX_NODES @@ -838,13 +833,6 @@ static void domain_enable_resources(struct device *dev) { -#if CONFIG(BINARYPI_LEGACY_WRAPPER) - /* Must be called after PCI enumeration and resource allocation */ - if (!acpi_is_wakeup_s3()) - AGESAWRAPPER(amdinitmid); - - printk(BIOS_DEBUG, " ader - leaving domain_enable_resources.\n"); -#endif } #if CONFIG_HW_MEM_HOLE_SIZEK != 0 diff --git a/src/northbridge/amd/pi/Makefile.inc b/src/northbridge/amd/pi/Makefile.inc index 349761b..886055a 100644 --- a/src/northbridge/amd/pi/Makefile.inc +++ b/src/northbridge/amd/pi/Makefile.inc @@ -19,13 +19,8 @@ subdirs-$(CONFIG_NORTHBRIDGE_AMD_PI_00730F01) += 00730F01 subdirs-$(CONFIG_NORTHBRIDGE_AMD_PI_00660F01) += 00660F01 -ifeq ($(CONFIG_BINARYPI_LEGACY_WRAPPER), y) -romstage-y += agesawrapper.c -ramstage-y += agesawrapper.c -else romstage-y += state_machine.c ramstage-y += state_machine.c -endif romstage-y += ramtop.c postcar-y += ramtop.c diff --git a/src/northbridge/amd/pi/agesawrapper.c b/src/northbridge/amd/pi/agesawrapper.c deleted file mode 100644 index e3bfd90..0000000 --- a/src/northbridge/amd/pi/agesawrapper.c +++ /dev/null @@ -1,317 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2012 - 2014 Advanced Micro Devices, Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include <AGESA.h> -#include <cbfs.h> -#include <cbmem.h> -#include <delay.h> -#include <console/console.h> -#include <cpu/x86/mtrr.h> -#include <FchPlatform.h> -#include <heapManager.h> -#include <northbridge/amd/agesa/agesa_helper.h> -#include <northbridge/amd/agesa/state_machine.h> -#include <northbridge/amd/pi/agesawrapper.h> -#include <northbridge/amd/agesa/BiosCallOuts.h> - -void __weak OemPostParams(AMD_POST_PARAMS *PostParams) {} - -#define FILECODE UNASSIGNED_FILE_FILECODE - -AGESA_STATUS agesawrapper_amdinitreset(void) -{ - AGESA_STATUS status; - AMD_INTERFACE_PARAMS AmdParamStruct; - AMD_RESET_PARAMS AmdResetParams; - - LibAmdMemFill (&AmdParamStruct, - 0, - sizeof(AMD_INTERFACE_PARAMS), - &(AmdParamStruct.StdHeader)); - - LibAmdMemFill (&AmdResetParams, - 0, - sizeof(AMD_RESET_PARAMS), - &(AmdResetParams.StdHeader)); - - AmdParamStruct.AgesaFunctionName = AMD_INIT_RESET; - AmdParamStruct.AllocationMethod = ByHost; - AmdParamStruct.NewStructSize = sizeof(AMD_RESET_PARAMS); - AmdParamStruct.NewStructPtr = &AmdResetParams; - AmdParamStruct.StdHeader.AltImageBasePtr = 0; - AmdParamStruct.StdHeader.CalloutPtr = &GetBiosCallout; - AmdParamStruct.StdHeader.Func = 0; - AmdParamStruct.StdHeader.ImageBasePtr = 0; - AmdCreateStruct (&AmdParamStruct); - - AmdResetParams.FchInterface.Xhci0Enable = CONFIG(HUDSON_XHCI_ENABLE); - if (CONFIG(SOUTHBRIDGE_AMD_PI_BOLTON)) - AmdResetParams.FchInterface.Xhci1Enable = TRUE; - - AmdResetParams.FchInterface.SataEnable = !((CONFIG_HUDSON_SATA_MODE == 0) || (CONFIG_HUDSON_SATA_MODE == 3)); - AmdResetParams.FchInterface.IdeEnable = (CONFIG_HUDSON_SATA_MODE == 0) || (CONFIG_HUDSON_SATA_MODE == 3); - - status = AmdInitReset(&AmdResetParams); - if (status != AGESA_SUCCESS) agesawrapper_amdreadeventlog(AmdParamStruct.StdHeader.HeapStatus); - AmdReleaseStruct (&AmdParamStruct); - return status; -} - -AGESA_STATUS agesawrapper_amdinitearly(void) -{ - AGESA_STATUS status; - AMD_INTERFACE_PARAMS AmdParamStruct; - AMD_EARLY_PARAMS *AmdEarlyParamsPtr; - - LibAmdMemFill (&AmdParamStruct, - 0, - sizeof(AMD_INTERFACE_PARAMS), - &(AmdParamStruct.StdHeader)); - - AmdParamStruct.AgesaFunctionName = AMD_INIT_EARLY; - AmdParamStruct.AllocationMethod = PreMemHeap; - AmdParamStruct.StdHeader.AltImageBasePtr = 0; - AmdParamStruct.StdHeader.CalloutPtr = &GetBiosCallout; - AmdParamStruct.StdHeader.Func = 0; - AmdParamStruct.StdHeader.ImageBasePtr = 0; - AmdCreateStruct (&AmdParamStruct); - - AmdEarlyParamsPtr = (AMD_EARLY_PARAMS *)AmdParamStruct.NewStructPtr; - OemCustomizeInitEarly (AmdEarlyParamsPtr); - - AmdEarlyParamsPtr->GnbConfig.PsppPolicy = PsppDisabled; - status = AmdInitEarly ((AMD_EARLY_PARAMS *)AmdParamStruct.NewStructPtr); - /* - * init_timer() needs to be called on CZ PI, because AGESA resets the LAPIC reload value - * on the AMD_INIT_EARLY call - */ - if (CONFIG(CPU_AMD_PI_00660F01)) - init_timer(); - if (status != AGESA_SUCCESS) agesawrapper_amdreadeventlog(AmdParamStruct.StdHeader.HeapStatus); - AmdReleaseStruct (&AmdParamStruct); - - return status; -} - -AGESA_STATUS agesawrapper_amdinitpost(void) -{ - AGESA_STATUS status; - AMD_INTERFACE_PARAMS AmdParamStruct; - AMD_POST_PARAMS *PostParams; - - LibAmdMemFill (&AmdParamStruct, - 0, - sizeof(AMD_INTERFACE_PARAMS), - &(AmdParamStruct.StdHeader)); - - AmdParamStruct.AgesaFunctionName = AMD_INIT_POST; - AmdParamStruct.AllocationMethod = PreMemHeap; - AmdParamStruct.StdHeader.AltImageBasePtr = NULL; - AmdParamStruct.StdHeader.CalloutPtr = &GetBiosCallout; - AmdParamStruct.StdHeader.Func = 0; - AmdParamStruct.StdHeader.ImageBasePtr = 0; - - AmdCreateStruct (&AmdParamStruct); - PostParams = (AMD_POST_PARAMS *)AmdParamStruct.NewStructPtr; - - PostParams->MemConfig.UmaMode = CONFIG(GFXUMA) ? UMA_AUTO : UMA_NONE; - PostParams->MemConfig.UmaSize = 0; - PostParams->MemConfig.BottomIo = (UINT16) - (CONFIG_BOTTOMIO_POSITION >> 24); - - OemPostParams(PostParams); - - status = AmdInitPost (PostParams); - - /* If UMA is enabled we currently have it below TOP_MEM as well. - * UMA may or may not be cacheable, so Sub4GCacheTop could be - * higher than UmaBase. With UMA_NONE we see UmaBase==0. */ - if (PostParams->MemConfig.UmaBase) - backup_top_of_low_cacheable(PostParams->MemConfig.UmaBase << 16); - else - backup_top_of_low_cacheable(PostParams->MemConfig.Sub4GCacheTop); - - printk( - BIOS_SPEW, - "setup_uma_memory: umamode %s\n", - (PostParams->MemConfig.UmaMode == UMA_AUTO) ? "UMA_AUTO" : - (PostParams->MemConfig.UmaMode == UMA_SPECIFIED) ? "UMA_SPECIFIED" : - (PostParams->MemConfig.UmaMode == UMA_NONE) ? "UMA_NONE" : - "unknown" - ); - printk( - BIOS_SPEW, - "setup_uma_memory: syslimit 0x%08llX, bottomio 0x%08lx\n", - (unsigned long long)(PostParams->MemConfig.SysLimit) << 16, - (unsigned long)(PostParams->MemConfig.BottomIo) << 16 - ); - printk( - BIOS_SPEW, - "setup_uma_memory: uma size %luMB, uma start 0x%08lx\n", - (unsigned long)(PostParams->MemConfig.UmaSize) >> (20 - 16), - (unsigned long)(PostParams->MemConfig.UmaBase) << 16 - ); - if (status != AGESA_SUCCESS) agesawrapper_amdreadeventlog(PostParams->StdHeader.HeapStatus); - AmdReleaseStruct (&AmdParamStruct); - - return status; -} - -AGESA_STATUS agesawrapper_amdinitenv(void) -{ - AGESA_STATUS status; - AMD_INTERFACE_PARAMS AmdParamStruct; - AMD_ENV_PARAMS *EnvParam; - - /* Initialize heap space */ - EmptyHeap(); - - LibAmdMemFill (&AmdParamStruct, - 0, - sizeof(AMD_INTERFACE_PARAMS), - &(AmdParamStruct.StdHeader)); - - AmdParamStruct.AgesaFunctionName = AMD_INIT_ENV; - AmdParamStruct.AllocationMethod = PostMemDram; - AmdParamStruct.StdHeader.AltImageBasePtr = 0; - AmdParamStruct.StdHeader.CalloutPtr = &GetBiosCallout; - AmdParamStruct.StdHeader.Func = 0; - AmdParamStruct.StdHeader.ImageBasePtr = 0; - status = AmdCreateStruct (&AmdParamStruct); - EnvParam = (AMD_ENV_PARAMS *)AmdParamStruct.NewStructPtr; - - EnvParam->FchInterface.AzaliaController = AzEnable; - EnvParam->FchInterface.SataClass = CONFIG_HUDSON_SATA_MODE; - EnvParam->FchInterface.SataEnable = !((CONFIG_HUDSON_SATA_MODE == 0) || (CONFIG_HUDSON_SATA_MODE == 3)); - EnvParam->FchInterface.IdeEnable = (CONFIG_HUDSON_SATA_MODE == 0) || (CONFIG_HUDSON_SATA_MODE == 3); - EnvParam->FchInterface.SataIdeMode = (CONFIG_HUDSON_SATA_MODE == 3); - - status = AmdInitEnv (EnvParam); - if (status != AGESA_SUCCESS) agesawrapper_amdreadeventlog(EnvParam->StdHeader.HeapStatus); - /* Initialize Subordinate Bus Number and Secondary Bus Number - * In platform BIOS this address is allocated by PCI enumeration code - Modify D1F0x18 - */ - - return status; -} - -AGESA_STATUS agesawrapper_amdinitmid(void) -{ - AGESA_STATUS status; - AMD_INTERFACE_PARAMS AmdParamStruct; - AMD_MID_PARAMS *MidParam; - - /* Enable MMIO on AMD CPU Address Map Controller */ - amd_initcpuio (); - - LibAmdMemFill (&AmdParamStruct, - 0, - sizeof(AMD_INTERFACE_PARAMS), - &(AmdParamStruct.StdHeader)); - - AmdParamStruct.AgesaFunctionName = AMD_INIT_MID; - AmdParamStruct.AllocationMethod = PostMemDram; - AmdParamStruct.StdHeader.AltImageBasePtr = 0; - AmdParamStruct.StdHeader.CalloutPtr = &GetBiosCallout; - AmdParamStruct.StdHeader.Func = 0; - AmdParamStruct.StdHeader.ImageBasePtr = 0; - - AmdCreateStruct (&AmdParamStruct); - MidParam = (AMD_MID_PARAMS *)AmdParamStruct.NewStructPtr; - - MidParam->GnbMidConfiguration.iGpuVgaMode = 0;/* 0 iGpuVgaAdapter, 1 iGpuVgaNonAdapter; */ - MidParam->GnbMidConfiguration.GnbIoapicAddress = 0xFEC20000; - - MidParam->FchInterface.AzaliaController = AzEnable; - MidParam->FchInterface.SataClass = CONFIG_HUDSON_SATA_MODE; - MidParam->FchInterface.SataEnable = !((CONFIG_HUDSON_SATA_MODE == 0) || (CONFIG_HUDSON_SATA_MODE == 3)); - MidParam->FchInterface.IdeEnable = (CONFIG_HUDSON_SATA_MODE == 0) || (CONFIG_HUDSON_SATA_MODE == 3); - MidParam->FchInterface.SataIdeMode = (CONFIG_HUDSON_SATA_MODE == 3); - - status = AmdInitMid ((AMD_MID_PARAMS *)AmdParamStruct.NewStructPtr); - if (status != AGESA_SUCCESS) agesawrapper_amdreadeventlog(AmdParamStruct.StdHeader.HeapStatus); - AmdReleaseStruct (&AmdParamStruct); - - return status; -} - -AGESA_STATUS agesawrapper_amdinitlate(void) -{ - AGESA_STATUS Status; - AMD_INTERFACE_PARAMS AmdParamStruct; - AMD_LATE_PARAMS *AmdLateParams; - - if (!ENV_RAMSTAGE) - return AGESA_UNSUPPORTED; - - LibAmdMemFill (&AmdParamStruct, - 0, - sizeof(AMD_INTERFACE_PARAMS), - &(AmdParamStruct.StdHeader)); - - AmdParamStruct.AgesaFunctionName = AMD_INIT_LATE; - AmdParamStruct.AllocationMethod = PostMemDram; - AmdParamStruct.StdHeader.AltImageBasePtr = 0; - AmdParamStruct.StdHeader.CalloutPtr = &GetBiosCallout; - AmdParamStruct.StdHeader.HeapStatus = HEAP_SYSTEM_MEM; - AmdParamStruct.StdHeader.Func = 0; - AmdParamStruct.StdHeader.ImageBasePtr = 0; - - /* NOTE: if not call amdcreatestruct, the initializer(AmdInitLateInitializer) would not be called */ - AmdCreateStruct(&AmdParamStruct); - AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr; - AmdLateParams->GnbLateConfiguration.GnbIoapicId = CONFIG_MAX_CPUS + 1; - AmdLateParams->GnbLateConfiguration.FchIoapicId = CONFIG_MAX_CPUS; - /* Code for creating CDIT requires hop count table. If it is not - * present AGESA_ERROR is returned, which confuses users. CDIT is not - * written to the ACPI tables anyway. */ - AmdLateParams->PlatformConfig.UserOptionCdit = 0; - - Status = AmdInitLate(AmdLateParams); - if (Status != AGESA_SUCCESS) { - agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus); - ASSERT(Status == AGESA_SUCCESS); - } - - agesawrapper_setlateinitptr(AmdLateParams); - - /* No AmdReleaseStruct(&AmdParamStruct), we need AmdLateParams later. */ - return Status; -} - -const void *agesawrapper_locate_module (const CHAR8 name[8]) -{ - const void *agesa; - const AMD_IMAGE_HEADER* image; - const AMD_MODULE_HEADER* module; - size_t file_size; - - if (CONFIG(VBOOT)) { - /* Use phys. location in flash and prevent vboot from searching cbmem */ - agesa = (void *)CONFIG_AGESA_BINARY_PI_LOCATION; - file_size = 0x100000; - } else { - agesa = cbfs_boot_map_with_leak((const char *)CONFIG_AGESA_CBFS_NAME, - CBFS_TYPE_RAW, &file_size); - } - - if (!agesa) - return NULL; - image = LibAmdLocateImage(agesa, agesa + file_size - 1, 4096, name); - module = (AMD_MODULE_HEADER*)image->ModuleInfoOffset; - - return module; -} diff --git a/src/northbridge/amd/pi/agesawrapper.h b/src/northbridge/amd/pi/agesawrapper.h deleted file mode 100644 index e1cec43..0000000 --- a/src/northbridge/amd/pi/agesawrapper.h +++ /dev/null @@ -1,61 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2011 Advanced Micro Devices, Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#ifndef _AGESAWRAPPER_H_ -#define _AGESAWRAPPER_H_ - -#if CONFIG(BINARYPI_LEGACY_WRAPPER) - -#include <stdint.h> -#include <Porting.h> -#include <AGESA.h> - -AGESA_STATUS agesawrapper_amdinitreset(void); -AGESA_STATUS agesawrapper_amdinitearly(void); -AGESA_STATUS agesawrapper_amdinitenv(void); -AGESA_STATUS agesawrapper_amdinitlate(void); -AGESA_STATUS agesawrapper_amdinitpost(void); -AGESA_STATUS agesawrapper_amdinitmid(void); - -AGESA_STATUS agesawrapper_amdinitresume(void); -AGESA_STATUS agesawrapper_amdS3Save(void); -AGESA_STATUS agesawrapper_amds3laterestore(void); - -AGESA_STATUS agesawrapper_fchs3earlyrestore(void); -AGESA_STATUS agesawrapper_fchs3laterestore(void); - -#define AGESA_EVENTLOG(status, stdheader) \ - agesawrapper_trace(status, stdheader, __func__) - -#else - -/* Defined to make unused agesa_main() build. */ -static inline int agesawrapper_amdinitreset(void) { return -1; } -static inline int agesawrapper_amdinitearly(void) { return -1; } -static inline int agesawrapper_amdinitenv(void) { return -1; } -static inline int agesawrapper_amdinitpost(void) { return -1; } -static inline int agesawrapper_amdinitresume(void) { return -1; } -static inline int agesawrapper_amds3laterestore(void) { return -1; } - -#endif - -#if CONFIG(BINARYPI_LEGACY_WRAPPER) -const void *agesawrapper_locate_module (const CHAR8 name[8]); - -VOID OemCustomizeInitEarly (IN OUT AMD_EARLY_PARAMS *InitEarly); -void OemPostParams(AMD_POST_PARAMS *PostParams); -#endif - -#endif /* _AGESAWRAPPER_H_ */ diff --git a/src/northbridge/amd/pi/agesawrapper_call.h b/src/northbridge/amd/pi/agesawrapper_call.h deleted file mode 100644 index b235b49..0000000 --- a/src/northbridge/amd/pi/agesawrapper_call.h +++ /dev/null @@ -1,58 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#ifndef _AGESAWRAPPER_CALL_H_ -#define _AGESAWRAPPER_CALL_H_ - -#include <stdint.h> -#include <console/console.h> -#include <AGESA.h> - -/* - * Possible AGESA_STATUS values: - * - * 0x0 = AGESA_SUCCESS - * 0x1 = AGESA_UNSUPPORTED - * 0x2 = AGESA_BOUNDS_CHK - * 0x3 = AGESA_ALERT - * 0x4 = AGESA_WARNING - * 0x5 = AGESA_ERROR - * 0x6 = AGESA_CRITICAL - * 0x7 = AGESA_FATAL - */ -static const char *decodeAGESA_STATUS(AGESA_STATUS sret) -{ - const char *statusStrings[] = { "AGESA_SUCCESS", "AGESA_UNSUPPORTED", - "AGESA_BOUNDS_CHK", "AGESA_ALERT", - "AGESA_WARNING", "AGESA_ERROR", - "AGESA_CRITICAL", "AGESA_FATAL" - }; - if (sret > 7) return "unknown"; /* Non-AGESA error code */ - return statusStrings[sret]; -} - -static inline u32 do_agesawrapper(AGESA_STATUS (*func)(void), const char *name) -{ - AGESA_STATUS ret; - printk(BIOS_DEBUG, "agesawrapper_%s() entry\n", name); - ret = func(); - printk(BIOS_DEBUG, "agesawrapper_%s() returned %s\n", - name, decodeAGESA_STATUS(ret)); - return (u32)ret; -} - -#define AGESAWRAPPER(func) do_agesawrapper(agesawrapper_ ## func, #func) - -#define AGESAWRAPPER_PRE_CONSOLE(func) agesawrapper_ ## func() - -#endif -- To view, visit https://review.coreboot.org/c/coreboot/+/37172 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91bf6216e147b376849966aed775dc8b10cd33c4 Gerrit-Change-Number: 37172 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newchange

1 2

Change in coreboot[master]: BINARYPI_LEGACY: Apply final cleanup and file removals
by Kyösti Mälkki (Code Review) 23 Nov '19

23 Nov '19

Kyösti Mälkki has restored this change. ( https://review.coreboot.org/c/coreboot/+/19275 ) Change subject: BINARYPI_LEGACY: Apply final cleanup and file removals ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/19275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6c6fd19875cb57f0caf42a1a94f59efed83bfe0d Gerrit-Change-Number: 19275 Gerrit-PatchSet: 7 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: restore

1 0

Change in coreboot[master]: [NOTFORMERGE]: Squashed away from BINARYPI_LEGACY_WRAPPER
by Kyösti Mälkki (Code Review) 23 Nov '19

23 Nov '19

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/19273 ) Change subject: [NOTFORMERGE]: Squashed away from BINARYPI_LEGACY_WRAPPER ...................................................................... Patch Set 6: This had been around for sometime... -- To view, visit https://review.coreboot.org/c/coreboot/+/19273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2db1482e60e59b060582310b2e86326051fb35f9 Gerrit-Change-Number: 19273 Gerrit-PatchSet: 6 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Sat, 23 Nov 2019 19:28:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: binaryPI CAR: Revert invd to wbinvd change
by Kyösti Mälkki (Code Review) 23 Nov '19

23 Nov '19

Kyösti Mälkki has restored this change. ( https://review.coreboot.org/c/coreboot/+/18526 ) Change subject: binaryPI CAR: Revert invd to wbinvd change ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/18526 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I693c104c3aab3be537c00695cbd764a48bd603b0 Gerrit-Change-Number: 18526 Gerrit-PatchSet: 7 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: restore

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2019