build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29967 )
Change subject: qclib: Add qclib support
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/29967/7/src/soc/qualcomm/qcs405/qclib_execu…
File src/soc/qualcomm/qcs405/qclib_execute.c:
https://review.coreboot.org/#/c/29967/7/src/soc/qualcomm/qcs405/qclib_execu…
PS7, Line 35: int (*doit)(void *, void *);
function definition argument 'void *' should also have an identifier name
https://review.coreboot.org/#/c/29967/7/src/soc/qualcomm/qcs405/qclib_execu…
PS7, Line 35: int (*doit)(void *, void *);
function definition argument 'void *' should also have an identifier name
--
To view, visit https://review.coreboot.org/c/coreboot/+/29967
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I534af71163d034ea04420dda6a94ce31b08c8a07
Gerrit-Change-Number: 29967
Gerrit-PatchSet: 7
Gerrit-Owner: nsekar(a)codeaurora.org
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: nsekar(a)codeaurora.org
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 14 Jan 2019 17:38:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Patrick Georgi has uploaded a new patch set (#7) to the change originally created by nsekar(a)codeaurora.org. ( https://review.coreboot.org/c/coreboot/+/29967 )
Change subject: qclib: Add qclib support
......................................................................
qclib: Add qclib support
Add qclib support to configure pmic, clocks, DDR
Change-Id: I534af71163d034ea04420dda6a94ce31b08c8a07
Signed-off-by: Nitheesh Sekar <nsekar(a)codeaurora.org>
Signed-off-by: Sricharan R <sricharan(a)codeaurora.org>
---
M src/mainboard/google/mistral/mainboard.c
M src/mainboard/google/mistral/romstage.c
M src/soc/qualcomm/qcs405/Makefile.inc
M src/soc/qualcomm/qcs405/include/soc/memlayout.ld
A src/soc/qualcomm/qcs405/include/soc/qclib.h
M src/soc/qualcomm/qcs405/include/soc/symbols.h
M src/soc/qualcomm/qcs405/mmu.c
A src/soc/qualcomm/qcs405/qclib_execute.c
8 files changed, 247 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/29967/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/29967
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I534af71163d034ea04420dda6a94ce31b08c8a07
Gerrit-Change-Number: 29967
Gerrit-PatchSet: 7
Gerrit-Owner: nsekar(a)codeaurora.org
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: nsekar(a)codeaurora.org
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Patrick Georgi has uploaded a new patch set (#7) to the change originally created by nsekar(a)codeaurora.org. ( https://review.coreboot.org/c/coreboot/+/29966 )
Change subject: qualcomm/qcs405: Add support for USB host mode for mistral platform
......................................................................
qualcomm/qcs405: Add support for USB host mode for mistral platform
Add required changes for USB host mode working on mistral platform for USB disk
enumeration.
Change-Id: I35ec549b49b9789389c80843f6103e7243d52aac
Signed-off-by: Nitheesh Sekar <nsekar(a)codeaurora.org>
Signed-off-by: Vijayavardhan Vennapusa <vvreddy(a)partner-android.googlesource.com>
Signed-off-by: Sricharan R <sricharan(a)codeaurora.org>
---
M src/mainboard/google/mistral/mainboard.c
M src/mainboard/google/mistral/romstage.c
M src/soc/qualcomm/qcs405/Makefile.inc
M src/soc/qualcomm/qcs405/include/soc/addressmap.h
M src/soc/qualcomm/qcs405/include/soc/clock.h
M src/soc/qualcomm/qcs405/include/soc/iomap.h
A src/soc/qualcomm/qcs405/include/soc/usb.h
A src/soc/qualcomm/qcs405/usb.c
8 files changed, 370 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/29966/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/29966
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35ec549b49b9789389c80843f6103e7243d52aac
Gerrit-Change-Number: 29966
Gerrit-PatchSet: 7
Gerrit-Owner: nsekar(a)codeaurora.org
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: nsekar(a)codeaurora.org
Gerrit-MessageType: newpatchset
Patrick Georgi has uploaded a new patch set (#7) to the change originally created by nsekar(a)codeaurora.org. ( https://review.coreboot.org/c/coreboot/+/29962 )
Change subject: qcs405: clock: Adding the clock support for qcs405
......................................................................
qcs405: clock: Adding the clock support for qcs405
Add basic clock support and enable UART, SPI clocks.
Change-Id: I991bdde5f69e1c0f6ec5d6961275a1c077bc5bae
Signed-off-by: Nitheesh Sekar <nsekar(a)codeaurora.org>
Signed-off-by: Pranav Agrawal <pranava(a)codeaurora.org>
Signed-off-by: Sricharan R <sricharan(a)codeaurora.org>
---
M src/soc/qualcomm/qcs405/Makefile.inc
M src/soc/qualcomm/qcs405/bootblock.c
A src/soc/qualcomm/qcs405/clock.c
A src/soc/qualcomm/qcs405/include/soc/clock.h
4 files changed, 365 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/29962/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/29962
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I991bdde5f69e1c0f6ec5d6961275a1c077bc5bae
Gerrit-Change-Number: 29962
Gerrit-PatchSet: 7
Gerrit-Owner: nsekar(a)codeaurora.org
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: nsekar(a)codeaurora.org
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Patrick Georgi has uploaded a new patch set (#7) to the change originally created by nsekar(a)codeaurora.org. ( https://review.coreboot.org/c/coreboot/+/29959 )
Change subject: qcs405:Add SPI_RAM_SIMULATION support for QCS405
......................................................................
qcs405:Add SPI_RAM_SIMULATION support for QCS405
Change-Id: I895315a995cbbd5e6a7a305e48476f0d0f583cfe
Signed-off-by: Sricharan R <sricharan(a)codeaurora.org>
Signed-off-by: Nitheesh Sekar <nsekar(a)codeaurora.org>
---
M src/mainboard/google/mistral/romstage.c
M src/soc/qualcomm/qcs405/Kconfig
M src/soc/qualcomm/qcs405/Makefile.inc
A src/soc/qualcomm/qcs405/flash_controller.c
A src/soc/qualcomm/qcs405/include/soc/flash_controller.h
M src/soc/qualcomm/qcs405/include/soc/mmu.h
M src/soc/qualcomm/qcs405/mmu.c
M src/soc/qualcomm/qcs405/spi.c
8 files changed, 173 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/29959/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/29959
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I895315a995cbbd5e6a7a305e48476f0d0f583cfe
Gerrit-Change-Number: 29959
Gerrit-PatchSet: 7
Gerrit-Owner: nsekar(a)codeaurora.org
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: nsekar(a)codeaurora.org
Gerrit-MessageType: newpatchset
Patrick Georgi has uploaded a new patch set (#7) to the change originally created by nsekar(a)codeaurora.org. ( https://review.coreboot.org/c/coreboot/+/29956 )
Change subject: qcs405: Implement bitbang UART for bootblock
......................................................................
qcs405: Implement bitbang UART for bootblock
This patch replaces the UART in the bootblock of QCS405 with a bitbang
implementation. Since QCS405 hardware UART needs a firmware blob loaded
into it before it becomes usable, it is not really suited for use in the
bootblock (since by the time we can read blobs from SPI, the bootblock
is essentially over anyway). This solution allows us to still have some
console output during early SoC initialization.
Change-Id: Ib631929f6194d0da8571a930230f0eb460fefaa6
Signed-off-by: Sricharan R <sricharan(a)codeaurora.org>
Signed-off-by: Nitheesh Sekar <nsekar(a)codeaurora.org>
---
M src/soc/qualcomm/qcs405/Kconfig
M src/soc/qualcomm/qcs405/Makefile.inc
A src/soc/qualcomm/qcs405/uart_bitbang.c
3 files changed, 61 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/29956/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/29956
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib631929f6194d0da8571a930230f0eb460fefaa6
Gerrit-Change-Number: 29956
Gerrit-PatchSet: 7
Gerrit-Owner: nsekar(a)codeaurora.org
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: nsekar(a)codeaurora.org
Gerrit-MessageType: newpatchset