coreboot-gerrit January 2019

coreboot-gerrit@coreboot.org

1 participants
1296 discussions

Change in ...coreboot[master]: mb/purism/librem_skl: add 13v3 variant
by Matt DeVillier (Code Review) 23 Jan '19

23 Jan '19

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31010 Change subject: mb/purism/librem_skl: add 13v3 variant ...................................................................... mb/purism/librem_skl: add 13v3 variant The 13v3 is just a 13v2 with TPM added, so duplicate 13v2 config and change strings where needed. Leave MAINBOARD_PART_NUMBER unchanged since boards were initially shipped with 13v2 firmware, and changing it now would cause flashrom to throw a board mismatch error. Change-Id: I1a5e4c84cc9444bb9731b6dcc4de2ce7427dbbb1 Signed-off-by: Matt DeVillier <matt.devillier(a)puri.sm> --- M src/mainboard/purism/librem_skl/Kconfig M src/mainboard/purism/librem_skl/Kconfig.name 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/31010/1 diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig index bf62bff..b3413b7 100644 --- a/src/mainboard/purism/librem_skl/Kconfig +++ b/src/mainboard/purism/librem_skl/Kconfig @@ -22,6 +22,7 @@ config VARIANT_DIR string default "librem13v2" if BOARD_PURISM_LIBREM13_V2 + default "librem13v2" if BOARD_PURISM_LIBREM13_V3 default "librem15v3" if BOARD_PURISM_LIBREM15_V3 default "librem13v2" if BOARD_PURISM_LIBREM13_V4 default "librem15v3" if BOARD_PURISM_LIBREM15_V4 @@ -33,6 +34,7 @@ config MAINBOARD_FAMILY string default "Librem 13" if BOARD_PURISM_LIBREM13_V2 + default "Librem 13" if BOARD_PURISM_LIBREM13_V3 default "Librem 15" if BOARD_PURISM_LIBREM15_V3 default "Librem 13" if BOARD_PURISM_LIBREM13_V4 default "Librem 15" if BOARD_PURISM_LIBREM15_V4 @@ -40,6 +42,7 @@ config MAINBOARD_PART_NUMBER string default "Librem 13 v2" if BOARD_PURISM_LIBREM13_V2 + default "Librem 13 v2" if BOARD_PURISM_LIBREM13_V3 default "Librem 15 v3" if BOARD_PURISM_LIBREM15_V3 default "Librem 13 v4" if BOARD_PURISM_LIBREM13_V4 default "Librem 15 v4" if BOARD_PURISM_LIBREM15_V4 @@ -47,6 +50,7 @@ config MAINBOARD_VERSION string default "2.0" if BOARD_PURISM_LIBREM13_V2 + default "3.0" if BOARD_PURISM_LIBREM13_V3 default "3.0" if BOARD_PURISM_LIBREM15_V3 default "4.0" if BOARD_PURISM_LIBREM13_V4 default "4.0" if BOARD_PURISM_LIBREM15_V4 @@ -66,6 +70,7 @@ config VGA_BIOS_ID string default "8086,1916" if BOARD_PURISM_LIBREM13_V2 + default "8086,1916" if BOARD_PURISM_LIBREM13_V3 default "8086,1916" if BOARD_PURISM_LIBREM15_V3 default "8086,5916" if BOARD_PURISM_LIBREM13_V4 default "8086,5916" if BOARD_PURISM_LIBREM15_V4 diff --git a/src/mainboard/purism/librem_skl/Kconfig.name b/src/mainboard/purism/librem_skl/Kconfig.name index 6a66e45..5b82de7 100644 --- a/src/mainboard/purism/librem_skl/Kconfig.name +++ b/src/mainboard/purism/librem_skl/Kconfig.name @@ -2,6 +2,10 @@ bool "Librem 13 v2" select BOARD_PURISM_BASEBOARD_LIBREM_SKL +config BOARD_PURISM_LIBREM13_V3 + bool "Librem 13 v3" + select BOARD_PURISM_BASEBOARD_LIBREM_SKL + config BOARD_PURISM_LIBREM15_V3 bool "Librem 15 v3" select BOARD_PURISM_BASEBOARD_LIBREM_SKL -- To view, visit https://review.coreboot.org/c/coreboot/+/31010 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1a5e4c84cc9444bb9731b6dcc4de2ce7427dbbb1 Gerrit-Change-Number: 31010 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

4 4

Change in ...coreboot[master]: mb/purism/librem_skl: add support for 13v4/15v4 boards
by Matt DeVillier (Code Review) 23 Jan '19

23 Jan '19

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31009 Change subject: mb/purism/librem_skl: add support for 13v4/15v4 boards ...................................................................... mb/purism/librem_skl: add support for 13v4/15v4 boards Add support for Kabylake Librem 13v4/15v4 boards, reusing existing 13v2/15v3 variants since board design unchanged (only SoC). Adjust identification strings, add Kabylake VGA PCI ID. Change-Id: Ia795b9c7373ea2e2acd3bef309320b58e9e8449d Signed-off-by: Matt DeVillier <matt.devillier(a)puri.sm> --- M src/mainboard/purism/librem_skl/Kconfig M src/mainboard/purism/librem_skl/Kconfig.name 2 files changed, 20 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/31009/1 diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig index 0c138a6..bf62bff 100644 --- a/src/mainboard/purism/librem_skl/Kconfig +++ b/src/mainboard/purism/librem_skl/Kconfig @@ -23,6 +23,8 @@ string default "librem13v2" if BOARD_PURISM_LIBREM13_V2 default "librem15v3" if BOARD_PURISM_LIBREM15_V3 + default "librem13v2" if BOARD_PURISM_LIBREM13_V4 + default "librem15v3" if BOARD_PURISM_LIBREM15_V4 config MAINBOARD_VENDOR string @@ -32,16 +34,22 @@ string default "Librem 13" if BOARD_PURISM_LIBREM13_V2 default "Librem 15" if BOARD_PURISM_LIBREM15_V3 + default "Librem 13" if BOARD_PURISM_LIBREM13_V4 + default "Librem 15" if BOARD_PURISM_LIBREM15_V4 config MAINBOARD_PART_NUMBER string default "Librem 13 v2" if BOARD_PURISM_LIBREM13_V2 default "Librem 15 v3" if BOARD_PURISM_LIBREM15_V3 + default "Librem 13 v4" if BOARD_PURISM_LIBREM13_V4 + default "Librem 15 v4" if BOARD_PURISM_LIBREM15_V4 config MAINBOARD_VERSION string default "2.0" if BOARD_PURISM_LIBREM13_V2 default "3.0" if BOARD_PURISM_LIBREM15_V3 + default "4.0" if BOARD_PURISM_LIBREM13_V4 + default "4.0" if BOARD_PURISM_LIBREM15_V4 config MAINBOARD_DIR string @@ -57,7 +65,10 @@ config VGA_BIOS_ID string - default "8086,1916" + default "8086,1916" if BOARD_PURISM_LIBREM13_V2 + default "8086,1916" if BOARD_PURISM_LIBREM15_V3 + default "8086,5916" if BOARD_PURISM_LIBREM13_V4 + default "8086,5916" if BOARD_PURISM_LIBREM15_V4 config DIMM_MAX int diff --git a/src/mainboard/purism/librem_skl/Kconfig.name b/src/mainboard/purism/librem_skl/Kconfig.name index 3f43f68..6a66e45 100644 --- a/src/mainboard/purism/librem_skl/Kconfig.name +++ b/src/mainboard/purism/librem_skl/Kconfig.name @@ -5,3 +5,11 @@ config BOARD_PURISM_LIBREM15_V3 bool "Librem 15 v3" select BOARD_PURISM_BASEBOARD_LIBREM_SKL + +config BOARD_PURISM_LIBREM13_V4 + bool "Librem 13 v4" + select BOARD_PURISM_BASEBOARD_LIBREM_SKL + +config BOARD_PURISM_LIBREM15_V4 + bool "Librem 15 v4" + select BOARD_PURISM_BASEBOARD_LIBREM_SKL -- To view, visit https://review.coreboot.org/c/coreboot/+/31009 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia795b9c7373ea2e2acd3bef309320b58e9e8449d Gerrit-Change-Number: 31009 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

3 2

Change in ...coreboot[master]: mb/purism/librem_skl: adjust CBFS_SIZE
by Matt DeVillier (Code Review) 23 Jan '19

23 Jan '19

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31008 Change subject: mb/purism/librem_skl: adjust CBFS_SIZE ...................................................................... mb/purism/librem_skl: adjust CBFS_SIZE Adjust default CBFS_SIZE to match that used in configs for building Change-Id: Ibe1312560a923dcdefb8af52a721ab76c0b08a2e Signed-off-by: Matt DeVillier <matt.devillier(a)puri.sm> --- M src/mainboard/purism/librem_skl/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/31008/1 diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig index 224779d..0c138a6 100644 --- a/src/mainboard/purism/librem_skl/Kconfig +++ b/src/mainboard/purism/librem_skl/Kconfig @@ -77,6 +77,6 @@ config CBFS_SIZE hex - default 0x5c0000 + default 0xe00000 endif -- To view, visit https://review.coreboot.org/c/coreboot/+/31008 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe1312560a923dcdefb8af52a721ab76c0b08a2e Gerrit-Change-Number: 31008 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

4 4

Change in ...coreboot[master]: mb/google/poppy/variants/nami: close the FP power in S5
by Ren Kuo (Code Review) 23 Jan '19

23 Jan '19

Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30910 Change subject: mb/google/poppy/variants/nami: close the FP power in S5 ...................................................................... mb/google/poppy/variants/nami: close the FP power in S5 close the FP module power in power off (s5) BUG=None BRANCH=Nami TEST= build test firmware and measure the fp power enable pin Change-Id: I80ddfbf1edf7c6435d263d5f5e0edb8b8701817d Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> --- M src/mainboard/google/poppy/variants/nami/smihandler.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/30910/1 diff --git a/src/mainboard/google/poppy/variants/nami/smihandler.c b/src/mainboard/google/poppy/variants/nami/smihandler.c index b29e8cc..6816508 100644 --- a/src/mainboard/google/poppy/variants/nami/smihandler.c +++ b/src/mainboard/google/poppy/variants/nami/smihandler.c @@ -22,6 +22,7 @@ #define TOUCH_DISABLE GPP_C3 #define TOUCH_RESET GPP_B3 #define TOUCH_ENABLE GPP_B4 +#define FP_PWR_ENABLE GPP_B11 /* * Elan touchscreen has higher delay requirements than the other @@ -43,5 +44,7 @@ /* EN_PP3300_DX_TOUCHSCREEN */ gpio_set(TOUCH_ENABLE, 0); mdelay(ELAN_ENABLE_OFF_DELAY); + /* PCH_FP_PWR_EN */ + gpio_set(FP_PWR_ENABLE, 0); } } -- To view, visit https://review.coreboot.org/c/coreboot/+/30910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I80ddfbf1edf7c6435d263d5f5e0edb8b8701817d Gerrit-Change-Number: 30910 Gerrit-PatchSet: 1 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

4 8

Change in ...coreboot[master]: soc/cavium/cn81xx: Replace uses of dev_find_slot()
by Patrick Rudolph (Code Review) 23 Jan '19

23 Jan '19

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30517 ) Change subject: soc/cavium/cn81xx: Replace uses of dev_find_slot() ...................................................................... Patch Set 2: Code-Review+1 Tested on opencellular/elgon. Still boots to linux kernel, no regression is visible. -- To view, visit https://review.coreboot.org/c/coreboot/+/30517 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f176caff3b6423121676eb895f5f68a5b926de4 Gerrit-Change-Number: 30517 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Wed, 23 Jan 2019 14:28:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: lenovo/x230: introduce FHD variant
by Angel Pons (Code Review) 23 Jan '19

23 Jan '19

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 6: Code-Review-1 > Patch Set 6: > > > Patch Set 6: Code-Review+1 > > > > looks good to me, but should be tested again before i give a +2 > > I have build current master (edbf5d91) with patch set 6 applied for both a normal x230 and x230_fhd. > I have tested the following setup: coreboot -> seabios -> grub on both devices. > > The normal x230 works as expected. > > On the device with FHD-mod booting works as well, but graphical output of coreboot, seabios and grub is only visible if an additional external monitor is attached via VGA or DP. The internal FHD panel becomes active as soon as the linux kernel takes over. Right now I am unsure if this is due to misconfiguration on my part or if coreboot/libgfxinit needs to be told to use eDP1 for output on modded devices. Hints for further tests appreciated. > > Conclusion: Patch seems stable to me on default and modded x230 Thinkpads but has room for improvement on modded devices What you described for the FHD mod is "libgfxinit is not initializing the internal panel at all", which is a regression. Could you please investigate on this matter, or at least provide a coreboot log? Thanks! -- To view, visit https://review.coreboot.org/c/coreboot/+/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 6 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Slindee Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kilian Neuner <cb(a)9-r.net> Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-Comment-Date: Wed, 23 Jan 2019 13:15:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/hatch: Enable SD card support for hatch
by Maulik V Vaghela (Code Review) 23 Jan '19

23 Jan '19

Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30545 Change subject: mb/google/hatch: Enable SD card support for hatch ...................................................................... mb/google/hatch: Enable SD card support for hatch Enable support for SD card support for hatch 1. Enable PCI device for SD and also configure SD detect GPIO 2. Configure SD card related GPIOs in gpio.c BUG=b:120914069 BRANCH=none TEST=check if code compiles correctly and verify GPIO configuration with schematics Change-Id: I8ccaa28323b1e1fcc192e245347a96309227660b Signed-off-by: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb M src/mainboard/google/hatch/variants/baseboard/gpio.c 2 files changed, 24 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/30545/1 diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index dc17559..7978b44 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -80,6 +80,9 @@ register "PcieClkSrcUsage[3]" = "13" register "PcieClkSrcClkReq[3]" = "3" + # GPIO for SD card detect + register "sdcard_cd_gpio" = "GPP_G5" + device domain 0 on device pci 00.0 on end # Host Bridge device pci 02.0 on end # Integrated Graphics Device @@ -168,7 +171,7 @@ register "wake" = "GPE0_PME_B0" device pci 14.3 on end # CNVi wifi end - device pci 14.5 off end # SDCard + device pci 14.5 on end # SDCard device pci 15.0 on chip drivers/i2c/generic register "hid" = ""ELAN0000"" diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 3d63997..5eeddb0 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -19,6 +19,10 @@ #include <commonlib/helpers.h> static const struct pad_config gpio_table[] = { + /* SD_1P8_SEL => NC */ + PAD_NC(GPP_A16, DN_20K), + /* EN_PP3300_SD_DX */ + PAD_CFG_NF(GPP_A17, NONE, DEEP, NF1), /* TRACKPAD_INT_ODL */ PAD_CFG_GPI_APIC(GPP_A21, NONE, PLTRST, LEVEL, INVERT), /* SRCCLKREQ1 */ @@ -103,6 +107,22 @@ PAD_CFG_GPI(GPP_F11, NONE, PLTRST), /* PCH_MEM_STRAP3 */ PAD_CFG_GPI(GPP_F22, NONE, PLTRST), + /* SD_CMD */ + PAD_CFG_NF(GPP_G0, NONE, DEEP, NF1), + /* SD_DATA0 */ + PAD_CFG_NF(GPP_G1, NONE, DEEP, NF1), + /* SD_DATA1 */ + PAD_CFG_NF(GPP_G2, NONE, DEEP, NF1), + /* SD_DATA2 */ + PAD_CFG_NF(GPP_G3, NONE, DEEP, NF1), + /* SD_DATA3 */ + PAD_CFG_NF(GPP_G4, NONE, DEEP, NF1), + /* SD_CD# */ + PAD_CFG_NF(GPP_G5, NONE, DEEP, NF1), + /* SD_CLK */ + PAD_CFG_NF(GPP_G6, NONE, DEEP, NF1), + /* SD_WP => NC */ + PAD_NC(GPP_G7, DN_20K), }; const struct pad_config *__weak variant_gpio_table(size_t *num) -- To view, visit https://review.coreboot.org/c/coreboot/+/30545 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ccaa28323b1e1fcc192e245347a96309227660b Gerrit-Change-Number: 30545 Gerrit-PatchSet: 1 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-MessageType: newchange

6 18

Change in ...coreboot[master]: lenovo/x230: introduce FHD variant
by Kilian Neuner (Code Review) 23 Jan '19

23 Jan '19

Kilian Neuner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 6: > Patch Set 6: Code-Review+1 > > looks good to me, but should be tested again before i give a +2 I have build current master (edbf5d91) with patch set 6 applied for both a normal x230 and x230_fhd. I have tested the following setup: coreboot -> seabios -> grub on both devices. The normal x230 works as expected. On the device with FHD-mod booting works as well, but graphical output of coreboot, seabios and grub is only visible if an additional external monitor is attached via VGA or DP. The internal FHD panel becomes active as soon as the linux kernel takes over. Right now I am unsure if this is due to misconfiguration on my part or if coreboot/libgfxinit needs to be told to use eDP1 for output on modded devices. Hints for further tests appreciated. Conclusion: Patch seems stable to me on default and modded x230 Thinkpads but has room for improvement on modded devices -- To view, visit https://review.coreboot.org/c/coreboot/+/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 6 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Slindee Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kilian Neuner <cb(a)9-r.net> Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-Comment-Date: Wed, 23 Jan 2019 12:12:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/{amd,intel}: Remove needless '&' on function pointers
by Alex Thiessen (Code Review) 23 Jan '19

23 Jan '19

Alex Thiessen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29862 ) Change subject: soc/{amd,intel}: Remove needless '&' on function pointers ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29862 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a59fd2f370d2b0d830ca83be9a9bc1abe2750f5 Gerrit-Change-Number: 29862 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com> Gerrit-Reviewer: David Guckian Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Vanny E <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: York Yang <york.yang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Jan 2019 12:10:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/cavium/cn81xx: Replace uses of dev_find_slot()
by Kyösti Mälkki (Code Review) 23 Jan '19

23 Jan '19

Hello Felix Held, Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30517 to look at the new patch set (#2). Change subject: soc/cavium/cn81xx: Replace uses of dev_find_slot() ...................................................................... soc/cavium/cn81xx: Replace uses of dev_find_slot() Change-Id: I9f176caff3b6423121676eb895f5f68a5b926de4 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/soc/cavium/cn81xx/ecam0.c 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/30517/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30517 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f176caff3b6423121676eb895f5f68a5b926de4 Gerrit-Change-Number: 30517 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2019