Change in ...coreboot[master]: mb/google/poppy/variants/nami: close the FP power in S5

[Ren Kuo (Code Review)]

Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30910

Change subject: mb/google/poppy/variants/nami: close the FP power in S5
......................................................................

mb/google/poppy/variants/nami: close the FP power in S5

close the FP module power in power off (s5)

BUG=None
BRANCH=Nami
TEST= build test firmware and measure the fp power enable pin

Change-Id: I80ddfbf1edf7c6435d263d5f5e0edb8b8701817d
Signed-off-by: Ren Kuo 
---
M src/mainboard/google/poppy/variants/nami/smihandler.c
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/30910/1

diff --git a/src/mainboard/google/poppy/variants/nami/smihandler.c b/src/mainboard/google/poppy/variants/nami/smihandler.c
index b29e8cc..6816508 100644
--- a/src/mainboard/google/poppy/variants/nami/smihandler.c
+++ b/src/mainboard/google/poppy/variants/nami/smihandler.c
@@ -22,6 +22,7 @@
 #define TOUCH_DISABLE         GPP_C3
 #define TOUCH_RESET           GPP_B3
 #define TOUCH_ENABLE          GPP_B4
+#define FP_PWR_ENABLE         GPP_B11

/*
  * Elan touchscreen has higher delay requirements than the other
@@ -43,5 +44,7 @@
    	/* EN_PP3300_DX_TOUCHSCREEN */
    	gpio_set(TOUCH_ENABLE, 0);
    	mdelay(ELAN_ENABLE_OFF_DELAY);
+		/* PCH_FP_PWR_EN */
+		gpio_set(FP_PWR_ENABLE, 0);
    }
 }

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30910 )

Change subject: mb/google/poppy/variants/nami: close the FP power in S5
......................................................................

Patch Set 1: Code-Review+1

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30910 )

Change subject: mb/google/poppy/variants/nami: close the FP power in S5
......................................................................

Patch Set 1: Code-Review-1

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30910 )

Change subject: mb/google/poppy/variants/nami: close the FP power in S5
......................................................................

Patch Set 1: -Code-Review

[Ren Kuo (Code Review)]

Hello Vincent Wang, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/30910

to look at the new patch set (#2).

Change subject: mb/google/poppy/variants/nami: close the FP power in S5
......................................................................

mb/google/poppy/variants/nami: close the FP power in S5

close the FP module power in power off (s5)

BUG=122887366
BRANCH=Nami
TEST= build test firmware and measure the fp power enable pin

Change-Id: I80ddfbf1edf7c6435d263d5f5e0edb8b8701817d
Signed-off-by: Ren Kuo 
---
M src/mainboard/google/poppy/variants/nami/smihandler.c
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/30910/2

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30910 )

Change subject: mb/google/poppy/variants/nami: close the FP power in S5
......................................................................

Patch Set 2: Code-Review+1

[Shelley Chen (Code Review)]

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30910 )

Change subject: mb/google/poppy/variants/nami: close the FP power in S5
......................................................................

Patch Set 2: Code-Review+2

[Vincent Wang (Code Review)]

Vincent Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30910 )

Change subject: mb/google/poppy/variants/nami: close the FP power in S5
......................................................................

Patch Set 2: Code-Review+1

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30910 )

Change subject: mb/google/poppy/variants/nami: close the FP power in S5
......................................................................

mb/google/poppy/variants/nami: close the FP power in S5

close the FP module power in power off (s5)

BUG=122887366
BRANCH=Nami
TEST= build test firmware and measure the fp power enable pin

Change-Id: I80ddfbf1edf7c6435d263d5f5e0edb8b8701817d
Signed-off-by: Ren Kuo 
Reviewed-on: https://review.coreboot.org/c/30910
Reviewed-by: Shelley Chen 
Reviewed-by: Vincent Wang 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/poppy/variants/nami/smihandler.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Shelley Chen: Looks good to me, approved
  Ren Kuo: Looks good to me, but someone else must approve
  Vincent Wang: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/poppy/variants/nami/smihandler.c b/src/mainboard/google/poppy/variants/nami/smihandler.c
index b29e8cc..6816508 100644
--- a/src/mainboard/google/poppy/variants/nami/smihandler.c
+++ b/src/mainboard/google/poppy/variants/nami/smihandler.c
@@ -22,6 +22,7 @@
 #define TOUCH_DISABLE         GPP_C3
 #define TOUCH_RESET           GPP_B3
 #define TOUCH_ENABLE          GPP_B4
+#define FP_PWR_ENABLE         GPP_B11

/*
  * Elan touchscreen has higher delay requirements than the other
@@ -43,5 +44,7 @@
    	/* EN_PP3300_DX_TOUCHSCREEN */
    	gpio_set(TOUCH_ENABLE, 0);
    	mdelay(ELAN_ENABLE_OFF_DELAY);
+		/* PCH_FP_PWR_EN */
+		gpio_set(FP_PWR_ENABLE, 0);
    }
 }