Patrick Georgi merged this change.

View Change

Approvals: build bot (Jenkins): Verified Shelley Chen: Looks good to me, approved Ren Kuo: Looks good to me, but someone else must approve Vincent Wang: Looks good to me, but someone else must approve
mb/google/poppy/variants/nami: close the FP power in S5

close the FP module power in power off (s5)

BUG=122887366
BRANCH=Nami
TEST= build test firmware and measure the fp power enable pin

Change-Id: I80ddfbf1edf7c6435d263d5f5e0edb8b8701817d
Signed-off-by: Ren Kuo <ren.kuo@quanta.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/30910
Reviewed-by: Shelley Chen <shchen@google.com>
Reviewed-by: Vincent Wang <vwang@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/google/poppy/variants/nami/smihandler.c
1 file changed, 3 insertions(+), 0 deletions(-)

diff --git a/src/mainboard/google/poppy/variants/nami/smihandler.c b/src/mainboard/google/poppy/variants/nami/smihandler.c
index b29e8cc..6816508 100644
--- a/src/mainboard/google/poppy/variants/nami/smihandler.c
+++ b/src/mainboard/google/poppy/variants/nami/smihandler.c
@@ -22,6 +22,7 @@
#define TOUCH_DISABLE GPP_C3
#define TOUCH_RESET GPP_B3
#define TOUCH_ENABLE GPP_B4
+#define FP_PWR_ENABLE GPP_B11

/*
* Elan touchscreen has higher delay requirements than the other
@@ -43,5 +44,7 @@
/* EN_PP3300_DX_TOUCHSCREEN */
gpio_set(TOUCH_ENABLE, 0);
mdelay(ELAN_ENABLE_OFF_DELAY);
+ /* PCH_FP_PWR_EN */
+ gpio_set(FP_PWR_ENABLE, 0);
}
}

To view, visit change 30910. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80ddfbf1edf7c6435d263d5f5e0edb8b8701817d
Gerrit-Change-Number: 30910
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo <ren.kuo@quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo@quanta.corp-partner.google.com>
Gerrit-Reviewer: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: Vincent Wang <vwang@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged