Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 )
Change subject: lenovo/x230: introduce FHD variant ......................................................................
Patch Set 6: Code-Review-1
Patch Set 6:
Patch Set 6: Code-Review+1
looks good to me, but should be tested again before i give a +2
I have build current master (edbf5d91) with patch set 6 applied for both a normal x230 and x230_fhd. I have tested the following setup: coreboot -> seabios -> grub on both devices.
The normal x230 works as expected.
On the device with FHD-mod booting works as well, but graphical output of coreboot, seabios and grub is only visible if an additional external monitor is attached via VGA or DP. The internal FHD panel becomes active as soon as the linux kernel takes over. Right now I am unsure if this is due to misconfiguration on my part or if coreboot/libgfxinit needs to be told to use eDP1 for output on modded devices. Hints for further tests appreciated.
Conclusion: Patch seems stable to me on default and modded x230 Thinkpads but has room for improvement on modded devices
What you described for the FHD mod is "libgfxinit is not initializing the internal panel at all", which is a regression. Could you please investigate on this matter, or at least provide a coreboot log? Thanks!
-
Angel Pons (Code Review)