coreboot-gerrit September 2018

coreboot-gerrit@coreboot.org

1 participants
886 discussions

Change in coreboot[master]: x86/acpi: Add APEI definitions
by Marshall Dawson (Code Review) 05 Sep '18

05 Sep '18

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/28469 ) Change subject: x86/acpi: Add APEI definitions ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/28469/1/src/arch/x86/include/arch/acpi.h File src/arch/x86/include/arch/acpi.h: https://review.coreboot.org/#/c/28469/1/src/arch/x86/include/arch/acpi.h@693 PS1, Line 693: /* zero or more Generic Error Data Entries */ > I don't understand what this comment is referring to. The "zero or more" part? That odd phrase came from the spec but I can make it better. -- To view, visit https://review.coreboot.org/28469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9f4e506080285a7c3de6a223632c6f70933e66c Gerrit-Change-Number: 28469 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Tue, 04 Sep 2018 22:18:21 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: x86/acpi: Add APEI definitions
by Martin Roth (Code Review) 05 Sep '18

05 Sep '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28469 ) Change subject: x86/acpi: Add APEI definitions ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/28469/1/src/arch/x86/include/arch/acpi.h File src/arch/x86/include/arch/acpi.h: https://review.coreboot.org/#/c/28469/1/src/arch/x86/include/arch/acpi.h@660 PS1, Line 660: see Table 18-382 Add spec and version? https://review.coreboot.org/#/c/28469/1/src/arch/x86/include/arch/acpi.h@693 PS1, Line 693: /* zero or more Generic Error Data Entries */ I don't understand what this comment is referring to. -- To view, visit https://review.coreboot.org/28469 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9f4e506080285a7c3de6a223632c6f70933e66c Gerrit-Change-Number: 28469 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Tue, 04 Sep 2018 22:09:15 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/include: Add CPER definitions
by Martin Roth (Code Review) 05 Sep '18

05 Sep '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28468 ) Change subject: src/include: Add CPER definitions ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/28468/1/src/include/cper.h File src/include/cper.h: https://review.coreboot.org/#/c/28468/1/src/include/cper.h@398 PS1, Line 398: 0x20; Is there a reason you didn't use "bin2bcd(time.year / 100);" -- To view, visit https://review.coreboot.org/28468 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74d8ec8311de749e891827747b84dce0e737aceb Gerrit-Change-Number: 28468 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 04 Sep 2018 22:05:47 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/octopus/variants/fleex: Enable TBMC device
by Jett Rink (Code Review) 04 Sep '18

04 Sep '18

Jett Rink has uploaded this change for review. ( https://review.coreboot.org/28483 Change subject: mb/google/octopus/variants/fleex: Enable TBMC device ...................................................................... mb/google/octopus/variants/fleex: Enable TBMC device This change enables tablet mode ACPI device for fleex BRANCH=none BUG=b:113348027 TEST=evtest shows tablet mode events CQ-DEPEND=CL:1204699 Change-Id: Ifdec853935bfb7719226c7ea19b5bfd84edd7783 Signed-off-by: Jett Rink <jettrink(a)chromium.org> --- M src/mainboard/google/octopus/variants/fleex/include/variant/ec.h 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/28483/1 diff --git a/src/mainboard/google/octopus/variants/fleex/include/variant/ec.h b/src/mainboard/google/octopus/variants/fleex/include/variant/ec.h index 16f931b..48cb584 100644 --- a/src/mainboard/google/octopus/variants/fleex/include/variant/ec.h +++ b/src/mainboard/google/octopus/variants/fleex/include/variant/ec.h @@ -18,4 +18,7 @@ #include <baseboard/ec.h> +/* Enable Tablet switch */ +#define EC_ENABLE_TBMC_DEVICE + #endif -- To view, visit https://review.coreboot.org/28483 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifdec853935bfb7719226c7ea19b5bfd84edd7783 Gerrit-Change-Number: 28483 Gerrit-PatchSet: 1 Gerrit-Owner: Jett Rink <jettrink(a)chromium.org>

1 0

Change in coreboot[master]: amd/stoneyridge: Construct BERT region from machine check
by Marshall Dawson (Code Review) 04 Sep '18

04 Sep '18

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/28477 ) Change subject: amd/stoneyridge: Construct BERT region from machine check ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/28477/1/src/soc/amd/stoneyridge/mca.c File src/soc/amd/stoneyridge/mca.c: https://review.coreboot.org/#/c/28477/1/src/soc/amd/stoneyridge/mca.c@74 PS1, Line 74: MCA_ERRTYPE_INT no longer correct -- To view, visit https://review.coreboot.org/28477 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d4ce29ddefa22aa29e6d3184f1adeaea1d5f837 Gerrit-Change-Number: 28477 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 04 Sep 2018 21:33:18 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: amd/stoneyridge: Adjust memory map for reserved
by Marshall Dawson (Code Review) 04 Sep '18

04 Sep '18

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/28474 ) Change subject: amd/stoneyridge: Adjust memory map for reserved ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/28474/1/src/soc/amd/stoneyridge/ramtop.c File src/soc/amd/stoneyridge/ramtop.c: https://review.coreboot.org/#/c/28474/1/src/soc/amd/stoneyridge/ramtop.c@41 PS1, Line 41: BERT_REGION_MAX_SIZE CONFIG_SMM_TSEG_SIZE likely way bigger than ever required, but I think our mapping has some assumptions built into it. Need to look more closely. -- To view, visit https://review.coreboot.org/28474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0958f6b6bab3fe9dae36c83e1fd9ae6ed0290a18 Gerrit-Change-Number: 28474 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 04 Sep 2018 21:28:43 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/kahlee: Enable the BCLK buffer
by Martin Roth (Code Review) 04 Sep '18

04 Sep '18

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/28482 Change subject: mainboard/google/kahlee: Enable the BCLK buffer ...................................................................... mainboard/google/kahlee: Enable the BCLK buffer Set GPIO135 high to enable audio through the BCLK buffer. BUG=b:113559558 TEST=None BRANCH=grunt Change-Id: I1dcecf5960d3c91e0c2165e7f8856ff423c06e8c Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/mainboard/google/kahlee/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/28482/1 diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c index db68fa4..66d5c99 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c +++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c @@ -213,8 +213,8 @@ /* GPIO_133 - APU_EDP_BKLTEN_L (backlight - Active LOW) */ PAD_GPO(GPIO_133, HIGH), - /* GPIO_135 - Unused (TP128) */ - PAD_GPI(GPIO_135, PULL_UP), + /* GPIO_135 - BCLK Buffer Enable */ + PAD_GPO(GPIO_135, HIGH), /* GPIO_137 - Unused (TP27) */ PAD_GPI(GPIO_137, PULL_UP), -- To view, visit https://review.coreboot.org/28482 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1dcecf5960d3c91e0c2165e7f8856ff423c06e8c Gerrit-Change-Number: 28482 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: amd/fam15: Add more MCA information
by Marshall Dawson (Code Review) 04 Sep '18

04 Sep '18

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/28473 ) Change subject: amd/fam15: Add more MCA information ...................................................................... Patch Set 1: (3 comments) https://review.coreboot.org/#/c/28473/1/src/include/cpu/amd/amdfam15.h File src/include/cpu/amd/amdfam15.h: https://review.coreboot.org/#/c/28473/1/src/include/cpu/amd/amdfam15.h@116 PS1, Line 116: = remove https://review.coreboot.org/#/c/28473/1/src/include/cpu/amd/amdfam15.h@121 PS1, Line 121: = remove https://review.coreboot.org/#/c/28473/1/src/include/cpu/amd/amdfam15.h@123 PS1, Line 123: add comment about how to find in the bkdg -- To view, visit https://review.coreboot.org/28473 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0682288aa58c69aee323fb43f74027f7a1905b68 Gerrit-Change-Number: 28473 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 04 Sep 2018 21:26:14 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: arch/x86: Add BERT region support functions
by Marshall Dawson (Code Review) 04 Sep '18

04 Sep '18

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/28470 ) Change subject: arch/x86: Add BERT region support functions ...................................................................... Patch Set 1: (2 comments) I'd meant to relook at the error reporting, i.e. make sure there aren't duplicates. https://review.coreboot.org/#/c/28470/1/src/arch/x86/acpi_bert_storage.c File src/arch/x86/acpi_bert_storage.c: https://review.coreboot.org/#/c/28470/1/src/arch/x86/acpi_bert_storage.c@4 PS1, Line 4: 2015 Google Inc. copy/paste fail https://review.coreboot.org/#/c/28470/1/src/arch/x86/acpi_bert_storage.c@19 PS1, Line 19: todo remove todo. was left over from old location of this file -- To view, visit https://review.coreboot.org/28470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I54826981639b5647a8ca33b8b55ff097681402b9 Gerrit-Change-Number: 28470 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 04 Sep 2018 21:21:09 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/include: Introduce guid_t type
by Martin Roth (Code Review) 04 Sep '18

04 Sep '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28467 ) Change subject: src/include: Introduce guid_t type ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1cd7a1f0e0f900858830e1a6a7e2bbbe272fa30 Gerrit-Change-Number: 28467 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 04 Sep 2018 21:19:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

← Newer
1
...
76
77
78
79
80
81
82
...
89
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2018