coreboot-gerrit September 2018

coreboot-gerrit@coreboot.org

1 participants
886 discussions

Change in coreboot[master]: soc/intel/skylake: Make usage of SMI optional where possible
by dhaval v sharma (Code Review) 20 Sep '18

20 Sep '18

dhaval v sharma has uploaded this change for review. ( https://review.coreboot.org/28696 Change subject: soc/intel/skylake: Make usage of SMI optional where possible ...................................................................... soc/intel/skylake: Make usage of SMI optional where possible Make usage of SMI optional where possible 3 different hooks provided as such: 1. Most modern OSes are ACPI aware-avoid ACPI switch SMI if possible. 2. Avoid finalize soc SMI. Most finalize implementation can be done in normal code. 3. Do not need to disable ACPI during boot - leave it enabled through boot. Note: With reduced SMI PWRBTN event based graceful shutdown will not work until OS is booted. BUG=None BRANCH=None TEST=Booted Soraka with option enabled/disabled. Change-Id: I3f0c64b15ed6d0854ff350fcd75d299e45c23f18 Signed-off-by: Dhaval <dhaval.v.sharma(a)intel.com> --- M src/ec/google/chromeec/ec.c M src/soc/intel/common/block/smm/Kconfig M src/soc/intel/skylake/acpi.c M src/soc/intel/skylake/finalize.c M src/soc/intel/skylake/pmc.c 5 files changed, 26 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/28696/1 diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 09550d5..f2f4e0d 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -474,9 +474,6 @@ while (google_chromeec_get_event() != 0) ; - /* Restore SCI event mask. */ - google_chromeec_set_sci_mask(info->sci_events); - } else { google_chromeec_set_smi_mask(info->smi_events); @@ -489,6 +486,13 @@ info->s3_wake_events, info->s0ix_wake_events); } + /* Should be okay to set sci mask for s0 path also because + * anyways SCI interrupt gets enabled later during finalize + * stage and ACPI_DISABLE calls can explicitely disable it + * as required this helps with SMI_REDUCED implementation*/ + + google_chromeec_set_sci_mask(info->sci_events); + /* Clear wake event mask. */ google_chromeec_set_wake_mask(0); diff --git a/src/soc/intel/common/block/smm/Kconfig b/src/soc/intel/common/block/smm/Kconfig index 909382e..064d4d8 100644 --- a/src/soc/intel/common/block/smm/Kconfig +++ b/src/soc/intel/common/block/smm/Kconfig @@ -16,3 +16,9 @@ Time in milliseconds that SLP_SMI for S5 waits for before enabling sleep. This is required to avoid any race between SLP_SMI and PWRBTN SMI. + +config REDUCED_SMI + bool "Reduce SMI usage during boot" + default n + help + Reduce SMI usage diff --git a/src/soc/intel/skylake/acpi.c b/src/soc/intel/skylake/acpi.c index d2ec7e7..5f018ef 100644 --- a/src/soc/intel/skylake/acpi.c +++ b/src/soc/intel/skylake/acpi.c @@ -244,7 +244,13 @@ fadt->header.revision = get_acpi_table_revision(FADT); fadt->sci_int = acpi_sci_irq(); - fadt->smi_cmd = APM_CNT; + + if (IS_ENABLED(CONFIG_REDUCED_SMI)) + /* ACPI 2.0: if SMI_CMD in FADT is zero no SMI transitions supported */ + fadt->smi_cmd = 0; + else + fadt->smi_cmd = APM_CNT; + fadt->acpi_enable = APM_CNT_ACPI_ENABLE; fadt->acpi_disable = APM_CNT_ACPI_DISABLE; fadt->s4bios_req = 0x0; diff --git a/src/soc/intel/skylake/finalize.c b/src/soc/intel/skylake/finalize.c index 4c8a129..996088d 100644 --- a/src/soc/intel/skylake/finalize.c +++ b/src/soc/intel/skylake/finalize.c @@ -144,9 +144,10 @@ soc_lockdown(dev); - printk(BIOS_DEBUG, "Finalizing SMM.\n"); - outb(APM_CNT_FINALIZE, APM_CNT); - + if (!IS_ENABLED(CONFIG_REDUCED_SMI)){ + printk(BIOS_DEBUG, "Finalizing SMM.\n"); + outb(APM_CNT_FINALIZE, APM_CNT); + } /* Indicate finalize step with post code */ post_code(POST_OS_BOOT); } diff --git a/src/soc/intel/skylake/pmc.c b/src/soc/intel/skylake/pmc.c index a2623d9..4f77414 100644 --- a/src/soc/intel/skylake/pmc.c +++ b/src/soc/intel/skylake/pmc.c @@ -190,7 +190,8 @@ /* Note that certain bits may be cleared from running script as * certain bit fields are write 1 to clear. */ reg_script_run_on_dev(dev, pch_pmc_misc_init_script); - pmc_set_acpi_mode(); + if (!IS_ENABLED(CONFIG_REDUCED_SMI)) + pmc_set_acpi_mode(); config_deep_s3(config->deep_s3_enable_ac, config->deep_s3_enable_dc); config_deep_s5(config->deep_s5_enable_ac, config->deep_s5_enable_dc); -- To view, visit https://review.coreboot.org/28696 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3f0c64b15ed6d0854ff350fcd75d299e45c23f18 Gerrit-Change-Number: 28696 Gerrit-PatchSet: 1 Gerrit-Owner: dhaval v sharma <dhaval.v.sharma(a)intel.com>

1 0

Change in coreboot[master]: mb/solidrun/solidpc: Do initial commit
by build bot (Jenkins) (Code Review) 20 Sep '18

20 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23027 ) Change subject: mb/solidrun/solidpc: Do initial commit ...................................................................... Patch Set 7: (262 comments) https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… File src/mainboard/solidrun/solidpc/gpio.c: https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 67: /*SE00 */ { .pad_conf0 = 0x00110380, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 69: /*SE02 */ { .pad_conf0 = 0x00110380, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 70: /*SE03 */ { .pad_conf0 = 0x00130300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 71: /*SE04 */ { .pad_conf0 = 0x00110380, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 73: /*SE06 */ { .pad_conf0 = 0x00130300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 74: /*SE07 */ { .pad_conf0 = 0x00110380, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 99: /*SE16 */ { .pad_conf0 = 0x00110380, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 100: /*SE17 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 103: /*SE20 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 106: /*SE23 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 107: /*SE24 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 109: /*SE26 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 124: /*SE30 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 125: /*SE31 */ { .pad_conf0 = 0x00110380, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 126: /*SE32 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 127: /*SE33 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 128: /*SE34 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 129: /*SE35 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 148: /*SE45 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 149: /*SE46 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 150: /*SE47 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 151: /*SE48 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 153: /*SE50 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 154: /*SE51 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 155: /*SE52 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 165: // GPI(trig_edge_low, L5, P_20K_H, non_maskable, en_rx_data, UNMASK_WAKE , NA), /* 60 SPI1_MISO */ /* PMIC_IRQ_1P8 */ /* Open drain? */ /* FIXME: InvRX_Enable - is this connected to the PMIC? */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 171: // GPIO_OUT_HIGH, /* 66 SPI1_CS1_B */ /* LAN P0 ISOLATE */ /* FIXME: check if this pin is actually used as P0 Isolate */ //FIXME: Find P1 isolate line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 176: /*SE60 */ { .pad_conf0 = 0x58918200, .pad_conf1 = 0x05C00019, .wake_mask = 1, .int_mask = 1, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 177: /*SE61 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 178: /*SE62 */ { .pad_conf0 = 0x4C918201, .pad_conf1 = 0x05C00001, .wake_mask = 0, .int_mask = 1, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 179: /*SE63 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 180: /*SE64 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 181: /*SE65 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 182: /*SE66 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 183: /*SE67 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 184: /*SE68 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 196: // Native_M1, /* 75 USB_OC1_B */ /* USB_OC1_B */ /* FIXME: pulls? */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 197: // Native_M1, /* 76 PMU_RESETBUTTON_B */ /* PMU_RESETBUTTON_B */ /* FIXME: pulls? */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 199: // Native_M1, /* 78 SDMMC3_PWR_EN_B */ /* SD_CARD_PWRDN_N */ /* FIXME: pulls? */ //FIXME: Connected? line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 201: // Native_M1, /* 80 USB_OC0_B */ /* USB_OC0_B */ /* FIXME: pulls? */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 202: // NATIVE_INT_PU20K(1, L1), /* 81 SDMMC3_CD_B */ /* SD_CARD_DET_N */ /* FIXME: Native M1, no pull, trig_level, invert */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 205: // Native_M1, /* 84 SDMMC1_RCLK */ /* SDMMC1_RCLK */ /* FIXME: no SPARE_PIN!? check if NC */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 206: // Native_M1, /* 85 SDMMC3_1P8_EN */ /* SD_CARD_PWR_EN */ /* FIXME: check if NC */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 208: /*SE75 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 209: /*SE76 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 210: /*SE77 */ { .pad_conf0 = 0x14918201, .pad_conf1 = 0x05C00001, .wake_mask = 1, .int_mask = 1, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 211: /*SE78 */ { .pad_conf0 = 0x00110301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 212: /*SE79 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 213: /*SE80 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 214: /*SE81 */ { .pad_conf0 = 0x10910300, .pad_conf1 = 0x05C00004, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 216: /*SE83 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 217: /*SE84 */ { .pad_conf0 = 0x00110380, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 218: /*SE85 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 238: // Native_M1, /* 06 FST_SPI_CS0_B */ /* SPI_CS (SPI NOR on SOM) */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 241: /*SW00 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 242: /*SW01 */ { .pad_conf0 = 0x00910300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 243: /*SW02 */ { .pad_conf0 = 0x00910300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 244: /*SW03 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 245: /*SW04 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 246: /*SW05 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 247: /*SW06 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 248: /*SW07 */ { .pad_conf0 = 0x00218100, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 258: // Native_M2, /* 16 UART1_RXD */ /* UART1_RXD */ //NOTE: set to UART0 for debugging line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 262: // Native_M2, /* 20 UART1_TXD */ /* UART1_TXD */ //NOTE: set to UART0 for debugging line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 266: /*SW15 */ GPIO_SKIP, //{ .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 267: /*SW16 */ GPIO_SKIP, //{ .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 268: /*SW17 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 270: /*SW19 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 272: /*SW21 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 273: /*SW22 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 282: // Native_M2, /* 30 MF_HDA_CLK */ /* MF_HDA_CLK II GP_SSP_0_I2S_TXD */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 283: // Native_M2, /* 31 GPIO_SW31/MF_HDA_RSTB */ /* AUD_LINK_RST_N || I2S_0_CLK_R_AICO (AIC) */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 284: // Native_M2, /* 32 GPIO_SW32 /MF_HDA_SDI0 */ /* AUD_LINK_SDI0 (ALC282) || I2S_2_CLK_R_AICO (AIC) */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 285: // Native_M2, /* 33 MF_HDA_SDO */ /* AUD_LINK_SDO_R||I2S_0_RXD_R_AICO (AIC) */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 286: // GPIO_NC, /* 34 MF_HDA_DOCKRSTB */ /* I2S_2_TXD_R_AICO (AIC) */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 287: // Native_M2, /* 35 MF_HDA_SYNC */ /* AUD_LINKSYNC_R|| I2S_0_FS_R_AICO (AIC) */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 288: // GPIO_NC, /* 36 GPIO_SW36 MF_HDA_SDI1 */ /* I2S_2_FS_R_AICO */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 289: // GPIO_NC, /* 37 MF_HDA_DOCKENB */ /* I2S_2_RXD_R_AICO(AIC) */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 291: /*SW30 */ { .pad_conf0 = 0x00120300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 292: /*SW31 */ { .pad_conf0 = 0x00120300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 293: /*SW32 */ { .pad_conf0 = 0x00120300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 294: /*SW33 */ { .pad_conf0 = 0x00120300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 295: /*SW34 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 296: /*SW35 */ { .pad_conf0 = 0x00120300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 297: /*SW36 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 298: /*SW37 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 306: // GPIO_NC, /* 45 I2C5_SDA */ /* Touch Panel */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 307: // NATIVE_PU1K_CSEN_INVTX(1), /* 46 I2C4_SDA */ /* I2C Audio | Touch PAD */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 309: // GPIO_NC, /* 48 I2C5_SCL */ /* Touch Panel */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 311: // NATIVE_PU1K_CSEN_INVTX(1), /* 50 I2C4_SCL */ /* I2C Audio | Touch PAD */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 315: /*SW45 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 316: /*SW46 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 317: /*SW47 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 318: /*SW48 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 320: /*SW50 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 321: /*SW51 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 331: // GPIO_NC, /* 61 I2C0_SDA */ /* 3rd party Sensor Card */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 332: // GPIO_NC, /* 62 I2C2_SDA */ /* MIPI_CSI CAMERAS, FLASH */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 334: // GPIO_NC, /* 64 I2C3_SDA */ /* MIPI_CSI CAMERAS, FLASH */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 335: // GPIO_NC, /* 65 I2C0_SCL */ /* 3rd party Sensor Card */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 336: // GPIO_NC, /* 66 I2C2_SCL */ /* MIPI_CSI CAMERAS, FLASH */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 337: // GPIO_NC, /* 67 I2C3_SCL */ /* MIPI_CSI CAMERAS, FLASH */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 339: /*SW60 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 340: /*SW61 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 341: /*SW62 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 342: /*SW63 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 343: /*SW64 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 344: /*SW65 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 345: /*SW66 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 346: /*SW67 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 355: // GPIO_NC, /* 75 SATA_GP0 */ /* TOUCH_PNL_RST_N */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 356: // GPIO_NC, /* 76 SATA_GP1 */ /* TOUCH_INT_N */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 357: // Native_M1, /* 77 SATA_LEDN */ /* SATA_LED_N */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 358: // Native_M1, /* 78 SATA_GP2 */ /* SATA_DEVSLP_R */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 359: // GPIO_NC, /* 79 MF_SMB_ALERTB */ /* MF_SMB_ALERTB */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 360: // Native_M1, /* 80 SATA_GP3 */ /* eMMC_RST_N */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 361: // GPIO_NC, /* 81 NFC_DEV_WAKE , MF_SMB_CLK */ /* MF_SMB_CLK */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 362: // GPIO_NC, /* 82 NFC_FW_DOWNLOAD, MF_SMB_DATA */ /* MF_SMB_DATA */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 364: /*SW75 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 365: /*SW76 */ { .pad_conf0 = 0x0CC18200, .pad_conf1 = 0x05C00011, .wake_mask = 0, .int_mask = 1, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 366: /*SW77 */ { .pad_conf0 = 0x00110301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 367: /*SW78 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 369: /*SW80 */ { .pad_conf0 = 0x00110002, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 385: // Native_M1, /* 95 PCIE_CLKREQ3B */ /* Tied to Micro SD */ //FIXME: What does this pin do? Is it even a CLKREQ? line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 389: /*SW90 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 390: /*SW91 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 392: /*SW93 */ { .pad_conf0 = 0x00910300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 394: /*SW95 */ { .pad_conf0 = 0x00910300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 412: // GPIO_OUT_HIGH, /* 00 GPIO_DFX0 */ /* LAN P0 RESET */ //FIXME: Is this a reset? line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 422: /*N00 */ { .pad_conf0 = 0x00118102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 423: /*N01 */ { .pad_conf0 = 0x2C018200, .pad_conf1 = 0x05C00021, .wake_mask = 0, .int_mask = 1, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 425: /*N03 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 426: /*N04 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 427: /*N05 */ { .pad_conf0 = 0x00118102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 428: /*N06 */ { .pad_conf0 = 0x00918203, .pad_conf1 = 0x00918001, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 429: /*N07 */ { .pad_conf0 = 0x00918202, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 430: /*N08 */ { .pad_conf0 = 0x00918203, .pad_conf1 = 0x00918001, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 444: // GPI(trig_edge_low, L1, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA), /* 18 GPIO_SUS7 */ /* GPIO_SUS7 */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 445: // Native_M6, /* 19 GPIO_SUS1 */ /* GPIO_SUS1 */ //NOTE: configured as PCI_WAKE1_N, but is just a pin on the headers line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 446: // Native_M1, /* 20 GPIO_SUS5 */ /* GPIO_SUS5 */ //FIXME: What's the native mode of this pin? docs only say strapping pin for Flash Descriptor Security Override line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 448: // Native_M6, /* 22 GPIO_SUS4 */ /* */ //NOTE: configured as PCI_WAKE4_N //FIXME: What's on this pin? line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 450: // Native_M6, /* 24 GPIO_SUS2 */ /* GPIO_SUS2 */ //NOTE: configured as PCI_WAKE2_N, but is just a pin on the headers line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 456: /*N15 */ { .pad_conf0 = 0x3C018200, .pad_conf1 = 0x05C00001, .wake_mask = 1, .int_mask = 1, .gpe = SCI }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 458: /*N17 */ { .pad_conf0 = 0x4C118200, .pad_conf1 = 0x05C00001, .wake_mask = 0, .int_mask = 1, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 459: /*N18 */ { .pad_conf0 = 0xFC918200, .pad_conf1 = 0x05C00001, .wake_mask = 0, .int_mask = 1, .gpe = SMI }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 460: /*N19 */ { .pad_conf0 = 0x00160301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 461: /*N20 */ { .pad_conf0 = 0x00910201, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 463: /*N22 */ { .pad_conf0 = 0x00960301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 465: /*N24 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 466: /*N25 */ { .pad_conf0 = 0xEC918201, .pad_conf1 = 0x05C00001, .wake_mask = 0, .int_mask = 1, .gpe = SCI }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 493: /*N30 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 494: /*N31 */ { .pad_conf0 = 0x00210300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 495: /*N32 */ { .pad_conf0 = 0x00010301, .pad_conf1 = 0x05C00060, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 497: /*N34 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 498: /*N35 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 499: /*N36 */ { .pad_conf0 = 0x00010300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 500: /*N37 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 502: /*N39 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 504: /*N41 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 529: /*N45 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 530: /*N46 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 531: /*N47 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 532: /*N48 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 533: /*N49 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 534: /*N50 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 535: /*N51 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 536: /*N52 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 537: /*N53 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 538: /*N54 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 539: /*N55 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 540: /*N56 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 555: // Native_M1, /* 62 HV_DDI2_DDC_SDA */ /* DDI2_SDA_1P8 */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 556: // Native_M1, /* 63 PANEL1_BKLTCTL */ /* PANEL1_BKLTCTL */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 559: // Native_M1, /* 66 HV_DDI0_DDC_SDA */ /* DDI0_1_SDA_1P8 */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 560: // Native_M1, /* 67 HV_DDI2_DDC_SCL */ /* DDI2_SCL_1P8 */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 562: // Native_M1, /* 69 PANEL1_VDDEN */ /* PANEL1_VDDEN */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 563: // Native_M1, /* 70 PANEL1_BKLTEN */ /* PANEL1_BKLTEN */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 564: // GPIO_NC, /* 71 HV_DDI0_DDC_SCL */ /* DDI0_1_SCL_1P8 */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 567: /*N60 */ { .pad_conf0 = 0x00010300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 568: /*N61 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 569: /*N62 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x04C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 570: /*N63 */ { .pad_conf0 = 0x00010300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 571: /*N64 */ { .pad_conf0 = 0x00110301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 572: /*N65 */ { .pad_conf0 = 0x00010300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 573: /*N66 */ { .pad_conf0 = 0x00920301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 574: /*N67 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x04C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 575: /*N68 */ { .pad_conf0 = 0x00110301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 576: /*N69 */ { .pad_conf0 = 0x00010300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 577: /*N70 */ { .pad_conf0 = 0x00010300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 578: /*N71 */ { .pad_conf0 = 0x00920301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 595: // Native_M1, /* 00 PMU_SLP_S3_B */ /* PMU_SLP_S3_N */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 596: // Native_M1, /* 01 PMU_BATLOW_B */ /* PMU_BATLOW_B */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 599: // Native_M1, /* 04 PMU_AC_PRESENT */ /* PMU_AC_PRESENT */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 600: // Native_M1, /* 05 PMU_PLTRST_B */ /* PMU_PLTRST_B */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 601: // Native_M1, /* 06 PMU_SUSCLK */ /* PMU_SUSCLK_1P8 */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 603: // Native_M1, /* 08 PMU_PWRBTN_B */ /* PMU_PWRBTN_N */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 604: // Native_M1, /* 09 PMU_SLP_S4_B */ /* PMU_SLP_S4_N */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 605: // NATIVE_FUNC(M1, P_1K_H, NA), /* 10 PMU_WAKE_B */ /* PMU_WAKE_N */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 606: // GPIO_NC, /* 11 PMU_WAKE_LAN_B */ /* PMU_WAKE_LAN_N */ /* FIXME: Does this connect to onboard RTL8111? */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 608: /*E00 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 609: /*E01 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 610: /*E02 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 611: /*E03 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 612: /*E04 */ { .pad_conf0 = 0x00110301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 613: /*E05 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 614: /*E06 */ { .pad_conf0 = 0x00110301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 616: /*E08 */ { .pad_conf0 = 0X00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 617: /*E09 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 618: /*E10 */ { .pad_conf0 = 0X00C10301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 619: /*E11 */ { .pad_conf0 = 0X2C918201, .pad_conf1 = 0X05C00041, .wake_mask = 1, .int_mask = 1, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 630: // GPIO_NC, /* 15 MF_GPIO_3 */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 631: // GPIO_NC, /* 16 MF_GPIO_7 */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 632: // GPIO_NC, /* 17 MF_I2C1_SCL */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 633: // GPIO_NC, /* 18 MF_GPIO_1 */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 634: // GPIO_NC, /* 19 MF_GPIO_5 */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 635: // GPIO_NC, /* 20 MF_GPIO_9 */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 636: // GPIO_NC, /* 21 MF_GPIO_0 */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 637: // GPIO_NC, /* 22 MF_GPIO_4 */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 638: // GPIO_NC, /* 23 MF_GPIO_8 */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 639: // GPIO_NC, /* 24 MF_GPIO_2 */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 640: // GPIO_NC, /* 25 MF_GPIO_6 */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 641: // GPIO_NC, /* 26 MF_I2C1_SDA */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 643: /*E15 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 644: /*E16 */ { .pad_conf0 = 0x00118102, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 646: /*E18 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 647: /*E19 */ { .pad_conf0 = 0x00118100, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 648: /*E20 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 649: /*E21 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 650: /*E22 */ { .pad_conf0 = 0x08918201, .pad_conf1 = 0x05C00044, .wake_mask = 0, .int_mask = 1, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 651: /*E23 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 652: /*E24 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio… PS7, Line 653: /*E25 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/irqr… File src/mainboard/solidrun/solidpc/irqroute.h: https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/irqr… PS7, Line 21: #define PCI_DEV_PIRQ_ROUTES \ Macros with complex values should be enclosed in parentheses https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/irqr… PS7, Line 36: #define PIRQ_PIC_ROUTES \ Macros with complex values should be enclosed in parentheses https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… File src/mainboard/solidrun/solidpc/ramstage.c: https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 25: /* N71:HV_DDI0_DDC_SCL >> 0 2 0 00 0xFED8D458 0x00920301 0xFED8D45C 0x05C00000 line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 26: N66:HV_DDI0_DDC_SDA >> 0 2 0 00 0xFED8D430 0x00920301 0xFED8D434 0x05C00000 line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 27: N61:HV_DDI0_HPD >> 0 1 0 00 0xFED8D408 0x00110300 0xFED8D40C 0x05C00020 line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 28: N64:HV_DDI1_HPD >> 0 1 0 00 0xFED8D420 0x00110301 0xFED8D424 0x05C00020 line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 29: N67:HV_DDI2_DDC_SCL >> 0 1 0 00 0xFED8D438 0x00910301 0xFED8D43C 0x04C00000 line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 30: N62:HV_DDI2_DDC_SDA >> 0 1 0 00 0xFED8D410 0x00910301 0xFED8D414 0x04C00000 line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 31: N68:HV_DDI2_HPD >> 0 1 0 00 0xFED8D440 0x00110301 0xFED8D444 0x05C00020 line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 32: N65:PANEL0_BKLTCTL >> 0 1 0 00 0xFED8D428 0x00010300 0xFED8D42C 0x05C00000 line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 33: N60:PANEL0_BKLTEN >> 0 1 0 00 0xFED8D400 0x00010300 0xFED8D404 0x05C00000 line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 34: N72:PANEL0_VDDEN >> 0 1 0 00 0xFED8D460 0x00010300 0xFED8D464 0x05C00000 line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 35: N63:PANEL1_BKLTCTL >> 0 1 0 00 0xFED8D418 0x00010300 0xFED8D41C 0x05C00000 line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 36: N70:PANEL1_BKLTEN >> 0 1 0 00 0xFED8D450 0x00010300 0xFED8D454 0x05C00000 line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 37: N69:PANEL1_VDDEN >> 0 1 0 00 0xFED8D448 0x00010300 0xFED8D44C 0x05C00000 line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 43: { .Name = NULL /*L"N71:HV_DDI0_DDC_SCL"*/, .Confg0 = 0x00920301, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5458, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 44: { .Name = NULL /*L"N66:HV_DDI0_DDC_SDA"*/, .Confg0 = 0x00920301, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5430, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 45: { .Name = NULL /*L"N61:HV_DDI0_HPD"*/, .Confg0 = 0x00110300, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00020, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5408, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 46: { .Name = NULL /*L"N64:HV_DDI1_HPD"*/, .Confg0 = 0x00110301, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00020, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5420, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 46: { .Name = NULL /*L"N64:HV_DDI1_HPD"*/, .Confg0 = 0x00110301, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00020, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5420, .Misc = 0 }, please, no space before tabs https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 47: { .Name = NULL /*L"N67:HV_DDI2_DDC_SCL"*/, .Confg0 = 0x00910301, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x04C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5438, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 48: { .Name = NULL /*L"N62:HV_DDI2_DDC_SDA"*/, .Confg0 = 0x00910301, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x04C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5410, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 49: { .Name = NULL /*L"N68:HV_DDI2_HPD"*/, .Confg0 = 0x00110301, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00020, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5440, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 50: { .Name = NULL /*L"N65:PANEL0_BKLTCTL"*/, .Confg0 = 0x00010300, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5428, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 51: { .Name = NULL /*L"N60:PANEL0_BKLTEN"*/, .Confg0 = 0x00010300, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5400, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 52: { .Name = NULL /*L"N72:PANEL0_VDDEN"*/, .Confg0 = 0x00010300, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5460, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 53: { .Name = NULL /*L"N63:PANEL1_BKLTCTL"*/, .Confg0 = 0x00010300, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5418, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 54: { .Name = NULL /*L"N70:PANEL1_BKLTEN"*/, .Confg0 = 0x00010300, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5450, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 55: { .Name = NULL /*L"N69:PANEL1_VDDEN"*/, .Confg0 = 0x00010300, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5448, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/rams… PS7, Line 56: { .Name = NULL /*L""*/, .Confg0 = 0xFFFFFFFF, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0xFFFFFFFF, .Confg1Changes = 0xFFFFFFFF, .Community = 0xFFFFFFFF, .MmioAddr = 0xFFFFFFFF, .Misc = 0xFFFFFFFF }, line over 80 characters -- To view, visit https://review.coreboot.org/23027 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00ff95313d74091e7411f6c8658d0d560a0e682b Gerrit-Change-Number: 23027 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer <migy(a)darmstadt.ccc.de> Gerrit-Reviewer: Felix Singer <migy(a)darmstadt.ccc.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Thu, 20 Sep 2018 09:38:23 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/solidrun/solidpc: Do initial commit
by build bot (Jenkins) (Code Review) 20 Sep '18

20 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23027 ) Change subject: mb/solidrun/solidpc: Do initial commit ...................................................................... Patch Set 6: (260 comments) https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… File src/mainboard/solidrun/solidpc/gpio.c: https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 67: /*SE00 */ { .pad_conf0 = 0x00110380, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 69: /*SE02 */ { .pad_conf0 = 0x00110380, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 70: /*SE03 */ { .pad_conf0 = 0x00130300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 71: /*SE04 */ { .pad_conf0 = 0x00110380, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 73: /*SE06 */ { .pad_conf0 = 0x00130300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 74: /*SE07 */ { .pad_conf0 = 0x00110380, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 99: /*SE16 */ { .pad_conf0 = 0x00110380, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 100: /*SE17 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 103: /*SE20 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 106: /*SE23 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 107: /*SE24 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 109: /*SE26 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 124: /*SE30 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 125: /*SE31 */ { .pad_conf0 = 0x00110380, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 126: /*SE32 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 127: /*SE33 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 128: /*SE34 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 129: /*SE35 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 148: /*SE45 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 149: /*SE46 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 150: /*SE47 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 151: /*SE48 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 153: /*SE50 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 154: /*SE51 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 155: /*SE52 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 165: // GPI(trig_edge_low, L5, P_20K_H, non_maskable, en_rx_data, UNMASK_WAKE , NA), /* 60 SPI1_MISO */ /* PMIC_IRQ_1P8 */ /* Open drain? */ /* FIXME: InvRX_Enable - is this connected to the PMIC? */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 171: // GPIO_OUT_HIGH, /* 66 SPI1_CS1_B */ /* LAN P0 ISOLATE */ /* FIXME: check if this pin is actually used as P0 Isolate */ //FIXME: Find P1 isolate line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 176: /*SE60 */ { .pad_conf0 = 0x58918200, .pad_conf1 = 0x05C00019, .wake_mask = 1, .int_mask = 1, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 177: /*SE61 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 178: /*SE62 */ { .pad_conf0 = 0x4C918201, .pad_conf1 = 0x05C00001, .wake_mask = 0, .int_mask = 1, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 179: /*SE63 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 180: /*SE64 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 181: /*SE65 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 182: /*SE66 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 183: /*SE67 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 184: /*SE68 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 196: // Native_M1, /* 75 USB_OC1_B */ /* USB_OC1_B */ /* FIXME: pulls? */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 197: // Native_M1, /* 76 PMU_RESETBUTTON_B */ /* PMU_RESETBUTTON_B */ /* FIXME: pulls? */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 199: // Native_M1, /* 78 SDMMC3_PWR_EN_B */ /* SD_CARD_PWRDN_N */ /* FIXME: pulls? */ //FIXME: Connected? line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 201: // Native_M1, /* 80 USB_OC0_B */ /* USB_OC0_B */ /* FIXME: pulls? */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 202: // NATIVE_INT_PU20K(1, L1), /* 81 SDMMC3_CD_B */ /* SD_CARD_DET_N */ /* FIXME: Native M1, no pull, trig_level, invert */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 205: // Native_M1, /* 84 SDMMC1_RCLK */ /* SDMMC1_RCLK */ /* FIXME: no SPARE_PIN!? check if NC */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 206: // Native_M1, /* 85 SDMMC3_1P8_EN */ /* SD_CARD_PWR_EN */ /* FIXME: check if NC */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 208: /*SE75 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 209: /*SE76 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 210: /*SE77 */ { .pad_conf0 = 0x14918201, .pad_conf1 = 0x05C00001, .wake_mask = 1, .int_mask = 1, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 211: /*SE78 */ { .pad_conf0 = 0x00110301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 212: /*SE79 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 213: /*SE80 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 214: /*SE81 */ { .pad_conf0 = 0x10910300, .pad_conf1 = 0x05C00004, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 216: /*SE83 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 217: /*SE84 */ { .pad_conf0 = 0x00110380, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 218: /*SE85 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 238: // Native_M1, /* 06 FST_SPI_CS0_B */ /* SPI_CS (SPI NOR on SOM) */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 241: /*SW00 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 242: /*SW01 */ { .pad_conf0 = 0x00910300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 243: /*SW02 */ { .pad_conf0 = 0x00910300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 244: /*SW03 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 245: /*SW04 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 246: /*SW05 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 247: /*SW06 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 248: /*SW07 */ { .pad_conf0 = 0x00218100, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 258: // Native_M2, /* 16 UART1_RXD */ /* UART1_RXD */ //NOTE: set to UART0 for debugging line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 262: // Native_M2, /* 20 UART1_TXD */ /* UART1_TXD */ //NOTE: set to UART0 for debugging line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 266: /*SW15 */ GPIO_SKIP, //{ .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 267: /*SW16 */ GPIO_SKIP, //{ .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 268: /*SW17 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 270: /*SW19 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 272: /*SW21 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 273: /*SW22 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 282: // Native_M2, /* 30 MF_HDA_CLK */ /* MF_HDA_CLK II GP_SSP_0_I2S_TXD */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 283: // Native_M2, /* 31 GPIO_SW31/MF_HDA_RSTB */ /* AUD_LINK_RST_N || I2S_0_CLK_R_AICO (AIC) */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 284: // Native_M2, /* 32 GPIO_SW32 /MF_HDA_SDI0 */ /* AUD_LINK_SDI0 (ALC282) || I2S_2_CLK_R_AICO (AIC) */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 285: // Native_M2, /* 33 MF_HDA_SDO */ /* AUD_LINK_SDO_R||I2S_0_RXD_R_AICO (AIC) */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 286: // GPIO_NC, /* 34 MF_HDA_DOCKRSTB */ /* I2S_2_TXD_R_AICO (AIC) */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 287: // Native_M2, /* 35 MF_HDA_SYNC */ /* AUD_LINKSYNC_R|| I2S_0_FS_R_AICO (AIC) */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 288: // GPIO_NC, /* 36 GPIO_SW36 MF_HDA_SDI1 */ /* I2S_2_FS_R_AICO */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 289: // GPIO_NC, /* 37 MF_HDA_DOCKENB */ /* I2S_2_RXD_R_AICO(AIC) */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 291: /*SW30 */ { .pad_conf0 = 0x00120300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 292: /*SW31 */ { .pad_conf0 = 0x00120300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 293: /*SW32 */ { .pad_conf0 = 0x00120300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 294: /*SW33 */ { .pad_conf0 = 0x00120300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 295: /*SW34 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 296: /*SW35 */ { .pad_conf0 = 0x00120300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 297: /*SW36 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 298: /*SW37 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 306: // GPIO_NC, /* 45 I2C5_SDA */ /* Touch Panel */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 307: // NATIVE_PU1K_CSEN_INVTX(1), /* 46 I2C4_SDA */ /* I2C Audio | Touch PAD */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 309: // GPIO_NC, /* 48 I2C5_SCL */ /* Touch Panel */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 311: // NATIVE_PU1K_CSEN_INVTX(1), /* 50 I2C4_SCL */ /* I2C Audio | Touch PAD */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 315: /*SW45 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 316: /*SW46 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 317: /*SW47 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 318: /*SW48 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 320: /*SW50 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 321: /*SW51 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 331: // GPIO_NC, /* 61 I2C0_SDA */ /* 3rd party Sensor Card */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 332: // GPIO_NC, /* 62 I2C2_SDA */ /* MIPI_CSI CAMERAS, FLASH */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 334: // GPIO_NC, /* 64 I2C3_SDA */ /* MIPI_CSI CAMERAS, FLASH */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 335: // GPIO_NC, /* 65 I2C0_SCL */ /* 3rd party Sensor Card */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 336: // GPIO_NC, /* 66 I2C2_SCL */ /* MIPI_CSI CAMERAS, FLASH */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 337: // GPIO_NC, /* 67 I2C3_SCL */ /* MIPI_CSI CAMERAS, FLASH */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 339: /*SW60 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 340: /*SW61 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 341: /*SW62 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 342: /*SW63 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 343: /*SW64 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 344: /*SW65 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 345: /*SW66 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 346: /*SW67 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 355: // GPIO_NC, /* 75 SATA_GP0 */ /* TOUCH_PNL_RST_N */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 356: // GPIO_NC, /* 76 SATA_GP1 */ /* TOUCH_INT_N */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 357: // Native_M1, /* 77 SATA_LEDN */ /* SATA_LED_N */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 358: // Native_M1, /* 78 SATA_GP2 */ /* SATA_DEVSLP_R */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 359: // GPIO_NC, /* 79 MF_SMB_ALERTB */ /* MF_SMB_ALERTB */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 360: // Native_M1, /* 80 SATA_GP3 */ /* eMMC_RST_N */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 361: // GPIO_NC, /* 81 NFC_DEV_WAKE , MF_SMB_CLK */ /* MF_SMB_CLK */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 362: // GPIO_NC, /* 82 NFC_FW_DOWNLOAD, MF_SMB_DATA */ /* MF_SMB_DATA */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 364: /*SW75 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 365: /*SW76 */ { .pad_conf0 = 0x0CC18200, .pad_conf1 = 0x05C00011, .wake_mask = 0, .int_mask = 1, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 366: /*SW77 */ { .pad_conf0 = 0x00110301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 367: /*SW78 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 369: /*SW80 */ { .pad_conf0 = 0x00110002, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 385: // Native_M1, /* 95 PCIE_CLKREQ3B */ /* Tied to Micro SD */ //FIXME: What does this pin do? Is it even a CLKREQ? line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 389: /*SW90 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 390: /*SW91 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 392: /*SW93 */ { .pad_conf0 = 0x00910300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 394: /*SW95 */ { .pad_conf0 = 0x00910300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 412: // GPIO_OUT_HIGH, /* 00 GPIO_DFX0 */ /* LAN P0 RESET */ //FIXME: Is this a reset? line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 422: /*N00 */ { .pad_conf0 = 0x00118102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 423: /*N01 */ { .pad_conf0 = 0x2C018200, .pad_conf1 = 0x05C00021, .wake_mask = 0, .int_mask = 1, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 425: /*N03 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 426: /*N04 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 427: /*N05 */ { .pad_conf0 = 0x00118102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 428: /*N06 */ { .pad_conf0 = 0x00918203, .pad_conf1 = 0x00918001, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 429: /*N07 */ { .pad_conf0 = 0x00918202, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 430: /*N08 */ { .pad_conf0 = 0x00918203, .pad_conf1 = 0x00918001, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 444: // GPI(trig_edge_low, L1, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA), /* 18 GPIO_SUS7 */ /* GPIO_SUS7 */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 445: // Native_M6, /* 19 GPIO_SUS1 */ /* GPIO_SUS1 */ //NOTE: configured as PCI_WAKE1_N, but is just a pin on the headers line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 446: // Native_M1, /* 20 GPIO_SUS5 */ /* GPIO_SUS5 */ //FIXME: What's the native mode of this pin? docs only say strapping pin for Flash Descriptor Security Override line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 448: // Native_M6, /* 22 GPIO_SUS4 */ /* */ //NOTE: configured as PCI_WAKE4_N //FIXME: What's on this pin? line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 450: // Native_M6, /* 24 GPIO_SUS2 */ /* GPIO_SUS2 */ //NOTE: configured as PCI_WAKE2_N, but is just a pin on the headers line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 456: /*N15 */ { .pad_conf0 = 0x3C018200, .pad_conf1 = 0x05C00001, .wake_mask = 1, .int_mask = 1, .gpe = SCI }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 458: /*N17 */ { .pad_conf0 = 0x4C118200, .pad_conf1 = 0x05C00001, .wake_mask = 0, .int_mask = 1, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 459: /*N18 */ { .pad_conf0 = 0xFC918200, .pad_conf1 = 0x05C00001, .wake_mask = 0, .int_mask = 1, .gpe = SMI }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 460: /*N19 */ { .pad_conf0 = 0x00160301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 461: /*N20 */ { .pad_conf0 = 0x00910201, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 463: /*N22 */ { .pad_conf0 = 0x00960301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 465: /*N24 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 466: /*N25 */ { .pad_conf0 = 0xEC918201, .pad_conf1 = 0x05C00001, .wake_mask = 0, .int_mask = 1, .gpe = SCI }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 493: /*N30 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 494: /*N31 */ { .pad_conf0 = 0x00210300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 495: /*N32 */ { .pad_conf0 = 0x00010301, .pad_conf1 = 0x05C00060, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 497: /*N34 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 498: /*N35 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 499: /*N36 */ { .pad_conf0 = 0x00010300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 500: /*N37 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 502: /*N39 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 504: /*N41 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 529: /*N45 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 530: /*N46 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 531: /*N47 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 532: /*N48 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 533: /*N49 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 534: /*N50 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 535: /*N51 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 536: /*N52 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 537: /*N53 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 538: /*N54 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 539: /*N55 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 540: /*N56 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 555: // Native_M1, /* 62 HV_DDI2_DDC_SDA */ /* DDI2_SDA_1P8 */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 556: // Native_M1, /* 63 PANEL1_BKLTCTL */ /* PANEL1_BKLTCTL */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 559: // Native_M1, /* 66 HV_DDI0_DDC_SDA */ /* DDI0_1_SDA_1P8 */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 560: // Native_M1, /* 67 HV_DDI2_DDC_SCL */ /* DDI2_SCL_1P8 */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 562: // Native_M1, /* 69 PANEL1_VDDEN */ /* PANEL1_VDDEN */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 563: // Native_M1, /* 70 PANEL1_BKLTEN */ /* PANEL1_BKLTEN */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 564: // GPIO_NC, /* 71 HV_DDI0_DDC_SCL */ /* DDI0_1_SCL_1P8 */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 567: /*N60 */ { .pad_conf0 = 0x00010300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 568: /*N61 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 569: /*N62 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x04C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 570: /*N63 */ { .pad_conf0 = 0x00010300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 571: /*N64 */ { .pad_conf0 = 0x00110301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 572: /*N65 */ { .pad_conf0 = 0x00010300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 573: /*N66 */ { .pad_conf0 = 0x00920301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 574: /*N67 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x04C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 575: /*N68 */ { .pad_conf0 = 0x00110301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 576: /*N69 */ { .pad_conf0 = 0x00010300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 577: /*N70 */ { .pad_conf0 = 0x00010300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 578: /*N71 */ { .pad_conf0 = 0x00920301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 595: // Native_M1, /* 00 PMU_SLP_S3_B */ /* PMU_SLP_S3_N */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 596: // Native_M1, /* 01 PMU_BATLOW_B */ /* PMU_BATLOW_B */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 599: // Native_M1, /* 04 PMU_AC_PRESENT */ /* PMU_AC_PRESENT */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 600: // Native_M1, /* 05 PMU_PLTRST_B */ /* PMU_PLTRST_B */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 601: // Native_M1, /* 06 PMU_SUSCLK */ /* PMU_SUSCLK_1P8 */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 603: // Native_M1, /* 08 PMU_PWRBTN_B */ /* PMU_PWRBTN_N */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 604: // Native_M1, /* 09 PMU_SLP_S4_B */ /* PMU_SLP_S4_N */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 605: // NATIVE_FUNC(M1, P_1K_H, NA), /* 10 PMU_WAKE_B */ /* PMU_WAKE_N */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 606: // GPIO_NC, /* 11 PMU_WAKE_LAN_B */ /* PMU_WAKE_LAN_N */ /* FIXME: Does this connect to onboard RTL8111? */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 608: /*E00 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 609: /*E01 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 610: /*E02 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 611: /*E03 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 612: /*E04 */ { .pad_conf0 = 0x00110301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 613: /*E05 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 614: /*E06 */ { .pad_conf0 = 0x00110301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 616: /*E08 */ { .pad_conf0 = 0X00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 617: /*E09 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 618: /*E10 */ { .pad_conf0 = 0X00C10301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 619: /*E11 */ { .pad_conf0 = 0X2C918201, .pad_conf1 = 0X05C00041, .wake_mask = 1, .int_mask = 1, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 630: // GPIO_NC, /* 15 MF_GPIO_3 */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 631: // GPIO_NC, /* 16 MF_GPIO_7 */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 632: // GPIO_NC, /* 17 MF_I2C1_SCL */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 633: // GPIO_NC, /* 18 MF_GPIO_1 */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 634: // GPIO_NC, /* 19 MF_GPIO_5 */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 635: // GPIO_NC, /* 20 MF_GPIO_9 */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 636: // GPIO_NC, /* 21 MF_GPIO_0 */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 637: // GPIO_NC, /* 22 MF_GPIO_4 */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 638: // GPIO_NC, /* 23 MF_GPIO_8 */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 639: // GPIO_NC, /* 24 MF_GPIO_2 */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 640: // GPIO_NC, /* 25 MF_GPIO_6 */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 641: // GPIO_NC, /* 26 MF_I2C1_SDA */ /* */ /* FIXME: NC? Braswell doesn't have an ISH */ line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 643: /*E15 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 644: /*E16 */ { .pad_conf0 = 0x00118102, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 646: /*E18 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 647: /*E19 */ { .pad_conf0 = 0x00118100, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 648: /*E20 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 649: /*E21 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 650: /*E22 */ { .pad_conf0 = 0x08918201, .pad_conf1 = 0x05C00044, .wake_mask = 0, .int_mask = 1, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 651: /*E23 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 652: /*E24 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/gpio… PS6, Line 653: /*E25 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… File src/mainboard/solidrun/solidpc/ramstage.c: https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 25: /* N71:HV_DDI0_DDC_SCL >> 0 2 0 00 0xFED8D458 0x00920301 0xFED8D45C 0x05C00000 line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 26: N66:HV_DDI0_DDC_SDA >> 0 2 0 00 0xFED8D430 0x00920301 0xFED8D434 0x05C00000 line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 27: N61:HV_DDI0_HPD >> 0 1 0 00 0xFED8D408 0x00110300 0xFED8D40C 0x05C00020 line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 28: N64:HV_DDI1_HPD >> 0 1 0 00 0xFED8D420 0x00110301 0xFED8D424 0x05C00020 line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 29: N67:HV_DDI2_DDC_SCL >> 0 1 0 00 0xFED8D438 0x00910301 0xFED8D43C 0x04C00000 line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 30: N62:HV_DDI2_DDC_SDA >> 0 1 0 00 0xFED8D410 0x00910301 0xFED8D414 0x04C00000 line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 31: N68:HV_DDI2_HPD >> 0 1 0 00 0xFED8D440 0x00110301 0xFED8D444 0x05C00020 line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 32: N65:PANEL0_BKLTCTL >> 0 1 0 00 0xFED8D428 0x00010300 0xFED8D42C 0x05C00000 line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 33: N60:PANEL0_BKLTEN >> 0 1 0 00 0xFED8D400 0x00010300 0xFED8D404 0x05C00000 line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 34: N72:PANEL0_VDDEN >> 0 1 0 00 0xFED8D460 0x00010300 0xFED8D464 0x05C00000 line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 35: N63:PANEL1_BKLTCTL >> 0 1 0 00 0xFED8D418 0x00010300 0xFED8D41C 0x05C00000 line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 36: N70:PANEL1_BKLTEN >> 0 1 0 00 0xFED8D450 0x00010300 0xFED8D454 0x05C00000 line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 37: N69:PANEL1_VDDEN >> 0 1 0 00 0xFED8D448 0x00010300 0xFED8D44C 0x05C00000 line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 43: { .Name = NULL /*L"N71:HV_DDI0_DDC_SCL"*/, .Confg0 = 0x00920301, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5458, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 44: { .Name = NULL /*L"N66:HV_DDI0_DDC_SDA"*/, .Confg0 = 0x00920301, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5430, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 45: { .Name = NULL /*L"N61:HV_DDI0_HPD"*/, .Confg0 = 0x00110300, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00020, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5408, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 46: { .Name = NULL /*L"N64:HV_DDI1_HPD"*/, .Confg0 = 0x00110301, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00020, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5420, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 46: { .Name = NULL /*L"N64:HV_DDI1_HPD"*/, .Confg0 = 0x00110301, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00020, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5420, .Misc = 0 }, please, no space before tabs https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 47: { .Name = NULL /*L"N67:HV_DDI2_DDC_SCL"*/, .Confg0 = 0x00910301, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x04C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5438, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 48: { .Name = NULL /*L"N62:HV_DDI2_DDC_SDA"*/, .Confg0 = 0x00910301, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x04C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5410, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 49: { .Name = NULL /*L"N68:HV_DDI2_HPD"*/, .Confg0 = 0x00110301, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00020, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5440, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 50: { .Name = NULL /*L"N65:PANEL0_BKLTCTL"*/, .Confg0 = 0x00010300, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5428, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 51: { .Name = NULL /*L"N60:PANEL0_BKLTEN"*/, .Confg0 = 0x00010300, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5400, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 52: { .Name = NULL /*L"N72:PANEL0_VDDEN"*/, .Confg0 = 0x00010300, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5460, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 53: { .Name = NULL /*L"N63:PANEL1_BKLTCTL"*/, .Confg0 = 0x00010300, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5418, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 54: { .Name = NULL /*L"N70:PANEL1_BKLTEN"*/, .Confg0 = 0x00010300, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5450, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 55: { .Name = NULL /*L"N69:PANEL1_VDDEN"*/, .Confg0 = 0x00010300, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5448, .Misc = 0 }, line over 80 characters https://review.coreboot.org/#/c/23027/6/src/mainboard/solidrun/solidpc/rams… PS6, Line 56: { .Name = NULL /*L""*/, .Confg0 = 0xFFFFFFFF, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0xFFFFFFFF, .Confg1Changes = 0xFFFFFFFF, .Community = 0xFFFFFFFF, .MmioAddr = 0xFFFFFFFF, .Misc = 0xFFFFFFFF }, line over 80 characters -- To view, visit https://review.coreboot.org/23027 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00ff95313d74091e7411f6c8658d0d560a0e682b Gerrit-Change-Number: 23027 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <migy(a)darmstadt.ccc.de> Gerrit-Reviewer: Felix Singer <migy(a)darmstadt.ccc.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Thu, 20 Sep 2018 07:25:59 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/lynxpoint: Don't use device_t
by build bot (Jenkins) (Code Review) 20 Sep '18

20 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28641 ) Change subject: sb/intel/lynxpoint: Don't use device_t ...................................................................... Patch Set 5: (5 comments) https://review.coreboot.org/#/c/28641/5/src/southbridge/intel/lynxpoint/aza… File src/southbridge/intel/lynxpoint/azalia.c: https://review.coreboot.org/#/c/28641/5/src/southbridge/intel/lynxpoint/aza… PS5, Line 157: static void azalia_set_subsystem(struct device *dev, unsigned vendor, Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/5/src/southbridge/intel/lynxpoint/aza… PS5, Line 158: unsigned device) Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/5/src/southbridge/intel/lynxpoint/ser… File src/southbridge/intel/lynxpoint/serialio.c: https://review.coreboot.org/#/c/28641/5/src/southbridge/intel/lynxpoint/ser… PS5, Line 240: static void serialio_set_subsystem(struct device *dev, unsigned vendor, Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/5/src/southbridge/intel/lynxpoint/smb… File src/southbridge/intel/lynxpoint/smbus.c: https://review.coreboot.org/#/c/28641/5/src/southbridge/intel/lynxpoint/smb… PS5, Line 73: static void smbus_set_subsystem(struct device *dev, unsigned vendor, Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/5/src/southbridge/intel/lynxpoint/smb… PS5, Line 74: unsigned device) Prefer 'unsigned int' to bare use of 'unsigned' -- To view, visit https://review.coreboot.org/28641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I515b9e388dd2c1d1a9f4a24b2966a4b4656965a7 Gerrit-Change-Number: 28641 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 20 Sep 2018 07:00:11 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/skylake: Don't use device_t
by Elyes HAOUAS (Code Review) 20 Sep '18

20 Sep '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/28693 Change subject: soc/intel/skylake: Don't use device_t ...................................................................... soc/intel/skylake: Don't use device_t Use of device_t is deprecated. Change-Id: Ifd1471a9cd76d2cea72262ed81b7071f31f7b375 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/intel/skylake/include/soc/pch.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/28693/1 diff --git a/src/soc/intel/skylake/include/soc/pch.h b/src/soc/intel/skylake/include/soc/pch.h index 18b030d..e9e2f2f 100644 --- a/src/soc/intel/skylake/include/soc/pch.h +++ b/src/soc/intel/skylake/include/soc/pch.h @@ -23,7 +23,7 @@ void pch_log_state(void); #if ENV_RAMSTAGE -void pch_disable_devfn(device_t dev); +void pch_disable_devfn(struct device *dev); #endif #endif /* _SOC_PCH_H_ */ -- To view, visit https://review.coreboot.org/28693 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifd1471a9cd76d2cea72262ed81b7071f31f7b375 Gerrit-Change-Number: 28693 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: soc/intel/common/block: Don't use device_t
by Elyes HAOUAS (Code Review) 20 Sep '18

20 Sep '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/28694 Change subject: soc/intel/common/block: Don't use device_t ...................................................................... soc/intel/common/block: Don't use device_t Use of device_t is deprecated. Change-Id: Id82059898844fbe20665250062b67652d6cc1f9e Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/intel/common/block/include/intelblocks/smihandler.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/28694/1 diff --git a/src/soc/intel/common/block/include/intelblocks/smihandler.h b/src/soc/intel/common/block/include/intelblocks/smihandler.h index 197268b..050d93a 100644 --- a/src/soc/intel/common/block/include/intelblocks/smihandler.h +++ b/src/soc/intel/common/block/include/intelblocks/smihandler.h @@ -155,7 +155,7 @@ * This function returns a 1 or 0 depending on whether disable_busmaster * needs to be done for the specified device on S5 entry */ -int smihandler_soc_disable_busmaster(device_t dev); +int smihandler_soc_disable_busmaster(pci_devfn_t dev); /* SMI handlers that should be serviced in SCI mode too. */ uint32_t smihandler_soc_get_sci_mask(void); -- To view, visit https://review.coreboot.org/28694 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id82059898844fbe20665250062b67652d6cc1f9e Gerrit-Change-Number: 28694 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: soc/broadwell: Don't use device_t
by Elyes HAOUAS (Code Review) 20 Sep '18

20 Sep '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/28692 Change subject: soc/broadwell: Don't use device_t ...................................................................... soc/broadwell: Don't use device_t Use of device_t is deprecated. Change-Id: Ifdf3d1870500812a417eaa5e93fcc168629c094f Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/intel/broadwell/include/soc/pch.h M src/soc/intel/broadwell/include/soc/xhci.h M src/soc/intel/broadwell/pch.c M src/soc/intel/broadwell/xhci.c 4 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/28692/1 diff --git a/src/soc/intel/broadwell/include/soc/pch.h b/src/soc/intel/broadwell/include/soc/pch.h index 690af9f..19ba2e0b 100644 --- a/src/soc/intel/broadwell/include/soc/pch.h +++ b/src/soc/intel/broadwell/include/soc/pch.h @@ -43,6 +43,6 @@ int pch_is_wpt_ulx(void); u32 pch_read_soft_strap(int id); void pch_log_state(void); -void pch_disable_devfn(device_t dev); +void pch_disable_devfn(struct device *dev); #endif diff --git a/src/soc/intel/broadwell/include/soc/xhci.h b/src/soc/intel/broadwell/include/soc/xhci.h index cf1b135..33e4c2d 100644 --- a/src/soc/intel/broadwell/include/soc/xhci.h +++ b/src/soc/intel/broadwell/include/soc/xhci.h @@ -51,7 +51,7 @@ #define XHCI_PLSW_ENABLE (5 << 5) /* Transition from disabled */ #ifdef __SMM__ -void usb_xhci_sleep_prepare(device_t dev, u8 slp_typ); +void usb_xhci_sleep_prepare(pci_devfn_t dev, u8 slp_typ); #endif #endif diff --git a/src/soc/intel/broadwell/pch.c b/src/soc/intel/broadwell/pch.c index a8b25cf..c5df1ad 100644 --- a/src/soc/intel/broadwell/pch.c +++ b/src/soc/intel/broadwell/pch.c @@ -77,7 +77,7 @@ #ifndef __PRE_RAM__ /* Put device in D3Hot Power State */ -static void pch_enable_d3hot(device_t dev) +static void pch_enable_d3hot(struct device *dev) { u32 reg32 = pci_read_config32(dev, PCH_PCS); reg32 |= PCH_PCS_PS_D3HOT; @@ -92,7 +92,7 @@ } /* Set bit in Function Disable register to hide this device */ -void pch_disable_devfn(device_t dev) +void pch_disable_devfn(struct device *dev) { switch (dev->path.pci.devfn) { case PCH_DEVFN_ADSP: /* Audio DSP */ @@ -183,7 +183,7 @@ } } -void broadwell_pch_enable_dev(device_t dev) +void broadwell_pch_enable_dev(struct device *dev) { u32 reg32; diff --git a/src/soc/intel/broadwell/xhci.c b/src/soc/intel/broadwell/xhci.c index 75a63cf..8b4c7b1 100644 --- a/src/soc/intel/broadwell/xhci.c +++ b/src/soc/intel/broadwell/xhci.c @@ -25,7 +25,7 @@ #include <soc/cpu.h> #ifdef __SMM__ -static u8 *usb_xhci_mem_base(device_t dev) +static u8 *usb_xhci_mem_base(pci_devfn_t dev) { u32 mem_base = pci_read_config32(dev, PCI_BASE_ADDRESS_0); @@ -36,7 +36,7 @@ return (u8 *)(mem_base & ~0xf); } -static int usb_xhci_port_count_usb3(device_t dev) +static int usb_xhci_port_count_usb3(pci_devfn_t dev) { /* PCH-LP has 4 SS ports */ return 4; @@ -69,7 +69,7 @@ * b) Poll for warm reset complete * c) Write 1 to port change status bits */ -static void usb_xhci_reset_usb3(device_t dev, int all) +static void usb_xhci_reset_usb3(pci_devfn_t dev, int all) { u32 status, port_disabled; int timeout, port; @@ -140,7 +140,7 @@ } /* Handler for XHCI controller on entry to S3/S4/S5 */ -void usb_xhci_sleep_prepare(device_t dev, u8 slp_typ) +void usb_xhci_sleep_prepare(pci_devfn_t dev, u8 slp_typ) { u16 reg16; u32 reg32; -- To view, visit https://review.coreboot.org/28692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifdf3d1870500812a417eaa5e93fcc168629c094f Gerrit-Change-Number: 28692 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: sb/intel/lynxpoint: Don't use device_t
by build bot (Jenkins) (Code Review) 20 Sep '18

20 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28641 ) Change subject: sb/intel/lynxpoint: Don't use device_t ...................................................................... Patch Set 4: (5 comments) https://review.coreboot.org/#/c/28641/4/src/southbridge/intel/lynxpoint/aza… File src/southbridge/intel/lynxpoint/azalia.c: https://review.coreboot.org/#/c/28641/4/src/southbridge/intel/lynxpoint/aza… PS4, Line 157: static void azalia_set_subsystem(struct device *dev, unsigned vendor, Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/4/src/southbridge/intel/lynxpoint/aza… PS4, Line 158: unsigned device) Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/4/src/southbridge/intel/lynxpoint/ser… File src/southbridge/intel/lynxpoint/serialio.c: https://review.coreboot.org/#/c/28641/4/src/southbridge/intel/lynxpoint/ser… PS4, Line 240: static void serialio_set_subsystem(struct device *dev, unsigned vendor, Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/4/src/southbridge/intel/lynxpoint/smb… File src/southbridge/intel/lynxpoint/smbus.c: https://review.coreboot.org/#/c/28641/4/src/southbridge/intel/lynxpoint/smb… PS4, Line 73: static void smbus_set_subsystem(struct device *dev, unsigned vendor, Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/4/src/southbridge/intel/lynxpoint/smb… PS4, Line 74: unsigned device) Prefer 'unsigned int' to bare use of 'unsigned' -- To view, visit https://review.coreboot.org/28641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I515b9e388dd2c1d1a9f4a24b2966a4b4656965a7 Gerrit-Change-Number: 28641 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 20 Sep 2018 06:12:31 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: arch/riscv/include/arch: Don't use device_t
by Elyes HAOUAS (Code Review) 20 Sep '18

20 Sep '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/28691 Change subject: arch/riscv/include/arch: Don't use device_t ...................................................................... arch/riscv/include/arch: Don't use device_t Use of device_t is deprecated. Change-Id: If52de0d87b02419090b29a7cf1952905d3f975f6 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/riscv/include/arch/cpu.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/28691/1 diff --git a/src/arch/riscv/include/arch/cpu.h b/src/arch/riscv/include/arch/cpu.h index d2f42a8..4ee580c 100644 --- a/src/arch/riscv/include/arch/cpu.h +++ b/src/arch/riscv/include/arch/cpu.h @@ -31,7 +31,7 @@ struct thread; struct cpu_info { - device_t cpu; + struct device *cpu; unsigned long index; #if IS_ENABLED(CONFIG_COOP_MULTITASKING) struct thread *thread; -- To view, visit https://review.coreboot.org/28691 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If52de0d87b02419090b29a7cf1952905d3f975f6 Gerrit-Change-Number: 28691 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: mb/google/octopus: Close unused I2C bus 7 include SCL and SDA for Pha...
by build bot (Jenkins) (Code Review) 20 Sep '18

20 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28669 ) Change subject: mb/google/octopus: Close unused I2C bus 7 include SCL and SDA for Phaseer ...................................................................... Patch Set 11: (2 comments) https://review.coreboot.org/#/c/28669/11/src/mainboard/google/octopus/varia… File src/mainboard/google/octopus/variants/phaser/gpio.c: https://review.coreboot.org/#/c/28669/11/src/mainboard/google/octopus/varia… PS11, Line 85: trailing whitespace https://review.coreboot.org/#/c/28669/11/src/mainboard/google/octopus/varia… PS11, Line 100: }else{ space required after that close brace '}' -- To view, visit https://review.coreboot.org/28669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ad17761f2a053dc329bbec0a0a3284d47289666 Gerrit-Change-Number: 28669 Gerrit-PatchSet: 11 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jett Rink <jettrink(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Thu, 20 Sep 2018 02:40:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

← Newer
1
...
32
33
34
35
36
37
38
...
89
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2018