coreboot-gerrit September 2018

coreboot-gerrit@coreboot.org

1 participants
886 discussions

Change in coreboot[master]: {device, drivers}: Use 'unsigned int' to bare use of 'unsigned'
by Elyes HAOUAS (Code Review) 20 Sep '18

20 Sep '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/28700 Change subject: {device,drivers}: Use 'unsigned int' to bare use of 'unsigned' ...................................................................... {device,drivers}: Use 'unsigned int' to bare use of 'unsigned' Change-Id: Iebb043a6fbc5803fbb7cad2f35b43917e10d09d4 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/device/pci_device.c M src/drivers/ricoh/rce822/rce822.c 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/28700/1 diff --git a/src/device/pci_device.c b/src/device/pci_device.c index b4a8a5c..e35c22c 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -726,7 +726,8 @@ delay(1); } -void pci_dev_set_subsystem(struct device *dev, unsigned vendor, unsigned device) +void pci_dev_set_subsystem(struct device *dev, unsigned int vendor, + unsigned int device) { pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID, ((device & 0xffff) << 16) | (vendor & 0xffff)); diff --git a/src/drivers/ricoh/rce822/rce822.c b/src/drivers/ricoh/rce822/rce822.c index b364946..a974811 100644 --- a/src/drivers/ricoh/rce822/rce822.c +++ b/src/drivers/ricoh/rce822/rce822.c @@ -39,7 +39,7 @@ pci_write_config8(dev, 0xf9, 0x00); } -static void rce822_set_subsystem(struct device *dev, unsigned vendor, unsigned device) +static void rce822_set_subsystem(struct device *dev, unsigned int vendor, unsigned int device) { if (!vendor || !device) { pci_write_config32(dev, 0xac, -- To view, visit https://review.coreboot.org/28700 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iebb043a6fbc5803fbb7cad2f35b43917e10d09d4 Gerrit-Change-Number: 28700 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: soc/sifive/fu540: Document #if ENV_ROMSTAGE line
by Jonathan Neuschäfer (Code Review) 20 Sep '18

20 Sep '18

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/28699 Change subject: soc/sifive/fu540: Document #if ENV_ROMSTAGE line ...................................................................... soc/sifive/fu540: Document #if ENV_ROMSTAGE line Change-Id: Idcd72c558e46637b1b99e9613963436fedd4a8b9 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/soc/sifive/fu540/clock.c 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/28699/1 diff --git a/src/soc/sifive/fu540/clock.c b/src/soc/sifive/fu540/clock.c index eb7a8b5..20dce23 100644 --- a/src/soc/sifive/fu540/clock.c +++ b/src/soc/sifive/fu540/clock.c @@ -121,8 +121,8 @@ // 33.33 Mhz after reset #define FU540_BASE_FQY 33330 +/* Clock initialization should only be done in romstage. */ #if ENV_ROMSTAGE - static void init_coreclk(void) { // switch coreclk to input reference frequency before modifying PLL @@ -240,8 +240,7 @@ for (int i = 0; i < 256; i++) asm volatile ("nop"); } - -#endif +#endif /* ENV_ROMSTAGE */ int clock_get_coreclk_khz(void) { -- To view, visit https://review.coreboot.org/28699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idcd72c558e46637b1b99e9613963436fedd4a8b9 Gerrit-Change-Number: 28699 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: sb/intel/lynxpoint: Don't use device_t
by build bot (Jenkins) (Code Review) 20 Sep '18

20 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28641 ) Change subject: sb/intel/lynxpoint: Don't use device_t ...................................................................... Patch Set 7: (8 comments) https://review.coreboot.org/#/c/28641/7/src/southbridge/intel/lynxpoint/aza… File src/southbridge/intel/lynxpoint/azalia.c: https://review.coreboot.org/#/c/28641/7/src/southbridge/intel/lynxpoint/aza… PS7, Line 157: static void azalia_set_subsystem(struct device *dev, unsigned vendor, Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/7/src/southbridge/intel/lynxpoint/aza… PS7, Line 158: unsigned device) Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/7/src/southbridge/intel/lynxpoint/ser… File src/southbridge/intel/lynxpoint/serialio.c: https://review.coreboot.org/#/c/28641/7/src/southbridge/intel/lynxpoint/ser… PS7, Line 240: static void serialio_set_subsystem(struct device *dev, unsigned vendor, Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/7/src/southbridge/intel/lynxpoint/smb… File src/southbridge/intel/lynxpoint/smbus.c: https://review.coreboot.org/#/c/28641/7/src/southbridge/intel/lynxpoint/smb… PS7, Line 73: static void smbus_set_subsystem(struct device *dev, unsigned vendor, Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/7/src/southbridge/intel/lynxpoint/smb… PS7, Line 74: unsigned device) Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/7/src/southbridge/intel/lynxpoint/usb… File src/southbridge/intel/lynxpoint/usb_ehci.c: https://review.coreboot.org/#/c/28641/7/src/southbridge/intel/lynxpoint/usb… PS7, Line 167: static void usb_ehci_set_subsystem(struct device *dev, unsigned vendor, Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/7/src/southbridge/intel/lynxpoint/usb… PS7, Line 168: unsigned device) Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/7/src/southbridge/intel/lynxpoint/usb… File src/southbridge/intel/lynxpoint/usb_xhci.c: https://review.coreboot.org/#/c/28641/7/src/southbridge/intel/lynxpoint/usb… PS7, Line 364: static void usb_xhci_set_subsystem(struct device *dev, unsigned vendor, Prefer 'unsigned int' to bare use of 'unsigned' -- To view, visit https://review.coreboot.org/28641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I515b9e388dd2c1d1a9f4a24b2966a4b4656965a7 Gerrit-Change-Number: 28641 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 20 Sep 2018 15:05:10 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/lynxpoint: Don't use device_t
by build bot (Jenkins) (Code Review) 20 Sep '18

20 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28641 ) Change subject: sb/intel/lynxpoint: Don't use device_t ...................................................................... Patch Set 6: (9 comments) https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/aza… File src/southbridge/intel/lynxpoint/azalia.c: https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/aza… PS6, Line 157: static void azalia_set_subsystem(struct device *dev, unsigned vendor, Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/aza… PS6, Line 158: unsigned device) Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/ser… File src/southbridge/intel/lynxpoint/serialio.c: https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/ser… PS6, Line 240: static void serialio_set_subsystem(struct device *dev, unsigned vendor, Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/smb… File src/southbridge/intel/lynxpoint/smbus.c: https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/smb… PS6, Line 73: static void smbus_set_subsystem(struct device *dev, unsigned vendor, Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/smb… PS6, Line 74: unsigned device) Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/usb… File src/southbridge/intel/lynxpoint/usb_ehci.c: https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/usb… PS6, Line 167: static void usb_ehci_set_subsystem(struct device *dev, unsigned vendor, unsigned device) line over 80 characters https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/usb… PS6, Line 167: static void usb_ehci_set_subsystem(struct device *dev, unsigned vendor, unsigned device) Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/usb… PS6, Line 167: static void usb_ehci_set_subsystem(struct device *dev, unsigned vendor, unsigned device) Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/usb… File src/southbridge/intel/lynxpoint/usb_xhci.c: https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/usb… PS6, Line 364: static void usb_xhci_set_subsystem(struct device *dev, unsigned vendor, Prefer 'unsigned int' to bare use of 'unsigned' -- To view, visit https://review.coreboot.org/28641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I515b9e388dd2c1d1a9f4a24b2966a4b4656965a7 Gerrit-Change-Number: 28641 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 20 Sep 2018 15:02:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/denverton_ns/csme_ie_kt.c: Don't use device_t
by Jonathan Neuschäfer (Code Review) 20 Sep '18

20 Sep '18

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/28679 ) Change subject: soc/intel/denverton_ns/csme_ie_kt.c: Don't use device_t ...................................................................... Patch Set 3: Code-Review+2 Looks good to me, thanks -- To view, visit https://review.coreboot.org/28679 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dde92314af8ef87a5acb550f0fb25b8ce875174 Gerrit-Change-Number: 28679 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 20 Sep 2018 14:14:11 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block/smm/smihandler.c: Don't use device_t
by Jonathan Neuschäfer (Code Review) 20 Sep '18

20 Sep '18

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/28678 ) Change subject: soc/intel/common/block/smm/smihandler.c: Don't use device_t ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/28678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6679fc151c26607eaffdd4a8cdb3da8a1290fef7 Gerrit-Change-Number: 28678 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 20 Sep 2018 14:11:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/quark/uart.c: Don't use device_t
by Jonathan Neuschäfer (Code Review) 20 Sep '18

20 Sep '18

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/28677 ) Change subject: soc/intel/quark/uart.c: Don't use device_t ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/28677 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia50aa96901b979b947fd4d269b077814c06f60c6 Gerrit-Change-Number: 28677 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 20 Sep 2018 14:11:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block: Don't use device_t
by Jonathan Neuschäfer (Code Review) 20 Sep '18

20 Sep '18

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/28694 ) Change subject: soc/intel/common/block: Don't use device_t ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/28694 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id82059898844fbe20665250062b67652d6cc1f9e Gerrit-Change-Number: 28694 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 20 Sep 2018 14:09:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/skylake: Don't use device_t
by Jonathan Neuschäfer (Code Review) 20 Sep '18

20 Sep '18

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/28693 ) Change subject: soc/intel/skylake: Don't use device_t ...................................................................... Patch Set 2: Code-Review+2 Looks good, thanks -- To view, visit https://review.coreboot.org/28693 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd1471a9cd76d2cea72262ed81b7071f31f7b375 Gerrit-Change-Number: 28693 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 20 Sep 2018 14:08:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: sb/intel/bd82x6x: Don't use device_t
by Jonathan Neuschäfer (Code Review) 20 Sep '18

20 Sep '18

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/28657 ) Change subject: sb/intel/bd82x6x: Don't use device_t ...................................................................... Patch Set 7: Code-Review+2 Looks good to me, thanks. -- To view, visit https://review.coreboot.org/28657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4909ebffc978f537bbf6269d9e27dbaca43daa10 Gerrit-Change-Number: 28657 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 20 Sep 2018 14:06:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

← Newer
1
...
29
30
31
32
33
34
35
...
89
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2018