build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28651 )
Change subject: mainboard/google/kahlee: allow oem.bin file to update smbios
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/28651/3/src/mainboard/google/kahlee/variant…
File src/mainboard/google/kahlee/variants/baseboard/mainboard.c:
https://review.coreboot.org/#/c/28651/3/src/mainboard/google/kahlee/variant…
PS3, Line 84: /* "oem.bin" in cbfs contains an array of records using the following structure. */
line over 80 characters
--
To view, visit https://review.coreboot.org/28651
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I997dc39c7f36f70cf4320ef335831245889eb475
Gerrit-Change-Number: 28651
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 19 Sep 2018 16:24:30 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28651 )
Change subject: mainboard/google/kahlee: allow oem.bin file to update smbios
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/28651/3/src/mainboard/google/kahlee/variant…
File src/mainboard/google/kahlee/variants/baseboard/mainboard.c:
https://review.coreboot.org/#/c/28651/3/src/mainboard/google/kahlee/variant…
PS3, Line 84: /* "oem.bin" in cbfs contains an array of records using the following structure. */
line over 80 characters
--
To view, visit https://review.coreboot.org/28651
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I997dc39c7f36f70cf4320ef335831245889eb475
Gerrit-Change-Number: 28651
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 19 Sep 2018 16:08:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/28684
to look at the new patch set (#2).
Change subject: mb/google/auron/variants: Don't use device_t
......................................................................
mb/google/auron/variants: Don't use device_t
Use of device_t is deprecated.
Change-Id: Iafda1af7639e5f8f43b431794d9da8f8bc20661d
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/mainboard/google/auron/variant.h
M src/mainboard/google/auron/variants/auron_paine/variant.c
M src/mainboard/google/auron/variants/auron_yuna/variant.c
M src/mainboard/google/auron/variants/buddy/variant.c
M src/mainboard/google/auron/variants/gandof/variant.c
M src/mainboard/google/auron/variants/lulu/variant.c
M src/mainboard/google/auron/variants/samus/variant.c
7 files changed, 8 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/28684/2
--
To view, visit https://review.coreboot.org/28684
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iafda1af7639e5f8f43b431794d9da8f8bc20661d
Gerrit-Change-Number: 28684
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>