coreboot-gerrit August 2018

coreboot-gerrit@coreboot.org

1 participants
1120 discussions

Change in coreboot[master]: google/cyan: Fix ACPI resource scope for Melfas touchscreen
by Matt DeVillier (Code Review) 16 Aug '18

16 Aug '18

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/28114 Change subject: google/cyan: Fix ACPI resource scope for Melfas touchscreen ...................................................................... google/cyan: Fix ACPI resource scope for Melfas touchscreen Fix scope of ResourceSource, which should match the scope of the device itself. Change-Id: I9d0ff0ecc2721ec55b1ed12dddb495cd55966daf Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/cyan/acpi/touchscreen_melfas.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/28114/1 diff --git a/src/mainboard/google/cyan/acpi/touchscreen_melfas.asl b/src/mainboard/google/cyan/acpi/touchscreen_melfas.asl index 905b7b8..15b2237 100644 --- a/src/mainboard/google/cyan/acpi/touchscreen_melfas.asl +++ b/src/mainboard/google/cyan/acpi/touchscreen_melfas.asl @@ -33,7 +33,7 @@ ControllerInitiated, /* SlaveMode */ 400000, /* ConnectionSpeed */ AddressingMode7Bit, /* AddressingMode */ - "\\_SB.I2C1", /* ResourceSource */ + "\\_SB.PCI0.I2C1", /* ResourceSource */ ) GpioInt (Level, ActiveLow, ExclusiveAndWake, PullDefault,, "\\_SB.GPNC") { BOARD_TOUCH_GPIO_INDEX } -- To view, visit https://review.coreboot.org/28114 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9d0ff0ecc2721ec55b1ed12dddb495cd55966daf Gerrit-Change-Number: 28114 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

Change in coreboot[master]: Nami: Disable powering off EC on cr50 update
by Daisuke Nojiri (Code Review) 16 Aug '18

16 Aug '18

Daisuke Nojiri has uploaded this change for review. ( https://review.coreboot.org/28113 Change subject: Nami: Disable powering off EC on cr50 update ...................................................................... Nami: Disable powering off EC on cr50 update Nami doesn't support wakeup from hibernation by CR50. This causes the device to remain turned off after CR50 update. This patch disables turning off EC on cr50 update. CR50 resets the whole system. So, EC reset is not required. Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> BUG=b:112604277 BRANCH=none TEST=gsctool -a -u /media/removable/cr50.bin && reboot Verify EC reboots. AP prints 'Waiting for CR50 reset to pick up update' then reboots. Change-Id: I06f5eb6100e8af6ffec45d4de2b40eff44f89709 --- M src/mainboard/google/poppy/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/28113/1 diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index fc090df..1645451 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -169,6 +169,7 @@ select DRIVERS_SPI_ACPI select EXCLUDE_NATIVE_SD_INTERFACE select MAINBOARD_HAS_SPI_TPM_CR50 + select DISABLE_POWER_OFF_EC_ON_CR50_UPDATE config VARIANT_SPECIFIC_OPTIONS_NAUTILUS def_bool n -- To view, visit https://review.coreboot.org/28113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I06f5eb6100e8af6ffec45d4de2b40eff44f89709 Gerrit-Change-Number: 28113 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org>

1 0

Change in coreboot[master]: nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs
by Enrico Granata (Code Review) 16 Aug '18

16 Aug '18

Enrico Granata has uploaded this change for review. ( https://review.coreboot.org/28112 Change subject: nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs ...................................................................... nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs This is meant to solve an issue where the proximity sensor may fluctuate between CLOSE / FAR in rapid succession upon the user removing their hand from the unit, before settling on the correct output. Using the hardware debouncing filter solves this issue and removes the spurious fluctuations. BRANCH=None BUG=None TEST=manual on Nocturne, observing events come in Change-Id: I78cc4852d42fcda6209fedce1ce91236b5814571 Signed-off-by: Enrico Granata <egranata(a)chromium.org> --- M src/mainboard/google/poppy/variants/nocturne/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/28112/1 diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb index 88af929..32f09f1 100644 --- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb @@ -309,7 +309,7 @@ register "reg_prox_ctrl7" = "0x0d" register "reg_prox_ctrl8" = "0x8d" register "reg_prox_ctrl9" = "0x43" - register "reg_prox_ctrl10" = "0x11" + register "reg_prox_ctrl10" = "0x1F" register "reg_prox_ctrl11" = "0x00" register "reg_prox_ctrl12" = "0x00" register "reg_prox_ctrl13" = "0x00" @@ -350,7 +350,7 @@ register "reg_prox_ctrl7" = "0x0d" register "reg_prox_ctrl8" = "0x8d" register "reg_prox_ctrl9" = "0x43" - register "reg_prox_ctrl10" = "0x11" + register "reg_prox_ctrl10" = "0x1F" register "reg_prox_ctrl11" = "0x00" register "reg_prox_ctrl12" = "0x00" register "reg_prox_ctrl13" = "0x00" -- To view, visit https://review.coreboot.org/28112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I78cc4852d42fcda6209fedce1ce91236b5814571 Gerrit-Change-Number: 28112 Gerrit-PatchSet: 1 Gerrit-Owner: Enrico Granata <egranata(a)chromium.org>

1 0

Change in coreboot[master]: soc/intel/common/block: Add WHL 2-core SKU
by Krzysztof M Sywula (Code Review) 15 Aug '18

15 Aug '18

Krzysztof M Sywula has uploaded this change for review. ( https://review.coreboot.org/28111 Change subject: soc/intel/common/block: Add WHL 2-core SKU ...................................................................... soc/intel/common/block: Add WHL 2-core SKU There are two SKUs of Whiskey Lake W0, 2-core and 4-core. Change-Id: Ia9b2707568702a5fbae3e9495ca53df34613a542 Signed-off-by: Krzysztof Sywula <krzysztof.m.sywula(a)intel.com> --- M src/include/device/pci_ids.h M src/soc/intel/cannonlake/bootblock/report_platform.c M src/soc/intel/common/block/systemagent/systemagent.c 3 files changed, 6 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/28111/1 diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index c9e4212..4ced4a5 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -2902,7 +2902,8 @@ #define PCI_DEVICE_ID_INTEL_KBL_ID_DT 0x591f #define PCI_DEVICE_ID_INTEL_CNL_ID_U 0x5A04 #define PCI_DEVICE_ID_INTEL_CNL_ID_Y 0x5A02 -#define PCI_DEVICE_ID_INTEL_WHL_ID_W 0x3E34 +#define PCI_DEVICE_ID_INTEL_WHL_ID_Wx4 0x3E34 +#define PCI_DEVICE_ID_INTEL_WHL_ID_Wx2 0x3E35 #define PCI_DEVICE_ID_INTEL_CFL_ID_U 0x3ED0 /* Intel SMBUS device Ids */ diff --git a/src/soc/intel/cannonlake/bootblock/report_platform.c b/src/soc/intel/cannonlake/bootblock/report_platform.c index d7daa18..937e56c 100644 --- a/src/soc/intel/cannonlake/bootblock/report_platform.c +++ b/src/soc/intel/cannonlake/bootblock/report_platform.c @@ -47,7 +47,8 @@ { PCI_DEVICE_ID_INTEL_CNL_ID_U, "Cannonlake-U" }, { PCI_DEVICE_ID_INTEL_CNL_ID_Y, "Cannonlake-Y" }, { PCI_DEVICE_ID_INTEL_CFL_ID_U, "Coffeelake U (4+3e)"}, - { PCI_DEVICE_ID_INTEL_WHL_ID_W, "Whiskeylake"}, + { PCI_DEVICE_ID_INTEL_WHL_ID_Wx4, "Whiskeylake W (4+2)"}, + { PCI_DEVICE_ID_INTEL_WHL_ID_Wx2, "Whiskeylake W (2+2)"}, }; static struct { diff --git a/src/soc/intel/common/block/systemagent/systemagent.c b/src/soc/intel/common/block/systemagent/systemagent.c index 7f5e5a9..72cecb1 100644 --- a/src/soc/intel/common/block/systemagent/systemagent.c +++ b/src/soc/intel/common/block/systemagent/systemagent.c @@ -294,7 +294,8 @@ PCI_DEVICE_ID_INTEL_SKL_ID_Y, PCI_DEVICE_ID_INTEL_SKL_ID_ULX, PCI_DEVICE_ID_INTEL_SKL_ID_H, - PCI_DEVICE_ID_INTEL_WHL_ID_W, + PCI_DEVICE_ID_INTEL_WHL_ID_Wx2, + PCI_DEVICE_ID_INTEL_WHL_ID_Wx4, PCI_DEVICE_ID_INTEL_KBL_ID_S, PCI_DEVICE_ID_INTEL_SKL_ID_H_EM, PCI_DEVICE_ID_INTEL_KBL_ID_U, -- To view, visit https://review.coreboot.org/28111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia9b2707568702a5fbae3e9495ca53df34613a542 Gerrit-Change-Number: 28111 Gerrit-PatchSet: 1 Gerrit-Owner: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com>

1 0

Change in coreboot[master]: lib/fit_payload: Add coreboot tables support for FDT.
by Philipp Deppenwiese (Code Review) 15 Aug '18

15 Aug '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28104 to look at the new patch set (#4). Change subject: lib/fit_payload: Add coreboot tables support for FDT. ...................................................................... lib/fit_payload: Add coreboot tables support for FDT. * Copy code of depthcharge boot/coreboot.c and modify it. Change-Id: Ib714a021a24f51407558f484cd97aa58ecd43977 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M src/lib/fit_payload.c 1 file changed, 65 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/28104/4 -- To view, visit https://review.coreboot.org/28104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib714a021a24f51407558f484cd97aa58ecd43977 Gerrit-Change-Number: 28104 Gerrit-PatchSet: 4 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org>

1 0

Change in coreboot[master]: lib/fit_payload: Add coreboot tables support for FDT.
by Julius Werner (Code Review) 15 Aug '18

15 Aug '18

Julius Werner has posted comments on this change. ( https://review.coreboot.org/28104 ) Change subject: lib/fit_payload: Add coreboot tables support for FDT. ...................................................................... Patch Set 3: (4 comments) https://review.coreboot.org/#/c/28104/2/src/lib/fit_payload.c File src/lib/fit_payload.c: https://review.coreboot.org/#/c/28104/2/src/lib/fit_payload.c@112 PS2, Line 112: // Need to add 'ranges' to the intermediate node to make 'reg' work. Remember to convert everything to coreboot comment style. https://review.coreboot.org/#/c/28104/2/src/lib/fit_payload.c@119 PS2, Line 119: (char *) Do you need this cast? Looks like we didn't need it in depthcharge so I'm confused... Maybe we should change all the dt_add_..._prop() stuff to take const values? https://review.coreboot.org/#/c/28104/2/src/lib/fit_payload.c@138 PS2, Line 138: reg_sizes[1] = cbmem_overhead_size(); These aren't the right numbers... at least not the numbers used by depthcharge. We don't actually have any uses for this field yet, so it's not that big of a deal, but we should try to keep it consistent. The correct range (that depthcharge uses) is found by cbmem_add_bootmem(). Maybe we should expand that function to a slightly more generic cbmem_full_area(&start, &size) or something like that, so that we can use it both for bootmem and here. https://review.coreboot.org/#/c/28104/2/src/lib/fit_payload.c@143 PS2, Line 143: exported from coreboot nit: not really "exported from coreboot" anymore now, since we're still in coreboot -- To view, visit https://review.coreboot.org/28104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib714a021a24f51407558f484cd97aa58ecd43977 Gerrit-Change-Number: 28104 Gerrit-PatchSet: 3 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 15 Aug 2018 23:11:24 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: Nami: Disable powering off EC on cr50 update
by Daisuke Nojiri (Code Review) 15 Aug '18

15 Aug '18

Daisuke Nojiri has uploaded this change for review. ( https://review.coreboot.org/28110 Change subject: Nami: Disable powering off EC on cr50 update ...................................................................... Nami: Disable powering off EC on cr50 update Nami doesn't support wakeup from hibernation by CR50. This causes the device to remain turned off after CR50 update. This patch disables turning off EC on cr50 update. CR50 resets the whole system. So, EC reset is not required. Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> BUG=b:112604277 BRANCH=none TEST=gsctool -a -u /media/removable/cr50.bin && reboot Verify EC reboots. AP prints 'Waiting for CR50 reset to pick up update' then reboots. Change-Id: I60a7aa50a549e7a5a1a114245fbf7b9646d813bb --- M src/mainboard/google/poppy/Kconfig M src/security/tpm/tss/vendor/cr50/Kconfig M src/vendorcode/google/chromeos/cr50_enable_update.c 3 files changed, 10 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/28110/1 diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index fc090df..1645451 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -169,6 +169,7 @@ select DRIVERS_SPI_ACPI select EXCLUDE_NATIVE_SD_INTERFACE select MAINBOARD_HAS_SPI_TPM_CR50 + select DISABLE_POWER_OFF_EC_ON_CR50_UPDATE config VARIANT_SPECIFIC_OPTIONS_NAUTILUS def_bool n diff --git a/src/security/tpm/tss/vendor/cr50/Kconfig b/src/security/tpm/tss/vendor/cr50/Kconfig index 4d40c08..e98ec11 100644 --- a/src/security/tpm/tss/vendor/cr50/Kconfig +++ b/src/security/tpm/tss/vendor/cr50/Kconfig @@ -25,4 +25,11 @@ help Power off machine while waiting for CR50 update to take effect. +config DISABLE_POWER_OFF_EC_ON_CR50_UPDATE + bool + default n + help + Disable powering off EC while waiting for CR50 update to take effect. + Turning off EC is not necessary if CR50 resets the whole system. + endif diff --git a/src/vendorcode/google/chromeos/cr50_enable_update.c b/src/vendorcode/google/chromeos/cr50_enable_update.c index 1d91112..d07a9a3 100644 --- a/src/vendorcode/google/chromeos/cr50_enable_update.c +++ b/src/vendorcode/google/chromeos/cr50_enable_update.c @@ -60,7 +60,8 @@ printk(BIOS_INFO, "Waiting for CR50 reset to pick up update.\n"); if (IS_ENABLED(CONFIG_POWER_OFF_ON_CR50_UPDATE)) { - if (IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC)) { + if (IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC) && + !IS_ENABLED(CONFIG_DISABLE_POWER_OFF_EC_ON_CR50_UPDATE)) { printk(BIOS_INFO, "Hibernating EC. Clearing AP_OFF.\n"); google_chromeec_reboot(0, EC_REBOOT_HIBERNATE_CLEAR_AP_OFF, -- To view, visit https://review.coreboot.org/28110 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I60a7aa50a549e7a5a1a114245fbf7b9646d813bb Gerrit-Change-Number: 28110 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org>

1 0

Change in coreboot[master]: mainboard/google: delete tablet mode defines
by Matt Delco (Code Review) 15 Aug '18

15 Aug '18

Matt Delco has uploaded this change for review. ( https://review.coreboot.org/28109 Change subject: mainboard/google: delete tablet mode defines ...................................................................... mainboard/google: delete tablet mode defines The define for the tablet mode device has changed to Kconfig, so the instances of enabling the device via ec.h can now be removed. Change-Id: I3e0e20df6698180e34fc281cf691cad228486953 Signed-off-by: Matt Delco <delco(a)chromium.org> --- M src/mainboard/google/eve/ec.h M src/mainboard/google/octopus/variants/phaser/include/variant/ec.h M src/mainboard/google/octopus/variants/yorp/include/variant/ec.h M src/mainboard/google/poppy/variants/nami/include/variant/ec.h M src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h M src/mainboard/google/poppy/variants/rammus/include/variant/ec.h M src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h 7 files changed, 0 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/28109/1 diff --git a/src/mainboard/google/eve/ec.h b/src/mainboard/google/eve/ec.h index 1b55248..81d591c 100644 --- a/src/mainboard/google/eve/ec.h +++ b/src/mainboard/google/eve/ec.h @@ -79,8 +79,6 @@ /* Enable Tablet switch */ #define EC_ENABLE_TABLET_EVENT -#define EC_ENABLE_TBMC_DEVICE - #define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */ diff --git a/src/mainboard/google/octopus/variants/phaser/include/variant/ec.h b/src/mainboard/google/octopus/variants/phaser/include/variant/ec.h index 48cb584..16f931b 100644 --- a/src/mainboard/google/octopus/variants/phaser/include/variant/ec.h +++ b/src/mainboard/google/octopus/variants/phaser/include/variant/ec.h @@ -18,7 +18,4 @@ #include <baseboard/ec.h> -/* Enable Tablet switch */ -#define EC_ENABLE_TBMC_DEVICE - #endif diff --git a/src/mainboard/google/octopus/variants/yorp/include/variant/ec.h b/src/mainboard/google/octopus/variants/yorp/include/variant/ec.h index 48cb584..16f931b 100644 --- a/src/mainboard/google/octopus/variants/yorp/include/variant/ec.h +++ b/src/mainboard/google/octopus/variants/yorp/include/variant/ec.h @@ -18,7 +18,4 @@ #include <baseboard/ec.h> -/* Enable Tablet switch */ -#define EC_ENABLE_TBMC_DEVICE - #endif diff --git a/src/mainboard/google/poppy/variants/nami/include/variant/ec.h b/src/mainboard/google/poppy/variants/nami/include/variant/ec.h index a5a0196..52a24e5 100644 --- a/src/mainboard/google/poppy/variants/nami/include/variant/ec.h +++ b/src/mainboard/google/poppy/variants/nami/include/variant/ec.h @@ -70,7 +70,6 @@ /* Enable Tablet switch */ #define EC_ENABLE_TABLET_EVENT -#define EC_ENABLE_TBMC_DEVICE #define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ diff --git a/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h b/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h index 70f12d5..ca9f865 100644 --- a/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h +++ b/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h @@ -72,7 +72,6 @@ #define EC_ENABLE_LID_SWITCH #define EC_ENABLE_WAKE_PIN GPE_EC_WAKE #define EC_ENABLE_TABLET_EVENT -#define EC_ENABLE_TBMC_DEVICE #define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ diff --git a/src/mainboard/google/poppy/variants/rammus/include/variant/ec.h b/src/mainboard/google/poppy/variants/rammus/include/variant/ec.h index b22fccb..302eb42 100644 --- a/src/mainboard/google/poppy/variants/rammus/include/variant/ec.h +++ b/src/mainboard/google/poppy/variants/rammus/include/variant/ec.h @@ -74,7 +74,6 @@ /* Enable Tablet switch */ #define EC_ENABLE_TABLET_EVENT -#define EC_ENABLE_TBMC_DEVICE #define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ diff --git a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h index 6e1de7a..6e5b277 100644 --- a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h @@ -71,8 +71,6 @@ #define EC_ENABLE_LID_SWITCH #define EC_ENABLE_WAKE_PIN GPE_EC_WAKE -#define EC_ENABLE_TBMC_DEVICE - #define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */ -- To view, visit https://review.coreboot.org/28109 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3e0e20df6698180e34fc281cf691cad228486953 Gerrit-Change-Number: 28109 Gerrit-PatchSet: 1 Gerrit-Owner: Matt Delco <delco(a)chromium.org>

1 0

Change in coreboot[master]: src/mainboard/google: set option for acpi device
by Matt Delco (Code Review) 15 Aug '18

15 Aug '18

Matt Delco has uploaded this change for review. ( https://review.coreboot.org/28107 Change subject: src/mainboard/google: set option for acpi device ...................................................................... src/mainboard/google: set option for acpi device This change enables an unused but soon to be used option for enabling the acpi tablet mode device. Change-Id: I53c80c7822c52ee805adacbcfc5d3fcc7cc476e6 Signed-off-by: Matt Delco <delco(a)chromium.org> --- M src/mainboard/google/eve/Kconfig M src/mainboard/google/octopus/Kconfig M src/mainboard/google/poppy/Kconfig M src/mainboard/google/reef/Kconfig 4 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/28107/1 diff --git a/src/mainboard/google/eve/Kconfig b/src/mainboard/google/eve/Kconfig index 71b011b..236a48c 100644 --- a/src/mainboard/google/eve/Kconfig +++ b/src/mainboard/google/eve/Kconfig @@ -12,6 +12,7 @@ select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_BOARDID select EC_GOOGLE_CHROMEEC_LPC + select EC_GOOGLE_CHROMEEC_ACPI_TABLET_DEVICE select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select INTEL_GMA_HAVE_VBT diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig index 54e77ec..10ef1ac 100644 --- a/src/mainboard/google/octopus/Kconfig +++ b/src/mainboard/google/octopus/Kconfig @@ -34,6 +34,7 @@ config BASEBOARD_OCTOPUS_CONVERTIBLE def_bool n + select EC_GOOGLE_CHROMEEC_ACPI_TABLET_DEVICE select SYSTEM_TYPE_CONVERTIBLE config CHROMEOS diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index 4ec34b8..d617119 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -19,6 +19,7 @@ config BASEBOARD_POPPY_CONVERTIBLE def_bool n + select EC_GOOGLE_CHROMEEC_ACPI_TABLET_DEVICE select SYSTEM_TYPE_CONVERTIBLE config CHROMEOS_WIFI_SAR diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig index 3e85e35..8433289 100644 --- a/src/mainboard/google/reef/Kconfig +++ b/src/mainboard/google/reef/Kconfig @@ -25,6 +25,7 @@ config BASEBOARD_REEF_CONVERTIBLE def_bool n + select EC_GOOGLE_CHROMEEC_ACPI_TABLET_DEVICE select SYSTEM_TYPE_CONVERTIBLE config DRIVER_TPM_I2C_BUS -- To view, visit https://review.coreboot.org/28107 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I53c80c7822c52ee805adacbcfc5d3fcc7cc476e6 Gerrit-Change-Number: 28107 Gerrit-PatchSet: 1 Gerrit-Owner: Matt Delco <delco(a)chromium.org>

1 0

Change in coreboot[master]: ec/google/chromec/acpi: switch tablet device from .h to Kconfig
by Matt Delco (Code Review) 15 Aug '18

15 Aug '18

Matt Delco has uploaded this change for review. ( https://review.coreboot.org/28108 Change subject: ec/google/chromec/acpi: switch tablet device from .h to Kconfig ...................................................................... ec/google/chromec/acpi: switch tablet device from .h to Kconfig The ACPI tablet mode device was previously enabled by setting a #define in an ec.h file. Prior changes have (if correct) set an analogous setting in Kconfig. This change changes the compile-time check to be based on Kconfig rather than ec.h. Change-Id: Ie7d7301c2a11c3ae32b870b724018832200b49eb Signed-off-by: Matt Delco <delco(a)chromium.org> --- M src/ec/google/chromeec/acpi/ec.asl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/28108/1 diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl index 94917dd..90ff62f 100644 --- a/src/ec/google/chromeec/acpi/ec.asl +++ b/src/ec/google/chromeec/acpi/ec.asl @@ -374,7 +374,7 @@ #ifdef EC_ENABLE_TABLET_EVENT \_SB.DPTF.TPET() #endif -#ifdef EC_ENABLE_TBMC_DEVICE +#if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC_ACPI_TABLET_DEVICE) Notify (TBMC, 0x80) #endif } @@ -547,7 +547,7 @@ #include "pd.asl" #endif -#ifdef EC_ENABLE_TBMC_DEVICE +#if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC_ACPI_TABLET_DEVICE) #include "tbmc.asl" #endif } -- To view, visit https://review.coreboot.org/28108 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie7d7301c2a11c3ae32b870b724018832200b49eb Gerrit-Change-Number: 28108 Gerrit-PatchSet: 1 Gerrit-Owner: Matt Delco <delco(a)chromium.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2018