coreboot-gerrit August 2018

coreboot-gerrit@coreboot.org

1 participants
1120 discussions

Change in coreboot[master]: lib/fit_payload: Add coreboot tables support for FDT.
by Patrick Rudolph (Code Review) 16 Aug '18

16 Aug '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28104 ) Change subject: lib/fit_payload: Add coreboot tables support for FDT. ...................................................................... Patch Set 7: Code-Review+1 (3 comments) https://review.coreboot.org/#/c/28104/7/src/lib/fit_payload.c File src/lib/fit_payload.c: https://review.coreboot.org/#/c/28104/7/src/lib/fit_payload.c@103 PS7, Line 103: tables And strappings https://review.coreboot.org/#/c/28104/7/src/lib/fit_payload.c@153 PS7, Line 153: userspace Why userspace ? I'd use the term payload here https://review.coreboot.org/#/c/28104/7/src/lib/fit_payload.c@202 PS7, Line 202: add_cb_fdt_data(dt) Should be after dt_apply_fixups(), as it could remove and regenerate the whole devicetree. -- To view, visit https://review.coreboot.org/28104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib714a021a24f51407558f484cd97aa58ecd43977 Gerrit-Change-Number: 28104 Gerrit-PatchSet: 7 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 16 Aug 2018 08:17:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/octopus/variants/fleex: Increase weida touchscreen reset delay
by Crystal Lin (Code Review) 16 Aug '18

16 Aug '18

Crystal Lin has uploaded this change for review. ( https://review.coreboot.org/28115 Change subject: mb/google/octopus/variants/fleex: Increase weida touchscreen reset delay ...................................................................... mb/google/octopus/variants/fleex: Increase weida touchscreen reset delay Weida touchscreen controller needs 130 ms delay after reset BUG=b:111102092 BRANCH=master TEST=Verify touchscreen on fleex works with this change Change-Id: Ia86c3acf3c0e09ca05cc1681113672b546f830a0 Signed-off-by: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com> --- M src/mainboard/google/octopus/variants/fleex/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/28115/1 diff --git a/src/mainboard/google/octopus/variants/fleex/overridetree.cb b/src/mainboard/google/octopus/variants/fleex/overridetree.cb index fdd8404..179b8f4 100644 --- a/src/mainboard/google/octopus/variants/fleex/overridetree.cb +++ b/src/mainboard/google/octopus/variants/fleex/overridetree.cb @@ -50,7 +50,7 @@ register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)" register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" - register "generic.reset_delay_ms" = "4" + register "generic.reset_delay_ms" = "130" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_213)" register "generic.enable_delay_ms" = "2" register "generic.has_power_resource" = "1" -- To view, visit https://review.coreboot.org/28115 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia86c3acf3c0e09ca05cc1681113672b546f830a0 Gerrit-Change-Number: 28115 Gerrit-PatchSet: 1 Gerrit-Owner: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com>

1 0

Change in coreboot[master]: security/tpm: Fix TPM 1.2 state machine issues
by Patrick Georgi (Code Review) 16 Aug '18

16 Aug '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/28085 ) Change subject: security/tpm: Fix TPM 1.2 state machine issues ...................................................................... Patch Set 3: Looks reasonable to me, but I don't know enough about the nitty gritty details of TPM states. Randall, what do you think? -- To view, visit https://review.coreboot.org/28085 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ided110e0c1889b302e29acac6d8d2341f97eb10b Gerrit-Change-Number: 28085 Gerrit-PatchSet: 3 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Randall Spangler <randall(a)spanglers.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Thu, 16 Aug 2018 07:58:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lib/fit_payload: Add coreboot tables support for FDT.
by Philipp Deppenwiese (Code Review) 16 Aug '18

16 Aug '18

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28104 to look at the new patch set (#7). Change subject: lib/fit_payload: Add coreboot tables support for FDT. ...................................................................... lib/fit_payload: Add coreboot tables support for FDT. * Copy code of depthcharge boot/coreboot.c and modify it. * Add const to last parameter of dt_add_string_prop function. Change-Id: Ib714a021a24f51407558f484cd97aa58ecd43977 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M src/include/device_tree.h M src/lib/device_tree.c M src/lib/fit_payload.c 3 files changed, 75 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/28104/7 -- To view, visit https://review.coreboot.org/28104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib714a021a24f51407558f484cd97aa58ecd43977 Gerrit-Change-Number: 28104 Gerrit-PatchSet: 7 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org>

1 0

Change in coreboot[master]: lib/fit_payload: Add coreboot tables support for FDT.
by Philipp Deppenwiese (Code Review) 16 Aug '18

16 Aug '18

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28104 to look at the new patch set (#6). Change subject: lib/fit_payload: Add coreboot tables support for FDT. ...................................................................... lib/fit_payload: Add coreboot tables support for FDT. * Copy code of depthcharge boot/coreboot.c and modify it. * Add const to last parameter of dt_add_string_prop function. Change-Id: Ib714a021a24f51407558f484cd97aa58ecd43977 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M src/include/device_tree.h M src/lib/device_tree.c M src/lib/fit_payload.c 3 files changed, 75 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/28104/6 -- To view, visit https://review.coreboot.org/28104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib714a021a24f51407558f484cd97aa58ecd43977 Gerrit-Change-Number: 28104 Gerrit-PatchSet: 6 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org>

1 0

Change in coreboot[master]: lib/fit_payload: Add coreboot tables support for FDT.
by Philipp Deppenwiese (Code Review) 16 Aug '18

16 Aug '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/28104 ) Change subject: lib/fit_payload: Add coreboot tables support for FDT. ...................................................................... Patch Set 5: done -- To view, visit https://review.coreboot.org/28104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib714a021a24f51407558f484cd97aa58ecd43977 Gerrit-Change-Number: 28104 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 16 Aug 2018 07:18:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lib/fit_payload: Add coreboot tables support for FDT.
by Philipp Deppenwiese (Code Review) 16 Aug '18

16 Aug '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28104 to look at the new patch set (#5). Change subject: lib/fit_payload: Add coreboot tables support for FDT. ...................................................................... lib/fit_payload: Add coreboot tables support for FDT. * Copy code of depthcharge boot/coreboot.c and modify it. * Add const to last parameter of dt_add_string_prop function. Change-Id: Ib714a021a24f51407558f484cd97aa58ecd43977 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M src/include/device_tree.h M src/lib/device_tree.c M src/lib/fit_payload.c 3 files changed, 74 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/28104/5 -- To view, visit https://review.coreboot.org/28104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib714a021a24f51407558f484cd97aa58ecd43977 Gerrit-Change-Number: 28104 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org>

1 0

Change in coreboot[master]: Snappy:TESTONLY Test setting is correct.
by TungYang Huang (Code Review) 16 Aug '18

16 Aug '18

Hello Tony Huang, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28098 to look at the new patch set (#2). Change subject: Snappy:TESTONLY Test setting is correct. ...................................................................... Snappy:TESTONLY Test setting is correct. BUG=None TEST=None Change-Id: Ieb6c859bba3aa2e53dfc491465188dccdfce3f40 Signed-off-by: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/reef/variants/snappy/mainboard.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/28098/2 -- To view, visit https://review.coreboot.org/28098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ieb6c859bba3aa2e53dfc491465188dccdfce3f40 Gerrit-Change-Number: 28098 Gerrit-PatchSet: 2 Gerrit-Owner: TungYang Huang <Tony-Huang(a)quantatw.com> Gerrit-Reviewer: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mainboard/google/nocturne: turn off cams in D3
by Lijian Zhao (Code Review) 16 Aug '18

16 Aug '18

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/28073 ) Change subject: mainboard/google/nocturne: turn off cams in D3 ...................................................................... Patch Set 1: Can't find some proper documentation described that more clearly. Other than ACPI spec itself, https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/device-po… may also have some high level descriptions. Okay, so go back to the real problem itself. Without _PR3, nocturne can still enter s0ix state properly with same level of power consumption? On my side, all the reference platform with MIPI camera support all have _PR3 there, in early stage people still use _PS0 and _PS3 to put the code directly, but later all switch to _PR0 and _PR3 with _ON and _OFF inside power resources. For the privacy LED always on issue, what about move some the turn off programming to _STA that will be loaded as first input of driver? Or maybe move the programing to pre-OS stage to coreboot? Using windbg to log ACPI event through AMLI debugger may be easier to understand the sequence I believe. -- To view, visit https://review.coreboot.org/28073 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id52c2499c3b7577f03395cc9ca2460f25b80e13f Gerrit-Change-Number: 28073 Gerrit-PatchSet: 1 Gerrit-Owner: Matt Delco <delco(a)chromium.org> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Matt Delco <delco(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Comment-Date: Thu, 16 Aug 2018 06:18:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/common/block: Add WHL 2-core SKU
by Lijian Zhao (Code Review) 16 Aug '18

16 Aug '18

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/28111 ) Change subject: soc/intel/common/block: Add WHL 2-core SKU ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/28111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b2707568702a5fbae3e9495ca53df34613a542 Gerrit-Change-Number: 28111 Gerrit-PatchSet: 1 Gerrit-Owner: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 16 Aug 2018 05:36:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2018