coreboot-gerrit August 2018

coreboot-gerrit@coreboot.org

1 participants
1120 discussions

Change in coreboot[master]: intel/common/block: Fix issues found by klockwork
by John Zhao (Code Review) 16 Aug '18

16 Aug '18

John Zhao has posted comments on this change. ( https://review.coreboot.org/28060 ) Change subject: intel/common/block: Fix issues found by klockwork ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/28060/2/src/soc/intel/common/block/cpu/mp_i… File src/soc/intel/common/block/cpu/mp_init.c: https://review.coreboot.org/#/c/28060/2/src/soc/intel/common/block/cpu/mp_i… PS2, Line 138: soc_init_cpus(dev->link_list); > wrap it with […] done -- To view, visit https://review.coreboot.org/28060 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e7caa15a3911e05ff346d338493673af5318a51 Gerrit-Change-Number: 28060 Gerrit-PatchSet: 3 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Thu, 16 Aug 2018 17:33:42 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: intel/common/block: Fix issues found by klockwork
by John Zhao (Code Review) 16 Aug '18

16 Aug '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28060 to look at the new patch set (#3). Change subject: intel/common/block: Fix issues found by klockwork ...................................................................... intel/common/block: Fix issues found by klockwork src/soc/intel/common/block/cpu/mp_init.c Function init_cpus: Pointer dev checked for NULL may be dereferenced. src/soc/intel/common/block/graphics/graphics.c Function graphics_get_bar: Pointer dev returned from call may be NULL and will be dereferenced. BRANCH=None TEST=Built & booted Yorp board. Change-Id: I5e7caa15a3911e05ff346d338493673af5318a51 Signed-off-by: John Zhao <john.zhao(a)intel.com> --- M src/soc/intel/common/block/cpu/mp_init.c M src/soc/intel/common/block/graphics/graphics.c 2 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/28060/3 -- To view, visit https://review.coreboot.org/28060 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5e7caa15a3911e05ff346d338493673af5318a51 Gerrit-Change-Number: 28060 Gerrit-PatchSet: 3 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: sandybridge/raminit_common.c: fix printram statement
by Felix Held (Code Review) 16 Aug '18

16 Aug '18

Felix Held has posted comments on this change. ( https://review.coreboot.org/28117 ) Change subject: sandybridge/raminit_common.c: fix printram statement ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/28117 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddea8cc71dc1fb33d46b22dd19e39bf1c1257555 Gerrit-Change-Number: 28117 Gerrit-PatchSet: 2 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 16 Aug 2018 17:06:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: configs: Add various common non-default mainboards
by Martin Roth (Code Review) 16 Aug '18

16 Aug '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28118 ) Change subject: configs: Add various common non-default mainboards ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28118 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib463f578c97a212d0729aa6f54b7b6fba33e0478 Gerrit-Change-Number: 28118 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 16 Aug 2018 16:48:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/tpm: Fix TPM 1.2 state machine issues
by Philipp Deppenwiese (Code Review) 16 Aug '18

16 Aug '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/28085 ) Change subject: security/tpm: Fix TPM 1.2 state machine issues ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/28085/3/src/drivers/tpm/tpm.c File src/drivers/tpm/tpm.c: https://review.coreboot.org/#/c/28085/3/src/drivers/tpm/tpm.c@35 PS3, Line 35: if (result == TPM_E_MUST_REBOOT) : do_global_reset(); > > This code isn't used for Chrome OS. But maybe we should somehow check for the reboot count […] The code is not compiled into vboot because it makes use of its own secdata implementation. This is just an driver for normal TPM usage. -- To view, visit https://review.coreboot.org/28085 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ided110e0c1889b302e29acac6d8d2341f97eb10b Gerrit-Change-Number: 28085 Gerrit-PatchSet: 3 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Randall Spangler <randall(a)spanglers.com> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Thu, 16 Aug 2018 16:46:44 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: security/tpm: Fix TPM 1.2 state machine issues
by Vadim Bendebury (Code Review) 16 Aug '18

16 Aug '18

Vadim Bendebury has posted comments on this change. ( https://review.coreboot.org/28085 ) Change subject: security/tpm: Fix TPM 1.2 state machine issues ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/28085/3/src/drivers/tpm/tpm.c File src/drivers/tpm/tpm.c: https://review.coreboot.org/#/c/28085/3/src/drivers/tpm/tpm.c@35 PS3, Line 35: if (result == TPM_E_MUST_REBOOT) : do_global_reset(); > This code isn't used for Chrome OS. But maybe we should somehow check for the reboot count how come - how is TPM 1.2 initialized on Chrome OS devices? -- To view, visit https://review.coreboot.org/28085 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ided110e0c1889b302e29acac6d8d2341f97eb10b Gerrit-Change-Number: 28085 Gerrit-PatchSet: 3 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Randall Spangler <randall(a)spanglers.com> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Thu, 16 Aug 2018 16:30:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sandybridge/raminit_common.c: fix printram statement
by Iru Cai (Code Review) 16 Aug '18

16 Aug '18

Hello Arthur Heymans, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28117 to look at the new patch set (#2). Change subject: sandybridge/raminit_common.c: fix printram statement ...................................................................... sandybridge/raminit_common.c: fix printram statement Change-Id: Iddea8cc71dc1fb33d46b22dd19e39bf1c1257555 Signed-off-by: Iru Cai <mytbk920423(a)gmail.com> --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 8 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/28117/2 -- To view, visit https://review.coreboot.org/28117 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iddea8cc71dc1fb33d46b22dd19e39bf1c1257555 Gerrit-Change-Number: 28117 Gerrit-PatchSet: 2 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/basecode: Add support for updating microcode in the field
by build bot (Jenkins) (Code Review) 16 Aug '18

16 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27369 ) Change subject: soc/intel/basecode: Add support for updating microcode in the field ...................................................................... Patch Set 17: (4 comments) https://review.coreboot.org/#/c/27369/17/src/soc/intel/common/basecode/fw_u… File src/soc/intel/common/basecode/fw_update/ucode_update.c: https://review.coreboot.org/#/c/27369/17/src/soc/intel/common/basecode/fw_u… PS17, Line 39: die("Failed to restart\n"); Prefer using '"%s...", __func__' to using 'restart', this function's name, in a string https://review.coreboot.org/#/c/27369/17/src/soc/intel/common/basecode/fw_u… PS17, Line 74: printk (BIOS_ERR, "Slot ucode not found!\n"); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/27369/17/src/soc/intel/common/basecode/fw_u… PS17, Line 84: printk (BIOS_ERR, "Staging area could not be initialized!\n"); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/27369/17/src/soc/intel/common/basecode/fw_u… PS17, Line 104: printk (BIOS_ERR, "Staging area could not be mapped!\n"); space prohibited between function name and open parenthesis '(' -- To view, visit https://review.coreboot.org/27369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab6ba36a2eb587f331fe522c778e2c430c8eb655 Gerrit-Change-Number: 27369 Gerrit-PatchSet: 17 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dhaval Sharma <dhaval.v.sharma(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Thu, 16 Aug 2018 15:48:34 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: security/tpm: Fix TPM 1.2 state machine issues
by Philipp Deppenwiese (Code Review) 16 Aug '18

16 Aug '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/28085 ) Change subject: security/tpm: Fix TPM 1.2 state machine issues ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/28085/3/src/drivers/tpm/tpm.c File src/drivers/tpm/tpm.c: https://review.coreboot.org/#/c/28085/3/src/drivers/tpm/tpm.c@35 PS3, Line 35: if (result == TPM_E_MUST_REBOOT) : do_global_reset(); > If the TPM is in a bad state, you could get stuck rebooting here forever. […] This code isn't used for Chrome OS. But maybe we should somehow check for the reboot count -- To view, visit https://review.coreboot.org/28085 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ided110e0c1889b302e29acac6d8d2341f97eb10b Gerrit-Change-Number: 28085 Gerrit-PatchSet: 3 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Randall Spangler <randall(a)spanglers.com> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Thu, 16 Aug 2018 15:12:22 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lib/fit_payload: Add coreboot tables support for FDT.
by Philipp Deppenwiese (Code Review) 16 Aug '18

16 Aug '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/28104 ) Change subject: lib/fit_payload: Add coreboot tables support for FDT. ...................................................................... Patch Set 8: done -- To view, visit https://review.coreboot.org/28104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib714a021a24f51407558f484cd97aa58ecd43977 Gerrit-Change-Number: 28104 Gerrit-PatchSet: 8 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 16 Aug 2018 15:08:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2018