coreboot-gerrit August 2018

coreboot-gerrit@coreboot.org

1 participants
1120 discussions

Change in coreboot[master]: mb/google/poppy/variant/nami: Tune Fan speed
by TH Lin (Code Review) 17 Aug '18

17 Aug '18

TH Lin has uploaded this change for review. ( https://review.coreboot.org/28186 Change subject: mb/google/poppy/variant/nami: Tune Fan speed ...................................................................... mb/google/poppy/variant/nami: Tune Fan speed Rescale DFPS table from 10% Level to 5% level BUG=b:112438998#3 BRANCH=nami TEST=emerge-nami coreboot chromeos-bootimage Test image with dptf.dv Change-Id: I680ee589872e998ba69735cb03728e2d83f187cc Signed-off-by: T.H. Lin <t.h_lin(a)quanta.corp-partner.google.com> --- M src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl 1 file changed, 37 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/28186/1 diff --git a/src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl b/src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl index 03567fc..caf3689 100644 --- a/src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl @@ -41,6 +41,16 @@ #define DPTF_TSR1_ACTIVE_AC3 42 #define DPTF_TSR1_ACTIVE_AC4 39 +#define DPTF_TSR2_SENSOR_ID 2 +#define DPTF_TSR2_SENSOR_NAME "Thermal_Sensor_Remote_CPU" +#define DPTF_TSR2_PASSIVE 75 +#define DPTF_TSR2_CRITICAL 125 +#define DPTF_TSR2_ACTIVE_AC0 50 +#define DPTF_TSR2_ACTIVE_AC1 47 +#define DPTF_TSR2_ACTIVE_AC2 45 +#define DPTF_TSR2_ACTIVE_AC3 42 +#define DPTF_TSR2_ACTIVE_AC4 39 + #define DPTF_ENABLE_CHARGER #define DPTF_ENABLE_FAN_CONTROL @@ -61,12 +71,26 @@ * These are initial reference values. */ /* Control, Trip Point, Speed, NoiseLevel, Power */ - Package () {90, 0xFFFFFFFF, 6700, 220, 2200}, - Package () {69, 0xFFFFFFFF, 5800, 180, 1800}, - Package () {56, 0xFFFFFFFF, 5000, 145, 1450}, - Package () {46, 0xFFFFFFFF, 4900, 115, 1150}, - Package () {36, 0xFFFFFFFF, 3900, 90, 900}, - Package () { 0, 0xFFFFFFFF, 0, 0, 0} + Package () {100, 0xFFFFFFFF, 6700, 250, 2500}, + Package () {90, 0xFFFFFFFF, 6300, 225, 2250}, + Package () {85, 0xFFFFFFFF, 6000, 210, 2100}, + Package () {80, 0xFFFFFFFF, 5800, 200, 2000}, + Package () {75, 0xFFFFFFFF, 5400, 185, 1850}, + Package () {70, 0xFFFFFFFF, 5000, 175, 1750}, + Package () {65, 0xFFFFFFFF, 4700, 160, 1600}, + Package () {60, 0xFFFFFFFF, 4400, 150, 1500}, + Package () {55, 0xFFFFFFFF, 4100, 135, 1350}, + Package () {50, 0xFFFFFFFF, 3800, 125, 1250}, + Package () {45, 0xFFFFFFFF, 3500, 110, 1100}, + Package () {40, 0xFFFFFFFF, 3300, 100, 1000}, + Package () {35, 0xFFFFFFFF, 2900, 85, 800}, + Package () {30, 0xFFFFFFFF, 2500, 75, 750}, + Package () {25, 0xFFFFFFFF, 2000, 60, 600}, + Package () {20, 0xFFFFFFFF, 1500, 50, 500}, + Package () {15, 0xFFFFFFFF, 1000, 35, 350}, + Package () {10, 0xFFFFFFFF, 800, 25, 250}, + Package () {5, 0xFFFFFFFF, 500, 10, 150}, + Package () {0, 0xFFFFFFFF, 0, 0, 50} }) Name (DART, Package () { @@ -87,6 +111,10 @@ Package () { \_SB.DPTF.TFN1, \_SB.DPTF.TSR1, 100, 90, 69, 56, 46, 36, 0, 0, 0, 0, 0 + }, + Package () { + \_SB.DPTF.TFN1, \_SB.DPTF.TSR2, 100, 90, 69, 56, 46, 36, 0, 0, + 0, 0, 0 } }) #endif @@ -100,6 +128,9 @@ /* CPU Throttle Effect on TSR1 */ Package () { \_SB.PCI0.B0D4, \_SB.DPTF.TSR1, 100, 1, 0, 0, 0, 0 }, + + /* CPU Throttle Effect on TSR2 */ + Package () { \_SB.PCI0.B0D4, \_SB.DPTF.TSR2, 100, 1, 0, 0, 0, 0 }, }) Name (MPPC, Package () -- To view, visit https://review.coreboot.org/28186 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I680ee589872e998ba69735cb03728e2d83f187cc Gerrit-Change-Number: 28186 Gerrit-PatchSet: 1 Gerrit-Owner: TH Lin <t.h_lin(a)quanta.corp-partner.google.com>

1 0

Change in coreboot[master]: coreboot-sdk: Add libjaylink-dev for future flashrom builds
by Patrick Georgi (Code Review) 17 Aug '18

17 Aug '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/28165 ) Change subject: coreboot-sdk: Add libjaylink-dev for future flashrom builds ...................................................................... coreboot-sdk: Add libjaylink-dev for future flashrom builds Change-Id: I13c5464cd0b5bc9c21d7b4831a0b7fdd9fbc85c6 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/28165 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martinroth(a)google.com> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Martin Roth: Looks good to me, approved diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile index 6c590df..412362f 100644 --- a/util/docker/coreboot-sdk/Dockerfile +++ b/util/docker/coreboot-sdk/Dockerfile @@ -43,6 +43,7 @@ libglib2.0-dev \ libgmp-dev \ libisl-dev \ + libjaylink-dev \ liblzma-dev \ libncurses5-dev \ libpci-dev \ -- To view, visit https://review.coreboot.org/28165 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I13c5464cd0b5bc9c21d7b4831a0b7fdd9fbc85c6 Gerrit-Change-Number: 28165 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: coreboot-sdk: Add libjaylink-dev for future flashrom builds
by Patrick Georgi (Code Review) 17 Aug '18

17 Aug '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/28165 ) Change subject: coreboot-sdk: Add libjaylink-dev for future flashrom builds ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28165 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13c5464cd0b5bc9c21d7b4831a0b7fdd9fbc85c6 Gerrit-Change-Number: 28165 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 17 Aug 2018 08:34:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: coreboot-sdk: Add libjaylink-dev for future flashrom builds
by Nico Huber (Code Review) 17 Aug '18

17 Aug '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28165 ) Change subject: coreboot-sdk: Add libjaylink-dev for future flashrom builds ...................................................................... Patch Set 1: > How soon do you need this updated on the builders? There's no rush, review is still in progress (and we can wait with submission afterwards if need be). -- To view, visit https://review.coreboot.org/28165 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13c5464cd0b5bc9c21d7b4831a0b7fdd9fbc85c6 Gerrit-Change-Number: 28165 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 17 Aug 2018 07:51:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/common/block: Add WHL 2-core SKU
by Furquan Shaikh (Code Review) 17 Aug '18

17 Aug '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/28111 ) Change subject: soc/intel/common/block: Add WHL 2-core SKU ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b2707568702a5fbae3e9495ca53df34613a542 Gerrit-Change-Number: 28111 Gerrit-PatchSet: 1 Gerrit-Owner: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 17 Aug 2018 06:04:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs
by Gwendal Grignou (Code Review) 17 Aug '18

17 Aug '18

Gwendal Grignou has posted comments on this change. ( https://review.coreboot.org/28112 ) Change subject: nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/28112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78cc4852d42fcda6209fedce1ce91236b5814571 Gerrit-Change-Number: 28112 Gerrit-PatchSet: 2 Gerrit-Owner: Enrico Granata <egranata(a)chromium.org> Gerrit-Reviewer: Enrico Granata <egranata(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 17 Aug 2018 00:17:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs
by Furquan Shaikh (Code Review) 16 Aug '18

16 Aug '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/28112 ) Change subject: nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/28112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78cc4852d42fcda6209fedce1ce91236b5814571 Gerrit-Change-Number: 28112 Gerrit-PatchSet: 2 Gerrit-Owner: Enrico Granata <egranata(a)chromium.org> Gerrit-Reviewer: Enrico Granata <egranata(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 16 Aug 2018 23:45:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs
by Enrico Granata (Code Review) 16 Aug '18

16 Aug '18

Enrico Granata has posted comments on this change. ( https://review.coreboot.org/28112 ) Change subject: nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs ...................................................................... Patch Set 1: (2 comments) Two lines of patch & two comments. Good ratio there :-) https://review.coreboot.org/#/c/28112/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nocturne/devicetree.cb: https://review.coreboot.org/#/c/28112/1/src/mainboard/google/poppy/variants… PS1, Line 312: register "reg_prox_ctrl10" = "0x1F" > nit: 1f Done https://review.coreboot.org/#/c/28112/1/src/mainboard/google/poppy/variants… PS1, Line 353: register "reg_prox_ctrl10" = "0x1F" > nit: 1f Done -- To view, visit https://review.coreboot.org/28112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78cc4852d42fcda6209fedce1ce91236b5814571 Gerrit-Change-Number: 28112 Gerrit-PatchSet: 1 Gerrit-Owner: Enrico Granata <egranata(a)chromium.org> Gerrit-Reviewer: Enrico Granata <egranata(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 16 Aug 2018 23:44:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs
by Enrico Granata (Code Review) 16 Aug '18

16 Aug '18

Hello Gwendal Grignou, build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/28112 to look at the new patch set (#2). Change subject: nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs ...................................................................... nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs This is meant to solve an issue where the proximity sensor may fluctuate between CLOSE / FAR in rapid succession upon the user removing their hand from the unit, before settling on the correct output. Using the hardware debouncing filter solves this issue and removes the spurious fluctuations. BRANCH=None BUG=None TEST=manual on Nocturne, observing events come in Change-Id: I78cc4852d42fcda6209fedce1ce91236b5814571 Signed-off-by: Enrico Granata <egranata(a)chromium.org> --- M src/mainboard/google/poppy/variants/nocturne/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/28112/2 -- To view, visit https://review.coreboot.org/28112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I78cc4852d42fcda6209fedce1ce91236b5814571 Gerrit-Change-Number: 28112 Gerrit-PatchSet: 2 Gerrit-Owner: Enrico Granata <egranata(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs
by Gwendal Grignou (Code Review) 16 Aug '18

16 Aug '18

Gwendal Grignou has posted comments on this change. ( https://review.coreboot.org/28112 ) Change subject: nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/28112/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nocturne/devicetree.cb: https://review.coreboot.org/#/c/28112/1/src/mainboard/google/poppy/variants… PS1, Line 312: register "reg_prox_ctrl10" = "0x1F" nit: 1f https://review.coreboot.org/#/c/28112/1/src/mainboard/google/poppy/variants… PS1, Line 353: register "reg_prox_ctrl10" = "0x1F" nit: 1f -- To view, visit https://review.coreboot.org/28112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78cc4852d42fcda6209fedce1ce91236b5814571 Gerrit-Change-Number: 28112 Gerrit-PatchSet: 1 Gerrit-Owner: Enrico Granata <egranata(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 16 Aug 2018 23:42:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2018