coreboot-gerrit August 2018

coreboot-gerrit@coreboot.org

1 participants
1120 discussions

Change in coreboot[master]: tint: introduce the new tint build system with checksum verification
by build bot (Jenkins) (Code Review) 16 Aug '18

16 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23856 ) Change subject: tint: introduce the new tint build system with checksum verification ...................................................................... Patch Set 6: (15 comments) https://review.coreboot.org/#/c/23856/6/payloads/external/tint/generate_cor… File payloads/external/tint/generate_core.sh: https://review.coreboot.org/#/c/23856/6/payloads/external/tint/generate_cor… PS6, Line 38: sed -n "/^${start}/,/^${end}/{/^${start}/{p;n};{p}}" $source >> $destination line over 80 characters https://review.coreboot.org/#/c/23856/6/payloads/external/tint/generate_cor… PS6, Line 40: sed -n "/^${start}/,/^${end}/{/^${start}/{p;n};/^${end}/{q};{p}}" $source >> $destination line over 80 characters https://review.coreboot.org/#/c/23856/6/payloads/external/tint/generate_cor… PS6, Line 54: FUNCTIONS="please_install searchtool download compute_hash error_hash_mismatch verify_hash unpack_and_patch" line over 80 characters https://review.coreboot.org/#/c/23856/6/payloads/external/tint/generate_cor… PS6, Line 64: import_from_file $buildgcc $corescript "# Find all the required tools" "# Allow" last_line_disabled || exit "$?" line over 80 characters https://review.coreboot.org/#/c/23856/6/payloads/external/tint/generate_cor… PS6, Line 70: import_from_file $buildgcc $corescript "if \[ \"\$HALT_FOR_TOOLS" "fi" || exit "$?" line over 80 characters https://review.coreboot.org/#/c/23856/6/payloads/external/tint/generate_cor… PS6, Line 86: sed -i -e "s/\tknown_hash=\"\$(get_known_hash.*/\tknown_hash=\"\$2\"/g" $corescript line over 80 characters https://review.coreboot.org/#/c/23856/6/payloads/external/tint/generate_cor… PS6, Line 95: # Insert prepare_${package} function call between the unpack and patch operations line over 80 characters https://review.coreboot.org/#/c/23856/6/payloads/external/tint/generate_cor… PS6, Line 99: sed -i -e "/\$TAR \$FLAGS \"\$(basename \"\$archive\")\"/a prepare_\${package} || exit \"\$?\"" $corescript line over 80 characters https://review.coreboot.org/#/c/23856/6/payloads/external/tint/tintify_core… File payloads/external/tint/tintify_core.sh: https://review.coreboot.org/#/c/23856/6/payloads/external/tint/tintify_core… PS6, Line 12: # <TINT_ARCHIVE_LINK> <TINT_ARCHIVE> <TINT_DIR> <TINT_CHECKSUM> line over 80 characters https://review.coreboot.org/#/c/23856/6/payloads/external/tint/tintify_core… PS6, Line 54: echo "if [ ! -z ./\${TINT_DIR} ] && [ -e ./\${TINT_DIR}/debian ]; then" >> $tintified line over 80 characters https://review.coreboot.org/#/c/23856/6/payloads/external/tint/tintify_core… PS6, Line 55: echo "rm -rf ./\${TINT_DIR}/debian ./\${TINT_DIR}/typedefs.h ./\${TINT_DIR}/Makefile;" >> $tintified line over 80 characters https://review.coreboot.org/#/c/23856/6/payloads/external/tint/tintify_core… PS6, Line 70: sed -i -e "/download() {/a package=\$1\narchive_link=\"\$(eval echo \\\\\$\$package\"_ARCHIVE_LINK\")\"" $tintified line over 80 characters https://review.coreboot.org/#/c/23856/6/payloads/external/tint/tintify_core… PS6, Line 72: sed -i -e "s/$download_showing_percentage \"\$archive$./\1_link\"\nreplace_plus_with_minus/g" $tintified line over 80 characters https://review.coreboot.org/#/c/23856/6/payloads/external/tint/tintify_core… PS6, Line 83: echo "printf \"Downloaded TINT tarball ... \${green}ok\${NC}\\n\"" >> ${tintified} line over 80 characters https://review.coreboot.org/#/c/23856/6/payloads/external/tint/tintify_core… PS6, Line 87: echo "printf \"Unpacked and patched TINT... \${green}ok\${NC}\\n\"" >> ${tintified} line over 80 characters -- To view, visit https://review.coreboot.org/23856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d24f222d1b92030b81bba3951e243a2a9f37290 Gerrit-Change-Number: 23856 Gerrit-PatchSet: 6 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 16 Aug 2018 23:24:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: intel/common/block: Fix issues found by klockwork
by Martin Roth (Code Review) 16 Aug '18

16 Aug '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28060 ) Change subject: intel/common/block: Fix issues found by klockwork ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/28060 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e7caa15a3911e05ff346d338493673af5318a51 Gerrit-Change-Number: 28060 Gerrit-PatchSet: 4 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Comment-Date: Thu, 16 Aug 2018 22:09:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: coreboot-sdk: Add libjaylink-dev for future flashrom builds
by Martin Roth (Code Review) 16 Aug '18

16 Aug '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28165 ) Change subject: coreboot-sdk: Add libjaylink-dev for future flashrom builds ...................................................................... Patch Set 1: How soon do you need this updated on the builders? -- To view, visit https://review.coreboot.org/28165 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13c5464cd0b5bc9c21d7b4831a0b7fdd9fbc85c6 Gerrit-Change-Number: 28165 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 16 Aug 2018 21:25:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: coreboot-sdk: Add libjaylink-dev for future flashrom builds
by Martin Roth (Code Review) 16 Aug '18

16 Aug '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28165 ) Change subject: coreboot-sdk: Add libjaylink-dev for future flashrom builds ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28165 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13c5464cd0b5bc9c21d7b4831a0b7fdd9fbc85c6 Gerrit-Change-Number: 28165 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 16 Aug 2018 21:25:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: intel/common/block: Fix issues found by klockwork
by John Zhao (Code Review) 16 Aug '18

16 Aug '18

John Zhao has posted comments on this change. ( https://review.coreboot.org/28060 ) Change subject: intel/common/block: Fix issues found by klockwork ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/#/c/28060/2/src/soc/intel/common/block/graphics… File src/soc/intel/common/block/graphics/graphics.c: https://review.coreboot.org/#/c/28060/2/src/soc/intel/common/block/graphics… PS2, Line 43: if (!dev || !dev-> > if (!dev || !dev->enabled) done -- To view, visit https://review.coreboot.org/28060 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e7caa15a3911e05ff346d338493673af5318a51 Gerrit-Change-Number: 28060 Gerrit-PatchSet: 4 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Thu, 16 Aug 2018 21:22:35 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: intel/common/block: Fix issues found by klockwork
by John Zhao (Code Review) 16 Aug '18

16 Aug '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28060 to look at the new patch set (#4). Change subject: intel/common/block: Fix issues found by klockwork ...................................................................... intel/common/block: Fix issues found by klockwork src/soc/intel/common/block/cpu/mp_init.c Function init_cpus: Pointer dev checked for NULL may be dereferenced. src/soc/intel/common/block/graphics/graphics.c Function graphics_get_bar: Pointer dev returned from call may be NULL and will be dereferenced. BRANCH=None TEST=Built & booted Yorp board. Change-Id: I5e7caa15a3911e05ff346d338493673af5318a51 Signed-off-by: John Zhao <john.zhao(a)intel.com> --- M src/soc/intel/common/block/cpu/mp_init.c M src/soc/intel/common/block/graphics/graphics.c 2 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/28060/4 -- To view, visit https://review.coreboot.org/28060 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5e7caa15a3911e05ff346d338493673af5318a51 Gerrit-Change-Number: 28060 Gerrit-PatchSet: 4 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: coreboot-sdk: Add libjaylink-dev for future flashrom builds
by Nico Huber (Code Review) 16 Aug '18

16 Aug '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/28165 Change subject: coreboot-sdk: Add libjaylink-dev for future flashrom builds ...................................................................... coreboot-sdk: Add libjaylink-dev for future flashrom builds Change-Id: I13c5464cd0b5bc9c21d7b4831a0b7fdd9fbc85c6 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/28165/1 diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile index 6c590df..412362f 100644 --- a/util/docker/coreboot-sdk/Dockerfile +++ b/util/docker/coreboot-sdk/Dockerfile @@ -43,6 +43,7 @@ libglib2.0-dev \ libgmp-dev \ libisl-dev \ + libjaylink-dev \ liblzma-dev \ libncurses5-dev \ libpci-dev \ -- To view, visit https://review.coreboot.org/28165 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I13c5464cd0b5bc9c21d7b4831a0b7fdd9fbc85c6 Gerrit-Change-Number: 28165 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: lib/fit_payload: Add coreboot tables support for FDT.
by Julius Werner (Code Review) 16 Aug '18

16 Aug '18

Julius Werner has posted comments on this change. ( https://review.coreboot.org/28104 ) Change subject: lib/fit_payload: Add coreboot tables support for FDT. ...................................................................... Patch Set 8: (6 comments) https://review.coreboot.org/#/c/28104/8/src/lib/device_tree.c File src/lib/device_tree.c: https://review.coreboot.org/#/c/28104/8/src/lib/device_tree.c@865 PS8, Line 865: (void *) Well, this just moves the problem around. I meant that we should make the value arguments of *all* the dt_add_xxx_prop() functions const (I guess you really only need to change dt_add_bin_prop(), the others can convert implicitly from non-const to const). And (struct device_tree_prop).prop.data would then also need to become a pointer to const. Then, I think, this should be possible without any casts. https://review.coreboot.org/#/c/28104/7/src/lib/fit_payload.c File src/lib/fit_payload.c: https://review.coreboot.org/#/c/28104/7/src/lib/fit_payload.c@153 PS7, Line 153: payload.* > Why userspace ? I'd use the term payload here These values are currently not read by any kernel driver, they're just there for consumption through /proc/device-tree. Of course, that may change, so "expose ... to the OS" or something might be more accurate. https://review.coreboot.org/#/c/28104/7/src/lib/fit_payload.c@202 PS7, Line 202: > Should be after dt_apply_fixups(), as it could remove and regenerate the whole devicetree. That's... not really the idea of fixups, though, they're just supposed to be for minor additions or changes. In depthcharge, this *is* a fixup, and execution order between different fixups is random. Anyway, shouldn't make a difference where it runs. https://review.coreboot.org/#/c/28104/8/src/lib/fit_payload.c File src/lib/fit_payload.c: https://review.coreboot.org/#/c/28104/8/src/lib/fit_payload.c@139 PS8, Line 139: includes the coreboot table). */ nit: Does this fit on one line? https://review.coreboot.org/#/c/28104/8/src/lib/fit_payload.c@140 PS8, Line 140: cbmem_get_imd I'm confused... how does this build? cbmem_get_imd() is a static inline in another .c file. Actually, is it possible that Jenkins doesn't test any of this code because none of our platforms enables CONFIG_PAYLOAD_FIT_SUPPORT? It would be great if you guys could select that for the Cavium board so that we have test coverage for this code. (Please also test that this gives you the right numbers. You can dump this via /proc/device-tree/firmware/coreboot/reg, and it should give you big-endian numbers that match the CBMEM ranges coreboot prints during boot.) https://review.coreboot.org/#/c/28104/8/src/lib/fit_payload.c@153 PS8, Line 153: payload.*/ nit: Doesn't need to wrap -- To view, visit https://review.coreboot.org/28104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib714a021a24f51407558f484cd97aa58ecd43977 Gerrit-Change-Number: 28104 Gerrit-PatchSet: 8 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 16 Aug 2018 21:02:42 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: libpayload/x86/exception: Add ability to handle user defined interrupts
by Julius Werner (Code Review) 16 Aug '18

16 Aug '18

Julius Werner has posted comments on this change. ( https://review.coreboot.org/28100 ) Change subject: libpayload/x86/exception: Add ability to handle user defined interrupts ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/28100/1/payloads/libpayload/arch/x86/except… File payloads/libpayload/arch/x86/exception.c: https://review.coreboot.org/#/c/28100/1/payloads/libpayload/arch/x86/except… PS1, Line 165: /* Handle user defined vectors */ > Ah, I haven't tested with a gdb build yet, so I haven't seen it break. […] If you think that's better, sure. I doubt we'll ever have enough handlers for the list to really be a problem, but it doesn't make a big difference either way (you're trading the time to iterate through a tiny list vs. the time to initialize a 2K array of function pointers). -- To view, visit https://review.coreboot.org/28100 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c2583c7c3d9be4a06a25e546e64399f2b0620c Gerrit-Change-Number: 28100 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Thu, 16 Aug 2018 20:45:00 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: ec/google/chromeec: Fix ACPI FWTS error
by Duncan Laurie (Code Review) 16 Aug '18

16 Aug '18

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/28123 ) Change subject: ec/google/chromeec: Fix ACPI FWTS error ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbda1649ec2eb9cdf9966d4ec92bfd203bb78d07 Gerrit-Change-Number: 28123 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 16 Aug 2018 19:26:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2018