coreboot-gerrit August 2018

coreboot-gerrit@coreboot.org

1 participants
1120 discussions

Change in coreboot[master]: mb/lenovo/x1_carbon_gen1: add vbt
by Alexander Couzens (Code Review) 01 Aug '18

01 Aug '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27782 to look at the new patch set (#4). Change subject: mb/lenovo/x1_carbon_gen1: add vbt ...................................................................... mb/lenovo/x1_carbon_gen1: add vbt Extracted from live running Thinkpad x1 carbon gen1 with vendor firmware. Thanks to Igor Lee. Change-Id: Id59517d9040c98e67a42fbce537f42f6b0c6db2d Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu> Tested-by: Igor Lee <getrun(a)gmail.com> --- M src/mainboard/lenovo/x1_carbon_gen1/Kconfig A src/mainboard/lenovo/x1_carbon_gen1/data.vbt 2 files changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/27782/4 -- To view, visit https://review.coreboot.org/27782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id59517d9040c98e67a42fbce537f42f6b0c6db2d Gerrit-Change-Number: 27782 Gerrit-PatchSet: 4 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mainboard/google/kahlee: Add PSPP override setting
by Marc Jones (Code Review) 01 Aug '18

01 Aug '18

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/27784 Change subject: mainboard/google/kahlee: Add PSPP override setting ...................................................................... mainboard/google/kahlee: Add PSPP override setting Add default PSPP AGESA setting for Kahlee/Grunt mainboards. BUG=b:112020107 TEST= build test Change-Id: I8a8605402379de88a04f3a16553c308513fa1531 Signed-off-by: Marc Jones <marcj303(a)gmail.com> --- M src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/27784/1 diff --git a/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c b/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c index 648329f..62adbcc 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c +++ b/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c @@ -148,6 +148,7 @@ VOID __weak OemCustomizeInitEarly(IN OUT AMD_EARLY_PARAMS *InitEarly) { InitEarly->GnbConfig.PcieComplexList = (void *)&PcieComplex; + InitEarly->GnbConfig.PsppPolicy = PsppDisabled; InitEarly->PlatformConfig.GnbAzI2sBusSelect = GnbAcpI2sBus; InitEarly->PlatformConfig.GnbAzI2sBusPinConfig = GnbAcp2Tx4RxBluetooth; -- To view, visit https://review.coreboot.org/27784 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8a8605402379de88a04f3a16553c308513fa1531 Gerrit-Change-Number: 27784 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Call AMD ALIB method with AC/DC state
by Marc Jones (Code Review) 01 Aug '18

01 Aug '18

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/27785 Change subject: soc/amd/stoneyridge: Call AMD ALIB method with AC/DC state ...................................................................... soc/amd/stoneyridge: Call AMD ALIB method with AC/DC state AMD ALIB Function 1 accepts the AC/DC startup state. This is reported to be required for AMD PSPP settings. BUG=b:112020107 TEST= build test Change-Id: Ibb6c872d84745217912956c15d6ca2e8ba387561 Signed-off-by: Marc Jones <marcj303(a)gmail.com> --- M src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/27785/1 diff --git a/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl b/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl index 81964ba..2855b23 100644 --- a/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl +++ b/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl @@ -14,6 +14,8 @@ * GNU General Public License for more details. */ +External(\_SB.ALIB, MethodObj) + /* System Bus */ /* _SB.PCI0 */ @@ -138,7 +140,7 @@ * 2. Get PCI Interrupt routing from ACPI VSM, this * value is based on user choice in BIOS setup. */ -Method(_INI, 0) { +Method(_INI, 0, Serialized) { /* DBGO("\\_SB\\_INI\n") */ /* DBGO(" DSDT.ASL code from ") */ /* DBGO(__DATE__) */ @@ -154,6 +156,17 @@ /* Determine the OS we're running on */ OSFL() + + /* Send ALIB Function 1 the AC/DC state */ + Name(F1BF, Buffer(0x03){}) + CreateWordField(F1BF, 0, F1SZ) + CreateByteField(F1BF, 2, F1DA) + + Store(3, F1SZ) + Store(\PWRS, F1DA) + + \_SB.ALIB(1, F1BF) + } /* End Method(_SB._INI) */ Method(OSFL, 0){ -- To view, visit https://review.coreboot.org/27785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibb6c872d84745217912956c15d6ca2e8ba387561 Gerrit-Change-Number: 27785 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>

1 0

Change in coreboot[master]: soc/amd/common: Remove PSPP override setting
by Marc Jones (Code Review) 01 Aug '18

01 Aug '18

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/27783 Change subject: soc/amd/common: Remove PSPP override setting ...................................................................... soc/amd/common: Remove PSPP override setting For some reason the PSPP setting was being overwritten in the common code. Remove the setting and allow the oem customize function to make the setting. BUG=b:112020107 TEST= build test Change-Id: If7f4511a71f725fedd60d33552656850e50d955d Signed-off-by: Marc Jones <marcj303(a)gmail.com> --- M src/soc/amd/common/block/pi/agesawrapper.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/27783/1 diff --git a/src/soc/amd/common/block/pi/agesawrapper.c b/src/soc/amd/common/block/pi/agesawrapper.c index c2a799a..c464b29 100644 --- a/src/soc/amd/common/block/pi/agesawrapper.c +++ b/src/soc/amd/common/block/pi/agesawrapper.c @@ -130,8 +130,6 @@ OemCustomizeInitEarly(EarlyParams); - EarlyParams->GnbConfig.PsppPolicy = PsppDisabled; - timestamp_add_now(TS_AGESA_INIT_EARLY_START); status = AmdInitEarly(EarlyParams); timestamp_add_now(TS_AGESA_INIT_EARLY_DONE); -- To view, visit https://review.coreboot.org/27783 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If7f4511a71f725fedd60d33552656850e50d955d Gerrit-Change-Number: 27783 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>

1 0

Change in coreboot[master]: mb/lenovo/x1_carbon_gen1: add vbt
by Alexander Couzens (Code Review) 01 Aug '18

01 Aug '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27782 to look at the new patch set (#3). Change subject: mb/lenovo/x1_carbon_gen1: add vbt ...................................................................... mb/lenovo/x1_carbon_gen1: add vbt Extracted from live running Thinkpad x1 cargon gen1 with vendor firmware. Thanks to Igor Lee. Change-Id: Id59517d9040c98e67a42fbce537f42f6b0c6db2d Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu> Tested-by: Igor Lee <getrun(a)gmail.com> --- M src/mainboard/lenovo/x1_carbon_gen1/Kconfig A src/mainboard/lenovo/x1_carbon_gen1/data.vbt 2 files changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/27782/3 -- To view, visit https://review.coreboot.org/27782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id59517d9040c98e67a42fbce537f42f6b0c6db2d Gerrit-Change-Number: 27782 Gerrit-PatchSet: 3 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/lenovo/x1_carbon_gen1: add support for hynix memory
by Alexander Couzens (Code Review) 01 Aug '18

01 Aug '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27781 to look at the new patch set (#3). Change subject: mb/lenovo/x1_carbon_gen1: add support for hynix memory ...................................................................... mb/lenovo/x1_carbon_gen1: add support for hynix memory All different memory configuration should be supported by now. Thanks to Igor Lee. Change-Id: Ib93c0e3cbdc29cbf6cff26292df4fbbb8208082f Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu> Tested-by: Igor Lee <getrun(a)gmail.com> --- M src/mainboard/lenovo/x1_carbon_gen1/romstage.c M src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc A src/mainboard/lenovo/x1_carbon_gen1/spd/hynix.hex 3 files changed, 20 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/27781/3 -- To view, visit https://review.coreboot.org/27781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib93c0e3cbdc29cbf6cff26292df4fbbb8208082f Gerrit-Change-Number: 27781 Gerrit-PatchSet: 3 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/lenovo/x1_carbon_gen1: add support for hynix memory
by build bot (Jenkins) (Code Review) 01 Aug '18

01 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27781 ) Change subject: mb/lenovo/x1_carbon_gen1: add support for hynix memory ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/27781/2/src/mainboard/lenovo/x1_carbon_gen1… File src/mainboard/lenovo/x1_carbon_gen1/romstage.c: https://review.coreboot.org/#/c/27781/2/src/mainboard/lenovo/x1_carbon_gen1… PS2, Line 112: die("Unsupported Memory. (detected 'reserved' memory configuration)."); line over 80 characters -- To view, visit https://review.coreboot.org/27781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib93c0e3cbdc29cbf6cff26292df4fbbb8208082f Gerrit-Change-Number: 27781 Gerrit-PatchSet: 2 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 01 Aug 2018 18:48:44 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/lenovo/x1_carbon_gen1: add support for hynix memory
by Alexander Couzens (Code Review) 01 Aug '18

01 Aug '18

Alexander Couzens has uploaded a new patch set (#2). ( https://review.coreboot.org/27781 ) Change subject: mb/lenovo/x1_carbon_gen1: add support for hynix memory ...................................................................... mb/lenovo/x1_carbon_gen1: add support for hynix memory All different memory configuration should be supported by now. Thanks to Igor Lee. Change-Id: Ib93c0e3cbdc29cbf6cff26292df4fbbb8208082f Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu> Tested-by: Igor Lee <gerun(a)gmail.com> --- M src/mainboard/lenovo/x1_carbon_gen1/romstage.c M src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc A src/mainboard/lenovo/x1_carbon_gen1/spd/hynix.hex 3 files changed, 20 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/27781/2 -- To view, visit https://review.coreboot.org/27781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib93c0e3cbdc29cbf6cff26292df4fbbb8208082f Gerrit-Change-Number: 27781 Gerrit-PatchSet: 2 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/lenovo/x1_carbon_gen1: add support for hynix memory
by build bot (Jenkins) (Code Review) 01 Aug '18

01 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27781 ) Change subject: mb/lenovo/x1_carbon_gen1: add support for hynix memory ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27781/1/src/mainboard/lenovo/x1_carbon_gen1… File src/mainboard/lenovo/x1_carbon_gen1/romstage.c: https://review.coreboot.org/#/c/27781/1/src/mainboard/lenovo/x1_carbon_gen1… PS1, Line 112: die("Unsupported Memory. (detected 'reserved' memory configuration)."); line over 80 characters -- To view, visit https://review.coreboot.org/27781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib93c0e3cbdc29cbf6cff26292df4fbbb8208082f Gerrit-Change-Number: 27781 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 01 Aug 2018 18:46:56 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/lenovo/x1_carbon_gen1: add vbt
by Alexander Couzens (Code Review) 01 Aug '18

01 Aug '18

Alexander Couzens has uploaded this change for review. ( https://review.coreboot.org/27782 Change subject: mb/lenovo/x1_carbon_gen1: add vbt ...................................................................... mb/lenovo/x1_carbon_gen1: add vbt Extracted from live running Thinkpad x1 cargon gen1 with vendor firmware. Thanks to Igor Lee. Change-Id: Id59517d9040c98e67a42fbce537f42f6b0c6db2d Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu> Tested-by: Igor Lee <gerun(a)gmail.com> --- M src/mainboard/lenovo/x1_carbon_gen1/Kconfig A src/mainboard/lenovo/x1_carbon_gen1/data.vbt 2 files changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/27782/1 diff --git a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig index abd3dc3..d33018e 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig +++ b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig @@ -22,6 +22,7 @@ select MAINBOARD_HAS_TPM1 select MAINBOARD_HAS_LIBGFXINIT select GFX_GMA_INTERNAL_IS_LVDS + select INTEL_GMA_HAVE_VBT # Workaround for EC/KBC IRQ1. select SERIRQ_CONTINUOUS_MODE diff --git a/src/mainboard/lenovo/x1_carbon_gen1/data.vbt b/src/mainboard/lenovo/x1_carbon_gen1/data.vbt new file mode 100644 index 0000000..d0b9c41 --- /dev/null +++ b/src/mainboard/lenovo/x1_carbon_gen1/data.vbt Binary files differ -- To view, visit https://review.coreboot.org/27782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id59517d9040c98e67a42fbce537f42f6b0c6db2d Gerrit-Change-Number: 27782 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2018