coreboot-gerrit August 2018

coreboot-gerrit@coreboot.org

1 participants
1120 discussions

Change in coreboot[master]: mb/google/poppy/variants/atlas: Do not override icc_max
by Gaggery Tsai (Code Review) 02 Aug '18

02 Aug '18

Gaggery Tsai has posted comments on this change. ( https://review.coreboot.org/27791 ) Change subject: mb/google/poppy/variants/atlas: Do not override icc_max ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/27791/2/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/atlas/devicetree.cb: https://review.coreboot.org/#/c/27791/2/src/mainboard/google/poppy/variants… PS2, Line 103: 0 I think 0 is confusing. Suggest to completely removing this line. Also, add one line comment above saying the icc max setting is covered in soc code for different CPU sku. -- To view, visit https://review.coreboot.org/27791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7eb3499b7bea9ab2c49e1f299e2dbb688c8d1c33 Gerrit-Change-Number: 27791 Gerrit-PatchSet: 2 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-Comment-Date: Thu, 02 Aug 2018 05:14:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sandybridge/raminit_mrc: remove reference to report_platform_info()
by Matt DeVillier (Code Review) 02 Aug '18

02 Aug '18

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/27793 Change subject: sandybridge/raminit_mrc: remove reference to report_platform_info() ...................................................................... sandybridge/raminit_mrc: remove reference to report_platform_info() Commit ef8c559e537ed10d8054ca6a72ca50e0531fde95 [nb/intel/sandybridge/report_platform: Move remaining code to sb folder] moved reporting code to the southbridge, but missed a reference in the non-default MRC raminit path (so testing missed it). Remove invalid reference to fix compilation error. Test: build google/link with MRC raminit option selected Change-Id: I270a95ac53fbc9f8792f375908cf91585261f6a1 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/northbridge/intel/sandybridge/raminit_mrc.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/27793/1 diff --git a/src/northbridge/intel/sandybridge/raminit_mrc.c b/src/northbridge/intel/sandybridge/raminit_mrc.c index c7e6e1f..39b540c 100644 --- a/src/northbridge/intel/sandybridge/raminit_mrc.c +++ b/src/northbridge/intel/sandybridge/raminit_mrc.c @@ -190,8 +190,6 @@ struct sys_info sysinfo; int (*entry) (struct pei_data *pei_data) __attribute__((regparm(1))); - report_platform_info(); - /* Wait for ME to be ready */ intel_early_me_init(); intel_early_me_uma_size(); -- To view, visit https://review.coreboot.org/27793 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I270a95ac53fbc9f8792f375908cf91585261f6a1 Gerrit-Change-Number: 27793 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

Change in coreboot[master]: mb/google/poppy/variants/atlas: Do not override icc_max
by Caveh Jalali (Code Review) 02 Aug '18

02 Aug '18

Hello caveh jalali, Gaggery Tsai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27791 to look at the new patch set (#2). Change subject: mb/google/poppy/variants/atlas: Do not override icc_max ...................................................................... mb/google/poppy/variants/atlas: Do not override icc_max Skylake SoC code now sets the icc_max based on the CPU SKU, so we should not hard-code it in the device tree. BUG=b:110890675 BRANCH=None TEST=boots on atlas Change-Id: I7eb3499b7bea9ab2c49e1f299e2dbb688c8d1c33 Signed-off-by: Caveh Jalali <caveh(a)chromium.org> --- M src/mainboard/google/poppy/variants/atlas/devicetree.cb 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/27791/2 -- To view, visit https://review.coreboot.org/27791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7eb3499b7bea9ab2c49e1f299e2dbb688c8d1c33 Gerrit-Change-Number: 27791 Gerrit-PatchSet: 2 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org>

1 0

Change in coreboot[master]: mb/google/poppy/variants/atlas: Not not override icc_max
by caveh jalali (Code Review) 02 Aug '18

02 Aug '18

caveh jalali has posted comments on this change. ( https://review.coreboot.org/27791 ) Change subject: mb/google/poppy/variants/atlas: Not not override icc_max ...................................................................... Patch Set 1: Code-Review-1 need to wait for https://review.coreboot.org/#/c/coreboot/+/27610/ to land. -- To view, visit https://review.coreboot.org/27791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7eb3499b7bea9ab2c49e1f299e2dbb688c8d1c33 Gerrit-Change-Number: 27791 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-Comment-Date: Thu, 02 Aug 2018 01:59:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/atlas: Not not override icc_max
by Caveh Jalali (Code Review) 02 Aug '18

02 Aug '18

Hello caveh jalali, I'd like you to do a code review. Please visit https://review.coreboot.org/27791 to review the following change. Change subject: mb/google/poppy/variants/atlas: Not not override icc_max ...................................................................... mb/google/poppy/variants/atlas: Not not override icc_max Skylake SoC code now sets the icc_max based on the CPU SKU, so we should not hard-code it in the device tree. BUG=b:110890675 BRANCH=None TEST=boots on atlas Change-Id: I7eb3499b7bea9ab2c49e1f299e2dbb688c8d1c33 Signed-off-by: Caveh Jalali <caveh(a)chromium.org> --- M src/mainboard/google/poppy/variants/atlas/devicetree.cb 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/27791/1 diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb index f6610df..98a49bc 100644 --- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb +++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb @@ -86,7 +86,7 @@ #| Psi4Enable | 1 | 1 | 1 | 1 | #| ImonSlope | 0 | 0 | 0 | 0 | #| ImonOffset | 0 | 0 | 0 | 0 | - #| IccMax | 4A | 24A | 24A | 24A | + #| IccMax | 0 | 0 | 0 | 0 | #| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V | #| AcLoadline | 14.9 | 5 | 5.7 | 4.57 | #| DcLoadline | 14.2 | 4.86 | 4.2 | 4.3 | @@ -100,7 +100,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(4), + .icc_max = 0, .voltage_limit = 1520, .ac_loadline = 1490, .dc_loadline = 1420, @@ -115,7 +115,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(24), + .icc_max = 0, .voltage_limit = 1520, .ac_loadline = 500, .dc_loadline = 486, @@ -130,7 +130,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(24), + .icc_max = 0, .voltage_limit = 1520, .ac_loadline = 570, .dc_loadline = 420, @@ -145,7 +145,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(24), + .icc_max = 0, .voltage_limit = 1520, .ac_loadline = 457, .dc_loadline = 430, -- To view, visit https://review.coreboot.org/27791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7eb3499b7bea9ab2c49e1f299e2dbb688c8d1c33 Gerrit-Change-Number: 27791 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org>

1 0

Change in coreboot[master]: mb/google/poppy/variants/atlas: Apply correct AC/DC loadlines
by Caveh Jalali (Code Review) 02 Aug '18

02 Aug '18

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/27788 ) Change subject: mb/google/poppy/variants/atlas: Apply correct AC/DC loadlines ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/27788 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e85b885a6d3a1db9a980d12f3cfc036a771422a Gerrit-Change-Number: 27788 Gerrit-PatchSet: 2 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 02 Aug 2018 00:46:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/atlas: Apply correct AC/DC loadlines
by Gaggery Tsai (Code Review) 02 Aug '18

02 Aug '18

Hello Nick Vaccaro, Caveh Jalali, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27788 to look at the new patch set (#2). Change subject: mb/google/poppy/variants/atlas: Apply correct AC/DC loadlines ...................................................................... mb/google/poppy/variants/atlas: Apply correct AC/DC loadlines This patch applies correct AC/DC loadline settings for Atlas from VRTT report. BUG=b:111419622 BRANCH=None TEST=emerge-atlas coreboot chromeos-bootimage and use DbC to check the AC/DC loadline settgins. Change-Id: I6e85b885a6d3a1db9a980d12f3cfc036a771422a Signed-off-by: Gaggery Tsai <gaggery.tsai(a)intel.com> --- M src/mainboard/google/poppy/variants/atlas/devicetree.cb 1 file changed, 9 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/27788/2 -- To view, visit https://review.coreboot.org/27788 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6e85b885a6d3a1db9a980d12f3cfc036a771422a Gerrit-Change-Number: 27788 Gerrit-PatchSet: 2 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/mb/google/poppy/variants/atlas: Apply correct AC/DC loadlines
by Caveh Jalali (Code Review) 02 Aug '18

02 Aug '18

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/27788 ) Change subject: src/mb/google/poppy/variants/atlas: Apply correct AC/DC loadlines ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27788/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/27788/1//COMMIT_MSG@7 PS1, Line 7: src oh, and you can drop the "src/" component. -- To view, visit https://review.coreboot.org/27788 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e85b885a6d3a1db9a980d12f3cfc036a771422a Gerrit-Change-Number: 27788 Gerrit-PatchSet: 1 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 01 Aug 2018 23:03:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/mb/google/poppy/variants/atlas: Apply correct AC/DC loadlines
by Caveh Jalali (Code Review) 02 Aug '18

02 Aug '18

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/27788 ) Change subject: src/mb/google/poppy/variants/atlas: Apply correct AC/DC loadlines ...................................................................... Patch Set 1: Code-Review+1 the syntax is BUG=b: instead of BUG=b/ -- To view, visit https://review.coreboot.org/27788 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e85b885a6d3a1db9a980d12f3cfc036a771422a Gerrit-Change-Number: 27788 Gerrit-PatchSet: 1 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 01 Aug 2018 23:01:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/crypto: Add crypto primitives for hashing data
by Philipp Deppenwiese (Code Review) 02 Aug '18

02 Aug '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22872 ) Change subject: security/crypto: Add crypto primitives for hashing data ...................................................................... Patch Set 27: Main issue here is the problem that not all people using vboot and hash algorithm/security can work and are used without vboot support. Just saying mrc cache... -- To view, visit https://review.coreboot.org/22872 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I807084ebfffdc159fe95c45b4e5f0820bbfee5e1 Gerrit-Change-Number: 22872 Gerrit-PatchSet: 27 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Anonymous Coward (1001824) Gerrit-Reviewer: Anonymous Coward (1001845) Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Randall Spangler <randall(a)spanglers.com> Gerrit-Comment-Date: Wed, 01 Aug 2018 22:31:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2018