Gaggery Tsai has posted comments on this change. ( https://review.coreboot.org/27791 )
Change subject: mb/google/poppy/variants/atlas: Do not override icc_max ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/27791/2/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/atlas/devicetree.cb:
https://review.coreboot.org/#/c/27791/2/src/mainboard/google/poppy/variants/... PS2, Line 103: 0 I think 0 is confusing. Suggest to completely removing this line. Also, add one line comment above saying the icc max setting is covered in soc code for different CPU sku.