coreboot-gerrit August 2018

coreboot-gerrit@coreboot.org

1 participants
1120 discussions

Change in coreboot[master]: mb/lenovo/x1_carbon_gen1: add support for hynix memory
by Alexander Couzens (Code Review) 01 Aug '18

01 Aug '18

Alexander Couzens has uploaded this change for review. ( https://review.coreboot.org/27781 Change subject: mb/lenovo/x1_carbon_gen1: add support for hynix memory ...................................................................... mb/lenovo/x1_carbon_gen1: add support for hynix memory All different memory configuration should be supported by now. Thanks to Igor Lee. Change-Id: Ib93c0e3cbdc29cbf6cff26292df4fbbb8208082f Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu> Tested-by: Igor Lee <gerun(a)gmail.com> --- M src/mainboard/lenovo/x1_carbon_gen1/romstage.c M src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc A src/mainboard/lenovo/x1_carbon_gen1/spd/hynix.hex 3 files changed, 20 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/27781/1 diff --git a/src/mainboard/lenovo/x1_carbon_gen1/romstage.c b/src/mainboard/lenovo/x1_carbon_gen1/romstage.c index 029d867..87fca34 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/romstage.c +++ b/src/mainboard/lenovo/x1_carbon_gen1/romstage.c @@ -98,7 +98,7 @@ /* 4gb model = 0, 8gb model = 1 */ /* int extended_memory_version = get_gpio(44); */ - /* TODO: how do they differ? Guess only one slot is connected */ + /* TODO: how do they differ? 4GB with hynix has to slot populated */ /* * GPIO45 GPIO25 @@ -108,10 +108,8 @@ * 1 1 reserved */ - /* We only support elpida and samsung. - Because the spd data is missing. */ - if (spd_index != 0 && spd_index != 2) - die("Unsupported Memory. Please add your SPD dump to coreboot."); + if (spd_index == 3) + die("Unsupported Memory. (detected 'reserved' memory configuration)."); memory = get_spd_data(spd_index); memcpy(&spd[0], memory, 256); diff --git a/src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc b/src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc index 0c90826..f5c233a 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc +++ b/src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc @@ -16,7 +16,7 @@ SPD_BIN = $(obj)/spd.bin SPD_SOURCES = elpida.hex # 0b0000 Single Channel 2GB -SPD_SOURCES += samsung.hex # 0b0001 placeholder +SPD_SOURCES += hynix.hex # 0b0001 2GiB SPD_SOURCES += samsung.hex # 0b0010 4GiB SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f)) diff --git a/src/mainboard/lenovo/x1_carbon_gen1/spd/hynix.hex b/src/mainboard/lenovo/x1_carbon_gen1/spd/hynix.hex new file mode 100644 index 0000000..111745c --- /dev/null +++ b/src/mainboard/lenovo/x1_carbon_gen1/spd/hynix.hex @@ -0,0 +1,16 @@ +92 11 0b 03 04 00 00 02 03 52 01 08 0c 00 20 00 +6c 78 6c 3c 6c 11 20 81 28 08 3c 3c 01 68 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 65 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 ae ea +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -- To view, visit https://review.coreboot.org/27781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib93c0e3cbdc29cbf6cff26292df4fbbb8208082f Gerrit-Change-Number: 27781 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Enable mbox command for ISL VR c-state...
by Shelley Chen (Code Review) 01 Aug '18

01 Aug '18

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/27780 Change subject: mb/google/poppy/variants/nami: Enable mbox command for ISL VR c-state issue ...................................................................... mb/google/poppy/variants/nami: Enable mbox command for ISL VR c-state issue There is a potential IMVP8 issue for KBL that affects Intersil VRs Nami is using one of the affected parts. The fix is to use an updated microcode and also send a mailbox box command from FSP. BUG=b:112081534 BRANCH=None TEST=Build and boot Nami Verify that suspend/resume and consecutive reboots are working Change-Id: I6ec18a4c3fae6a66cf8a95685d91a8ba51e2697c Signed-off-by: Shelley Chen <shchen(a)google.com> --- M src/mainboard/google/poppy/variants/nami/devicetree.cb 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/27780/1 diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb index 54d989f..fe105cb 100644 --- a/src/mainboard/google/poppy/variants/nami/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb @@ -59,6 +59,10 @@ register "PmTimerDisabled" = "1" register "VmxEnable" = "1" + # Intersil VR c-state issue workaround + # send VR mailbox command for IA/GT/SA rails + register "IslVrCmd" = "2" + register "pirqa_routing" = "PCH_IRQ11" register "pirqb_routing" = "PCH_IRQ10" register "pirqc_routing" = "PCH_IRQ11" -- To view, visit https://review.coreboot.org/27780 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6ec18a4c3fae6a66cf8a95685d91a8ba51e2697c Gerrit-Change-Number: 27780 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com>

1 0

Change in coreboot[master]: util/ectool: Handle arguments more carefully
by Evgeny Zinoviev (Code Review) 01 Aug '18

01 Aug '18

Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/27778 ) Change subject: util/ectool: Handle arguments more carefully ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/27778/2/util/ectool/ectool.c File util/ectool/ectool.c: https://review.coreboot.org/#/c/27778/2/util/ectool/ectool.c@95 PS2, Line 95: 1 Why not 0? -- To view, visit https://review.coreboot.org/27778 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I40dbd2a51d018eb549e9b2fa4365b3e4f9355bff Gerrit-Change-Number: 27778 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 01 Aug 2018 15:54:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/cbmem: Handle arguments more carefully
by Arthur Heymans (Code Review) 01 Aug '18

01 Aug '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27777 to look at the new patch set (#2). Change subject: util/cbmem: Handle arguments more carefully ...................................................................... util/cbmem: Handle arguments more carefully Check if an argument is given and if not print the usage. Check if all arguments are handled by getopt and if not print the usage. Change-Id: Iccbb65ca768a62791af54afd9b7903495bc690af Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M util/cbmem/cbmem.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/27777/2 -- To view, visit https://review.coreboot.org/27777 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iccbb65ca768a62791af54afd9b7903495bc690af Gerrit-Change-Number: 27777 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/ectool: Handle arguments more carefully
by Arthur Heymans (Code Review) 01 Aug '18

01 Aug '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27778 to look at the new patch set (#2). Change subject: util/ectool: Handle arguments more carefully ...................................................................... util/ectool: Handle arguments more carefully Check if an argument is given and if not print the usage. Check if all arguments are handled by getopt and if not print the usage. Change-Id: I40dbd2a51d018eb549e9b2fa4365b3e4f9355bff Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M util/ectool/ectool.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/27778/2 -- To view, visit https://review.coreboot.org/27778 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I40dbd2a51d018eb549e9b2fa4365b3e4f9355bff Gerrit-Change-Number: 27778 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: drivers/spi: Winbond specific write-protection enable
by build bot (Jenkins) (Code Review) 01 Aug '18

01 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25105 ) Change subject: drivers/spi: Winbond specific write-protection enable ...................................................................... Patch Set 13: (1 comment) https://review.coreboot.org/#/c/25105/13/src/drivers/spi/winbond.c File src/drivers/spi/winbond.c: https://review.coreboot.org/#/c/25105/13/src/drivers/spi/winbond.c@39 PS13, Line 39: #define CMD_VOLTILE_SREG_WREN 0x50 /* Write Enable for Volatile Status Register */ line over 80 characters -- To view, visit https://review.coreboot.org/25105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3765b013855538eca37bc7800d3f9d5d09b8402 Gerrit-Change-Number: 25105 Gerrit-PatchSet: 13 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Wed, 01 Aug 2018 15:32:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/ectool: Print usage when no arguments are given
by Arthur Heymans (Code Review) 01 Aug '18

01 Aug '18

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/27778 Change subject: util/ectool: Print usage when no arguments are given ...................................................................... util/ectool: Print usage when no arguments are given Change-Id: I40dbd2a51d018eb549e9b2fa4365b3e4f9355bff Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M util/ectool/ectool.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/27778/1 diff --git a/util/ectool/ectool.c b/util/ectool/ectool.c index be5a899..05a893c 100644 --- a/util/ectool/ectool.c +++ b/util/ectool/ectool.c @@ -90,6 +90,11 @@ {0, 0, 0, 0} }; + if (argv[1] == NULL) { + print_usage(argv[0]); + exit(1); + } + while ((opt = getopt_long(argc, argv, "vh?Vidqpw:z:", long_options, &option_index)) != EOF) { switch (opt) { -- To view, visit https://review.coreboot.org/27778 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I40dbd2a51d018eb549e9b2fa4365b3e4f9355bff Gerrit-Change-Number: 27778 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: util/cbmem: Print usage when no arguments are given
by Arthur Heymans (Code Review) 01 Aug '18

01 Aug '18

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/27777 Change subject: util/cbmem: Print usage when no arguments are given ...................................................................... util/cbmem: Print usage when no arguments are given Change-Id: Iccbb65ca768a62791af54afd9b7903495bc690af Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M util/cbmem/cbmem.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/27777/1 diff --git a/util/cbmem/cbmem.c b/util/cbmem/cbmem.c index 3435c4c..f567ffe 100644 --- a/util/cbmem/cbmem.c +++ b/util/cbmem/cbmem.c @@ -1268,6 +1268,10 @@ {"help", 0, 0, 'h'}, {0, 0, 0, 0} }; + + if (argv[1] == NULL) + print_usage(argv[0], 1); + while ((opt = getopt_long(argc, argv, "c1CltTLxVvh?r:", long_options, &option_index)) != EOF) { switch (opt) { -- To view, visit https://review.coreboot.org/27777 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iccbb65ca768a62791af54afd9b7903495bc690af Gerrit-Change-Number: 27777 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: security/tpm: TCPA log follow up
by Philipp Deppenwiese (Code Review) 01 Aug '18

01 Aug '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/27769 ) Change subject: security/tpm: TCPA log follow up ...................................................................... Patch Set 4: @Julius nothing good happens after 2 a.m. ;) -- To view, visit https://review.coreboot.org/27769 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I215d79eed7ad17c6ab87f0c4b14a282e519ef07d Gerrit-Change-Number: 27769 Gerrit-PatchSet: 4 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 01 Aug 2018 13:59:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/pmh7tool
by Evgeny Zinoviev (Code Review) 01 Aug '18

01 Aug '18

Evgeny Zinoviev has uploaded this change for review. ( https://review.coreboot.org/27776 Change subject: util/pmh7tool ...................................................................... util/pmh7tool A tool that dumps PMH7 registers. Change-Id: I05ccb5a9a861fe44efec794aafe1805062543d53 Signed-off-by: Evgeny Zinoviev <me(a)ch1p.com> --- A util/pmh7tool/Makefile A util/pmh7tool/pmh7tool.c A util/pmh7tool/pmh7tool.h 3 files changed, 96 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/27776/1 diff --git a/util/pmh7tool/Makefile b/util/pmh7tool/Makefile new file mode 100644 index 0000000..07a7a28 --- /dev/null +++ b/util/pmh7tool/Makefile @@ -0,0 +1,23 @@ +CC = gcc +CFLAGS = -O2 -Wall -W -Werror +PROGRAM = pmh7tool +INSTALL = /usr/bin/install +PREFIX = /usr/local + +all: $(PROGRAM) + +$(PROGRAM): pmh7tool.o + $(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS) + +install: $(PROGRAM) + $(INSTALL) $(PROGRAM) $(PREFIX)/sbin + +clean: + rm -f *.o $(PROGRAM) + +distclean: clean + +%.o: %.c + $(CC) $(CFLAGS) -c $^ -I. -o $@ + +.PHONY: all install clean distclean diff --git a/util/pmh7tool/pmh7tool.c b/util/pmh7tool/pmh7tool.c new file mode 100644 index 0000000..26807de7 --- /dev/null +++ b/util/pmh7tool/pmh7tool.c @@ -0,0 +1,62 @@ +#include <stdio.h> +#include <stdlib.h> +#include <getopt.h> +#include <sys/io.h> +#include "pmh7tool.h" + +unsigned char pmh7_register_read(int reg) +{ + outb(reg, EC_LENOVO_PMH7_ADDR); + return inb(EC_LENOVO_PMH7_DATA); +} + +void pmh7_register_write(int reg, int val) +{ + outb(reg, EC_LENOVO_PMH7_ADDR); + outb(val, EC_LENOVO_PMH7_DATA); +} + +void print_usage(const char *name) +{ + printf("usage: %s\n", name); + printf("\n" + " -h | --help: print this help\n" + " -d | --dump: print registers\n" + "\n"); + exit(1); +} + +int main(int argc, char *argv[]) +{ + int opt, option_index = 0; + static struct option long_options[] = { + {"help", 0, 0, 'h'}, + {"dump", 0, 0, 'd'}, + {0, 0, 0, 0} + }; + + while ((opt = getopt_long(argc, argv, "hd", + long_options, &option_index)) != EOF) { + switch (opt) { + case 'd': + break; + case 'h': + default: + print_usage(argv[0]); + break; + } + } + + ioperm(EC_LENOVO_PMH7_BASE, 0x100, 1); + for (int i = 0; i < 0x100; i++) { + if ((i % 0x10) == 0) { + if (i != 0) + printf("\n"); + printf("%02x: ", i); + } + printf("%02x ", pmh7_register_read(i)); + } + printf("\n"); + + return 0; +} diff --git a/util/pmh7tool/pmh7tool.h b/util/pmh7tool/pmh7tool.h new file mode 100644 index 0000000..651526f --- /dev/null +++ b/util/pmh7tool/pmh7tool.h @@ -0,0 +1,11 @@ +#ifndef PMH7TOOL_H +#define PMH7TOOL_H + +#define EC_LENOVO_PMH7_BASE 0x15e0 +#define EC_LENOVO_PMH7_ADDR (EC_LENOVO_PMH7_BASE + 0x0c) +#define EC_LENOVO_PMH7_DATA (EC_LENOVO_PMH7_BASE + 0x0e) + +unsigned char pmh7_register_read(int reg); +void pmh7_register_write(int reg, int val); + +#endif /* PMH7TOOL_H */ -- To view, visit https://review.coreboot.org/27776 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I05ccb5a9a861fe44efec794aafe1805062543d53 Gerrit-Change-Number: 27776 Gerrit-PatchSet: 1 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2018