coreboot-gerrit July 2018

coreboot-gerrit@coreboot.org

1 participants
877 discussions

Change in coreboot[master]: sifive/fu540: add empty sdram init and size functions
by Philipp Hug (Code Review) 12 Jul '18

12 Jul '18

Philipp Hug has uploaded this change for review. ( https://review.coreboot.org/27438 Change subject: sifive/fu540: add empty sdram init and size functions ...................................................................... sifive/fu540: add empty sdram init and size functions Change-Id: I65f900a3277bc8a4a83ebc8883d4a325bd690bf8 --- M src/soc/sifive/fu540/Makefile.inc A src/soc/sifive/fu540/include/soc/sdram.h A src/soc/sifive/fu540/sdram.c 3 files changed, 59 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/27438/1 diff --git a/src/soc/sifive/fu540/Makefile.inc b/src/soc/sifive/fu540/Makefile.inc index 8a2f3a6..9e7f584 100644 --- a/src/soc/sifive/fu540/Makefile.inc +++ b/src/soc/sifive/fu540/Makefile.inc @@ -19,9 +19,11 @@ romstage-y += uart.c romstage-y += media.c +romstage-y += sdram.c ramstage-y += uart.c ramstage-y += media.c +ramstage-y += sdram.c ramstage-y += cbmem.c CPPFLAGS_common += -Isrc/soc/sifive/fu540/include diff --git a/src/soc/sifive/fu540/include/soc/sdram.h b/src/soc/sifive/fu540/include/soc/sdram.h new file mode 100644 index 0000000..8610a7e --- /dev/null +++ b/src/soc/sifive/fu540/include/soc/sdram.h @@ -0,0 +1,24 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2018 Philipp Hug <philipp(a)hug.cx> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef __SOC_SIFIVE_FU540_SDRAM_H__ +#define __SOC_SIFIVE_FU540_SDRAM_H__ + +#include <types.h> + +void sdram_init(void); +size_t sdram_size_mb(void); + +#endif diff --git a/src/soc/sifive/fu540/sdram.c b/src/soc/sifive/fu540/sdram.c new file mode 100644 index 0000000..1ad36da --- /dev/null +++ b/src/soc/sifive/fu540/sdram.c @@ -0,0 +1,33 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2016 Philipp Hug <philipp(a)hug.cx> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <soc/sdram.h> + +void sdram_init(void) +{ + // TODO: implement +} + +size_t sdram_size_mb(void) +{ + static size_t size_mb = 0; + + if (!size_mb) { + // TODO: implement + size_mb = 8 * 1024; + } + + return size_mb; +} -- To view, visit https://review.coreboot.org/27438 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I65f900a3277bc8a4a83ebc8883d4a325bd690bf8 Gerrit-Change-Number: 27438 Gerrit-PatchSet: 1 Gerrit-Owner: Philipp Hug <philipp(a)hug.cx>

1 0

Change in coreboot[master]: mainboard/google/kahlee: Add more SPD files
by Raul Rangel (Code Review) 11 Jul '18

11 Jul '18

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/27437 ) Change subject: mainboard/google/kahlee: Add more SPD files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/27437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief5ed5c3ca1d96b36926f1fc84c344a8d66dcda5 Gerrit-Change-Number: 27437 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Comment-Date: Wed, 11 Jul 2018 20:30:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/kahlee: Add more SPD files
by Martin Roth (Code Review) 11 Jul '18

11 Jul '18

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/27437 Change subject: mainboard/google/kahlee: Add more SPD files ...................................................................... mainboard/google/kahlee: Add more SPD files BUG=b:111195311 TEST=Build grunt, verify SPDs are present Change-Id: Ief5ed5c3ca1d96b36926f1fc84c344a8d66dcda5 Signed-off-by: Martin Roth <martinroth(a)chromium.org> --- M src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc A src/mainboard/google/kahlee/variants/baseboard/spd/hynix-H5ANAG6NCMR-VKC.spd.hex A src/mainboard/google/kahlee/variants/baseboard/spd/samsung-K4A8G165WC-BCTD.spd.hex A src/mainboard/google/kahlee/variants/baseboard/spd/samsung-K4AAG165WB-MCTD.spd.hex 4 files changed, 102 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/27437/1 diff --git a/src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc b/src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc index 3b1631b..e6dc7e6 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc +++ b/src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc @@ -23,10 +23,10 @@ SPD_SOURCES += samsung-K4A8G165WB-BCRC # 0b0100 SPD_SOURCES += samsung-K4AAG165WB-MCRC # 0b0101 SPD_SOURCES += micron-MT40A512M16LY-075-E # 0b0110 -SPD_SOURCES += empty # 0b0111 +SPD_SOURCES += hynix-H5ANAG6NCMR-VKC # 0b0111 SPD_SOURCES += hynix-H5AN8G6NCJR-VKC # 0b1000 -SPD_SOURCES += empty # 0b1001 -SPD_SOURCES += empty # 0b1010 +SPD_SOURCES += samsung-K4A8G165WC-BCTD # 0b1001 +SPD_SOURCES += samsung-K4AAG165WB-MCTD # 0b1010 SPD_SOURCES += empty # 0b1011 SPD_SOURCES += empty # 0b1100 SPD_SOURCES += empty # 0b1101 diff --git a/src/mainboard/google/kahlee/variants/baseboard/spd/hynix-H5ANAG6NCMR-VKC.spd.hex b/src/mainboard/google/kahlee/variants/baseboard/spd/hynix-H5ANAG6NCMR-VKC.spd.hex new file mode 100644 index 0000000..e75e4c1 --- /dev/null +++ b/src/mainboard/google/kahlee/variants/baseboard/spd/hynix-H5ANAG6NCMR-VKC.spd.hex @@ -0,0 +1,33 @@ +# Hynix H5ANAG6NCMR-VKC +23 11 0C 03 85 21 91 08 00 60 00 03 01 03 00 00 +00 00 06 0D F8 3F 00 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 A8 18 28 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 0C 2B 2D 04 +16 35 23 0D 00 00 2C 0B 03 24 35 0C 03 2D 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C 00 00 00 00 00 E7 00 43 CE +0F 11 20 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 EF 55 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 AD 01 00 00 00 00 00 00 48 4D 41 41 31 47 53 +36 43 4D 52 38 4E 2D 56 4B 20 20 20 20 00 80 AD +FF 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 DD 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/kahlee/variants/baseboard/spd/samsung-K4A8G165WC-BCTD.spd.hex b/src/mainboard/google/kahlee/variants/baseboard/spd/samsung-K4A8G165WC-BCTD.spd.hex new file mode 100644 index 0000000..2688254 --- /dev/null +++ b/src/mainboard/google/kahlee/variants/baseboard/spd/samsung-K4A8G165WC-BCTD.spd.hex @@ -0,0 +1,33 @@ +# Samsung K4A8G165WC-BCTD +23 11 0C 03 45 21 00 08 00 60 00 03 02 03 00 00 +00 00 06 0D F8 3F 00 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 F0 2B 34 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 16 36 0B 35 +16 36 0B 35 00 00 16 36 0B 35 16 36 0B 35 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 87 2E +0F 11 02 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 DB 08 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 CE 00 00 00 00 00 00 00 4D 34 37 31 41 35 32 +34 34 43 42 30 2D 43 54 44 20 20 20 20 00 80 CE +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/kahlee/variants/baseboard/spd/samsung-K4AAG165WB-MCTD.spd.hex b/src/mainboard/google/kahlee/variants/baseboard/spd/samsung-K4AAG165WB-MCTD.spd.hex new file mode 100644 index 0000000..ede001a --- /dev/null +++ b/src/mainboard/google/kahlee/variants/baseboard/spd/samsung-K4AAG165WB-MCTD.spd.hex @@ -0,0 +1,33 @@ +# Samsung K4AAG165WB-MCTD +23 11 0C 03 85 21 00 08 00 60 00 03 01 03 00 00 +00 00 06 0D F8 3F 00 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 A8 18 28 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 0C 2B 2D 04 +16 35 23 0D 00 00 2C 0B 03 24 35 0C 03 2D 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C 00 00 00 00 00 E7 00 D0 4E +0F 11 20 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 EF 55 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 CE 00 00 00 00 00 00 00 4D 34 37 31 41 31 4B +34 33 42 42 31 2D 43 54 44 20 20 20 20 00 80 CE +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -- To view, visit https://review.coreboot.org/27437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ief5ed5c3ca1d96b36926f1fc84c344a8d66dcda5 Gerrit-Change-Number: 27437 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: mainboard/google/nocturne: Update GPIO_FCAM_PWR_EN
by Nick Vaccaro (Code Review) 11 Jul '18

11 Jul '18

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/27433 ) Change subject: mainboard/google/nocturne: Update GPIO_FCAM_PWR_EN ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/27433/2/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nocturne/gpio.c: https://review.coreboot.org/#/c/27433/2/src/mainboard/google/poppy/variants… PS2, Line 181: PAD_CFG_NC(GPP_D8), I left GPP_D8 configured in gpio.c on purpose, to allow camera development on preEVT2 devices as well as EVT2. GPP_D8 is a NC in EVT2, and GPP_B4 is a NC in preEVT2, so it should be safe. I filed a reminder bug for cleanup once we're ready to obsolete preEVT2 (https://b.corp.google.com/issues/110066750) -- To view, visit https://review.coreboot.org/27433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id926bd224b3392d8a61b6d8ae0509053afaa5b9e Gerrit-Change-Number: 27433 Gerrit-PatchSet: 2 Gerrit-Owner: Ricky Liang <jcliang(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Liang <jcliang(a)chromium.org> Gerrit-Reviewer: Tomasz Figa <tfiga(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Jul 2018 20:04:15 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/nocturne: Update GPIO_FCAM_PWR_EN
by Nick Vaccaro (Code Review) 11 Jul '18

11 Jul '18

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/27433 ) Change subject: mainboard/google/nocturne: Update GPIO_FCAM_PWR_EN ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27433/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h: https://review.coreboot.org/#/c/27433/1/src/mainboard/google/poppy/variants… PS1, Line 44: > Is GPP_D8 not connected now? You will have to configure it accordingly in gpio.c: https://review. […] I left GPP_D8 configured in gpio.c on purpose, to allow camera development on preEVT2 devices as well as EVT2. GPP_D8 is a NC in EVT2, and GPP_B4 is a NC in preEVT2, so it should be safe. I filed a reminder bug for cleanup once we're ready to obsolete preEVT2 (https://b.corp.google.com/issues/110066750) -- To view, visit https://review.coreboot.org/27433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id926bd224b3392d8a61b6d8ae0509053afaa5b9e Gerrit-Change-Number: 27433 Gerrit-PatchSet: 1 Gerrit-Owner: Ricky Liang <jcliang(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Liang <jcliang(a)chromium.org> Gerrit-Reviewer: Tomasz Figa <tfiga(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Jul 2018 20:01:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: buildgcc: Actually verify checksums
by Martin Roth (Code Review) 11 Jul '18

11 Jul '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/27426 ) Change subject: buildgcc: Actually verify checksums ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/27426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I132f5f86cd31a001372b19e0f81ad933916d2a83 Gerrit-Change-Number: 27426 Gerrit-PatchSet: 2 Gerrit-Owner: Hal Emmerich (1002051) Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Jul 2018 17:06:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Add Pantheon sku-id
by Furquan Shaikh (Code Review) 11 Jul '18

11 Jul '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27432 ) Change subject: mb/google/poppy/variants/nami: Add Pantheon sku-id ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/27432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ee156372754ac0e77caae5959a9ca9884de95f4 Gerrit-Change-Number: 27432 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Jul 2018 17:01:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: buildgcc: Actually verify checksums
by SolidHal (Code Review) 11 Jul '18

11 Jul '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27426 to look at the new patch set (#2). Change subject: buildgcc: Actually verify checksums ...................................................................... buildgcc: Actually verify checksums buildgcc doesn't verify the checksum of gcc downloaded using download(). This can be verified by modifyingthe gcc checksum in coreboot/util/crossgcc/sum, which won't cause a failure without this patch Change-Id: I132f5f86cd31a001372b19e0f81ad933916d2a83 Signed-off-by: Hal Emmerich <Hal(a)halemmerich.com> --- M util/crossgcc/buildgcc 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/27426/2 -- To view, visit https://review.coreboot.org/27426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I132f5f86cd31a001372b19e0f81ad933916d2a83 Gerrit-Change-Number: 27426 Gerrit-PatchSet: 2 Gerrit-Owner: SolidHal (1002051) Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: buildgcc: Actually verify checksums
by SolidHal (Code Review) 11 Jul '18

11 Jul '18

SolidHal has uploaded this change for review. ( https://review.coreboot.org/27436 Change subject: buildgcc: Actually verify checksums ...................................................................... buildgcc: Actually verify checksums buildgcc doesn't verify the checksum of gcc downloaded using download(). This can be verified by modifying the gcc checksum in coreboot/util/crossgcc/sum, which won't cause a failure without this patch Change-Id: Idcd583f853d0a3db5e6ccd25c27bc486c2c49691 Signed-off-by: Hal Emmerich <Hal(a)halemmerich.com> --- M util/crossgcc/buildgcc 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/27436/1 diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 5083773..788bb65 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -320,10 +320,10 @@ cd tarballs download_showing_percentage $archive cd .. - if ! check_sum $FILE; then - printf "\n${RED}$FILE Failed Checksum Verification${NC}\n" - exit 1 - fi + if ! check_sum $FILE; then + printf "\n${RED}$FILE Failed Checksum Verification${NC}\n" + exit 1 + fi fi if [ ! -f tarballs/$FILE ]; then -- To view, visit https://review.coreboot.org/27436 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idcd583f853d0a3db5e6ccd25c27bc486c2c49691 Gerrit-Change-Number: 27436 Gerrit-PatchSet: 1 Gerrit-Owner: SolidHal (1002051)

1 0

Change in coreboot[master]: mainboard/google/nocturne: Update GPIO_FCAM_PWR_EN
by Furquan Shaikh (Code Review) 11 Jul '18

11 Jul '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27433 ) Change subject: mainboard/google/nocturne: Update GPIO_FCAM_PWR_EN ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/27433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id926bd224b3392d8a61b6d8ae0509053afaa5b9e Gerrit-Change-Number: 27433 Gerrit-PatchSet: 2 Gerrit-Owner: Ricky Liang <jcliang(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Liang <jcliang(a)chromium.org> Gerrit-Reviewer: Tomasz Figa <tfiga(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Jul 2018 16:25:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

← Newer
1
...
58
59
60
61
62
63
64
...
88
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2018