coreboot-gerrit July 2018

coreboot-gerrit@coreboot.org

1 participants
877 discussions

Change in coreboot[master]: mainboard/google/kahlee: Enable backlight on resume
by Martin Roth (Code Review) 14 Jul '18

14 Jul '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/27488 ) Change subject: mainboard/google/kahlee: Enable backlight on resume ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27488/1/src/mainboard/google/kahlee/variant… File src/mainboard/google/kahlee/variants/baseboard/mainboard.c: https://review.coreboot.org/#/c/27488/1/src/mainboard/google/kahlee/variant… PS1, Line 32: #if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME) remove? -- To view, visit https://review.coreboot.org/27488 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I452e2ea94b508b137cf52301df5d2d1ad5c9ab70 Gerrit-Change-Number: 27488 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 15 Jul 2018 00:48:34 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/kahlee: Enable backlight in SMI APMC
by Martin Roth (Code Review) 14 Jul '18

14 Jul '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/27487 ) Change subject: mainboard/google/kahlee: Enable backlight in SMI APMC ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/27487 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf32b1a3d45971883571a829a5c0c1f8563bb1f7 Gerrit-Change-Number: 27487 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 15 Jul 2018 00:46:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/kahlee: Add mainboard resume function
by Martin Roth (Code Review) 14 Jul '18

14 Jul '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/27486 ) Change subject: mainboard/google/kahlee: Add mainboard resume function ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/27486/1/src/mainboard/google/kahlee/mainboa… File src/mainboard/google/kahlee/mainboard.c: https://review.coreboot.org/#/c/27486/1/src/mainboard/google/kahlee/mainboa… PS1, Line 193: #if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME) Is this needed here or below? https://review.coreboot.org/#/c/27486/1/src/mainboard/google/kahlee/variant… File src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h: https://review.coreboot.org/#/c/27486/1/src/mainboard/google/kahlee/variant… PS1, Line 33: #if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME) Needed? -- To view, visit https://review.coreboot.org/27486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I808734208bd1ce81428771ea203709b53db56cd3 Gerrit-Change-Number: 27486 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 15 Jul 2018 00:46:11 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add GPIO functions to SMM
by Martin Roth (Code Review) 14 Jul '18

14 Jul '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/27485 ) Change subject: soc/amd/stoneyridge: Add GPIO functions to SMM ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/27485 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id729139b02c10bdd922b3df298f8f9feb1aff745 Gerrit-Change-Number: 27485 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 15 Jul 2018 00:44:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Fix gpio_set function
by Martin Roth (Code Review) 14 Jul '18

14 Jul '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/27484 ) Change subject: soc/amd/stoneyridge: Fix gpio_set function ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/27484 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib306773ac72505977b606836bbaf3e2067324894 Gerrit-Change-Number: 27484 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 15 Jul 2018 00:43:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/gm45: Don't run the oprom when using libgfxinit
by Arthur Heymans (Code Review) 14 Jul '18

14 Jul '18

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/27490 Change subject: nb/intel/gm45: Don't run the oprom when using libgfxinit ...................................................................... nb/intel/gm45: Don't run the oprom when using libgfxinit Change-Id: Id4bffe50186e5f84d035c2f3dc44fafbc9de6456 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/gm45/gma.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/27490/1 diff --git a/src/northbridge/intel/gm45/gma.c b/src/northbridge/intel/gm45/gma.c index 606170c..6561fc7 100644 --- a/src/northbridge/intel/gm45/gma.c +++ b/src/northbridge/intel/gm45/gma.c @@ -756,7 +756,7 @@ return; mmio = res2mmio(gtt_res, 0, 0); - if (!IS_ENABLED(CONFIG_MAINBOARD_DO_NATIVE_VGA_INIT)) { + if (!IS_ENABLED(CONFIG_MAINBOARD_USE_LIBGFXINIT)) { /* PCI Init, will run VBIOS */ printk(BIOS_DEBUG, "Initialising IGD using VBIOS\n"); pci_dev_init(dev); -- To view, visit https://review.coreboot.org/27490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id4bffe50186e5f84d035c2f3dc44fafbc9de6456 Gerrit-Change-Number: 27490 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: mainboard/google/kahlee: Don't default backlight on
by Marc Jones (Code Review) 14 Jul '18

14 Jul '18

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/27489 Change subject: mainboard/google/kahlee: Don't default backlight on ...................................................................... mainboard/google/kahlee: Don't default backlight on Keep the backlight off until it is needed. BUG=b:72694972 TEST=Backlight turns on at ChromeOS splash screen, not prior. Change-Id: Ia1aba787734e2976146ecd305dd821f0b326f0db Signed-off-by: Marc Jones <marcj303(a)gmail.com> --- M src/mainboard/google/kahlee/variants/baseboard/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/27489/1 diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c index d8abe6c..db68fa4 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c +++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c @@ -211,7 +211,7 @@ PAD_GPI(GPIO_130, PULL_UP), /* GPIO_133 - APU_EDP_BKLTEN_L (backlight - Active LOW) */ - PAD_GPO(GPIO_133, LOW), + PAD_GPO(GPIO_133, HIGH), /* GPIO_135 - Unused (TP128) */ PAD_GPI(GPIO_135, PULL_UP), -- To view, visit https://review.coreboot.org/27489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia1aba787734e2976146ecd305dd821f0b326f0db Gerrit-Change-Number: 27489 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>

1 0

Change in coreboot[master]: mainboard/google/kahlee: Enable backlight on resume
by Marc Jones (Code Review) 14 Jul '18

14 Jul '18

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/27488 Change subject: mainboard/google/kahlee: Enable backlight on resume ...................................................................... mainboard/google/kahlee: Enable backlight on resume BUG=b:72694972 TEST=Backlight turns on ChromeOS resume Change-Id: I452e2ea94b508b137cf52301df5d2d1ad5c9ab70 Signed-off-by: Marc Jones <marcj303(a)gmail.com> --- M src/mainboard/google/kahlee/variants/baseboard/mainboard.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/27488/1 diff --git a/src/mainboard/google/kahlee/variants/baseboard/mainboard.c b/src/mainboard/google/kahlee/variants/baseboard/mainboard.c index c873299..54743ef 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/mainboard.c +++ b/src/mainboard/google/kahlee/variants/baseboard/mainboard.c @@ -15,6 +15,9 @@ #include <ec/google/chromeec/ec.h> #include <baseboard/variants.h> +#include <gpio.h> +#include <variant/gpio.h> + uint8_t variant_board_sku(void) { @@ -25,3 +28,11 @@ return sku; } + +#if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME) +void variant_mainboard_suspend_resume(void) +{ + /* Enable backlight - GPIO 133 active low */ + gpio_set(GPIO_133, 0); +} +#endif -- To view, visit https://review.coreboot.org/27488 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I452e2ea94b508b137cf52301df5d2d1ad5c9ab70 Gerrit-Change-Number: 27488 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>

1 0

Change in coreboot[master]: mainboard/google/kahlee: Enable backlight in SMI APMC
by Marc Jones (Code Review) 14 Jul '18

14 Jul '18

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/27487 Change subject: mainboard/google/kahlee: Enable backlight in SMI APMC ...................................................................... mainboard/google/kahlee: Enable backlight in SMI APMC Enable the backlight in the OS callback to SMI for APMC. This keeps the backlight off until the OS is ready to display something. BUG=b:72694972 TEST=Backlight turns on at ChromeOS splash screen Change-Id: Idf32b1a3d45971883571a829a5c0c1f8563bb1f7 Signed-off-by: Marc Jones <marcj303(a)gmail.com> --- M src/mainboard/google/kahlee/smihandler.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/27487/1 diff --git a/src/mainboard/google/kahlee/smihandler.c b/src/mainboard/google/kahlee/smihandler.c index 62ba2b0..83757a8 100644 --- a/src/mainboard/google/kahlee/smihandler.c +++ b/src/mainboard/google/kahlee/smihandler.c @@ -17,8 +17,10 @@ #include <arch/acpi.h> #include <cpu/x86/smm.h> #include <ec/google/chromeec/smm.h> +#include <gpio.h> #include <soc/smi.h> #include <variant/ec.h> +#include <variant/gpio.h> void mainboard_smi_gpi(u32 gpi_sts) { @@ -39,5 +41,9 @@ if (IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC)) chromeec_smi_apmc(apmc, MAINBOARD_EC_SCI_EVENTS, MAINBOARD_EC_SMI_EVENTS); + + /* Enable backlight - GPIO active low */ + gpio_set(GPIO_133, 0); + return 0; } -- To view, visit https://review.coreboot.org/27487 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idf32b1a3d45971883571a829a5c0c1f8563bb1f7 Gerrit-Change-Number: 27487 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>

1 0

Change in coreboot[master]: mainboard/google/kahlee: Add mainboard resume function
by Marc Jones (Code Review) 14 Jul '18

14 Jul '18

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/27486 Change subject: mainboard/google/kahlee: Add mainboard resume function ...................................................................... mainboard/google/kahlee: Add mainboard resume function Add the mainboard resume function and __weak variant override. Change-Id: I808734208bd1ce81428771ea203709b53db56cd3 Signed-off-by: Marc Jones <marcj303(a)gmail.com> --- M src/mainboard/google/kahlee/mainboard.c M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h 2 files changed, 17 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/27486/1 diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c index cf600d2..2efcb20 100644 --- a/src/mainboard/google/kahlee/mainboard.c +++ b/src/mainboard/google/kahlee/mainboard.c @@ -190,18 +190,31 @@ return variant_get_ehci_oc_map(map); } +#if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME) +void mainboard_suspend_resume(void) +{ + variant_mainboard_suspend_resume(); +} +#endif + struct chip_operations mainboard_ops = { .init = mainboard_init, .enable_dev = kahlee_enable, .final = mainboard_final, }; -/* Variants may override this function so see definitions in variants/ */ +/* Variants may override these functions so see definitions in variants/ */ uint8_t __weak variant_board_sku(void) { return 0; } +#if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME) +void __weak variant_mainboard_suspend_resume(void) +{ +} +#endif + const char *smbios_mainboard_sku(void) { static char sku_str[7]; /* sku{0..255} */ diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h index 23f9cb0..6e89105 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h @@ -30,5 +30,8 @@ const struct soc_amd_gpio *variant_early_gpio_table(size_t *size); const struct soc_amd_gpio *variant_gpio_table(size_t *size); void variant_romstage_entry(int s3_resume); +#if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME) +void variant_mainboard_suspend_resume(void); +#endif #endif /* __BASEBOARD_VARIANTS_H__ */ -- To view, visit https://review.coreboot.org/27486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I808734208bd1ce81428771ea203709b53db56cd3 Gerrit-Change-Number: 27486 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>

1 0

← Newer
1
...
50
51
52
53
54
55
56
...
88
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2018