coreboot-gerrit July 2018

coreboot-gerrit@coreboot.org

1 participants
877 discussions

Change in coreboot[master]: soc/intel/common/block: Add WhiskeyLake W0 CPUID
by Krzysztof M Sywula (Code Review) 16 Jul '18

16 Jul '18

Krzysztof M Sywula has uploaded this change for review. ( https://review.coreboot.org/27500 Change subject: soc/intel/common/block: Add WhiskeyLake W0 CPUID ...................................................................... soc/intel/common/block: Add WhiskeyLake W0 CPUID TEST=Boot up with W0 stepping processor. Change-Id: Ia7bcfd5235e57c70aa3f15d0042da8b16cf7e186 Signed-off-by: Krzysztof Sywula <krzysztof.m.sywula(a)intel.com> --- M src/soc/intel/common/block/cpu/mp_init.c M src/soc/intel/common/block/include/intelblocks/mp_init.h 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/27500/1 diff --git a/src/soc/intel/common/block/cpu/mp_init.c b/src/soc/intel/common/block/cpu/mp_init.c index fd0ac99..89c95a4 100644 --- a/src/soc/intel/common/block/cpu/mp_init.c +++ b/src/soc/intel/common/block/cpu/mp_init.c @@ -71,6 +71,7 @@ { X86_VENDOR_INTEL, CPUID_APOLLOLAKE_E0 }, { X86_VENDOR_INTEL, CPUID_GLK_A0 }, { X86_VENDOR_INTEL, CPUID_GLK_B0 }, + { X86_VENDOR_INTEL, CPUID_WHISKEYLAKE_W0 }, { 0, 0 }, }; diff --git a/src/soc/intel/common/block/include/intelblocks/mp_init.h b/src/soc/intel/common/block/include/intelblocks/mp_init.h index 3057209..740c255 100644 --- a/src/soc/intel/common/block/include/intelblocks/mp_init.h +++ b/src/soc/intel/common/block/include/intelblocks/mp_init.h @@ -37,6 +37,7 @@ #define CPUID_APOLLOLAKE_E0 0x506ca #define CPUID_GLK_A0 0x706a0 #define CPUID_GLK_B0 0x706a1 +#define CPUID_WHISKEYLAKE_W0 0x806eb /* * MP Init callback function to Find CPU Topology. This function is common -- To view, visit https://review.coreboot.org/27500 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia7bcfd5235e57c70aa3f15d0042da8b16cf7e186 Gerrit-Change-Number: 27500 Gerrit-PatchSet: 1 Gerrit-Owner: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com>

1 0

Change in coreboot[master]: cavium/bdk: Poke the watchdog while PCIe init
by Philipp Deppenwiese (Code Review) 16 Jul '18

16 Jul '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/27455 ) Change subject: cavium/bdk: Poke the watchdog while PCIe init ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/27455 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03739d7dbad3072ccf77364fa4caba42c66ac643 Gerrit-Change-Number: 27455 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Jul 2018 20:44:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cavium/bdk: Fix reference clock
by Philipp Deppenwiese (Code Review) 16 Jul '18

16 Jul '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/27454 ) Change subject: cavium/bdk: Fix reference clock ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/27454 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I312ce7379b361594249f9f26f4e561ebf57347df Gerrit-Change-Number: 27454 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Jul 2018 20:44:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cavium/bdk: Fix possible divide by zero
by Philipp Deppenwiese (Code Review) 16 Jul '18

16 Jul '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/27453 ) Change subject: cavium/bdk: Fix possible divide by zero ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/27453 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5db6866b8e51eaea201a4c03e59d7d00f4f826e7 Gerrit-Change-Number: 27453 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Jul 2018 20:44:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cavium/bdk: Fix coverity and remove hardcoded DRAM speed
by Philipp Deppenwiese (Code Review) 16 Jul '18

16 Jul '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/27452 ) Change subject: cavium/bdk: Fix coverity and remove hardcoded DRAM speed ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/27452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I96289da43c1018c2fdf9d013ce7f21d7511ba595 Gerrit-Change-Number: 27452 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Jul 2018 20:43:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cavium/bdk: Read DDR freq from memory controller
by Philipp Deppenwiese (Code Review) 16 Jul '18

16 Jul '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/27451 ) Change subject: cavium/bdk: Read DDR freq from memory controller ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/27451 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaee33e57e27ca182f41be923cf950868f66d3638 Gerrit-Change-Number: 27451 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Jul 2018 20:42:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cavium/bdk: Fix possible buffer overrun
by Philipp Deppenwiese (Code Review) 16 Jul '18

16 Jul '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/27449 ) Change subject: cavium/bdk: Fix possible buffer overrun ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/27449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I275cabf55fba464be7bd4c21dfe5826ea554ac84 Gerrit-Change-Number: 27449 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Jul 2018 20:42:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: bdk: Use Kconfig options instead of getenv()
by Philipp Deppenwiese (Code Review) 16 Jul '18

16 Jul '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/27448 ) Change subject: bdk: Use Kconfig options instead of getenv() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/27448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia16c0161b0e9cf5d06418e46556c0fb45532a5b1 Gerrit-Change-Number: 27448 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Jul 2018 20:42:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mediatek: Share GPIO code among similar SOCs
by build bot (Jenkins) (Code Review) 16 Jul '18

16 Jul '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27416 ) Change subject: mediatek: Share GPIO code among similar SOCs ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/27416/3/src/soc/mediatek/common/include/soc… File src/soc/mediatek/common/include/soc/gpio_common.h: https://review.coreboot.org/#/c/27416/3/src/soc/mediatek/common/include/soc… PS3, Line 19: #define PIN(index, name, func1, func2, func3, func4, func5, func6, func7) \ Macros with complex values should be enclosed in parentheses -- To view, visit https://review.coreboot.org/27416 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icdd1f2a1dd1bd64a7218bf9c63bd4a0af1acbcc0 Gerrit-Change-Number: 27416 Gerrit-PatchSet: 3 Gerrit-Owner: Tristan Hsieh <tristan.shieh(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Joel Kitching <kitching(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ting Shen <phoenixshen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Jul 2018 15:50:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: google/kukui: Add SPI NOR support
by Tristan Hsieh (Code Review) 16 Jul '18

16 Jul '18

Tristan Hsieh has uploaded this change for review. ( https://review.coreboot.org/27499 Change subject: google/kukui: Add SPI NOR support ...................................................................... google/kukui: Add SPI NOR support This patch set SPI flash related configs and init SPI bus 1 to support SPI NOR flash. BUG=b:80501386 BRANCH=none TEST=Boots correctly on Kukui Change-Id: I1a18a456f41a7c7daec954e961c9fbee3650493d Signed-off-by: Tristan Shieh <tristan.shieh(a)mediatek.com> --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Makefile.inc A src/mainboard/google/kukui/bootblock.c 3 files changed, 28 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/27499/1 diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index fa8099e..57266f2 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -11,6 +11,7 @@ select COMMON_CBFS_SPI_WRAPPER select SPI_FLASH select FATAL_ASSERTS + select SPI_FLASH_INCLUDE_ALL_DRIVERS config MAINBOARD_DIR string @@ -20,4 +21,8 @@ string default "Kukui" +config BOOT_DEVICE_SPI_FLASH_BUS + int + default 1 + endif diff --git a/src/mainboard/google/kukui/Makefile.inc b/src/mainboard/google/kukui/Makefile.inc index 2a68de0..e1fc54d 100644 --- a/src/mainboard/google/kukui/Makefile.inc +++ b/src/mainboard/google/kukui/Makefile.inc @@ -1,3 +1,4 @@ +bootblock-y += bootblock.c bootblock-y += memlayout.ld verstage-y += chromeos.c diff --git a/src/mainboard/google/kukui/bootblock.c b/src/mainboard/google/kukui/bootblock.c new file mode 100644 index 0000000..ebe72c2 --- /dev/null +++ b/src/mainboard/google/kukui/bootblock.c @@ -0,0 +1,22 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2018 MediaTek Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <bootblock_common.h> +#include <soc/spi.h> + +void bootblock_mainboard_init(void) +{ + mtk_spi_init(CONFIG_BOOT_DEVICE_SPI_FLASH_BUS, SPI_PAD0_MASK, 6*MHz); +} -- To view, visit https://review.coreboot.org/27499 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1a18a456f41a7c7daec954e961c9fbee3650493d Gerrit-Change-Number: 27499 Gerrit-PatchSet: 1 Gerrit-Owner: Tristan Hsieh <tristan.shieh(a)mediatek.com>

1 0

← Newer
1
...
48
49
50
51
52
53
54
...
88
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2018