coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: WIP: soc/amd/stoneyridge/southbridge.c: Fix saving _SWS parameters
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26547 ) Change subject: WIP: soc/amd/stoneyridge/southbridge.c: Fix saving _SWS parameters ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73675/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27798/ : SUCCESS -- To view, visit https://review.coreboot.org/26547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8bafc7bb7dd66e7f0eb8499e748535bbdcac5f53 Gerrit-Change-Number: 26547 Gerrit-PatchSet: 3 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 14:46:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/lint: Update lint-stable-000-license-headers linter
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26573 ) Change subject: util/lint: Update lint-stable-000-license-headers linter ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73674/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27797/ : SUCCESS -- To view, visit https://review.coreboot.org/26573 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I40046a2fb7359262b130f6813eda1f2c30916b46 Gerrit-Change-Number: 26573 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Wed, 30 May 2018 14:37:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/kahlee: Add careena variant
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26524 ) Change subject: mainboard/google/kahlee: Add careena variant ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73673/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27796/ : SUCCESS -- To view, visit https://review.coreboot.org/26524 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87a24f6d8115aacf5b21181f3820cf2718ad252a Gerrit-Change-Number: 26524 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 14:33:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in libgfxinit[master]: gma ironlake..broadwell: Enable X-tiling
by Nico Huber (Code Review) 30 May '18

30 May '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/26697 Change subject: gma ironlake..broadwell: Enable X-tiling ...................................................................... gma ironlake..broadwell: Enable X-tiling Generations pre Skylake support X-tiling only. Change-Id: I828e20e2a6bf71c88cf9e23ada0552e2462fe7c1 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-gma-config_helpers.adb M common/hw-gfx-gma-pipe_setup.adb 2 files changed, 17 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/97/26697/1 diff --git a/common/hw-gfx-gma-config_helpers.adb b/common/hw-gfx-gma-config_helpers.adb index 5e5be5d..4cf04c3 100644 --- a/common/hw-gfx-gma-config_helpers.adb +++ b/common/hw-gfx-gma-config_helpers.adb @@ -193,7 +193,7 @@ -- Only 32bpp RGB (ignored for VGA plane) -- Stride must be big enough and a multiple of 64 bytes or the tile size -- (ignored for VGA plane) - -- Tiling and rotation is only supported on newer generations (with + -- Y-Tiling and rotation are only supported on newer generations (with -- Plane_Control) -- 90 degree rotations are only supported with Y-tiling return @@ -206,7 +206,7 @@ (FB.Offset = VGA_PLANE_FRAMEBUFFER_OFFSET or (FB.BPC = 8 and Valid_Stride (FB) and (Config.Has_Plane_Control or - (FB.Tiling = Linear and FB.Rotation = No_Rotation)) and + (FB.Tiling /= Y_Tiled and FB.Rotation = No_Rotation)) and (FB.Tiling = Y_Tiled or not Rotation_90 (FB)))); end Validate_Config; diff --git a/common/hw-gfx-gma-pipe_setup.adb b/common/hw-gfx-gma-pipe_setup.adb index 7bccb4d..7a53faa 100644 --- a/common/hw-gfx-gma-pipe_setup.adb +++ b/common/hw-gfx-gma-pipe_setup.adb @@ -27,14 +27,22 @@ DSPCNTR_ENABLE : constant := 1 * 2 ** 31; DSPCNTR_GAMMA_CORRECTION : constant := 1 * 2 ** 30; - DSPCNTR_DISABLE_TRICKLE_FEED : constant := 1 * 2 ** 14; DSPCNTR_FORMAT_MASK : constant := 15 * 2 ** 26; + DSPCNTR_DISABLE_TRICKLE_FEED : constant := 1 * 2 ** 14; + DSPCNTR_TILED_SURFACE_LINEAR : constant := 0 * 2 ** 10; + DSPCNTR_TILED_SURFACE_X_TILED : constant := 1 * 2 ** 10; + + DSPCNTR_TILED_SURFACE : constant array (Tiling_Type) of Word32 := + (Linear => DSPCNTR_TILED_SURFACE_LINEAR, + X_Tiled => DSPCNTR_TILED_SURFACE_X_TILED, + Y_Tiled => 0); -- unsupported DSPCNTR_MASK : constant Word32 := DSPCNTR_ENABLE or DSPCNTR_GAMMA_CORRECTION or DSPCNTR_FORMAT_MASK or - DSPCNTR_DISABLE_TRICKLE_FEED; + DSPCNTR_DISABLE_TRICKLE_FEED or + DSPCNTR_TILED_SURFACE_X_TILED; PLANE_CTL_PLANE_ENABLE : constant := 1 * 2 ** 31; PLANE_CTL_SRC_PIX_FMT_RGB_32B_8888 : constant := 4 * 2 ** 24; @@ -239,17 +247,20 @@ Registers.Unset_And_Set_Mask (Register => Controller.DSPCNTR, Mask_Unset => DSPCNTR_MASK, - Mask_Set => PRI); + Mask_Set => PRI or DSPCNTR_TILED_SURFACE (FB.Tiling)); Registers.Write (Controller.DSPSTRIDE, Word32 (Pixel_To_Bytes (FB.Stride, FB))); - if Config.Has_DSP_Linoff then + if Config.Has_DSP_Linoff and then FB.Tiling = Linear then Registers.Write (Register => Controller.DSPLINOFF, Value => Word32 (Pixel_To_Bytes (FB.Start_Y * FB.Stride + FB.Start_X, FB))); Registers.Write (Controller.DSPTILEOFF, 0); else + if Config.Has_DSP_Linoff then + Registers.Write (Controller.DSPLINOFF, 0); + end if; Registers.Write (Register => Controller.DSPTILEOFF, Value => Shift_Left (Word32 (FB.Start_Y), 16) or -- To view, visit https://review.coreboot.org/26697 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I828e20e2a6bf71c88cf9e23ada0552e2462fe7c1 Gerrit-Change-Number: 26697 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: checkpatch: exclude util/crossgcc/patches
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26695 ) Change subject: checkpatch: exclude util/crossgcc/patches ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73672/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27795/ : SUCCESS -- To view, visit https://review.coreboot.org/26695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8816c05ea703964a332915a0675096836957b242 Gerrit-Change-Number: 26695 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 14:24:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in libgfxinit[master]: Rename Pos_Type --> Position_Type
by Nico Huber (Code Review) 30 May '18

30 May '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/26696 Change subject: Rename Pos_Type --> Position_Type ...................................................................... Rename Pos_Type --> Position_Type Yet after few months, it's already too confusing to me. Let's reserve `Pos` for `Positive` and spell out `Position`. Change-Id: I3445d20665ae6a993cb0e46d08e8f3148abef40e Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx.ads M gfxtest/hw-gfx-gma-gfx_test.adb 2 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/96/26696/1 diff --git a/common/hw-gfx.ads b/common/hw-gfx.ads index 1ab2518..7403a86 100644 --- a/common/hw-gfx.ads +++ b/common/hw-gfx.ads @@ -25,9 +25,9 @@ subtype Pos_Pixel_Type is Pixel_Type range 1 .. Pixel_Type'Last; -- Allow same range for width and height (for rotated framebuffers) - subtype Width_Type is Pos32 range 1 .. 8192; - subtype Height_Type is Pos32 range 1 .. 8192; - subtype Pos_Type is Int32 range 0 .. 4095; + subtype Width_Type is Pos32 range 1 .. 8192; + subtype Height_Type is Pos32 range 1 .. 8192; + subtype Position_Type is Int32 range 0 .. 4095; Auto_BPC : constant := 5; subtype BPC_Type is Int64 range Auto_BPC .. 16; @@ -41,8 +41,8 @@ record Width : Width_Type; Height : Height_Type; - Start_X : Pos_Type; - Start_Y : Pos_Type; + Start_X : Position_Type; + Start_Y : Position_Type; BPC : BPC_Type; Stride : Width_Type; V_Stride : Height_Type; diff --git a/gfxtest/hw-gfx-gma-gfx_test.adb b/gfxtest/hw-gfx-gma-gfx_test.adb index 94ee312..bf6e917 100644 --- a/gfxtest/hw-gfx-gma-gfx_test.adb +++ b/gfxtest/hw-gfx-gma-gfx_test.adb @@ -19,9 +19,9 @@ Secondary_Delay_MS : constant := 4_000; Seed : constant := 12345; - package Rand_P is new Ada.Numerics.Discrete_Random (Pos_Type); + package Rand_P is new Ada.Numerics.Discrete_Random (Position_Type); Gen : Rand_P.Generator; - function Rand return Pos_Type is (Rand_P.Random (Gen)); + function Rand return Position_Type is (Rand_P.Random (Gen)); Start_X : constant := 0; Start_Y : constant := 0; @@ -384,7 +384,7 @@ declare New_Pipes : GMA.Pipe_Configs := Pipes; - function Rand_Div (Num : Pos_Type) return Pos_Type is + function Rand_Div (Num : Position_Type) return Position_Type is (case Rand mod 4 is when 3 => Rand mod Num / 3, when 2 => Rand mod Num / 2, @@ -404,9 +404,9 @@ Height : constant Height_Type := Pipes (Pipe).Framebuffer.Height; begin - New_FB.Start_X := Pos_Type'Min + New_FB.Start_X := Position_Type'Min (Width - 320, Rand_Div (Width)); - New_FB.Start_Y := Pos_Type'Min + New_FB.Start_Y := Position_Type'Min (Height - 320, Rand_Div (Height)); New_FB.Width := Width_Type'Max (320, Width - New_FB.Start_X - Rand_Div (Width)); -- To view, visit https://review.coreboot.org/26696 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3445d20665ae6a993cb0e46d08e8f3148abef40e Gerrit-Change-Number: 26696 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: util/gitconfig: improve robustness of checkpatch in pre-commit
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26694 ) Change subject: util/gitconfig: improve robustness of checkpatch in pre-commit ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73671/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27794/ : SUCCESS -- To view, visit https://review.coreboot.org/26694 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I099795119456a73c900b31ce191c2d9e898a5c7e Gerrit-Change-Number: 26694 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 14:22:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/cavium/cn8100_sff_evb: Compile devicetree for Linux
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26229 ) Change subject: mb/cavium/cn8100_sff_evb: Compile devicetree for Linux ...................................................................... Patch Set 11: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/73670/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/27793/ : SUCCESS -- To view, visit https://review.coreboot.org/26229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a98ed7b128f65a6e0109963dbabca91563a315c Gerrit-Change-Number: 26229 Gerrit-PatchSet: 11 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 14:18:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: devicetree: Add method to delete property by name
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26693 ) Change subject: devicetree: Add method to delete property by name ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/73667/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/27790/ : SUCCESS -- To view, visit https://review.coreboot.org/26693 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c58a2411206bca62d0e96fa627530e937383ac9 Gerrit-Change-Number: 26693 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 14:17:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/cavium: Apply additional devicetree fixups
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25382 ) Change subject: soc/cavium: Apply additional devicetree fixups ...................................................................... Patch Set 27: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/73668/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/27791/ : SUCCESS -- To view, visit https://review.coreboot.org/25382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e8eefd913915a879dad28dfb7801a2018ed2985 Gerrit-Change-Number: 25382 Gerrit-PatchSet: 27 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 14:17:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018