coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: stoneyridge: Call APM_CNT_FINALIZE
by Raul Rangel (Code Review) 30 May '18

30 May '18

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/26701 Change subject: stoneyridge: Call APM_CNT_FINALIZE ...................................................................... stoneyridge: Call APM_CNT_FINALIZE I'm not sure if this is actually required or not. The stoneyridge smihandler doesn't actually handle this command. BUG=b:80295434 TEST=Boot on grunt Change-Id: I7ab85ac58a8f39f8519cdb3bff748d64d495bb7d Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> --- M src/soc/amd/stoneyridge/finalize.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/26701/1 diff --git a/src/soc/amd/stoneyridge/finalize.c b/src/soc/amd/stoneyridge/finalize.c index 21d203c..e51dd61 100644 --- a/src/soc/amd/stoneyridge/finalize.c +++ b/src/soc/amd/stoneyridge/finalize.c @@ -13,6 +13,7 @@ * GNU General Public License for more details. */ +#include <arch/io.h> #include <cpu/x86/mp.h> #include <cpu/x86/msr.h> #include <cpu/amd/amdfam15.h> @@ -53,6 +54,9 @@ { finalize_cores(); + printk(BIOS_DEBUG, "Finalizing SMM.\n"); + outb(APM_CNT_FINALIZE, APM_CNT); + post_code(POST_OS_BOOT); } -- To view, visit https://review.coreboot.org/26701 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7ab85ac58a8f39f8519cdb3bff748d64d495bb7d Gerrit-Change-Number: 26701 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org>

1 0

Change in coreboot[master]: util/docker/docs.coreboot.org: Patch recommonmark
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26699 ) Change subject: util/docker/docs.coreboot.org: Patch recommonmark ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73678/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27801/ : SUCCESS -- To view, visit https://review.coreboot.org/26699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I287deab9168ab6124b05d0c6d6e8cdbd7fdc2eec Gerrit-Change-Number: 26699 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 16:25:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Documentation/lessons/lesson1: Fix formatting
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26700 ) Change subject: Documentation/lessons/lesson1: Fix formatting ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73679/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27802/ : SUCCESS -- To view, visit https://review.coreboot.org/26700 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4f13db2e56f1641a4e6a3069b744514e3279e3c Gerrit-Change-Number: 26700 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 16:22:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Documentation/lessons/lesson1: Fix formatting
by Patrick Georgi (Code Review) 30 May '18

30 May '18

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/26700 Change subject: Documentation/lessons/lesson1: Fix formatting ...................................................................... Documentation/lessons/lesson1: Fix formatting Change-Id: If4f13db2e56f1641a4e6a3069b744514e3279e3c Signed-off-by: Patrick Georgi <patrick(a)georgi.software> --- M Documentation/lessons/lesson1.md 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/26700/1 diff --git a/Documentation/lessons/lesson1.md b/Documentation/lessons/lesson1.md index 0a10ba3..4cbdf95 100644 --- a/Documentation/lessons/lesson1.md +++ b/Documentation/lessons/lesson1.md @@ -29,7 +29,7 @@ ### Step 5 - Configure the build -* ##### Configure your mainboard +##### Configure your mainboard $ make menuconfig select 'Mainboard' menu Beside 'Mainboard vendor' should be '(Emulation)' @@ -38,12 +38,12 @@ These should be the default selections, so if anything else was set, run `make distclean` to remove your old config file and start over. -* ##### Optionally use your system toolchain (Again, not recommended) +##### Optionally use your system toolchain (Again, not recommended) select 'General Setup' menu select 'Allow building with any toolchain' select < Exit > -* ##### Select the payload +##### Select the payload select 'Payload' menu select 'Add a Payload' choose 'An Elf executable payload' -- To view, visit https://review.coreboot.org/26700 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If4f13db2e56f1641a4e6a3069b744514e3279e3c Gerrit-Change-Number: 26700 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: util/docker/docs.coreboot.org: Patch recommonmark
by Patrick Georgi (Code Review) 30 May '18

30 May '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/26699 ) Change subject: util/docker/docs.coreboot.org: Patch recommonmark ...................................................................... Patch Set 1: It also needs changing debian:sid to debian:buster (testing) due to a recent bug in the fonts-font-awesome package (updated to 5.x without providing a transition path), but I'm not certain that this helps for more than the 2-weeks-or-so that testing is behind unstable in many cases. -- To view, visit https://review.coreboot.org/26699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I287deab9168ab6124b05d0c6d6e8cdbd7fdc2eec Gerrit-Change-Number: 26699 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 16:17:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/docker/docs.coreboot.org: Patch recommonmark
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26699 ) Change subject: util/docker/docs.coreboot.org: Patch recommonmark ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/26699/1/util/docker/docs.coreboot.org/fix-r… File util/docker/docs.coreboot.org/fix-recommonmark.patch: https://review.coreboot.org/#/c/26699/1/util/docker/docs.coreboot.org/fix-r… PS1, Line 11: trailing whitespace -- To view, visit https://review.coreboot.org/26699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I287deab9168ab6124b05d0c6d6e8cdbd7fdc2eec Gerrit-Change-Number: 26699 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 16:16:42 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/docker/docs.coreboot.org: Patch recommonmark
by Patrick Georgi (Code Review) 30 May '18

30 May '18

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/26699 Change subject: util/docker/docs.coreboot.org: Patch recommonmark ...................................................................... util/docker/docs.coreboot.org: Patch recommonmark Using properties of a None object is a bad idea. Change-Id: I287deab9168ab6124b05d0c6d6e8cdbd7fdc2eec Signed-off-by: Patrick Georgi <patrick(a)georgi.software> --- M util/docker/docs.coreboot.org/Dockerfile A util/docker/docs.coreboot.org/fix-recommonmark.patch 2 files changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/26699/1 diff --git a/util/docker/docs.coreboot.org/Dockerfile b/util/docker/docs.coreboot.org/Dockerfile index fa2313c..6bf40e6 100644 --- a/util/docker/docs.coreboot.org/Dockerfile +++ b/util/docker/docs.coreboot.org/Dockerfile @@ -1,5 +1,7 @@ FROM debian:sid -RUN apt-get update && apt-get install -y make python-sphinx python-recommonmark python-sphinx-rtd-theme +RUN apt-get update && apt-get install -y make python-sphinx python-recommonmark python-sphinx-rtd-theme patch && apt-get clean +ADD fix-recommonmark.patch /tmp +RUN cd /; patch -p0 -i /tmp/fix-recommonmark.patch USER nobody VOLUME /data-in /data-out ENTRYPOINT bash -c "cd /data-in/Documentation && make sphinx BUILDDIR=/tmp/build && rm -rf /data-out/* && mv /tmp/build/html/* /data-out/" diff --git a/util/docker/docs.coreboot.org/fix-recommonmark.patch b/util/docker/docs.coreboot.org/fix-recommonmark.patch new file mode 100644 index 0000000..218ef62 --- /dev/null +++ b/util/docker/docs.coreboot.org/fix-recommonmark.patch @@ -0,0 +1,12 @@ +--- /usr/lib/python2.7/dist-packages/recommonmark/parser.py.orig 2018-05-30 15:04:29.410187358 +0000 ++++ /usr/lib/python2.7/dist-packages/recommonmark/parser.py 2018-05-30 15:04:34.934307335 +0000 +@@ -107,7 +107,8 @@ + new_section.append(title_node) + name = nodes.fully_normalize_name(title_node.astext()) + new_section['names'].append(name) +- self.current_node.document.note_implicit_target(new_section, new_section) ++ if self.current_node.document <> None: ++ self.current_node.document.note_implicit_target(new_section, new_section) + new_section['ids'].append(nodes.make_id(name)) + + self.section_handler.add_new_section(new_section, block.level) -- To view, visit https://review.coreboot.org/26699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I287deab9168ab6124b05d0c6d6e8cdbd7fdc2eec Gerrit-Change-Number: 26699 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add ACPI device name lookup
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26698 ) Change subject: soc/amd/stoneyridge: Add ACPI device name lookup ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73677/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27800/ : SUCCESS -- To view, visit https://review.coreboot.org/26698 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5117e0d39db831364173c9c61ccdab6e34f18c59 Gerrit-Change-Number: 26698 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 16:13:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add ACPI device name lookup
by Marc Jones (Code Review) 30 May '18

30 May '18

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/26698 Change subject: soc/amd/stoneyridge: Add ACPI device name lookup ...................................................................... soc/amd/stoneyridge: Add ACPI device name lookup Add the ACPI devices defined in ASL to the soc_acpi_name() lookup function. BUG=b:80280671 TEST=Add ACPI method to specific GPP bridge. Boot and verify method with ACPI dump. Change-Id: I5117e0d39db831364173c9c61ccdab6e34f18c59 Signed-off-by: Marc Jones <marc.jones(a)scarletltd.com> Signed-off-by: Marc Jones <marcj303(a)gmail.com> --- M src/soc/amd/stoneyridge/chip.c 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/26698/1 diff --git a/src/soc/amd/stoneyridge/chip.c b/src/soc/amd/stoneyridge/chip.c index 3b73a05..9ca2db7 100644 --- a/src/soc/amd/stoneyridge/chip.c +++ b/src/soc/amd/stoneyridge/chip.c @@ -82,6 +82,18 @@ return NULL; switch (dev->path.pci.devfn) { + case PCIE0_DEVFN: + return "PBR4"; + case PCIE1_DEVFN: + return "PBR5"; + case PCIE2_DEVFN: + return "PBR6"; + case PCIE3_DEVFN: + return "PBR7"; + case PCIE4_DEVFN: + return "PBR8"; + case HDA1_DEVFN: + return "AZHD"; case EHCI1_DEVFN: return "EHC0"; case LPC_DEVFN: -- To view, visit https://review.coreboot.org/26698 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5117e0d39db831364173c9c61ccdab6e34f18c59 Gerrit-Change-Number: 26698 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>

1 0

Change in coreboot[master]: src/mainboard: Add space after 'if'
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26462 ) Change subject: src/mainboard: Add space after 'if' ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73676/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27799/ : SUCCESS -- To view, visit https://review.coreboot.org/26462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icae1983be6b8c5aebb121be8a383e2613e064122 Gerrit-Change-Number: 26462 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 15:58:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018