coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: soc/cavium: Clean uart code
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25448 ) Change subject: soc/cavium: Clean uart code ...................................................................... Patch Set 26: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73658/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27781/ : SUCCESS -- To view, visit https://review.coreboot.org/25448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1043b30318ec6210e2dd6b7ac313a41171d37f55 Gerrit-Change-Number: 25448 Gerrit-PatchSet: 26 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:53:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/cavium: Apply additional devicetree fixups
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25382 ) Change subject: soc/cavium: Apply additional devicetree fixups ...................................................................... Patch Set 27: (7 comments) https://review.coreboot.org/#/c/25382/27/src/soc/cavium/cn81xx/soc.c File src/soc/cavium/cn81xx/soc.c: https://review.coreboot.org/#/c/25382/27/src/soc/cavium/cn81xx/soc.c@79 PS27, Line 79: Remove 'phy-handle' if this option is not availble */ 'availble' may be misspelled - perhaps 'available'? https://review.coreboot.org/#/c/25382/27/src/soc/cavium/cn81xx/soc.c@137 PS27, Line 137: /* Extract our MAC address info so we can assign them in the device tree */ line over 80 characters https://review.coreboot.org/#/c/25382/27/src/soc/cavium/cn81xx/soc.c@169 PS27, Line 169: if (!strcmp(name, prop->prop.name)) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/25382/27/src/soc/cavium/cn81xx/soc.c@265 PS27, Line 265: BDK_BGXX_CMRX_RX_DMAC_CTL(bgx_interface, bgx_index)); line over 80 characters https://review.coreboot.org/#/c/25382/27/src/soc/cavium/cn81xx/soc.c@296 PS27, Line 296: /* ATF reserved */ code indent should use tabs where possible https://review.coreboot.org/#/c/25382/27/src/soc/cavium/cn81xx/soc.c@297 PS27, Line 297: bootmem_add_range(0, 1 * MiB, BM_MEM_RESERVED); code indent should use tabs where possible https://review.coreboot.org/#/c/25382/27/src/soc/cavium/cn81xx/soc.c@297 PS27, Line 297: bootmem_add_range(0, 1 * MiB, BM_MEM_RESERVED); please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/25382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e8eefd913915a879dad28dfb7801a2018ed2985 Gerrit-Change-Number: 25382 Gerrit-PatchSet: 27 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:52:09 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/cavium: Add secondary CPU support
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25752 ) Change subject: soc/cavium: Add secondary CPU support ...................................................................... Patch Set 16: (6 comments) https://review.coreboot.org/#/c/25752/16/src/mainboard/cavium/cn8100_sff_ev… File src/mainboard/cavium/cn8100_sff_evb/mainboard.c: https://review.coreboot.org/#/c/25752/16/src/mainboard/cavium/cn8100_sff_ev… PS16, Line 71: printk(BIOS_INFO, "MB: #CPU cores : %zu\n", cpu_get_num_available_cores()); line over 80 characters https://review.coreboot.org/#/c/25752/16/src/soc/cavium/cn81xx/cpu.c File src/soc/cavium/cn81xx/cpu.c: https://review.coreboot.org/#/c/25752/16/src/soc/cavium/cn81xx/cpu.c@35 PS16, Line 35: static void (* secondary_c_entry)(size_t core_id) = NULL; Unnecessary space before function pointer name https://review.coreboot.org/#/c/25752/16/src/soc/cavium/cn81xx/cpu.c@35 PS16, Line 35: static void (* secondary_c_entry)(size_t core_id) = NULL; space prohibited after that '*' (ctx:BxW) https://review.coreboot.org/#/c/25752/16/src/soc/cavium/cn81xx/cpu.c@67 PS16, Line 67: size_t start_cpu(size_t cpu, void (* entry_64)(size_t core_id)) space prohibited after that '*' (ctx:BxW) https://review.coreboot.org/#/c/25752/16/src/soc/cavium/cn81xx/cpu.c@121 PS16, Line 121: while (!stopwatch_expired(&sw) && !read64(&secondary_booted)); trailing statements should be on next line https://review.coreboot.org/#/c/25752/16/src/soc/cavium/cn81xx/include/soc/… File src/soc/cavium/cn81xx/include/soc/cpu.h: https://review.coreboot.org/#/c/25752/16/src/soc/cavium/cn81xx/include/soc/… PS16, Line 47: size_t start_cpu(size_t cpu, void (* entry_64)(size_t core_id)); space prohibited after that '*' (ctx:BxW) -- To view, visit https://review.coreboot.org/25752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07428161615bcd3d03a3eea0df2dd813e08c8f66 Gerrit-Change-Number: 25752 Gerrit-PatchSet: 16 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:51:38 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [HACK]cavium/arm-trusted-firmware: Use 9elements ATF
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25751 ) Change subject: [HACK]cavium/arm-trusted-firmware: Use 9elements ATF ...................................................................... Patch Set 16: (2 comments) https://review.coreboot.org/#/c/25751/16/src/soc/cavium/cn81xx/soc.c File src/soc/cavium/cn81xx/soc.c: https://review.coreboot.org/#/c/25751/16/src/soc/cavium/cn81xx/soc.c@59 PS16, Line 59: void *ptr = cbfs_boot_map_with_leak("sff8104-linux.dtb", CBFS_TYPE_RAW, &size); line over 80 characters https://review.coreboot.org/#/c/25751/16/src/soc/cavium/common/include/soc/… File src/soc/cavium/common/include/soc/bl31_plat_params.h: https://review.coreboot.org/#/c/25751/16/src/soc/cavium/common/include/soc/… PS16, Line 21: #include <soc/cavium/common/arm-trusted-firmware/plat/cavium/common/include/plat_params.h> line over 80 characters -- To view, visit https://review.coreboot.org/25751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e9eb429d11150d43aa070d1bd6a11ea71951ce3 Gerrit-Change-Number: 25751 Gerrit-PatchSet: 16 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:51:13 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/cavium/cn8100_sff_evb: Compile devicetree for Linux
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26229 ) Change subject: mb/cavium/cn8100_sff_evb: Compile devicetree for Linux ...................................................................... Patch Set 10: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/73656/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/27779/ : SUCCESS -- To view, visit https://review.coreboot.org/26229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a98ed7b128f65a6e0109963dbabca91563a315c Gerrit-Change-Number: 26229 Gerrit-PatchSet: 10 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:49:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: device/pci: Add MSI-X helper functions
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26329 ) Change subject: device/pci: Add MSI-X helper functions ...................................................................... Patch Set 6: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/73655/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/27771/ : SUCCESS -- To view, visit https://review.coreboot.org/26329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94413712e7986efd17e6b11ba59f6eb390384c8c Gerrit-Change-Number: 26329 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:49:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/cavium: Apply additional devicetree fixups
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

1 0

Change in coreboot[master]: devicetree: Add method to delete property by name
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26693 ) Change subject: devicetree: Add method to delete property by name ...................................................................... Patch Set 2: Verified+1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/27776/ : SUCCESS -- To view, visit https://review.coreboot.org/26693 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c58a2411206bca62d0e96fa627530e937383ac9 Gerrit-Change-Number: 26693 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:49:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/cavium: Add secondary CPU support
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

1 0

Change in coreboot[master]: util/cavium: Add tool to convert devicetree blobs
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26228 ) Change subject: util/cavium: Add tool to convert devicetree blobs ...................................................................... Patch Set 10: Verified+1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/27775/ : SUCCESS -- To view, visit https://review.coreboot.org/26228 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76a5588aefe4f680228eca46a0e4dba7e695931c Gerrit-Change-Number: 26228 Gerrit-PatchSet: 10 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:49:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018