coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: northbridge/amd/lx: Fix function setShadowRCONF
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20808 ) Change subject: northbridge/amd/lx: Fix function setShadowRCONF ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73696/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27817/ : SUCCESS -- To view, visit https://review.coreboot.org/20808 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d7720121d4730254542372282f5561739e7214b Gerrit-Change-Number: 20808 Gerrit-PatchSet: 9 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 19:37:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: cpu/intel/car/cache_as_ram_ht.inc: cache the whole ROM_SIZE
by Arthur Heymans (Code Review) 30 May '18

30 May '18

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/26707 ) Change subject: cpu/intel/car/cache_as_ram_ht.inc: cache the whole ROM_SIZE ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/26707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ieeaee7b47fc9c31e9abae8c49e16f62bee7c76d5 Gerrit-Change-Number: 26707 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: cpu/intel/cache_as_ram_ht.inc: Compute the #var_mtrr during runtime
by Arthur Heymans (Code Review) 30 May '18

30 May '18

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/26705 ) Change subject: cpu/intel/cache_as_ram_ht.inc: Compute the #var_mtrr during runtime ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/26705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I51bd5ba3072837d64b46cd64cf609efc160e80fb Gerrit-Change-Number: 26705 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: security/tpm: Unify the coreboot TPM software stack
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24903 ) Change subject: security/tpm: Unify the coreboot TPM software stack ...................................................................... Patch Set 29: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/73695/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/27816/ : SUCCESS -- To view, visit https://review.coreboot.org/24903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ec277e82a3c20c62a0548a1a2b013e6ce8f5b3f Gerrit-Change-Number: 24903 Gerrit-PatchSet: 29 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Wed, 30 May 2018 19:29:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: ec/google/chromeec: Initialize SMI mask in google_chromeec_events_init
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26709 ) Change subject: ec/google/chromeec: Initialize SMI mask in google_chromeec_events_init ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73693/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27814/ : SUCCESS -- To view, visit https://review.coreboot.org/26709 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I899a6af6e57d295b4eac2039c8245ebcc73a42bb Gerrit-Change-Number: 26709 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 19:12:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/rambi: Set SMI mask using google_chromeec_events_init
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26710 ) Change subject: mb/google/rambi: Set SMI mask using google_chromeec_events_init ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73694/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27815/ : SUCCESS -- To view, visit https://review.coreboot.org/26710 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7def3c07b4d7bfbe15b2d1c45381bdc31b7e3476 Gerrit-Change-Number: 26710 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 19:10:11 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/rambi: Set SMI mask using google_chromeec_events_init
by Furquan Shaikh (Code Review) 30 May '18

30 May '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/26710 Change subject: mb/google/rambi: Set SMI mask using google_chromeec_events_init ...................................................................... mb/google/rambi: Set SMI mask using google_chromeec_events_init This change updates rambi ec init to perform SMI mask setting using google_chromeec_events_init. Change-Id: I7def3c07b4d7bfbe15b2d1c45381bdc31b7e3476 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/mainboard/google/rambi/ec.c 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/26710/1 diff --git a/src/mainboard/google/rambi/ec.c b/src/mainboard/google/rambi/ec.c index 307aedf..60f3d30 100644 --- a/src/mainboard/google/rambi/ec.c +++ b/src/mainboard/google/rambi/ec.c @@ -25,6 +25,7 @@ const struct google_chromeec_event_info info = { .log_events = MAINBOARD_EC_LOG_EVENTS, .sci_events = MAINBOARD_EC_SCI_EVENTS, + .smi_events = MAINBOARD_EC_SMI_EVENTS, .s3_wake_events = MAINBOARD_EC_S3_WAKE_EVENTS, .s5_wake_events = MAINBOARD_EC_S5_WAKE_EVENTS, }; @@ -34,8 +35,5 @@ google_chromeec_events_init(&info, s3_wakeup); - if (!s3_wakeup) - google_chromeec_set_smi_mask(MAINBOARD_EC_SMI_EVENTS); - post_code(0xf1); } -- To view, visit https://review.coreboot.org/26710 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7def3c07b4d7bfbe15b2d1c45381bdc31b7e3476 Gerrit-Change-Number: 26710 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: ec/google/chromeec: Initialize SMI mask in google_chromeec_events_init
by Furquan Shaikh (Code Review) 30 May '18

30 May '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/26709 Change subject: ec/google/chromeec: Initialize SMI mask in google_chromeec_events_init ...................................................................... ec/google/chromeec: Initialize SMI mask in google_chromeec_events_init This change adds smi_events to google_chromeec_event_info and allows mainboards to set SMI mask if current boot type is not S3 wakeup. Change-Id: I899a6af6e57d295b4eac2039c8245ebcc73a42bb Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h 2 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/26709/1 diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 72ca240..094f7ce 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -474,14 +474,16 @@ google_chromeec_set_sci_mask(info->sci_events); } else { + google_chromeec_set_smi_mask(info->smi_events); + google_chromeec_log_events(info->log_events | info->s5_wake_events); + if (google_chromeec_is_uhepi_supported()) google_chromeec_set_lazy_wake_masks (info->s5_wake_events, info->s3_wake_events, info->s0ix_wake_events); - } /* Clear wake event mask. */ diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h index 24c8922..7310ade 100644 --- a/src/ec/google/chromeec/ec.h +++ b/src/ec/google/chromeec/ec.h @@ -152,6 +152,7 @@ struct google_chromeec_event_info { uint64_t log_events; uint64_t sci_events; + uint64_t smi_events; uint64_t s3_wake_events; uint64_t s3_device_events; uint64_t s5_wake_events; -- To view, visit https://review.coreboot.org/26709 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I899a6af6e57d295b4eac2039c8245ebcc73a42bb Gerrit-Change-Number: 26709 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: [WIP]cpu/intel/model_206ax: Use cache_as_ram_ht.inc
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26708 ) Change subject: [WIP]cpu/intel/model_206ax: Use cache_as_ram_ht.inc ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73691/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27812/ : SUCCESS -- To view, visit https://review.coreboot.org/26708 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f73271721072fb3ea4aaaf0b09141d83cf5ff5f Gerrit-Change-Number: 26708 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 18:42:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cpu/intel/car/cache_as_ram_ht.inc: cache the whole ROM_SIZE
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26707 ) Change subject: cpu/intel/car/cache_as_ram_ht.inc: cache the whole ROM_SIZE ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/73692/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/27813/ : SUCCESS -- To view, visit https://review.coreboot.org/26707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieeaee7b47fc9c31e9abae8c49e16f62bee7c76d5 Gerrit-Change-Number: 26707 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 18:41:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018