coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: soc/cavium: Add secondary CPU support
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25752 ) Change subject: soc/cavium: Add secondary CPU support ...................................................................... Patch Set 16: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/73666/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/27789/ : SUCCESS -- To view, visit https://review.coreboot.org/25752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07428161615bcd3d03a3eea0df2dd813e08c8f66 Gerrit-Change-Number: 25752 Gerrit-PatchSet: 16 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 14:17:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/cavium: Add tool to convert devicetree blobs
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26228 ) Change subject: util/cavium: Add tool to convert devicetree blobs ...................................................................... Patch Set 11: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/73665/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/27788/ : SUCCESS -- To view, visit https://review.coreboot.org/26228 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76a5588aefe4f680228eca46a0e4dba7e695931c Gerrit-Change-Number: 26228 Gerrit-PatchSet: 11 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 14:16:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [HACK]cavium/arm-trusted-firmware: Use 9elements ATF
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25751 ) Change subject: [HACK]cavium/arm-trusted-firmware: Use 9elements ATF ...................................................................... Patch Set 16: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/73664/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/27787/ : SUCCESS -- To view, visit https://review.coreboot.org/25751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e9eb429d11150d43aa070d1bd6a11ea71951ce3 Gerrit-Change-Number: 25751 Gerrit-PatchSet: 16 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 14:16:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/cavium: Add PCI support
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25750 ) Change subject: soc/cavium: Add PCI support ...................................................................... Patch Set 16: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/73663/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/27786/ : SUCCESS -- To view, visit https://review.coreboot.org/25750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I881f38a26a165e6bd965fcd73547473b5e32d4b0 Gerrit-Change-Number: 25750 Gerrit-PatchSet: 16 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 30 May 2018 14:15:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: device/pci: Add MSI-X helper functions
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26329 ) Change subject: device/pci: Add MSI-X helper functions ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73662/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27785/ : SUCCESS -- To view, visit https://review.coreboot.org/26329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94413712e7986efd17e6b11ba59f6eb390384c8c Gerrit-Change-Number: 26329 Gerrit-PatchSet: 7 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 14:09:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/cavium/cn8100_sff_evb: Be verbose
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25449 ) Change subject: mb/cavium/cn8100_sff_evb: Be verbose ...................................................................... Patch Set 26: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73661/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27784/ : SUCCESS -- To view, visit https://review.coreboot.org/25449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0acac7a29290bc2eb9f4283317165fa0cf1b24e1 Gerrit-Change-Number: 25449 Gerrit-PatchSet: 26 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 14:05:27 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/cavium/cn81xx: Set cntfrq_el0
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25450 ) Change subject: soc/cavium/cn81xx: Set cntfrq_el0 ...................................................................... Patch Set 26: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73660/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27783/ : SUCCESS -- To view, visit https://review.coreboot.org/25450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b6d0b0cf646a066fc5a51552a1891eccbd91e5e Gerrit-Change-Number: 25450 Gerrit-PatchSet: 26 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 14:02:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/cavium: Enable MMU
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25371 ) Change subject: soc/cavium: Enable MMU ...................................................................... Patch Set 28: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73657/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27780/ : SUCCESS -- To view, visit https://review.coreboot.org/25371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I969446da62b4cc7adf9393fab69ff84ebf49220d Gerrit-Change-Number: 25371 Gerrit-PatchSet: 28 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:59:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: checkpatch: exclude util/crossgcc/patches
by Patrick Georgi (Code Review) 30 May '18

30 May '18

Hello Martin Roth, I'd like you to do a code review. Please visit https://review.coreboot.org/26695 to review the following change. Change subject: checkpatch: exclude util/crossgcc/patches ...................................................................... checkpatch: exclude util/crossgcc/patches These files are supposed to contain trailing whitespace due to the patch format. Change-Id: I8816c05ea703964a332915a0675096836957b242 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> --- M util/gitconfig/pre-commit M util/lint/lint-007-checkpatch 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/26695/1 diff --git a/util/gitconfig/pre-commit b/util/gitconfig/pre-commit index 2aed957..e48d2e1 100755 --- a/util/gitconfig/pre-commit +++ b/util/gitconfig/pre-commit @@ -24,5 +24,6 @@ if printf "%s\n" "$PATCHDIFF" | grep -q "@@"; then echo echo "Running checkpatch" - printf "%s\n" "$PATCHDIFF" | util/lint/checkpatch.pl --no-signoff -q - + printf "%s\n" "$PATCHDIFF" | util/lint/checkpatch.pl --no-signoff \ + -q - --exclude=util/crossgcc/patches fi diff --git a/util/lint/lint-007-checkpatch b/util/lint/lint-007-checkpatch index 2e451cb..8c3b05a 100755 --- a/util/lint/lint-007-checkpatch +++ b/util/lint/lint-007-checkpatch @@ -21,6 +21,7 @@ EXCLUDED_DIRS="^payloads/libpayload/util/kconfig\|\ ^payloads/libpayload/curses/PDCurses\|\ +^util/crossgcc/patches\|\ ^util/kconfig\|\ ^src/vendorcode\|\ ^Documentation" -- To view, visit https://review.coreboot.org/26695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8816c05ea703964a332915a0675096836957b242 Gerrit-Change-Number: 26695 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: util/gitconfig: improve robustness of checkpatch in pre-commit
by Patrick Georgi (Code Review) 30 May '18

30 May '18

Hello Martin Roth, I'd like you to do a code review. Please visit https://review.coreboot.org/26694 to review the following change. Change subject: util/gitconfig: improve robustness of checkpatch in pre-commit ...................................................................... util/gitconfig: improve robustness of checkpatch in pre-commit Users can have non-default configurations as to how git diff et al are presenting file names in diffs (default: a/ and b/ prefixes). checkpatch expects that and trims the first element, so enforce that configuration for the diff that's sent into it. Change-Id: I099795119456a73c900b31ce191c2d9e898a5c7e Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> --- M util/gitconfig/pre-commit 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/26694/1 diff --git a/util/gitconfig/pre-commit b/util/gitconfig/pre-commit index 0f13062..2aed957 100755 --- a/util/gitconfig/pre-commit +++ b/util/gitconfig/pre-commit @@ -20,7 +20,7 @@ %MAKE% lint-stable -PATCHDIFF=$(git diff --cached) +PATCHDIFF=$(git diff --cached --src-prefix=a/ --dst-prefix=b/) if printf "%s\n" "$PATCHDIFF" | grep -q "@@"; then echo echo "Running checkpatch" -- To view, visit https://review.coreboot.org/26694 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I099795119456a73c900b31ce191c2d9e898a5c7e Gerrit-Change-Number: 26694 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018