coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: [HACK]cavium/arm-trusted-firmware: Use 9elements ATF
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

1 0

Change in coreboot[master]: soc/cavium: Add PCI support
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25750 ) Change subject: soc/cavium: Add PCI support ...................................................................... Patch Set 15: Verified+1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/27773/ : SUCCESS -- To view, visit https://review.coreboot.org/25750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I881f38a26a165e6bd965fcd73547473b5e32d4b0 Gerrit-Change-Number: 25750 Gerrit-PatchSet: 15 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 30 May 2018 13:49:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/cavium/cn81xx: Set cntfrq_el0
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25450 ) Change subject: soc/cavium/cn81xx: Set cntfrq_el0 ...................................................................... Patch Set 25: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73654/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27770/ : SUCCESS -- To view, visit https://review.coreboot.org/25450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b6d0b0cf646a066fc5a51552a1891eccbd91e5e Gerrit-Change-Number: 25450 Gerrit-PatchSet: 25 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:47:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/cavium/cn8100_sff_evb: Be verbose
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25449 ) Change subject: mb/cavium/cn8100_sff_evb: Be verbose ...................................................................... Patch Set 25: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73653/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27769/ : SUCCESS -- To view, visit https://review.coreboot.org/25449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0acac7a29290bc2eb9f4283317165fa0cf1b24e1 Gerrit-Change-Number: 25449 Gerrit-PatchSet: 25 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:43:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/cavium: Enable MMU
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25371 ) Change subject: soc/cavium: Enable MMU ...................................................................... Patch Set 27: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/73652/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/27768/ : SUCCESS -- To view, visit https://review.coreboot.org/25371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I969446da62b4cc7adf9393fab69ff84ebf49220d Gerrit-Change-Number: 25371 Gerrit-PatchSet: 27 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:39:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/cavium: Clean uart code
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25448 ) Change subject: soc/cavium: Clean uart code ...................................................................... Patch Set 25: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/73650/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/27766/ : SUCCESS -- To view, visit https://review.coreboot.org/25448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1043b30318ec6210e2dd6b7ac313a41171d37f55 Gerrit-Change-Number: 25448 Gerrit-PatchSet: 25 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:35:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/cavium: Apply additional devicetree fixups
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25382 ) Change subject: soc/cavium: Apply additional devicetree fixups ...................................................................... Patch Set 26: (7 comments) https://review.coreboot.org/#/c/25382/26/src/soc/cavium/cn81xx/soc.c File src/soc/cavium/cn81xx/soc.c: https://review.coreboot.org/#/c/25382/26/src/soc/cavium/cn81xx/soc.c@79 PS26, Line 79: Remove 'phy-handle' if this option is not availble */ 'availble' may be misspelled - perhaps 'available'? https://review.coreboot.org/#/c/25382/26/src/soc/cavium/cn81xx/soc.c@137 PS26, Line 137: /* Extract our MAC address info so we can assign them in the device tree */ line over 80 characters https://review.coreboot.org/#/c/25382/26/src/soc/cavium/cn81xx/soc.c@169 PS26, Line 169: if (!strcmp(name, prop->prop.name)) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/25382/26/src/soc/cavium/cn81xx/soc.c@265 PS26, Line 265: BDK_BGXX_CMRX_RX_DMAC_CTL(bgx_interface, bgx_index)); line over 80 characters https://review.coreboot.org/#/c/25382/26/src/soc/cavium/cn81xx/soc.c@296 PS26, Line 296: /* ATF reserved */ code indent should use tabs where possible https://review.coreboot.org/#/c/25382/26/src/soc/cavium/cn81xx/soc.c@297 PS26, Line 297: bootmem_add_range(0, 1 * MiB, BM_MEM_RESERVED); code indent should use tabs where possible https://review.coreboot.org/#/c/25382/26/src/soc/cavium/cn81xx/soc.c@297 PS26, Line 297: bootmem_add_range(0, 1 * MiB, BM_MEM_RESERVED); please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/25382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e8eefd913915a879dad28dfb7801a2018ed2985 Gerrit-Change-Number: 25382 Gerrit-PatchSet: 26 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:30:48 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/cavium: Add secondary CPU support
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25752 ) Change subject: soc/cavium: Add secondary CPU support ...................................................................... Patch Set 15: (6 comments) https://review.coreboot.org/#/c/25752/15/src/mainboard/cavium/cn8100_sff_ev… File src/mainboard/cavium/cn8100_sff_evb/mainboard.c: https://review.coreboot.org/#/c/25752/15/src/mainboard/cavium/cn8100_sff_ev… PS15, Line 70: printk(BIOS_INFO, "MB: #CPU cores : %zu\n", cpu_get_num_available_cores()); line over 80 characters https://review.coreboot.org/#/c/25752/15/src/soc/cavium/cn81xx/cpu.c File src/soc/cavium/cn81xx/cpu.c: https://review.coreboot.org/#/c/25752/15/src/soc/cavium/cn81xx/cpu.c@35 PS15, Line 35: static void (* secondary_c_entry)(size_t core_id) = NULL; Unnecessary space before function pointer name https://review.coreboot.org/#/c/25752/15/src/soc/cavium/cn81xx/cpu.c@35 PS15, Line 35: static void (* secondary_c_entry)(size_t core_id) = NULL; space prohibited after that '*' (ctx:BxW) https://review.coreboot.org/#/c/25752/15/src/soc/cavium/cn81xx/cpu.c@67 PS15, Line 67: size_t start_cpu(size_t cpu, void (* entry_64)(size_t core_id)) space prohibited after that '*' (ctx:BxW) https://review.coreboot.org/#/c/25752/15/src/soc/cavium/cn81xx/cpu.c@121 PS15, Line 121: while (!stopwatch_expired(&sw) && !read64(&secondary_booted)); trailing statements should be on next line https://review.coreboot.org/#/c/25752/15/src/soc/cavium/cn81xx/include/soc/… File src/soc/cavium/cn81xx/include/soc/cpu.h: https://review.coreboot.org/#/c/25752/15/src/soc/cavium/cn81xx/include/soc/… PS15, Line 47: size_t start_cpu(size_t cpu, void (* entry_64)(size_t core_id)); space prohibited after that '*' (ctx:BxW) -- To view, visit https://review.coreboot.org/25752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07428161615bcd3d03a3eea0df2dd813e08c8f66 Gerrit-Change-Number: 25752 Gerrit-PatchSet: 15 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:30:06 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [HACK]cavium/arm-trusted-firmware: Use 9elements ATF
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25751 ) Change subject: [HACK]cavium/arm-trusted-firmware: Use 9elements ATF ...................................................................... Patch Set 15: (2 comments) https://review.coreboot.org/#/c/25751/15/src/soc/cavium/cn81xx/soc.c File src/soc/cavium/cn81xx/soc.c: https://review.coreboot.org/#/c/25751/15/src/soc/cavium/cn81xx/soc.c@59 PS15, Line 59: void *ptr = cbfs_boot_map_with_leak("sff8104-linux.dtb", CBFS_TYPE_RAW, &size); line over 80 characters https://review.coreboot.org/#/c/25751/15/src/soc/cavium/common/include/soc/… File src/soc/cavium/common/include/soc/bl31_plat_params.h: https://review.coreboot.org/#/c/25751/15/src/soc/cavium/common/include/soc/… PS15, Line 21: #include <soc/cavium/common/arm-trusted-firmware/plat/cavium/common/include/plat_params.h> line over 80 characters -- To view, visit https://review.coreboot.org/25751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e9eb429d11150d43aa070d1bd6a11ea71951ce3 Gerrit-Change-Number: 25751 Gerrit-PatchSet: 15 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:29:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/cavium/cn8100_sff_evb: Be verbose
by build bot (Jenkins) (Code Review) 30 May '18

30 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25449 ) Change subject: mb/cavium/cn8100_sff_evb: Be verbose ...................................................................... Patch Set 25: (1 comment) https://review.coreboot.org/#/c/25449/25/src/mainboard/cavium/cn8100_sff_ev… File src/mainboard/cavium/cn8100_sff_evb/mainboard.c: https://review.coreboot.org/#/c/25449/25/src/mainboard/cavium/cn8100_sff_ev… PS25, Line 41: switch (boot_method) { switch and case should be at the same indent -- To view, visit https://review.coreboot.org/25449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0acac7a29290bc2eb9f4283317165fa0cf1b24e1 Gerrit-Change-Number: 25449 Gerrit-PatchSet: 25 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 May 2018 13:29:00 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018