coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return ...
by build bot (Jenkins) (Code Review) 07 Mar '18

07 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25028 ) Change subject: mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return SKU IDs ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22800/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68366/ : SUCCESS -- To view, visit https://review.coreboot.org/25028 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I665fa491de6e277fea5cc071b1f04a21317bccba Gerrit-Change-Number: 25028 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Mar 2018 00:31:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return ...
by Shelley Chen (Code Review) 07 Mar '18

07 Mar '18

Hello build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/25028 to look at the new patch set (#2). Change subject: mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return SKU IDs ...................................................................... mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return SKU IDs Return proper SKU IDs so that mosys can return the proper variant. BUG=b:74059798 BRANCH=None TEST=./util/abuild/abuild -p none -t google/poppy -x -a Change-Id: I665fa491de6e277fea5cc071b1f04a21317bccba Signed-off-by: Shelley Chen <shchen(a)chromium.org> --- M src/mainboard/google/poppy/variants/nami/mainboard.c 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/25028/2 -- To view, visit https://review.coreboot.org/25028 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I665fa491de6e277fea5cc071b1f04a21317bccba Gerrit-Change-Number: 25028 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return ...
by build bot (Jenkins) (Code Review) 07 Mar '18

07 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25028 ) Change subject: mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return SKU IDs ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22798/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68364/ : SUCCESS -- To view, visit https://review.coreboot.org/25028 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I665fa491de6e277fea5cc071b1f04a21317bccba Gerrit-Change-Number: 25028 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Mar 2018 23:55:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy : Get SKU_ID from EC for Nami/Vayne
by build bot (Jenkins) (Code Review) 07 Mar '18

07 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24996 ) Change subject: mb/google/poppy : Get SKU_ID from EC for Nami/Vayne ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22799/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68365/ : SUCCESS -- To view, visit https://review.coreboot.org/24996 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42dd177de8c49cf3c122c2ebb1fcf42e5ba4cd75 Gerrit-Change-Number: 24996 Gerrit-PatchSet: 6 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jimmy M Wang <jimmym_wang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: luke yang <luke_yang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Wed, 07 Mar 2018 23:54:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return ...
by Shelley Chen (Code Review) 07 Mar '18

07 Mar '18

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/25028 ) Change subject: mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return SKU IDs ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/25028/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nami/mainboard.c: https://review.coreboot.org/#/c/25028/1/src/mainboard/google/poppy/variants… PS1, Line 72: 8 > Don't you need this to be 9? Oh sorry. I forgot the null termination. Thanks. -- To view, visit https://review.coreboot.org/25028 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I665fa491de6e277fea5cc071b1f04a21317bccba Gerrit-Change-Number: 25028 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Comment-Date: Wed, 07 Mar 2018 23:54:34 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return ...
by Furquan Shaikh (Code Review) 07 Mar '18

07 Mar '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/25028 ) Change subject: mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return SKU IDs ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/25028/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nami/mainboard.c: https://review.coreboot.org/#/c/25028/1/src/mainboard/google/poppy/variants… PS1, Line 72: 8 Don't you need this to be 9? -- To view, visit https://review.coreboot.org/25028 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I665fa491de6e277fea5cc071b1f04a21317bccba Gerrit-Change-Number: 25028 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Comment-Date: Wed, 07 Mar 2018 23:52:35 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/braswell: add resource allocation for LPE BAR1
by build bot (Jenkins) (Code Review) 07 Mar '18

07 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21103 ) Change subject: soc/intel/braswell: add resource allocation for LPE BAR1 ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22797/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68363/ : SUCCESS -- To view, visit https://review.coreboot.org/21103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa68319da5fb999fe8d73792eaee692cce60c8a2 Gerrit-Change-Number: 21103 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Mar 2018 23:50:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return ...
by Shelley Chen (Code Review) 07 Mar '18

07 Mar '18

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/25028 Change subject: mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return SKU IDs ...................................................................... mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return SKU IDs Return proper SKU IDs so that mosys can return the proper variant. BUG=b:74059798 BRANCH=None TEST=./util/abuild/abuild -p none -t google/poppy -x -a Change-Id: I665fa491de6e277fea5cc071b1f04a21317bccba Signed-off-by: Shelley Chen <shchen(a)chromium.org> --- M src/mainboard/google/poppy/variants/nami/mainboard.c 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/25028/1 diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c index 0f2dc9b..44b952f 100644 --- a/src/mainboard/google/poppy/variants/nami/mainboard.c +++ b/src/mainboard/google/poppy/variants/nami/mainboard.c @@ -14,12 +14,14 @@ */ #include <arch/cpu.h> +#include <assert.h> +#include <baseboard/variants.h> #include <chip.h> #include <device/device.h> -#include <assert.h> #include <ec/google/chromeec/ec.h> +#include <smbios.h> #include <soc/ramstage.h> -#include <baseboard/variants.h> +#include <string.h> #define SKU_0_Nami 0x3A7B #define SKU_1_Vayne 0x3A63 @@ -64,3 +66,12 @@ break; } } + +const char *smbios_mainboard_sku(void) +{ + static char sku_str[8]; /* sku{0..65535} (basically up to FFFF) */ + + snprintf(sku_str, sizeof(sku_str), "sku%d", board_sku_id()); + + return sku_str; +} -- To view, visit https://review.coreboot.org/25028 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I665fa491de6e277fea5cc071b1f04a21317bccba Gerrit-Change-Number: 25028 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com>

1 0

Change in coreboot[master]: [UNTESTED] soc/intel/braswell/lpe: Remove ASL remnants of BAR1
by Matt DeVillier (Code Review) 07 Mar '18

07 Mar '18

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/25020 ) Change subject: [UNTESTED] soc/intel/braswell/lpe: Remove ASL remnants of BAR1 ...................................................................... Patch Set 1: Code-Review-1 Although the Windows driver doesn't report any resource-related issues, the device fails to start with a Code 10 error (the requested operation was unsuccessful) and audio is non-functional -- To view, visit https://review.coreboot.org/25020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic265afc2b27c261ebdde42337c9dcc7c1ccc84f3 Gerrit-Change-Number: 25020 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Mar 2018 23:32:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Support I2C device enable
by build bot (Jenkins) (Code Review) 07 Mar '18

07 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25026 ) Change subject: soc/amd/stoneyridge: Support I2C device enable ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22795/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68361/ : SUCCESS -- To view, visit https://review.coreboot.org/25026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb55c49cf56c65a9c2e1838cff1ed5afc04e1826 Gerrit-Change-Number: 25026 Gerrit-PatchSet: 1 Gerrit-Owner: Garrett Kirkendall <garrett.kirkendall(a)amd.corp-partner.google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Mar 2018 23:06:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018