coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: acpi: update a comment referencing ACPI ID
by Joel Kitching (Code Review) 07 Mar '18

07 Mar '18

Joel Kitching has uploaded this change for review. ( https://review.coreboot.org/25042 Change subject: acpi: update a comment referencing ACPI ID ...................................................................... acpi: update a comment referencing ACPI ID ACPI ID for coreboot is now "BOOT" according to CL:18521. BUG=none BRANCH=master TEST=none Change-Id: I802ce284001b186f6cd8839b8c303d49f42b4d38 Signed-off-by: Joel Kitching <kitching(a)google.com> --- M src/arch/x86/acpigen.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/25042/1 diff --git a/src/arch/x86/acpigen.c b/src/arch/x86/acpigen.c index bdb73bf..fc6cc66 100644 --- a/src/arch/x86/acpigen.c +++ b/src/arch/x86/acpigen.c @@ -223,7 +223,7 @@ void acpigen_write_coreboot_hid(enum coreboot_acpi_ids id) { - char hid[9]; /* CORExxxx */ + char hid[9]; /* BOOTxxxx */ snprintf(hid, sizeof(hid), "%.4s%04X", COREBOOT_ACPI_ID, id); acpigen_write_name_string("_HID", hid); -- To view, visit https://review.coreboot.org/25042 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I802ce284001b186f6cd8839b8c303d49f42b4d38 Gerrit-Change-Number: 25042 Gerrit-PatchSet: 1 Gerrit-Owner: Joel Kitching <kitching(a)google.com>

1 0

Change in coreboot[master]: mb/google/poppy : Get SKU_ID from EC for Nami/Vayne
by build bot (Jenkins) (Code Review) 07 Mar '18

07 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24996 ) Change subject: mb/google/poppy : Get SKU_ID from EC for Nami/Vayne ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22802/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68369/ : SUCCESS -- To view, visit https://review.coreboot.org/24996 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42dd177de8c49cf3c122c2ebb1fcf42e5ba4cd75 Gerrit-Change-Number: 24996 Gerrit-PatchSet: 8 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jimmy M Wang <jimmym_wang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: luke yang <luke_yang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 08 Mar 2018 03:36:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy : Get SKU_ID from EC for Nami/Vayne
by build bot (Jenkins) (Code Review) 07 Mar '18

07 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24996 ) Change subject: mb/google/poppy : Get SKU_ID from EC for Nami/Vayne ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22801/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68368/ : SUCCESS -- To view, visit https://review.coreboot.org/24996 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42dd177de8c49cf3c122c2ebb1fcf42e5ba4cd75 Gerrit-Change-Number: 24996 Gerrit-PatchSet: 7 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jimmy M Wang <jimmym_wang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: luke yang <luke_yang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Thu, 08 Mar 2018 03:14:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/scarlet: Adjust K&D power sequence from software
by build bot (Jenkins) (Code Review) 07 Mar '18

07 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25023 ) Change subject: google/scarlet: Adjust K&D power sequence from software ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68367/ : SUCCESS -- To view, visit https://review.coreboot.org/25023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia076a378b10417dd9891746f9bc1086360a0f6e6 Gerrit-Change-Number: 25023 Gerrit-PatchSet: 3 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Mar 2018 02:35:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: google/scarlet: Adjust K&D power sequence from software
by Brian Norris (Code Review) 07 Mar '18

07 Mar '18

Brian Norris has posted comments on this change. ( https://review.coreboot.org/25023 ) Change subject: google/scarlet: Adjust K&D power sequence from software ...................................................................... Patch Set 3: Hey, display vendors read Gerrit and help me correct typos! Whoa! -- To view, visit https://review.coreboot.org/25023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia076a378b10417dd9891746f9bc1086360a0f6e6 Gerrit-Change-Number: 25023 Gerrit-PatchSet: 3 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Mar 2018 02:32:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: google/scarlet: Adjust K&D power sequence from software
by Brian Norris (Code Review) 07 Mar '18

07 Mar '18

Hello Lin Huang, Julius Werner, build bot (Jenkins), Matthias Kaehlcke, I'd like you to reexamine a change. Please visit https://review.coreboot.org/25023 to look at the new patch set (#3). Change subject: google/scarlet: Adjust K&D power sequence from software ...................................................................... google/scarlet: Adjust K&D power sequence from software Hardware updates have suggested we need to configure the K&D panel's power sequence in software, not in hardware. Without this change, K&D panels will no longer power on correctly and will instead display a black screen. Per K&D's suggestion, we tweak these two commands. From the little HW docs I have, this looks like it's: (Address 0xB7, Value 0x02) -> set BC_CTRL=bit(1) (Back light control) to 1 (Address 0xF1, Value 0x22) -> change GPO2_SEL=bits(0:3) from MIPI_TE(0001b) to BC_CTRL (0010b) BRANCH=scarlet BUG=b:73133861 TEST=KD display with and without HW fix on Scarlet Change-Id: Ia076a378b10417dd9891746f9bc1086360a0f6e6 Signed-off-by: Brian Norris <briannorris(a)chromium.org> --- M src/mainboard/google/gru/mainboard.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/25023/3 -- To view, visit https://review.coreboot.org/25023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia076a378b10417dd9891746f9bc1086360a0f6e6 Gerrit-Change-Number: 25023 Gerrit-PatchSet: 3 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: google/scarlet: Adjust K&D power sequence from software
by Brian Norris (Code Review) 07 Mar '18

07 Mar '18

Brian Norris has posted comments on this change. ( https://review.coreboot.org/25023 ) Change subject: google/scarlet: Adjust K&D power sequence from software ...................................................................... Patch Set 2: I guess I don't have 'submit' permissions? -- To view, visit https://review.coreboot.org/25023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia076a378b10417dd9891746f9bc1086360a0f6e6 Gerrit-Change-Number: 25023 Gerrit-PatchSet: 2 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Mar 2018 01:25:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: google/scarlet: Adjust K&D power sequence from software
by Brian Norris (Code Review) 07 Mar '18

07 Mar '18

Brian Norris has posted comments on this change. ( https://review.coreboot.org/25023 ) Change subject: google/scarlet: Adjust K&D power sequence from software ...................................................................... Patch Set 2: Hey, I documented it this time! Kind of. -- To view, visit https://review.coreboot.org/25023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia076a378b10417dd9891746f9bc1086360a0f6e6 Gerrit-Change-Number: 25023 Gerrit-PatchSet: 2 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Mar 2018 01:24:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: google/scarlet: Adjust K&D power sequence from software
by Julius Werner (Code Review) 07 Mar '18

07 Mar '18

Julius Werner has posted comments on this change. ( https://review.coreboot.org/25023 ) Change subject: google/scarlet: Adjust K&D power sequence from software ...................................................................... Patch Set 2: Code-Review+2 More random numbers in the MIPI init always look good to me. -- To view, visit https://review.coreboot.org/25023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia076a378b10417dd9891746f9bc1086360a0f6e6 Gerrit-Change-Number: 25023 Gerrit-PatchSet: 2 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Mar 2018 01:22:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return ...
by Furquan Shaikh (Code Review) 07 Mar '18

07 Mar '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/25028 ) Change subject: mb/google/poppy/variants/nami: Define smbios_mainboard_sku to return SKU IDs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/25028 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I665fa491de6e277fea5cc071b1f04a21317bccba Gerrit-Change-Number: 25028 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 08 Mar 2018 00:34:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018