coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: coreboot_table: Print GPIO state correctly for lb_gpios
by build bot (Jenkins) (Code Review) 07 Mar '18

07 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25022 ) Change subject: coreboot_table: Print GPIO state correctly for lb_gpios ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22787/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68353/ : SUCCESS -- To view, visit https://review.coreboot.org/25022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59b4d49955c13f920576dd09f463e2d399ab64e0 Gerrit-Change-Number: 25022 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Mar 2018 21:32:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/scarlet: Adjust K&D power sequence from software
by Matthias Kaehlcke (Code Review) 07 Mar '18

07 Mar '18

Matthias Kaehlcke has posted comments on this change. ( https://review.coreboot.org/25023 ) Change subject: google/scarlet: Adjust K&D power sequence from software ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/25023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia076a378b10417dd9891746f9bc1086360a0f6e6 Gerrit-Change-Number: 25023 Gerrit-PatchSet: 2 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Mar 2018 21:28:37 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/scaleway/tagada: Override baudrate with bmcInfo
by build bot (Jenkins) (Code Review) 07 Mar '18

07 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23815 ) Change subject: mb/scaleway/tagada: Override baudrate with bmcInfo ...................................................................... Patch Set 8: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22789/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68355/ : SUCCESS -- To view, visit https://review.coreboot.org/23815 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd93b64ef91a569127a0713fdb499dff2a1f11db Gerrit-Change-Number: 23815 Gerrit-PatchSet: 8 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Mar 2018 21:16:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: google/scarlet: Adjust K&D power sequence from software
by build bot (Jenkins) (Code Review) 07 Mar '18

07 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25023 ) Change subject: google/scarlet: Adjust K&D power sequence from software ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/22788/ : ABORTED https://qa.coreboot.org/job/coreboot-gerrit/68354/ : ABORTED -- To view, visit https://review.coreboot.org/25023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia076a378b10417dd9891746f9bc1086360a0f6e6 Gerrit-Change-Number: 25023 Gerrit-PatchSet: 1 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Mar 2018 21:12:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/scarlet: Adjust K&D power sequence from software
by Brian Norris (Code Review) 07 Mar '18

07 Mar '18

Brian Norris has uploaded a new patch set (#2). ( https://review.coreboot.org/25023 ) Change subject: google/scarlet: Adjust K&D power sequence from software ...................................................................... google/scarlet: Adjust K&D power sequence from software Hardware updates have suggested we need to configure the K&D panel's power sequence in software, not in hardware. Without this change, K&D panels will no longer power on correctly and will instead display a black screen. Per K&D's suggestion, we tweak these two commands. From the little HW docs I have, this looks like it's: (Address 0xB7, Value 0x02) -> set BC_CTRL=bit(1) (Back light control) to 1 (Address 0xF1, Value 0x23) -> change GPO2_SEL=bits(0:3) from MIPI_TE(0001b) to BC_CTRL (0010b) BRANCH=scarlet BUG=b:73133861 TEST=KD display with and without HW fix on Scarlet Change-Id: Ia076a378b10417dd9891746f9bc1086360a0f6e6 Signed-off-by: Brian Norris <briannorris(a)chromium.org> --- M src/mainboard/google/gru/mainboard.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/25023/2 -- To view, visit https://review.coreboot.org/25023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia076a378b10417dd9891746f9bc1086360a0f6e6 Gerrit-Change-Number: 25023 Gerrit-PatchSet: 2 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org>

1 0

Change in coreboot[master]: google/scarlet: Adjust K&D power sequence from software
by Brian Norris (Code Review) 07 Mar '18

07 Mar '18

Brian Norris has uploaded this change for review. ( https://review.coreboot.org/25023 Change subject: google/scarlet: Adjust K&D power sequence from software ...................................................................... google/scarlet: Adjust K&D power sequence from software Hardware updates have suggested we need to configure the K&D panel's power sequence in software, not in hardware. Without this change, K&D panels will no longer power on correctly and will instead display a black screen. Per K&D's suggestion, we tweak these two commands. From the little HW docs I have, this looks like it's: (Address 0xB7, Value 0x02) -> set BC_CTRL=bit(1) (Back light control) to 1 (Address 0xF1, Value 0x23) -> change GPO2_SEL=bits(0:3) from MIPI_TE(0001b) to BC_CTRL (0010b) BRANCH=scarlet BUG=b:73133861 TEST=KD display with and without HW fix on Scarlet Change-Id: Ia076a378b10417dd9891746f9bc1086360a0f6e6 Signed-off-by: Brian Norris <briannorris(a)chromium.org> --- M src/mainboard/google/gru/mainboard.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/25023/1 diff --git a/src/mainboard/google/gru/mainboard.c b/src/mainboard/google/gru/mainboard.c index 7cd9acd..c9f3c48 100644 --- a/src/mainboard/google/gru/mainboard.c +++ b/src/mainboard/google/gru/mainboard.c @@ -493,6 +493,7 @@ MIPI_INIT_CMD(0xB4, 0x00), MIPI_INIT_CMD(0xB6, 0x80), /* VCOM disable */ + MIPI_INIT_CMD(0xB7, 0x02), MIPI_INIT_CMD(0xB8, 0x80), MIPI_INIT_CMD(0xBA, 0x43), /* VCOM setting */ @@ -506,7 +507,7 @@ /* VGL setting */ MIPI_INIT_CMD(0xBF, 0x1A), MIPI_INIT_CMD(0xF0, 0x39), - MIPI_INIT_CMD(0xF1, 0x21), + MIPI_INIT_CMD(0xF1, 0x22), /* Gamma setting */ MIPI_INIT_CMD(0xB0, 0x02), MIPI_INIT_CMD(0xC0, 0x00), -- To view, visit https://review.coreboot.org/25023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia076a378b10417dd9891746f9bc1086360a0f6e6 Gerrit-Change-Number: 25023 Gerrit-PatchSet: 1 Gerrit-Owner: Brian Norris <briannorris(a)chromium.org>

1 0

Change in coreboot[master]: coreboot_table: Print GPIO state correctly for lb_gpios
by Julius Werner (Code Review) 07 Mar '18

07 Mar '18

Hello Nick Vaccaro, Furquan Shaikh, I'd like you to do a code review. Please visit https://review.coreboot.org/25022 to review the following change. Change subject: coreboot_table: Print GPIO state correctly for lb_gpios ...................................................................... coreboot_table: Print GPIO state correctly for lb_gpios Looks like there's a typo in the GPIO state table we print as part of assembling the coreboot tables. Of course, high GPIOs are represented as 1 and low GPIOs as 0. Fix this display bug. Change-Id: I59b4d49955c13f920576dd09f463e2d399ab64e0 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/lib/coreboot_table.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/25022/1 diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c index aeaff28..d03b771 100644 --- a/src/lib/coreboot_table.c +++ b/src/lib/coreboot_table.c @@ -186,10 +186,10 @@ printk(BIOS_INFO, " low | "); switch (g->value) { case 0: - printk(BIOS_INFO, " high\n"); + printk(BIOS_INFO, " low\n"); break; case 1: - printk(BIOS_INFO, " low\n"); + printk(BIOS_INFO, " high\n"); break; default: printk(BIOS_INFO, "undefined\n"); -- To view, visit https://review.coreboot.org/25022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I59b4d49955c13f920576dd09f463e2d399ab64e0 Gerrit-Change-Number: 25022 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>

1 0

Change in coreboot[master]: mb/intel/glkrvp: Enable ThunderPeak wifi card
by build bot (Jenkins) (Code Review) 07 Mar '18

07 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24931 ) Change subject: mb/intel/glkrvp: Enable ThunderPeak wifi card ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22786/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68352/ : SUCCESS -- To view, visit https://review.coreboot.org/24931 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b3f871bdc67bfc4ed283b997b2a5698451b2bd2 Gerrit-Change-Number: 24931 Gerrit-PatchSet: 2 Gerrit-Owner: Roy Mingi Park <roy.mingi.park(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Roy Mingi Park <roy.mingi.park(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Mar 2018 21:08:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/kahlee: Set GPIO 40 to input
by build bot (Jenkins) (Code Review) 07 Mar '18

07 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25016 ) Change subject: mainboard/google/kahlee: Set GPIO 40 to input ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22785/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68351/ : SUCCESS -- To view, visit https://review.coreboot.org/25016 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a04cbab1276cd20e7f9c7576e8111089dd2b155 Gerrit-Change-Number: 25016 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Wed, 07 Mar 2018 19:43:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: timestamps: Add timestamps around the vbios load & init
by build bot (Jenkins) (Code Review) 07 Mar '18

07 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25018 ) Change subject: timestamps: Add timestamps around the vbios load & init ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22784/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68350/ : SUCCESS -- To view, visit https://review.coreboot.org/25018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I878ba653eb086ad6c6614aa08a6d3fe216a9323e Gerrit-Change-Number: 25018 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Mar 2018 19:38:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018