Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30040
to look at the new patch set (#2).
Change subject: src: Get rid of "#define __SIMPLE_DEVICE__"
......................................................................
src: Get rid of "#define __SIMPLE_DEVICE__"
Change-Id: I4dd770fcddf44aeec847d3651ec281af5f91fbf0
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/commonlib/storage/pci_sdhci.c
M src/drivers/uart/oxpcie_early.c
M src/mainboard/intel/galileo/reg_access.c
M src/mainboard/lenovo/t400/dock.c
M src/mainboard/lenovo/x200/dock.c
M src/mainboard/lenovo/x201/dock.c
M src/northbridge/amd/pi/ramtop.c
M src/northbridge/intel/e7505/memmap.c
M src/northbridge/intel/fsp_rangeley/port_access.c
M src/northbridge/intel/gm45/ram_calc.c
M src/northbridge/intel/haswell/ram_calc.c
M src/northbridge/intel/i440bx/ram_calc.c
M src/northbridge/intel/i945/ram_calc.c
M src/northbridge/intel/nehalem/acpi.c
M src/northbridge/intel/nehalem/ram_calc.c
M src/northbridge/intel/nehalem/smi.c
M src/northbridge/intel/pineview/ram_calc.c
M src/northbridge/intel/sandybridge/ram_calc.c
M src/northbridge/intel/x4x/ram_calc.c
M src/northbridge/via/vx900/memmap.c
M src/soc/amd/stoneyridge/enable_usbdebug.c
M src/soc/amd/stoneyridge/ramtop.c
M src/soc/intel/apollolake/pmutil.c
M src/soc/intel/broadwell/usb_debug.c
M src/soc/intel/cannonlake/pmutil.c
M src/soc/intel/common/block/lpc/lpc_lib.c
M src/soc/intel/fsp_broadwell_de/smmrelocate.c
M src/soc/intel/icelake/pmutil.c
M src/soc/intel/quark/reg_access.c
M src/southbridge/amd/agesa/hudson/enable_usbdebug.c
M src/southbridge/amd/agesa/hudson/reset.c
M src/southbridge/amd/amd8111/reset.c
M src/southbridge/amd/cimx/sb800/reset.c
M src/southbridge/amd/cimx/sb900/early.c
M src/southbridge/amd/cimx/sb900/reset.c
M src/southbridge/amd/pi/hudson/enable_usbdebug.c
M src/southbridge/amd/pi/hudson/imc.c
M src/southbridge/amd/pi/hudson/reset.c
M src/southbridge/amd/sb700/enable_usbdebug.c
M src/southbridge/amd/sb700/reset.c
M src/southbridge/amd/sb800/enable_usbdebug.c
M src/southbridge/amd/sb800/reset.c
M src/southbridge/broadcom/bcm5785/reset.c
M src/southbridge/intel/common/usb_debug.c
M src/southbridge/intel/ibexpeak/smi.c
M src/southbridge/nvidia/ck804/enable_usbdebug.c
M src/southbridge/nvidia/ck804/reset.c
M src/southbridge/nvidia/mcp55/enable_usbdebug.c
M src/southbridge/nvidia/mcp55/reset.c
49 files changed, 0 insertions(+), 118 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/30040/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/30040
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4dd770fcddf44aeec847d3651ec281af5f91fbf0
Gerrit-Change-Number: 30040
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30040
Change subject: sb/nvidia/{ck804,mcp55}: Remove define __SIMPLE_DEVICE__
......................................................................
sb/nvidia/{ck804,mcp55}: Remove define __SIMPLE_DEVICE__
define __SIMPLE_DEVICE__is not needed as pci_devfn_t is
already used.
Change-Id: I4dd770fcddf44aeec847d3651ec281af5f91fbf0
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/southbridge/nvidia/ck804/enable_usbdebug.c
M src/southbridge/nvidia/ck804/reset.c
M src/southbridge/nvidia/mcp55/enable_usbdebug.c
M src/southbridge/nvidia/mcp55/reset.c
4 files changed, 0 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/30040/1
diff --git a/src/southbridge/nvidia/ck804/enable_usbdebug.c b/src/southbridge/nvidia/ck804/enable_usbdebug.c
index 7296e05..2e9a5e0 100644
--- a/src/southbridge/nvidia/ck804/enable_usbdebug.c
+++ b/src/southbridge/nvidia/ck804/enable_usbdebug.c
@@ -17,9 +17,6 @@
* GNU General Public License for more details.
*/
-// Use simple device model for this file even in ramstage
-#define __SIMPLE_DEVICE__
-
#include <stdint.h>
#include <arch/io.h>
#include <device/pci_ehci.h>
diff --git a/src/southbridge/nvidia/ck804/reset.c b/src/southbridge/nvidia/ck804/reset.c
index f828c53..f1ec77e 100644
--- a/src/southbridge/nvidia/ck804/reset.c
+++ b/src/southbridge/nvidia/ck804/reset.c
@@ -14,8 +14,6 @@
* GNU General Public License for more details.
*/
-#define __SIMPLE_DEVICE__
-
#include <arch/io.h>
#include <reset.h>
diff --git a/src/southbridge/nvidia/mcp55/enable_usbdebug.c b/src/southbridge/nvidia/mcp55/enable_usbdebug.c
index 69e0859..4a48638 100644
--- a/src/southbridge/nvidia/mcp55/enable_usbdebug.c
+++ b/src/southbridge/nvidia/mcp55/enable_usbdebug.c
@@ -17,9 +17,6 @@
* GNU General Public License for more details.
*/
-// Use simple device model for this file even in ramstage
-#define __SIMPLE_DEVICE__
-
#include <stdint.h>
#include <arch/io.h>
#include <device/pci_ehci.h>
diff --git a/src/southbridge/nvidia/mcp55/reset.c b/src/southbridge/nvidia/mcp55/reset.c
index d6f7f6f..eb16ef1 100644
--- a/src/southbridge/nvidia/mcp55/reset.c
+++ b/src/southbridge/nvidia/mcp55/reset.c
@@ -17,8 +17,6 @@
* GNU General Public License for more details.
*/
-#define __SIMPLE_DEVICE__
-
#include <arch/io.h>
#include <reset.h>
--
To view, visit https://review.coreboot.org/c/coreboot/+/30040
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4dd770fcddf44aeec847d3651ec281af5f91fbf0
Gerrit-Change-Number: 30040
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-MessageType: newchange