coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in ...coreboot[master]: mb/google/dragonegg: Enable ps2 keyboard
by Aamir Bohra (Code Review) 21 Nov '18

21 Nov '18

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29750 ) Change subject: mb/google/dragonegg: Enable ps2 keyboard ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a6b382be84bc5201beafe21ff8ddee3738bc5c2 Gerrit-Change-Number: 29750 Gerrit-PatchSet: 7 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Nov 2018 08:23:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/poppy/variants/nami: Enable g2touch touchscreen device
by Crystal Lin (Code Review) 21 Nov '18

21 Nov '18

Crystal Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29768 Change subject: mb/google/poppy/variants/nami: Enable g2touch touchscreen device ...................................................................... mb/google/poppy/variants/nami: Enable g2touch touchscreen device This change adds ACPI properties for GGT_7503 device. BUG=b:119169362 BRANCH=firmware-nami-10775.B TEST=Verify touchscreen works with this change Change-Id: I26e16b7e118121b3dd9a88c76d04898b97753df0 Signed-off-by: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com> --- M src/mainboard/google/poppy/variants/nami/devicetree.cb 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/29768/1 diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb index de00522..3a78c4a 100644 --- a/src/mainboard/google/poppy/variants/nami/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb @@ -346,6 +346,20 @@ register "hid_desc_reg_offset" = "0x20" device i2c 20 on end end + chip drivers/i2c/hid + register "generic.hid" = ""GGT_7503"" + register "generic.desc" = ""G2TOUCH Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_E7_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_B3)" + register "generic.reset_delay_ms" = "50" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B4)" + register "generic.enable_delay_ms" = "1" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 40 on end + end end # I2C #0 device pci 15.1 on chip drivers/i2c/generic -- To view, visit https://review.coreboot.org/c/coreboot/+/29768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I26e16b7e118121b3dd9a88c76d04898b97753df0 Gerrit-Change-Number: 29768 Gerrit-PatchSet: 1 Gerrit-Owner: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: mb/google/fizz/variants/karma: Disable SD controller and update GPIO
by David Wu (Code Review) 21 Nov '18

21 Nov '18

Hello Zhuohao Lee, Shelley Chen, build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29765 to look at the new patch set (#3). Change subject: mb/google/fizz/variants/karma: Disable SD controller and update GPIO ...................................................................... mb/google/fizz/variants/karma: Disable SD controller and update GPIO The SD cardreader is on USB bus, not on SDIO/SDXC. BUG=b:119798840 BRANCH=master TEST=Compiles successfully and boot on DUT. Change-Id: I8015fe35a4ff79469b5781942f588c3e1b88b751 Signed-off-by: David Wu <David_Wu(a)quanta.corp-partner.google.com> --- M src/mainboard/google/fizz/variants/baseboard/devicetree.cb M src/mainboard/google/fizz/variants/fizz/overridetree.cb M src/mainboard/google/fizz/variants/karma/gpio.c M src/mainboard/google/fizz/variants/karma/overridetree.cb 4 files changed, 40 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/29765/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/29765 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8015fe35a4ff79469b5781942f588c3e1b88b751 Gerrit-Change-Number: 29765 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: mb/google/fizz/variants/karma: Disable SD controller and update GPIO
by David Wu (Code Review) 21 Nov '18

21 Nov '18

David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29765 ) Change subject: mb/google/fizz/variants/karma: Disable SD controller and update GPIO ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/29765/2/src/mainboard/google/fizz/variants/… File src/mainboard/google/fizz/variants/karma/overridetree.cb: https://review.coreboot.org/#/c/29765/2/src/mainboard/google/fizz/variants/… PS2, Line 24: 2.3 > Devices 2.3, 2.9, 3.3 in baseboard/devicetree should be moved to fizz/overridetree. […] I can't see device 2.9 in baseboard/devicetree.cb, so I will move device 2.3 and 3.3 to fizz/overridetree.cb. Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/29765 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8015fe35a4ff79469b5781942f588c3e1b88b751 Gerrit-Change-Number: 29765 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Nov 2018 07:29:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: riscv: fix bug of sifive-gpt.py
by Xiang Wang (Code Review) 21 Nov '18

21 Nov '18

Xiang Wang has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/29767 ) Change subject: riscv: fix bug of sifive-gpt.py ...................................................................... riscv: fix bug of sifive-gpt.py The GPT version must be "00 00 01 00" and the small end should be represented as 0x10000. Please refer to: https://en.wikipedia.org/wiki/GUID_Partition_Table Change-Id: Ib025197fc96f32823e687a89de0cee51c952b031 Signed-off-by: Xiang Wang <wxjstz(a)126.com> --- M util/riscv/sifive-gpt.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/29767/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29767 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib025197fc96f32823e687a89de0cee51c952b031 Gerrit-Change-Number: 29767 Gerrit-PatchSet: 2 Gerrit-Owner: Xiang Wang <wxjstz(a)126.com> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: riscv: fix bug of riscv
by Xiang Wang (Code Review) 21 Nov '18

21 Nov '18

Xiang Wang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29767 Change subject: riscv: fix bug of riscv ...................................................................... riscv: fix bug of riscv The GPT version must be "00 00 01 00" and the small end should be represented as 0x10000. Please refer to: https://en.wikipedia.org/wiki/GUID_Partition_Table Change-Id: Ib025197fc96f32823e687a89de0cee51c952b031 Signed-off-by: Xiang Wang <wxjstz(a)126.com> --- M util/riscv/sifive-gpt.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/29767/1 diff --git a/util/riscv/sifive-gpt.py b/util/riscv/sifive-gpt.py index 7f522d9..f1e4fa8 100755 --- a/util/riscv/sifive-gpt.py +++ b/util/riscv/sifive-gpt.py @@ -88,7 +88,7 @@ def pack_with_crc(self, crc): header_size = 92 header = struct.pack('<8sIIIIQQQQ16sQIII', - b'EFI PART', 0x100, header_size, crc, 0, + b'EFI PART', 0x10000, header_size, crc, 0, self.current_lba, self.backup_lba, self.first_usable_lba, self.last_usable_lba, self.uniq.get_bytes(), self.part_entries_lba, self.part_entries_number, -- To view, visit https://review.coreboot.org/c/coreboot/+/29767 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib025197fc96f32823e687a89de0cee51c952b031 Gerrit-Change-Number: 29767 Gerrit-PatchSet: 1 Gerrit-Owner: Xiang Wang <wxjstz(a)126.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: mb/google/fizz/variants/karma: Disable SD controller and update GPIO
by Furquan Shaikh (Code Review) 21 Nov '18

21 Nov '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29765 ) Change subject: mb/google/fizz/variants/karma: Disable SD controller and update GPIO ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/29765/2/src/mainboard/google/fizz/variants/… File src/mainboard/google/fizz/variants/karma/overridetree.cb: https://review.coreboot.org/#/c/29765/2/src/mainboard/google/fizz/variants/… PS2, Line 24: 2.3 Devices 2.3, 2.9, 3.3 in baseboard/devicetree should be moved to fizz/overridetree.cb -- To view, visit https://review.coreboot.org/c/coreboot/+/29765 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8015fe35a4ff79469b5781942f588c3e1b88b751 Gerrit-Change-Number: 29765 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Nov 2018 07:18:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/dragonegg: Enable trackpad
by Subrata Banik (Code Review) 21 Nov '18

21 Nov '18

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29752 ) Change subject: mb/google/dragonegg: Enable trackpad ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86d6b7815147d558065611604363bb607119c154 Gerrit-Change-Number: 29752 Gerrit-PatchSet: 7 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Nov 2018 07:17:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/dragonegg: Enable ps2 keyboard
by Subrata Banik (Code Review) 21 Nov '18

21 Nov '18

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29750 ) Change subject: mb/google/dragonegg: Enable ps2 keyboard ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a6b382be84bc5201beafe21ff8ddee3738bc5c2 Gerrit-Change-Number: 29750 Gerrit-PatchSet: 7 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Nov 2018 07:17:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/dragonegg: Add initial mainboard code support
by Subrata Banik (Code Review) 21 Nov '18

21 Nov '18

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29749 ) Change subject: mb/google/dragonegg: Add initial mainboard code support ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2cc269cb0050bf5b031f48cfe114485c55ab8fa9 Gerrit-Change-Number: 29749 Gerrit-PatchSet: 7 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 21 Nov 2018 07:17:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018