coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in ...coreboot[master]: src: Remove duplicated round up function
by build bot (Jenkins) (Code Review) 27 Nov '18

27 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29847 ) Change subject: src: Remove duplicated round up function ...................................................................... Patch Set 4: (2 comments) https://review.coreboot.org/#/c/29847/4/src/soc/nvidia/tegra210/include/soc… File src/soc/nvidia/tegra210/include/soc/clock.h: https://review.coreboot.org/#/c/29847/4/src/soc/nvidia/tegra210/include/soc… PS4, Line 327: #define get_i2c_clk_div(src,freq) (DIV_ROUND_UP(src, (freq) * (0x19 + 1) * 8) - 1) line over 80 characters https://review.coreboot.org/#/c/29847/4/src/soc/nvidia/tegra210/include/soc… PS4, Line 327: #define get_i2c_clk_div(src,freq) (DIV_ROUND_UP(src, (freq) * (0x19 + 1) * 8) - 1) space required after that ',' (ctx:VxV) -- To view, visit https://review.coreboot.org/c/coreboot/+/29847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9aabc3fbe7834834c92d6ba59ff0005986622a34 Gerrit-Change-Number: 29847 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Nov 2018 07:31:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: src: Remove duplicated round up function
by HAOUAS Elyes (Code Review) 27 Nov '18

27 Nov '18

Hello Patrick Rudolph, Julius Werner, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29847 to look at the new patch set (#4). Change subject: src: Remove duplicated round up function ...................................................................... src: Remove duplicated round up function Fixes 7116ac8037 (src: Make use of 'CEIL_DIV(a, b)' macro across tree). Change-Id: I9aabc3fbe7834834c92d6ba59ff0005986622a34 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/arm/armv7/mmu.c M src/commonlib/include/commonlib/helpers.h M src/cpu/allwinner/a10/clock.c M src/cpu/x86/tsc/delay_tsc.c M src/include/stdlib.h M src/lib/edid.c M src/mainboard/google/nyan/romstage.c M src/mainboard/google/nyan_big/romstage.c M src/mainboard/google/nyan_blaze/romstage.c M src/northbridge/intel/gm45/raminit.c M src/northbridge/intel/nehalem/raminit.c M src/northbridge/via/vx900/raminit_ddr3.c M src/soc/mediatek/common/spi.c M src/soc/mediatek/mt8173/dsi.c M src/soc/mediatek/mt8173/i2c.c M src/soc/nvidia/tegra124/clock.c M src/soc/nvidia/tegra124/include/soc/clock.h M src/soc/nvidia/tegra124/verstage.c M src/soc/nvidia/tegra210/clock.c M src/soc/nvidia/tegra210/include/soc/clock.h M src/soc/rockchip/common/i2c.c M src/soc/rockchip/common/rk808.c M src/soc/rockchip/rk3288/clock.c M src/soc/rockchip/rk3288/sdram.c M src/soc/rockchip/rk3399/clock.c M src/soc/rockchip/rk3399/mipi.c M src/soc/samsung/exynos5250/cpu.c M src/soc/samsung/exynos5420/clock.c M src/soc/samsung/exynos5420/cpu.c 29 files changed, 74 insertions(+), 84 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/29847/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/29847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9aabc3fbe7834834c92d6ba59ff0005986622a34 Gerrit-Change-Number: 29847 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: src: Remove duplicated round up function
by HAOUAS Elyes (Code Review) 27 Nov '18

27 Nov '18

Hello Patrick Rudolph, Julius Werner, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29847 to look at the new patch set (#3). Change subject: src: Remove duplicated round up function ...................................................................... src: Remove duplicated round up function Fixes 7116ac8037 (src: Make use of 'CEIL_DIV(a, b)' macro across tree). Change-Id: I9aabc3fbe7834834c92d6ba59ff0005986622a34 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/commonlib/include/commonlib/helpers.h M src/cpu/allwinner/a10/clock.c M src/cpu/x86/tsc/delay_tsc.c M src/northbridge/intel/gm45/raminit.c M src/northbridge/intel/nehalem/raminit.c M src/northbridge/via/vx900/raminit_ddr3.c M src/soc/nvidia/tegra124/clock.c M src/soc/samsung/exynos5250/cpu.c M src/soc/samsung/exynos5420/clock.c M src/soc/samsung/exynos5420/cpu.c 10 files changed, 26 insertions(+), 28 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/29847/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/29847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9aabc3fbe7834834c92d6ba59ff0005986622a34 Gerrit-Change-Number: 29847 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: soc/intel/braswell/northcluster.c: Reserve local APIC resources
by Patrick Rudolph (Code Review) 27 Nov '18

27 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29375 ) Change subject: soc/intel/braswell/northcluster.c: Reserve local APIC resources ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29375 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb9de45098d507d59f1974eddb7a94cb18ef7903 Gerrit-Change-Number: 29375 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 27 Nov 2018 07:05:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/dragonegg: Add initial mainboard code support
by build bot (Jenkins) (Code Review) 27 Nov '18

27 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29749 ) Change subject: mb/google/dragonegg: Add initial mainboard code support ...................................................................... Patch Set 18: (1 comment) https://review.coreboot.org/#/c/29749/18/src/mainboard/google/dragonegg/acp… File src/mainboard/google/dragonegg/acpi_tables.c: https://review.coreboot.org/#/c/29749/18/src/mainboard/google/dragonegg/acp… PS18, Line 3: */ adding a line without newline at end of file -- To view, visit https://review.coreboot.org/c/coreboot/+/29749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2cc269cb0050bf5b031f48cfe114485c55ab8fa9 Gerrit-Change-Number: 29749 Gerrit-PatchSet: 18 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 27 Nov 2018 05:30:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Documentation/../../icelake_rvp: Add RVP coreboot development documen...
by Subrata Banik (Code Review) 27 Nov '18

27 Nov '18

Hello Patrick Rudolph, Arthur Heymans, Aamir Bohra, Shelley Chen, build bot (Jenkins), Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29828 to look at the new patch set (#3). Change subject: Documentation/../../icelake_rvp: Add RVP coreboot development documentation ...................................................................... Documentation/../../icelake_rvp: Add RVP coreboot development documentation Change-Id: If063cbd3436d9ee107945f425a31ba0009039a1d Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M Documentation/mainboard/index.md A Documentation/mainboard/intel/icelake_rvp.md 2 files changed, 40 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/29828/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/29828 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If063cbd3436d9ee107945f425a31ba0009039a1d Gerrit-Change-Number: 29828 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: Documentation/../../dragonegg: Add dragonegg coreboot development doc...
by Subrata Banik (Code Review) 27 Nov '18

27 Nov '18

Hello Patrick Rudolph, Aamir Bohra, Shelley Chen, build bot (Jenkins), Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29829 to look at the new patch set (#4). Change subject: Documentation/../../dragonegg: Add dragonegg coreboot development documentation ...................................................................... Documentation/../../dragonegg: Add dragonegg coreboot development documentation Change-Id: Ia15e317557a0893d9f80cc9e87c6b90c85b93dcf Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- A Documentation/mainboard/google/dragonegg.md M Documentation/mainboard/index.md 2 files changed, 43 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/29829/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/29829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia15e317557a0893d9f80cc9e87c6b90c85b93dcf Gerrit-Change-Number: 29829 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: Documentation/../../dragonegg: Add dragonegg coreboot development doc...
by Subrata Banik (Code Review) 27 Nov '18

27 Nov '18

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29829 ) Change subject: Documentation/../../dragonegg: Add dragonegg coreboot development documentation ...................................................................... Patch Set 3: > same thing about a comment on FSP availability. Not sure if it > needs reiterating here, since it's also on the Ice Lake page, but > if it's in the RVP instructions, it also belongs here. done -- To view, visit https://review.coreboot.org/c/coreboot/+/29829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia15e317557a0893d9f80cc9e87c6b90c85b93dcf Gerrit-Change-Number: 29829 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Nov 2018 05:12:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Documentation/../../icelake_rvp: Add RVP coreboot development documen...
by Subrata Banik (Code Review) 27 Nov '18

27 Nov '18

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29828 ) Change subject: Documentation/../../icelake_rvp: Add RVP coreboot development documentation ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/29828/2/Documentation/mainboard/intel/icela… File Documentation/mainboard/intel/icelake_rvp.md: https://review.coreboot.org/#/c/29828/2/Documentation/mainboard/intel/icela… PS2, Line 17: > I'm fine with that, but it's an extra step compared to these 3. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/29828 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If063cbd3436d9ee107945f425a31ba0009039a1d Gerrit-Change-Number: 29828 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Nov 2018 05:11:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/poppy/variants/nami: Enable g2touch touchscreen device
by Crystal Lin (Code Review) 27 Nov '18

27 Nov '18

Crystal Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29768 ) Change subject: mb/google/poppy/variants/nami: Enable g2touch touchscreen device ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/29768/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nami/devicetree.cb: https://review.coreboot.org/#/c/29768/1/src/mainboard/google/poppy/variants… PS1, Line 350: H > I don't think using '_' is valid. HID needs to be either uppercase letter (A-Z) or numeral (0-9). After confirm with vendor, change GGT_7503 to GTCH7503. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/29768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I26e16b7e118121b3dd9a88c76d04898b97753df0 Gerrit-Change-Number: 29768 Gerrit-PatchSet: 2 Gerrit-Owner: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com> Gerrit-Reviewer: Crystal Lin <crystal_lin(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Nov 2018 02:42:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018