coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in ...coreboot[master]: vendorcode/cavium: Supply bdk_pop and bdk_dpop definitions
by Patrick Rudolph (Code Review) 27 Nov '18

27 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29851 ) Change subject: vendorcode/cavium: Supply bdk_pop and bdk_dpop definitions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29851 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf71e4556014795bfedceccfe3837dc9deb29ad2 Gerrit-Change-Number: 29851 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Nov 2018 08:21:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: romcc: Increase buffer size to fit max string size
by Patrick Rudolph (Code Review) 27 Nov '18

27 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29850 ) Change subject: romcc: Increase buffer size to fit max string size ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29850 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7879a7202cc3ff52301b10118fc49fcc601f133e Gerrit-Change-Number: 29850 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Nov 2018 08:21:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Documentation/../../dragonegg: Add dragonegg coreboot development doc...
by Subrata Banik (Code Review) 27 Nov '18

27 Nov '18

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29829 ) Change subject: Documentation/../../dragonegg: Add dragonegg coreboot development documentation ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/#/c/29829/4/Documentation/mainboard/google/drag… File Documentation/mainboard/google/dragonegg.md: https://review.coreboot.org/#/c/29829/4/Documentation/mainboard/google/drag… PS4, Line 19: # echo "CONFIG_VENDOR_GOOGLE=y" > .config > ```bash […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/29829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia15e317557a0893d9f80cc9e87c6b90c85b93dcf Gerrit-Change-Number: 29829 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Nov 2018 08:20:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Documentation/../../dragonegg: Add dragonegg coreboot development doc...
by Subrata Banik (Code Review) 27 Nov '18

27 Nov '18

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29829 ) Change subject: Documentation/../../dragonegg: Add dragonegg coreboot development documentation ...................................................................... Patch Set 4: (2 comments) https://review.coreboot.org/#/c/29829/4/Documentation/mainboard/google/drag… File Documentation/mainboard/google/dragonegg.md: https://review.coreboot.org/#/c/29829/4/Documentation/mainboard/google/drag… PS4, Line 7: .. Ice Lake coreboot development:doc: ‘../../soc/intel/iceLake_coreboot_development.md’ > :doc:`../.. […] Done https://review.coreboot.org/#/c/29829/4/Documentation/mainboard/google/drag… PS4, Line 14: .. Create coreboot Image:doc: ‘../../soc/intel/iceLake_coreboot_development.md’ > You don't need to set a title, sphinx will automatically insert the referenced document title. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/29829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia15e317557a0893d9f80cc9e87c6b90c85b93dcf Gerrit-Change-Number: 29829 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Nov 2018 08:20:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Documentation/../../dragonegg: Add dragonegg coreboot development doc...
by Subrata Banik (Code Review) 27 Nov '18

27 Nov '18

Hello Patrick Rudolph, Aamir Bohra, Shelley Chen, build bot (Jenkins), Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29829 to look at the new patch set (#5). Change subject: Documentation/../../dragonegg: Add dragonegg coreboot development documentation ...................................................................... Documentation/../../dragonegg: Add dragonegg coreboot development documentation Change-Id: Ia15e317557a0893d9f80cc9e87c6b90c85b93dcf Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- A Documentation/mainboard/google/dragonegg.md M Documentation/mainboard/index.md 2 files changed, 44 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/29829/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/29829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia15e317557a0893d9f80cc9e87c6b90c85b93dcf Gerrit-Change-Number: 29829 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: Documentation/../../icelake_rvp: Add RVP coreboot development documen...
by Subrata Banik (Code Review) 27 Nov '18

27 Nov '18

Hello Patrick Rudolph, Arthur Heymans, Aamir Bohra, Shelley Chen, build bot (Jenkins), Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29828 to look at the new patch set (#4). Change subject: Documentation/../../icelake_rvp: Add RVP coreboot development documentation ...................................................................... Documentation/../../icelake_rvp: Add RVP coreboot development documentation Change-Id: If063cbd3436d9ee107945f425a31ba0009039a1d Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M Documentation/mainboard/index.md A Documentation/mainboard/intel/icelake_rvp.md 2 files changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/29828/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/29828 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If063cbd3436d9ee107945f425a31ba0009039a1d Gerrit-Change-Number: 29828 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: Documentation/../../icelake_rvp: Add RVP coreboot development documen...
by Subrata Banik (Code Review) 27 Nov '18

27 Nov '18

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29828 ) Change subject: Documentation/../../icelake_rvp: Add RVP coreboot development documentation ...................................................................... Patch Set 3: (3 comments) https://review.coreboot.org/#/c/29828/3/Documentation/mainboard/intel/icela… File Documentation/mainboard/intel/icelake_rvp.md: https://review.coreboot.org/#/c/29828/3/Documentation/mainboard/intel/icela… PS3, Line 7: .. Ice Lake coreboot development:doc: ‘../../soc/intel/iceLake_coreboot_development.md’ > :doc:`../.. […] Done https://review.coreboot.org/#/c/29828/3/Documentation/mainboard/intel/icela… PS3, Line 14: .. Create coreboot Image:doc: ‘../../soc/intel/iceLake_coreboot_development.md’ > :doc:`../.. […] Done https://review.coreboot.org/#/c/29828/3/Documentation/mainboard/intel/icela… PS3, Line 19: # echo "CONFIG_VENDOR_INTEL=y" > .config > ```bash […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/29828 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If063cbd3436d9ee107945f425a31ba0009039a1d Gerrit-Change-Number: 29828 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Nov 2018 08:10:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: src/vendorcode: [test] Fix invalid hexadecimal number.
by HAOUAS Elyes (Code Review) 27 Nov '18

27 Nov '18

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29852 Change subject: src/vendorcode: [test] Fix invalid hexadecimal number. ...................................................................... src/vendorcode: [test] Fix invalid hexadecimal number. Change-Id: Ifdef135aa7517477a10657bb01f866ec41f5bdf7 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/vendorcode/amd/pi/00630F01/binaryPI/gcccar.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/29852/1 diff --git a/src/vendorcode/amd/pi/00630F01/binaryPI/gcccar.inc b/src/vendorcode/amd/pi/00630F01/binaryPI/gcccar.inc index f444852..f68c9dc 100644 --- a/src/vendorcode/amd/pi/00630F01/binaryPI/gcccar.inc +++ b/src/vendorcode/amd/pi/00630F01/binaryPI/gcccar.inc @@ -523,7 +523,7 @@ LOCAL node_core_f14_exit - cmp $0x-1, %si # Has node/core already been discovered? + cmp $-1, %si # Has node/core already been discovered? jnz node_core_f14_exit # Br if yes AMD_CPUID $CPUID_MODEL -- To view, visit https://review.coreboot.org/c/coreboot/+/29852 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifdef135aa7517477a10657bb01f866ec41f5bdf7 Gerrit-Change-Number: 29852 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: Documentation/../../icelake_rvp: Add RVP coreboot development documen...
by Patrick Rudolph (Code Review) 27 Nov '18

27 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29828 ) Change subject: Documentation/../../icelake_rvp: Add RVP coreboot development documentation ...................................................................... Patch Set 3: (3 comments) https://review.coreboot.org/#/c/29828/3/Documentation/mainboard/intel/icela… File Documentation/mainboard/intel/icelake_rvp.md: https://review.coreboot.org/#/c/29828/3/Documentation/mainboard/intel/icela… PS3, Line 7: .. Ice Lake coreboot development:doc: ‘../../soc/intel/iceLake_coreboot_development.md’ :doc:`../../soc/intel/icelake/iceLake_coreboot_development` https://review.coreboot.org/#/c/29828/3/Documentation/mainboard/intel/icela… PS3, Line 14: .. Create coreboot Image:doc: ‘../../soc/intel/iceLake_coreboot_development.md’ :doc:`../../soc/intel/icelake/iceLake_coreboot_development` https://review.coreboot.org/#/c/29828/3/Documentation/mainboard/intel/icela… PS3, Line 19: # echo "CONFIG_VENDOR_INTEL=y" > .config ```bash ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/29828 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If063cbd3436d9ee107945f425a31ba0009039a1d Gerrit-Change-Number: 29828 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Nov 2018 07:48:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Documentation/../../dragonegg: Add dragonegg coreboot development doc...
by Patrick Rudolph (Code Review) 27 Nov '18

27 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29829 ) Change subject: Documentation/../../dragonegg: Add dragonegg coreboot development documentation ...................................................................... Patch Set 4: (3 comments) https://review.coreboot.org/#/c/29829/4/Documentation/mainboard/google/drag… File Documentation/mainboard/google/dragonegg.md: https://review.coreboot.org/#/c/29829/4/Documentation/mainboard/google/drag… PS4, Line 7: .. Ice Lake coreboot development:doc: ‘../../soc/intel/iceLake_coreboot_development.md’ :doc:`../../soc/intel/icelake/iceLake_coreboot_development` https://review.coreboot.org/#/c/29829/4/Documentation/mainboard/google/drag… PS4, Line 14: .. Create coreboot Image:doc: ‘../../soc/intel/iceLake_coreboot_development.md’ You don't need to set a title, sphinx will automatically insert the referenced document title. The correct path is: :doc:`../../soc/intel/icelake/iceLake_coreboot_development` https://review.coreboot.org/#/c/29829/4/Documentation/mainboard/google/drag… PS4, Line 19: # echo "CONFIG_VENDOR_GOOGLE=y" > .config ```bash ``` Otherwise this renders are chapter title -- To view, visit https://review.coreboot.org/c/coreboot/+/29829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia15e317557a0893d9f80cc9e87c6b90c85b93dcf Gerrit-Change-Number: 29829 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 27 Nov 2018 07:48:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018